Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

test(web): replace prompt and generator mocks with behavior checks (#44985)

Stephen Zhou2f20f4c5ef71
diff --git a/web/app/components/workflow/nodes/_base/components/__tests__/code-generator-button.spec.tsx b/web/app/components/workflow/nodes/_base/components/__tests__/code-generator-button.spec.tsx
index 5b8fe8975b9..c1f9bf9848e 100644
--- a/web/app/components/workflow/nodes/_base/components/__tests__/code-generator-button.spec.tsx
+++ b/web/app/components/workflow/nodes/_base/components/__tests__/code-generator-button.spec.tsx
@@ -1,39 +1,166 @@
-import type { GenRes } from '@/service/debug'
-import { screen } from '@testing-library/react'
+import { screen, waitFor, within } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
-import { renderEditor as render } from '@/app/components/workflow/editor-resource/__tests__/render'
+import { useState } from 'react'
+import { replacePromptEditorText } from '@/app/components/base/prompt-editor/plugins/__tests__/test-helpers'
+import {
+ createEdge,
+ createNode,
+ createStartNode,
+} from '@/app/components/workflow/__tests__/fixtures'
+import { renderWorkflowFlowComponent } from '@/app/components/workflow/__tests__/workflow-test-env'
import { CodeLanguage } from '@/app/components/workflow/nodes/code/types'
+import { BlockEnum, InputVarType } from '@/app/components/workflow/types'
+import { EventEmitterContextProvider } from '@/context/event-emitter-provider'
+import { consoleQuery } from '@/service/console'
+import {
+ createCatalogModelFixture,
+ createDefaultModelFixture,
+ createModelCatalogFixture,
+ seedModelProviderQueries,
+} from '@/test/console/model-provider'
+import { createConsoleQueryWrapper } from '@/test/console/query-data'
+import { seedToolProviders } from '@/test/console/tool-providers'
+import { createNuqsTestRenderer } from '@/test/nuqs-testing'
import CodeGenerateBtn from '../code-generator-button'
-vi.mock('@/app/components/app/configuration/config/code-generator/get-code-generator-res', () => ({
- GetCodeGeneratorResModal: ({ onFinished }: { onFinished: (result: GenRes) => void }) => (
- <div role="dialog" aria-label="code generator">
- <button type="button" onClick={() => onFinished({ modified: 'print("hello")' })}>
- Apply generated code
- </button>
- </div>
- ),
+const { generateRule } = vi.hoisted(() => ({ generateRule: vi.fn() }))
+
+vi.mock('@/service/debug', async (importOriginal) => ({
+ ...(await importOriginal<typeof import('@/service/debug')>()),
+ generateRule: (...args: unknown[]) => generateRule(...args),
}))
+const renderGenerator = createNuqsTestRenderer((ui) => {
+ const { queryClient } = createConsoleQueryWrapper({ appDslVersion: '0.6.0' })
+ seedToolProviders(queryClient, {
+ builtInTools: [],
+ customTools: [],
+ workflowTools: [],
+ mcpTools: [],
+ })
+ queryClient.setQueryData(consoleQuery.spec.schemaDefinitions.get.queryKey(), [])
+ seedModelProviderQueries(queryClient, [
+ createModelCatalogFixture({
+ models: [
+ createCatalogModelFixture({
+ model: 'gpt-4o-mini',
+ label: { en_US: 'GPT-4o mini' },
+ model_properties: { mode: 'chat' },
+ }),
+ ],
+ }),
+ ])
+ queryClient.setQueryData(
+ consoleQuery.workspaces.current.defaultModel.get.queryKey({
+ input: { query: { model_type: 'llm' } },
+ }),
+ { data: createDefaultModelFixture({ model: 'gpt-4o-mini' }) },
+ )
+ queryClient.setQueryDefaults(
+ consoleQuery.workspaces.current.modelProviders.byProvider.models.parameterRules.get.key(),
+ { initialData: { data: [] } },
+ )
+ queryClient.setQueryData(
+ consoleQuery.instructionGenerate.template.post.queryOptions({
+ input: { body: { type: 'code' } },
+ }).queryKey,
+ { data: 'Describe the Python change' },
+ )
+
+ const start = createStartNode({
+ id: 'start',
+ data: {
+ title: 'Inputs',
+ variables: [
+ {
+ variable: 'query',
+ label: 'Query',
+ type: InputVarType.textInput,
+ required: true,
+ },
+ ],
+ },
+ })
+ const code = createNode({
+ id: 'node-1',
+ data: { type: BlockEnum.Code, title: 'Python code' },
+ })
+
+ return renderWorkflowFlowComponent(
+ <EventEmitterContextProvider>{ui}</EventEmitterContextProvider>,
+ {
+ queryClient,
+ resource: { kind: 'app', appId: 'app-1', mode: 'workflow' },
+ nodes: [start, code],
+ edges: [
+ createEdge({
+ source: start.id,
+ target: code.id,
+ data: { sourceType: BlockEnum.Start, targetType: BlockEnum.Code },
+ }),
+ ],
+ },
+ )
+})
+
describe('CodeGenerateBtn', () => {
it('applies generated code and closes the generator', async () => {
+ sessionStorage.clear()
+ localStorage.removeItem('auto-gen-model')
+ generateRule.mockResolvedValue({ code: 'print("hello")' })
const user = userEvent.setup()
- const onGenerated = vi.fn()
- render(
- <CodeGenerateBtn
- nodeId="node-1"
- codeLanguages={CodeLanguage.python3}
- onGenerated={onGenerated}
- />,
- {
- resource: { kind: 'app', appId: 'app-1', mode: 'workflow' },
- },
- )
+
+ function ControlledCode() {
+ const [code, setCode] = useState('print("before")')
+ return (
+ <>
+ <CodeGenerateBtn
+ nodeId="node-1"
+ currentCode={code}
+ codeLanguages={CodeLanguage.python3}
+ onGenerated={setCode}
+ />
+ <output aria-label="Saved code">{code}</output>
+ </>
+ )
+ }
+
+ renderGenerator(<ControlledCode />)
await user.click(screen.getByRole('button', { name: 'appDebug.operation.automatic' }))
+ const dialog = await screen.findByRole('dialog')
+ expect(within(dialog).getByText('appGeneration.codegen.title')).toBeInTheDocument()
+ expect(within(dialog).getByRole('button', { name: /GPT-4o mini/ })).toBeInTheDocument()
+ await replacePromptEditorText(
+ within(dialog).getByRole('textbox', { name: 'appGeneration.generate.instruction' }),
+ 'Return a greeting',
+ )
+ await user.click(within(dialog).getByRole('button', { name: 'appGeneration.codegen.generate' }))
- await user.click(screen.getByRole('button', { name: 'Apply generated code' }))
- expect(onGenerated).toHaveBeenCalledExactlyOnceWith('print("hello")')
- expect(screen.queryByRole('dialog', { name: 'code generator' })).not.toBeInTheDocument()
+ expect(await within(dialog).findByDisplayValue('print("hello")')).toBeInTheDocument()
+ expect(generateRule).toHaveBeenCalledExactlyOnceWith({
+ flow_id: 'app-1',
+ node_id: 'node-1',
+ current: 'print("before")',
+ instruction: 'Return a greeting',
+ model_config: expect.objectContaining({
+ name: 'gpt-4o-mini',
+ provider: 'openai',
+ mode: 'chat',
+ }),
+ ideal_output: '',
+ language: 'python',
+ })
+ await user.click(within(dialog).getByRole('button', { name: 'appGeneration.generate.apply' }))
+ await user.click(
+ within(await screen.findByRole('alertdialog')).getByRole('button', {
+ name: 'common.operation.confirm',
+ }),
+ )
+
+ expect(screen.getByRole('status', { name: 'Saved code' })).toHaveTextContent('print("hello")')
+ await waitFor(() =>
+ expect(screen.queryByText('appGeneration.codegen.title')).not.toBeInTheDocument(),
+ )
})
})
diff --git a/web/app/components/workflow/nodes/llm/components/__tests__/config-prompt.spec.tsx b/web/app/components/workflow/nodes/llm/components/__tests__/config-prompt.spec.tsx
index cff77549493..5cb15d702c6 100644
--- a/web/app/components/workflow/nodes/llm/components/__tests__/config-prompt.spec.tsx
+++ b/web/app/components/workflow/nodes/llm/components/__tests__/config-prompt.spec.tsx
@@ -3,69 +3,61 @@ import type { LLMNodeType } from '../../types'
import { screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { useState } from 'react'
-import { renderWorkflowComponent } from '@/app/components/workflow/__tests__/workflow-test-env'
-import { BlockEnum, EditionType, PromptRole } from '../../../../types'
+import {
+ createEdge,
+ createNode,
+ createStartNode,
+} from '@/app/components/workflow/__tests__/fixtures'
+import { renderWorkflowFlowComponent } from '@/app/components/workflow/__tests__/workflow-test-env'
+import { EventEmitterContextProvider } from '@/context/event-emitter-provider'
+import { consoleQuery } from '@/service/console'
+import {
+ createCatalogModelFixture,
+ createModelCatalogFixture,
+ seedModelProviderQueries,
+} from '@/test/console/model-provider'
+import { createConsoleQueryWrapper } from '@/test/console/query-data'
+import { seedToolProviders } from '@/test/console/tool-providers'
+import { BlockEnum, EditionType, InputVarType, PromptRole, VarType } from '../../../../types'
import useLLMInputManager from '../../hooks/use-llm-input-manager'
import useLLMPromptConfig from '../../hooks/use-llm-prompt-config'
import ConfigPrompt from '../config-prompt'
-vi.mock('../../../_base/hooks/use-available-var-list', () => ({
- default: () => ({ availableVars: [], availableNodesWithParent: [] }),
-}))
-
-vi.mock('../../../_base/components/prompt/editor', () => ({ default: () => null }))
-
-vi.mock('../config-prompt-item', () => ({
- default: ({
- payload,
- onPromptChange,
- }: {
- payload: PromptItem
- onPromptChange: (value: string) => void
- }) => (
- <textarea
- aria-label={payload.role}
- value={payload.text}
- onChange={(event) => onPromptChange(event.target.value)}
- />
- ),
-}))
-
const initialPrompts: PromptItem[] = [
{ id: 'system', role: PromptRole.system, text: 'System instruction' },
{ id: 'user', role: PromptRole.user, text: 'User question' },
{ id: 'assistant', role: PromptRole.assistant, text: 'Assistant answer' },
]
+const remotePrompts = initialPrompts.map(({ role, text }) => ({ role, text }))
-function Fixture({
- onChange,
- initial = initialPrompts,
-}: {
- onChange: (items: PromptItem | PromptItem[]) => void
- initial?: PromptItem[]
-}) {
+function Fixture({ initial = initialPrompts }: { initial?: PromptItem[] }) {
const [prompts, setPrompts] = useState(initial)
return (
- <ConfigPrompt
- readOnly={false}
- nodeId="llm"
- filterVar={() => true}
- isChatModel
- isChatApp={false}
- payload={prompts}
- onChange={(items) => {
- onChange(items)
- setPrompts(items as PromptItem[])
- }}
- isShowContext={false}
- hasSetBlockStatus={{ context: false, history: false, query: false }}
- handleAddVariable={vi.fn()}
- modelConfig={{ provider: 'openai', name: 'gpt-4', mode: 'chat', completion_params: {} }}
- />
+ <>
+ <ConfigPrompt
+ readOnly={false}
+ nodeId="llm"
+ filterVar={() => true}
+ isChatModel
+ isChatApp={false}
+ payload={prompts}
+ onChange={(items) => setPrompts(items as PromptItem[])}
+ isShowContext={false}
+ hasSetBlockStatus={{ context: false, history: false, query: false }}
+ handleAddVariable={() => {}}
+ modelConfig={{
+ provider: 'openai',
+ name: 'gpt-4o-mini',
+ mode: 'chat',
+ completion_params: {},
+ }}
+ />
+ <output aria-label="Saved prompts">{JSON.stringify(prompts)}</output>
+ </>
)
}
-function RemoteModelChangeFixture({ onChange }: { onChange: (inputs: LLMNodeType) => void }) {
+function RemoteModelChangeFixture() {
const [inputs, setInputs] = useState<LLMNodeType>({
type: BlockEnum.LLM,
title: 'LLM',
@@ -84,10 +76,7 @@ function RemoteModelChangeFixture({ onChange }: { onChange: (inputs: LLMNodeType
const inputManager = useLLMInputManager({
inputs,
isChatModel,
- doSetInputs: (nextInputs) => {
- onChange(nextInputs)
- setInputs(nextInputs)
- },
+ doSetInputs: setInputs,
})
const promptConfig = useLLMPromptConfig({
inputs,
@@ -104,13 +93,14 @@ function RemoteModelChangeFixture({ onChange }: { onChange: (inputs: LLMNodeType
setInputs({
...inputs,
model: { ...inputs.model, name: 'chat-model', mode: 'chat' },
- prompt_template: initialPrompts.map(({ role, text }) => ({ role, text })),
+ prompt_template: remotePrompts,
})
}
>
Receive remote Chat model
</button>
<output aria-label="Model mode">{inputs.model.mode}</output>
+ <output aria-label="Saved remote prompts">{JSON.stringify(inputs.prompt_template)}</output>
<ConfigPrompt
readOnly={false}
nodeId="llm"
@@ -128,69 +118,125 @@ function RemoteModelChangeFixture({ onChange }: { onChange: (inputs: LLMNodeType
)
}
+const renderPromptConfig = (ui: React.ReactElement) => {
+ const { queryClient } = createConsoleQueryWrapper({ appDslVersion: '0.6.0' })
+ seedToolProviders(queryClient, {
+ builtInTools: [],
+ customTools: [],
+ workflowTools: [],
+ mcpTools: [],
+ })
+ queryClient.setQueryData(consoleQuery.spec.schemaDefinitions.get.queryKey(), [])
+ seedModelProviderQueries(queryClient, [
+ createModelCatalogFixture({
+ models: [
+ createCatalogModelFixture({
+ model: 'gpt-4o-mini',
+ label: { en_US: 'GPT-4o mini' },
+ model_properties: { mode: 'chat' },
+ }),
+ ],
+ }),
+ ])
+ const start = createStartNode({
+ id: 'start',
+ data: {
+ title: 'Inputs',
+ variables: [
+ {
+ variable: 'query',
+ label: 'Query',
+ type: InputVarType.textInput,
+ required: true,
+ },
+ ],
+ },
+ })
+ const code = createNode({
+ id: 'code',
+ data: {
+ type: BlockEnum.Code,
+ title: 'Draft data',
+ outputs: { answer: { type: VarType.string, children: null } },
+ },
+ })
+ const llm = createNode({ id: 'llm', data: { type: BlockEnum.LLM, title: 'Writer' } })
+
+ return renderWorkflowFlowComponent(
+ <EventEmitterContextProvider>{ui}</EventEmitterContextProvider>,
+ {
+ queryClient,
+ nodes: [start, code, llm],
+ edges: [
+ createEdge({
+ source: start.id,
+ target: code.id,
+ data: { sourceType: BlockEnum.Start, targetType: BlockEnum.Code },
+ }),
+ createEdge({
+ source: code.id,
+ target: llm.id,
+ data: { sourceType: BlockEnum.Code, targetType: BlockEnum.LLM },
+ }),
+ ],
+ },
+ )
+}
+
+const editorTexts = () => screen.getAllByRole('textbox').map((editor) => editor.textContent)
+
it('retains a remote model change without writing back its default prompts', async () => {
const user = userEvent.setup()
- const onChange = vi.fn<(inputs: LLMNodeType) => void>()
- renderWorkflowComponent(<RemoteModelChangeFixture onChange={onChange} />)
+ renderPromptConfig(<RemoteModelChangeFixture />)
await user.click(screen.getByRole('button', { name: 'Receive remote Chat model' }))
expect(screen.getByRole('status', { name: 'Model mode' })).toHaveTextContent('chat')
- expect(onChange).not.toHaveBeenCalled()
expect(
- screen.getAllByRole('textbox').map((editor) => (editor as HTMLTextAreaElement).value),
- ).toEqual(initialPrompts.map((prompt) => prompt.text))
+ JSON.parse(screen.getByRole('status', { name: 'Saved remote prompts' }).textContent!),
+ ).toEqual(remotePrompts)
+ expect(editorTexts()).toEqual(initialPrompts.map((prompt) => prompt.text))
})
it('reorders messages without moving past the leading system prompt', async () => {
const user = userEvent.setup()
- const onChange = vi.fn()
- renderWorkflowComponent(<Fixture onChange={onChange} />)
- expect(onChange).not.toHaveBeenCalled()
- expect(screen.getAllByRole('button', { pressed: false })).toHaveLength(2)
- const handle = screen.getAllByRole('button', { pressed: false })[0]!
- for (let index = 0; index < 10 && document.activeElement !== handle; index++) await user.tab()
+ renderPromptConfig(<Fixture />)
+ const savedPrompts = screen.getByRole('status', { name: 'Saved prompts' })
+ const handle = screen.getAllByRole('button', { name: /common.sort.handle/ })[0]!
+ for (let index = 0; index < 20 && document.activeElement !== handle; index++) await user.tab()
expect(handle).toHaveFocus()
await user.keyboard('{Enter}{ArrowUp}')
- expect(
- screen.getAllByRole('textbox').map((input) => (input as HTMLTextAreaElement).value),
- ).toEqual(initialPrompts.map((item) => item.text))
+ expect(editorTexts()).toEqual(initialPrompts.map((item) => item.text))
await user.keyboard('{ArrowDown}')
- expect(
- screen.getAllByRole('textbox').map((input) => (input as HTMLTextAreaElement).value),
- ).toEqual(['System instruction', 'Assistant answer', 'User question'])
- expect(onChange).not.toHaveBeenCalled()
+ expect(editorTexts()).toEqual(['System instruction', 'Assistant answer', 'User question'])
+ expect(savedPrompts).toHaveTextContent(JSON.stringify(initialPrompts))
await user.keyboard('{Enter}')
- expect(onChange).toHaveBeenCalledExactlyOnceWith([
+ expect(JSON.parse(savedPrompts.textContent!)).toEqual([
initialPrompts[0],
initialPrompts[2],
initialPrompts[1],
])
- expect(screen.getAllByRole('button', { pressed: false })[1]).toHaveFocus()
+ expect(screen.getAllByRole('button', { name: /common.sort.handle/ })[1]).toHaveFocus()
})
it('only writes default prompts without IDs after completing a reorder', async () => {
const user = userEvent.setup()
- const onChange = vi.fn<(items: PromptItem | PromptItem[]) => void>()
const initial = initialPrompts.map((item) => ({ role: item.role, text: item.text }))
- renderWorkflowComponent(<Fixture onChange={onChange} initial={initial} />)
- expect(onChange).not.toHaveBeenCalled()
+ renderPromptConfig(<Fixture initial={initial} />)
+ const savedPrompts = screen.getByRole('status', { name: 'Saved prompts' })
- const handle = screen.getAllByRole('button', { pressed: false })[0]!
- for (let index = 0; index < 10 && document.activeElement !== handle; index++) await user.tab()
+ const handle = screen.getAllByRole('button', { name: /common.sort.handle/ })[0]!
+ for (let index = 0; index < 20 && document.activeElement !== handle; index++) await user.tab()
expect(handle).toHaveFocus()
await user.keyboard('{Enter}{ArrowDown}{Escape}')
- expect(onChange).not.toHaveBeenCalled()
+ expect(JSON.parse(savedPrompts.textContent!)).toEqual(initial)
await user.keyboard('{Enter}{ArrowDown}{Enter}')
- expect(onChange).toHaveBeenCalledExactlyOnceWith(
+ const reordered = JSON.parse(savedPrompts.textContent!) as PromptItem[]
+ expect(reordered).toEqual(
[initial[0], initial[2], initial[1]].map((prompt) => ({ ...prompt, id: expect.any(String) })),
)
- const reordered = onChange.mock.lastCall![0] as PromptItem[]
expect(new Set(reordered.map((prompt) => prompt.id)).size).toBe(initial.length)
- expect(
- screen.getAllByRole('textbox').map((editor) => (editor as HTMLTextAreaElement).value),
- ).toEqual(['System instruction', 'Assistant answer', 'User question'])
+ expect(editorTexts()).toEqual(['System instruction', 'Assistant answer', 'User question'])
await user.keyboard('{Enter}{ArrowUp}{Enter}')
- expect(onChange).toHaveBeenCalledTimes(2)
- expect(onChange).toHaveBeenLastCalledWith([reordered[0], reordered[2], reordered[1]])
+ expect(JSON.parse(savedPrompts.textContent!)).toEqual([reordered[0], reordered[2], reordered[1]])
})
diff --git a/web/app/components/workflow/nodes/llm/components/__tests__/prompt-generator-btn.spec.tsx b/web/app/components/workflow/nodes/llm/components/__tests__/prompt-generator-btn.spec.tsx
index 42030ba29f3..88589ea46c5 100644
--- a/web/app/components/workflow/nodes/llm/components/__tests__/prompt-generator-btn.spec.tsx
+++ b/web/app/components/workflow/nodes/llm/components/__tests__/prompt-generator-btn.spec.tsx
@@ -1,31 +1,167 @@
-import type { GenRes } from '@/service/debug'
-import { screen } from '@testing-library/react'
+import { screen, waitFor, within } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
-import { renderEditor as render } from '@/app/components/workflow/editor-resource/__tests__/render'
+import { useState } from 'react'
+import { replacePromptEditorText } from '@/app/components/base/prompt-editor/plugins/__tests__/test-helpers'
+import {
+ createEdge,
+ createNode,
+ createStartNode,
+} from '@/app/components/workflow/__tests__/fixtures'
+import { renderWorkflowFlowComponent } from '@/app/components/workflow/__tests__/workflow-test-env'
+import { BlockEnum, InputVarType } from '@/app/components/workflow/types'
+import { EventEmitterContextProvider } from '@/context/event-emitter-provider'
+import { consoleQuery } from '@/service/console'
+import {
+ createCatalogModelFixture,
+ createDefaultModelFixture,
+ createModelCatalogFixture,
+ seedModelProviderQueries,
+} from '@/test/console/model-provider'
+import { createConsoleQueryWrapper } from '@/test/console/query-data'
+import { seedToolProviders } from '@/test/console/tool-providers'
+import { createNuqsTestRenderer } from '@/test/nuqs-testing'
import PromptGeneratorBtn from '../prompt-generator-btn'
-vi.mock('@/app/components/app/configuration/config/automatic/get-automatic-res', () => ({
- default: ({ onFinished }: { onFinished: (result: GenRes) => void }) => (
- <div role="dialog" aria-label="prompt generator">
- <button type="button" onClick={() => onFinished({ modified: 'Generated prompt' })}>
- Apply generated prompt
- </button>
- </div>
- ),
+const { generateRule } = vi.hoisted(() => ({ generateRule: vi.fn() }))
+
+vi.mock('@/service/debug', async (importOriginal) => ({
+ ...(await importOriginal<typeof import('@/service/debug')>()),
+ generateRule: (...args: unknown[]) => generateRule(...args),
}))
+const renderGenerator = createNuqsTestRenderer((ui) => {
+ const { queryClient } = createConsoleQueryWrapper({ appDslVersion: '0.6.0' })
+ seedToolProviders(queryClient, {
+ builtInTools: [],
+ customTools: [],
+ workflowTools: [],
+ mcpTools: [],
+ })
+ queryClient.setQueryData(consoleQuery.spec.schemaDefinitions.get.queryKey(), [])
+ seedModelProviderQueries(queryClient, [
+ createModelCatalogFixture({
+ models: [
+ createCatalogModelFixture({
+ model: 'gpt-4o-mini',
+ label: { en_US: 'GPT-4o mini' },
+ model_properties: { mode: 'chat' },
+ }),
+ ],
+ }),
+ ])
+ queryClient.setQueryData(
+ consoleQuery.workspaces.current.defaultModel.get.queryKey({
+ input: { query: { model_type: 'llm' } },
+ }),
+ { data: createDefaultModelFixture({ model: 'gpt-4o-mini' }) },
+ )
+ queryClient.setQueryDefaults(
+ consoleQuery.workspaces.current.modelProviders.byProvider.models.parameterRules.get.key(),
+ { initialData: { data: [] } },
+ )
+ queryClient.setQueryData(
+ consoleQuery.instructionGenerate.template.post.queryOptions({
+ input: { body: { type: 'prompt' } },
+ }).queryKey,
+ { data: 'Describe the prompt improvement' },
+ )
+
+ const start = createStartNode({
+ id: 'start',
+ data: {
+ title: 'Inputs',
+ variables: [
+ {
+ variable: 'query',
+ label: 'Query',
+ type: InputVarType.textInput,
+ required: true,
+ },
+ ],
+ },
+ })
+ const llm = createNode({
+ id: 'node-1',
+ data: { type: BlockEnum.LLM, title: 'Prompt writer' },
+ })
+
+ return renderWorkflowFlowComponent(
+ <EventEmitterContextProvider>{ui}</EventEmitterContextProvider>,
+ {
+ queryClient,
+ resource: { kind: 'app', appId: 'app-1', mode: 'workflow' },
+ nodes: [start, llm],
+ edges: [
+ createEdge({
+ source: start.id,
+ target: llm.id,
+ data: { sourceType: BlockEnum.Start, targetType: BlockEnum.LLM },
+ }),
+ ],
+ },
+ )
+})
+
describe('PromptGeneratorBtn', () => {
it('applies generated text and closes the generator', async () => {
+ sessionStorage.clear()
+ localStorage.removeItem('auto-gen-model')
+ generateRule.mockResolvedValue({ modified: 'Generated prompt' })
const user = userEvent.setup()
- const onGenerated = vi.fn()
- render(<PromptGeneratorBtn nodeId="node-1" onGenerated={onGenerated} />, {
- resource: { kind: 'app', appId: 'app-1', mode: 'workflow' },
- })
+
+ function ControlledPrompt() {
+ const [prompt, setPrompt] = useState('Original prompt')
+ return (
+ <>
+ <PromptGeneratorBtn
+ nodeId="node-1"
+ editorId="system"
+ currentPrompt={prompt}
+ onGenerated={setPrompt}
+ />
+ <output aria-label="Saved prompt">{prompt}</output>
+ </>
+ )
+ }
+
+ renderGenerator(<ControlledPrompt />)
await user.click(screen.getByRole('button', { name: 'appDebug.operation.automatic' }))
+ const dialog = await screen.findByRole('dialog', { name: 'appGeneration.generate.title' })
+ expect(within(dialog).getByRole('button', { name: /GPT-4o mini/ })).toBeInTheDocument()
+ await replacePromptEditorText(
+ within(dialog).getByRole('textbox', { name: 'appGeneration.generate.instruction' }),
+ 'Make the prompt concise',
+ )
+ await user.click(
+ within(dialog).getByRole('button', { name: 'appGeneration.generate.generate' }),
+ )
+
+ expect(await within(dialog).findByText('Generated prompt')).toBeInTheDocument()
+ expect(generateRule).toHaveBeenCalledExactlyOnceWith({
+ flow_id: 'app-1',
+ node_id: 'node-1',
+ current: 'Original prompt',
+ instruction: 'Make the prompt concise',
+ ideal_output: '',
+ model_config: expect.objectContaining({
+ name: 'gpt-4o-mini',
+ provider: 'openai',
+ mode: 'chat',
+ }),
+ })
+ await user.click(within(dialog).getByRole('button', { name: 'appGeneration.generate.apply' }))
+ await user.click(
+ within(await screen.findByRole('alertdialog')).getByRole('button', {
+ name: 'common.operation.confirm',
+ }),
+ )
- await user.click(screen.getByRole('button', { name: 'Apply generated prompt' }))
- expect(onGenerated).toHaveBeenCalledExactlyOnceWith('Generated prompt')
- expect(screen.queryByRole('dialog', { name: 'prompt generator' })).not.toBeInTheDocument()
+ expect(screen.getByRole('status', { name: 'Saved prompt' })).toHaveTextContent(
+ 'Generated prompt',
+ )
+ await waitFor(() =>
+ expect(screen.queryByText('appGeneration.generate.title')).not.toBeInTheDocument(),
+ )
})
})
diff --git a/web/app/components/workflow/nodes/question-classifier/components/__tests__/class-item.spec.tsx b/web/app/components/workflow/nodes/question-classifier/components/__tests__/class-item.spec.tsx
index 62291a1c9ad..c9de482e94f 100644
--- a/web/app/components/workflow/nodes/question-classifier/components/__tests__/class-item.spec.tsx
+++ b/web/app/components/workflow/nodes/question-classifier/components/__tests__/class-item.spec.tsx
@@ -1,137 +1,204 @@
import type { Topic } from '@/app/components/workflow/nodes/_base/components/branch-list/types'
-import { render, screen } from '@testing-library/react'
+import type { CodeNodeType } from '@/app/components/workflow/nodes/code/types'
+import { screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { useState } from 'react'
+import { replacePromptEditorText } from '@/app/components/base/prompt-editor/plugins/__tests__/test-helpers'
+import {
+ createEdge,
+ createNode,
+ createStartNode,
+} from '@/app/components/workflow/__tests__/fixtures'
+import { renderWorkflowFlowComponent } from '@/app/components/workflow/__tests__/workflow-test-env'
+import { CodeLanguage } from '@/app/components/workflow/nodes/code/types'
+import { BlockEnum, InputVarType, VarType } from '@/app/components/workflow/types'
+import { EventEmitterContextProvider } from '@/context/event-emitter-provider'
+import { consoleQuery } from '@/service/console'
+import { seedModelProviderQueries } from '@/test/console/model-provider'
+import { createConsoleQueryWrapper } from '@/test/console/query-data'
+import { seedToolProviders } from '@/test/console/tool-providers'
import ClassItem from '../../../_base/components/branch-list/class-item'
-vi.mock('@/app/components/workflow/nodes/_base/hooks/use-available-var-list', () => ({
- __esModule: true,
- default: () => ({
- availableVars: [{ variable: ['node-1', 'answer'], type: 'string' }],
- availableNodesWithParent: [{ id: 'node-1', data: { title: 'Answer' } }],
- }),
-}))
-
-// The independently tested rich editor is outside this payload-preservation contract.
-vi.mock('@/app/components/workflow/nodes/_base/components/prompt/editor', () => ({
- __esModule: true,
- default: (props: {
- title: React.ReactNode
- value: string
- onChange: (value: string) => void
- onRemove: () => void
- showRemove?: boolean
- }) => {
- return (
- <div>
- <div>{props.title}</div>
- <input
- aria-label="class-name"
- value={props.value}
- onChange={(event) => props.onChange(event.target.value)}
- />
- {props.showRemove && (
- <button type="button" onClick={props.onRemove}>
- remove-item
- </button>
- )}
- </div>
- )
- },
-}))
-
const createTopic = (overrides: Partial<Topic> = {}): Topic => ({
id: 'topic-1',
name: 'Billing questions',
...overrides,
})
+const createCodeNode = () => {
+ const data = {
+ title: 'Answer producer',
+ desc: '',
+ type: BlockEnum.Code,
+ code_language: CodeLanguage.python3,
+ code: 'def main():\n return {"answer": "Billing question"}',
+ variables: [],
+ outputs: { answer: { type: VarType.string, children: null } },
+ } satisfies CodeNodeType
+ return createNode({ id: 'code', data })
+}
+
+const renderClass = (ui: React.ReactElement) => {
+ const { queryClient } = createConsoleQueryWrapper({ appDslVersion: '0.6.0' })
+ seedModelProviderQueries(queryClient, [])
+ seedToolProviders(queryClient, {
+ builtInTools: [],
+ customTools: [],
+ workflowTools: [],
+ mcpTools: [],
+ })
+ queryClient.setQueryData(consoleQuery.spec.schemaDefinitions.get.queryKey(), [])
+ const start = createStartNode({
+ id: 'start',
+ data: {
+ title: 'Inputs',
+ variables: [
+ {
+ variable: 'query',
+ label: 'Query',
+ type: InputVarType.textInput,
+ required: true,
+ },
+ ],
+ },
+ })
+ const code = createCodeNode()
+ const classifier = createNode({
+ id: 'node-1',
+ data: { title: 'Classifier', type: BlockEnum.QuestionClassifier },
+ })
+
+ return renderWorkflowFlowComponent(
+ <EventEmitterContextProvider>{ui}</EventEmitterContextProvider>,
+ {
+ queryClient,
+ nodes: [start, code, classifier],
+ edges: [
+ createEdge({
+ source: start.id,
+ target: code.id,
+ data: { sourceType: BlockEnum.Start, targetType: BlockEnum.Code },
+ }),
+ createEdge({
+ source: code.id,
+ target: classifier.id,
+ data: { sourceType: BlockEnum.Code, targetType: BlockEnum.QuestionClassifier },
+ }),
+ ],
+ },
+ )
+}
+
describe('question-classifier/class-item', () => {
it('forwards editor updates and remove actions', async () => {
const user = userEvent.setup()
- const onChange = vi.fn()
- const onRemove = vi.fn()
- render(
- <ClassItem
- nodeId="node-1"
- payload={createTopic()}
- onChange={onChange}
- onRemove={onRemove}
- index={1}
- filterVar={() => true}
- />,
- )
+ function EditableClass() {
+ const [topic, setTopic] = useState(createTopic)
+ const [removed, setRemoved] = useState(false)
+ return (
+ <>
+ {!removed && (
+ <ClassItem
+ nodeId="node-1"
+ payload={topic}
+ onChange={setTopic}
+ onRemove={() => setRemoved(true)}
+ index={1}
+ filterVar={() => true}
+ />
+ )}
+ <output aria-label="Saved class">{JSON.stringify(topic)}</output>
+ <output aria-label="Removal state">{removed ? 'removed' : 'present'}</output>
+ </>
+ )
+ }
- await user.tripleClick(screen.getByRole('textbox', { name: 'class-name' }))
- await user.paste('Billing questions updated')
- await user.click(screen.getByRole('button', { name: 'remove-item' }))
+ renderClass(<EditableClass />)
- expect(onChange).toHaveBeenCalledWith({
- id: 'topic-1',
- name: 'Billing questions updated',
- })
- expect(onRemove).toHaveBeenCalledTimes(1)
expect(screen.getByRole('button', { name: 'CLASS 1' })).toBeInTheDocument()
+ await replacePromptEditorText(screen.getByRole('textbox'), 'Billing questions updated')
+ await waitFor(() =>
+ expect(JSON.parse(screen.getByRole('status', { name: 'Saved class' }).textContent!)).toEqual({
+ id: 'topic-1',
+ name: 'Billing questions updated',
+ }),
+ )
+ await user.click(screen.getByRole('button', { name: 'common.operation.remove' }))
+
+ expect(screen.getByRole('status', { name: 'Removal state' })).toHaveTextContent('removed')
+ expect(screen.queryByRole('textbox')).not.toBeInTheDocument()
})
it('preserves a custom label when editing the classifier name', async () => {
- const user = userEvent.setup()
- const onChange = vi.fn()
+ function LabeledClass() {
+ const [topic, setTopic] = useState(() => createTopic({ label: 'Billing' }))
+ return (
+ <>
+ <ClassItem
+ nodeId="node-1"
+ payload={topic}
+ onChange={setTopic}
+ onRemove={() => {}}
+ index={1}
+ filterVar={() => true}
+ />
+ <output aria-label="Saved class">{JSON.stringify(topic)}</output>
+ </>
+ )
+ }
- render(
- <ClassItem
- nodeId="node-1"
- payload={createTopic({ label: 'Billing' })}
- onChange={onChange}
- onRemove={vi.fn()}
- index={1}
- filterVar={() => true}
- />,
- )
+ renderClass(<LabeledClass />)
- await user.tripleClick(screen.getByRole('textbox', { name: 'class-name' }))
- await user.paste('Billing questions updated')
+ await replacePromptEditorText(screen.getByRole('textbox'), 'Billing questions updated')
- expect(onChange).toHaveBeenCalledWith({
- id: 'topic-1',
- name: 'Billing questions updated',
- label: 'Billing',
- })
+ await waitFor(() =>
+ expect(JSON.parse(screen.getByRole('status', { name: 'Saved class' }).textContent!)).toEqual({
+ id: 'topic-1',
+ name: 'Billing questions updated',
+ label: 'Billing',
+ }),
+ )
expect(screen.getByRole('button', { name: 'Billing' })).toBeInTheDocument()
})
})
it('preserves the group name during label editing and updates it on save', async () => {
const user = userEvent.setup()
- function NamedClass({ readonly = false }: { readonly?: boolean }) {
- const [topic, setTopic] = useState(createTopic({ label: 'Billing' }))
+ function NamedClass() {
+ const [topic, setTopic] = useState(() => createTopic({ label: 'Billing' }))
+ const [readonly, setReadonly] = useState(false)
return (
- <div role="group" aria-labelledby="class-title">
- <ClassItem
- labelId="class-title"
- nodeId="node-1"
- payload={topic}
- onChange={setTopic}
- onRemove={vi.fn()}
- index={1}
- filterVar={() => true}
- readonly={readonly}
- />
- </div>
+ <>
+ <button type="button" onClick={() => setReadonly(true)}>
+ Make readonly
+ </button>
+ <div role="group" aria-labelledby="class-title">
+ <ClassItem
+ labelId="class-title"
+ nodeId="node-1"
+ payload={topic}
+ onChange={setTopic}
+ onRemove={() => {}}
+ index={1}
+ filterVar={() => true}
+ readonly={readonly}
+ />
+ </div>
+ </>
)
}
- const { rerender } = render(<NamedClass />)
- const group = screen.getByRole('group', { name: 'Billing' })
+ renderClass(<NamedClass />)
+ expect(screen.getByRole('group', { name: 'Billing' })).toBeInTheDocument()
await user.dblClick(screen.getByRole('button', { name: 'Billing' }))
const labelInput = screen.getByRole('textbox', {
name: 'workflowModels.nodes.questionClassifiers.labelEditorAriaLabel',
})
await user.clear(labelInput)
await user.type(labelInput, 'Refunds')
- expect(group).toHaveAccessibleName('Billing')
+ expect(screen.getByRole('group', { name: 'Billing' })).toBeInTheDocument()
await user.keyboard('{Enter}')
- expect(group).toHaveAccessibleName('Refunds')
- rerender(<NamedClass readonly />)
- expect(group).toHaveAccessibleName('Refunds')
+ expect(screen.getByRole('group', { name: 'Refunds' })).toBeInTheDocument()
+ await user.click(screen.getByRole('button', { name: 'Make readonly' }))
+ expect(screen.getByRole('group', { name: 'Refunds' })).toBeInTheDocument()
})