Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(web): separate app dialog group and control labels (#44261)

yyh3552815c8941
diff --git a/web/app/components/app-sidebar/app-info/__tests__/app-info-identity.spec.tsx b/web/app/components/app-sidebar/app-info/__tests__/app-info-identity.spec.tsx
index 9fae8f9c2fa..441e9992c4a 100644
--- a/web/app/components/app-sidebar/app-info/__tests__/app-info-identity.spec.tsx
+++ b/web/app/components/app-sidebar/app-info/__tests__/app-info-identity.spec.tsx
@@ -59,7 +59,7 @@ describe('AppInfoView identity in the app detail sidebar', () => {
await user.click(screen.getByRole('button', { name: /moreActionsFor/ }))
await user.click(await screen.findByRole('menuitem', { name: 'app.editApp' }))
- const name = await screen.findByRole('textbox', { name: 'app.newApp.captionName' })
+ const name = await screen.findByRole('textbox', { name: 'app.newApp.name' })
await user.clear(name)
await user.type(name, 'Unsaved draft')
diff --git a/web/app/components/app-sidebar/app-info/__tests__/app-info-modals.spec.tsx b/web/app/components/app-sidebar/app-info/__tests__/app-info-modals.spec.tsx
index 009a3930af1..e09cb786355 100644
--- a/web/app/components/app-sidebar/app-info/__tests__/app-info-modals.spec.tsx
+++ b/web/app/components/app-sidebar/app-info/__tests__/app-info-modals.spec.tsx
@@ -75,6 +75,16 @@ beforeEach(() => {
service.exportWorkflow.mockReset()
})
+it.each(['edit', 'duplicate'] as const)(
+ 'separates the %s app name and icon within their named group',
+ async (operation) => {
+ render(<MetadataEntry operation={operation} />)
+ const group = await screen.findByRole('group', { name: 'app.newApp.captionName' })
+ expect(within(group).getByRole('textbox', { name: 'app.newApp.name' })).toBeRequired()
+ expect(within(group).getByRole('button', { name: 'app.iconPicker.title' })).toBeEnabled()
+ },
+)
+
it('keeps the edit draft on failure, guards pending dismissal and closes only after a successful save', async () => {
const user = userEvent.setup()
let reject: (error: Error) => void = () => {}
@@ -85,7 +95,7 @@ it('keeps the edit draft on failure, guards pending dismissal and closes only af
}),
)
render(<MetadataEntry />)
- const name = await screen.findByRole('textbox', { name: 'app.newApp.captionName' })
+ const name = await screen.findByRole('textbox', { name: 'app.newApp.name' })
await user.clear(name)
await user.type(name, 'Retried name')
await user.click(screen.getByRole('button', { name: 'common.operation.save' }))
@@ -104,7 +114,7 @@ it('keeps the edit draft on failure, guards pending dismissal and closes only af
it('keeps the edit draft after an outside press and still allows explicit cancellation', async () => {
const user = userEvent.setup()
render(<MetadataEntry />)
- const name = await screen.findByRole('textbox', { name: 'app.newApp.captionName' })
+ const name = await screen.findByRole('textbox', { name: 'app.newApp.name' })
await user.clear(name)
await user.type(name, 'Unsaved draft')
await user.click(document.body)
@@ -118,22 +128,20 @@ it('keeps the edit draft after an outside press and still allows explicit cancel
it('discards a cancelled draft and initializes the next edit session from saved data', async () => {
const user = userEvent.setup()
render(<MetadataEntry />)
- const name = await screen.findByRole('textbox', { name: 'app.newApp.captionName' })
+ const name = await screen.findByRole('textbox', { name: 'app.newApp.name' })
await user.clear(name)
await user.type(name, 'Discarded')
await user.click(screen.getByRole('button', { name: 'common.operation.cancel' }))
await waitFor(() => expect(screen.queryByRole('dialog')).not.toBeInTheDocument())
await user.click(screen.getByRole('button', { name: 'Reopen' }))
- expect(await screen.findByRole('textbox', { name: 'app.newApp.captionName' })).toHaveValue(
- app.name,
- )
+ expect(await screen.findByRole('textbox', { name: 'app.newApp.name' })).toHaveValue(app.name)
})
it('keeps the duplicate name after a failed copy', async () => {
const user = userEvent.setup()
service.request.mockRejectedValueOnce(new Error('Unavailable'))
render(<MetadataEntry operation="duplicate" />)
- const name = await screen.findByRole('textbox', { name: 'app.newApp.captionName' })
+ const name = await screen.findByRole('textbox', { name: 'app.newApp.name' })
await user.clear(name)
await user.type(name, 'Copy draft{Enter}')
await waitFor(() => expect(service.request).toHaveBeenCalledTimes(1))
@@ -220,9 +228,7 @@ it.each(['edit', 'duplicate', 'switch', 'delete', 'importDSL'] as const)(
? within(dialog).getByRole('button', { name: 'app.dslUploader.browse' })
: within(dialog).getByRole(
'textbox',
- operation === 'delete'
- ? {}
- : { name: operation === 'switch' ? 'app.switchLabel' : 'app.newApp.captionName' },
+ operation === 'delete' ? {} : { name: 'app.newApp.name' },
)
await waitFor(() => expect(target).toHaveFocus())
},
@@ -251,7 +257,7 @@ it('validates the edit form and submits current values after choosing an icon',
const user = userEvent.setup()
service.request.mockResolvedValueOnce(Response.json(app))
render(<MetadataEntry />)
- const name = await screen.findByRole('textbox', { name: 'app.newApp.captionName' })
+ const name = await screen.findByRole('textbox', { name: 'app.newApp.name' })
await user.clear(name)
await user.keyboard('{Enter}')
expect(service.request).not.toHaveBeenCalled()
diff --git a/web/app/components/app-sidebar/app-info/app-metadata-dialog.tsx b/web/app/components/app-sidebar/app-info/app-metadata-dialog.tsx
index e5949d00c64..0130f63b198 100644
--- a/web/app/components/app-sidebar/app-info/app-metadata-dialog.tsx
+++ b/web/app/components/app-sidebar/app-info/app-metadata-dialog.tsx
@@ -16,6 +16,7 @@ import {
DialogTitle,
} from '@langgenius/dify-ui/dialog'
import { Field, FieldDescription, FieldError, FieldLabel } from '@langgenius/dify-ui/field'
+import { Fieldset, FieldsetLegend } from '@langgenius/dify-ui/fieldset'
import { Form } from '@langgenius/dify-ui/form'
import { Input } from '@langgenius/dify-ui/input'
import { Switch } from '@langgenius/dify-ui/switch'
@@ -216,29 +217,38 @@ function AppMetadataForm({
/>
</DialogHeader>
<DialogBody className="flex flex-col gap-4">
- <IconPicker value={icon} onValueChange={setSelectedIcon}>
+ <Fieldset className="grid grid-cols-[auto_minmax(0,1fr)] items-center gap-x-2 gap-y-1">
+ <FieldsetLegend className="col-span-2 mb-0">
+ {t(($) => $['newApp.captionName'], { ns: 'app' })}
+ </FieldsetLegend>
+ <IconPicker value={icon} onValueChange={setSelectedIcon}>
+ <IconPickerTrigger
+ disabled={isPending}
+ aria-label={t(($) => $['iconPicker.title'], { ns: 'app' })}
+ >
+ <IconPickerIcon size="large" />
+ </IconPickerTrigger>
+ <IconPickerContent />
+ </IconPicker>
<Field
name="name"
+ className="contents"
validate={(value) =>
typeof value === 'string' && !value.trim()
? t(($) => $['appCustomize.nameRequired'], { ns: 'explore' })
: null
}
>
- <FieldLabel>{t(($) => $['newApp.captionName'], { ns: 'app' })}</FieldLabel>
- <div className="flex items-center gap-2">
- <IconPickerTrigger
- disabled={isPending}
- aria-label={t(($) => $['iconPicker.title'], { ns: 'app' })}
- >
- <IconPickerIcon size="large" />
- </IconPickerTrigger>
- <Input ref={nameInputRef} defaultValue={source.name} readOnly={isPending} required />
- </div>
- <FieldError />
+ <Input
+ aria-label={t(($) => $['newApp.name'], { ns: 'app' })}
+ ref={nameInputRef}
+ defaultValue={source.name}
+ readOnly={isPending}
+ required
+ />
+ <FieldError className="col-span-2" />
</Field>
- <IconPickerContent />
- </IconPicker>
+ </Fieldset>
{isEdit && (
<>
<Field name="description">
diff --git a/web/app/components/app/create-app-modal/__tests__/index.spec.tsx b/web/app/components/app/create-app-modal/__tests__/index.spec.tsx
index 5fb36790c5d..345e50b5034 100644
--- a/web/app/components/app/create-app-modal/__tests__/index.spec.tsx
+++ b/web/app/components/app/create-app-modal/__tests__/index.spec.tsx
@@ -103,6 +103,18 @@ describe('CreateAppModal', () => {
mockConsoleState.workspacePermissionKeys = ['app.create_and_management']
})
+ it('names the app input separately from its group and focuses the description from its visible label', async () => {
+ const user = userEvent.setup()
+ renderModal()
+
+ expect(screen.getByRole('group', { name: 'app.newApp.captionName' })).toContainElement(
+ screen.getByRole('textbox', { name: 'app.newApp.name' }),
+ )
+ const description = screen.getByRole('textbox', { name: 'app.newApp.captionDescription' })
+ await user.click(screen.getByText('app.newApp.captionDescription'))
+ expect(description).toHaveFocus()
+ })
+
it('creates an app and fires callbacks', async () => {
const user = userEvent.setup()
const mockApp = createAppDetailFixture({
diff --git a/web/app/components/app/create-app-modal/index.tsx b/web/app/components/app/create-app-modal/index.tsx
index b3843b7009d..e3a69ba5bee 100644
--- a/web/app/components/app/create-app-modal/index.tsx
+++ b/web/app/components/app/create-app-modal/index.tsx
@@ -6,6 +6,8 @@ import type { IconPickerValue } from '@/app/components/base/icon-picker'
import { zPostAppsBody } from '@dify/contracts/api/console/apps/zod.gen'
import { Button } from '@langgenius/dify-ui/button'
import { cn } from '@langgenius/dify-ui/cn'
+import { Field } from '@langgenius/dify-ui/field'
+import { Fieldset, FieldsetLegend } from '@langgenius/dify-ui/fieldset'
import { Input } from '@langgenius/dify-ui/input'
import { Kbd, KbdGroup } from '@langgenius/dify-ui/kbd'
import { Separator } from '@langgenius/dify-ui/separator'
@@ -51,7 +53,7 @@ const shouldExpandBeginnerAppTypes = (appMode?: AppType) => {
function CreateApp({ onClose, onCreateFromTemplate, defaultAppMode }: CreateAppProps) {
const { t } = useTranslation(['app'])
const { push } = useRouter()
- const nameInputId = useId()
+ const descriptionInputId = useId()
const contentRef = useRef<HTMLDivElement>(null)
const [appMode, setAppMode] = useState<AppType>(defaultAppMode || 'advanced-chat')
@@ -308,19 +310,19 @@ function CreateApp({ onClose, onCreateFromTemplate, defaultAppMode }: CreateAppP
)}
</div>
<Separator />
- <div className="flex items-center space-x-3">
+ <Fieldset className="flex items-center space-x-3">
<div className="flex-1">
- <div className="mb-1 flex h-6 items-center">
- <label htmlFor={nameInputId} className="system-sm-semibold text-text-secondary">
- {t(($) => $['newApp.captionName'], { ns: 'app' })}
- </label>
- </div>
- <Input
- id={nameInputId}
- value={name}
- onChange={(e) => setName(e.target.value)}
- placeholder={t(($) => $['newApp.appNamePlaceholder'], { ns: 'app' }) || ''}
- />
+ <FieldsetLegend className="flex h-6 items-center py-0 system-sm-semibold">
+ {t(($) => $['newApp.captionName'], { ns: 'app' })}
+ </FieldsetLegend>
+ <Field name="name">
+ <Input
+ aria-label={t(($) => $['newApp.name'], { ns: 'app' })}
+ value={name}
+ onChange={(e) => setName(e.target.value)}
+ placeholder={t(($) => $['newApp.appNamePlaceholder'], { ns: 'app' }) || ''}
+ />
+ </Field>
</div>
<IconPicker value={appIcon} onValueChange={setAppIcon}>
<IconPickerTrigger
@@ -331,10 +333,13 @@ function CreateApp({ onClose, onCreateFromTemplate, defaultAppMode }: CreateAppP
</IconPickerTrigger>
<IconPickerContent />
</IconPicker>
- </div>
+ </Fieldset>
<div>
<div className="mb-1 flex h-6 items-center">
- <label className="system-sm-semibold text-text-secondary">
+ <label
+ htmlFor={descriptionInputId}
+ className="system-sm-semibold text-text-secondary"
+ >
{t(($) => $['newApp.captionDescription'], { ns: 'app' })}
</label>
<span className="ml-1 system-xs-regular text-text-tertiary">
@@ -342,7 +347,7 @@ function CreateApp({ onClose, onCreateFromTemplate, defaultAppMode }: CreateAppP
</span>
</div>
<Textarea
- aria-label={t(($) => $['newApp.captionDescription'], { ns: 'app' })}
+ id={descriptionInputId}
className="resize-none"
placeholder={t(($) => $['newApp.appDescriptionPlaceholder'], { ns: 'app' }) || ''}
value={description}
diff --git a/web/app/components/app/duplicate-modal/__tests__/index.spec.tsx b/web/app/components/app/duplicate-modal/__tests__/index.spec.tsx
index 9c97cbd84dc..6d4a3cc60ec 100644
--- a/web/app/components/app/duplicate-modal/__tests__/index.spec.tsx
+++ b/web/app/components/app/duplicate-modal/__tests__/index.spec.tsx
@@ -37,7 +37,7 @@ function render(ui: ReactElement) {
describe('DuplicateAppModal', () => {
const getIconButton = () =>
screen.getByRole('button', {
- name: /operation\.edit.*appCustomize\.subTitle/,
+ name: /iconPicker\.title/,
})
beforeEach(() => {
@@ -88,13 +88,16 @@ describe('DuplicateAppModal', () => {
)
expect(screen.getByRole('dialog', { name: /duplicateTitle/ })).toBeInTheDocument()
- const input = screen.getByRole('textbox', { name: /appCustomize\.subTitle/ })
+ const input = screen.getByRole('textbox', { name: /newApp\.name/ })
+ expect(screen.getByRole('group', { name: 'explore.appCustomize.subTitle' })).toContainElement(
+ input,
+ )
await user.clear(input)
await user.type(input, 'Updated App')
expect(input).toHaveValue('Updated App')
await user.clear(input)
- await user.click(screen.getByRole('textbox', { name: /appCustomize\.subTitle/ }))
+ await user.click(screen.getByRole('textbox', { name: /newApp\.name/ }))
await user.keyboard('{Enter}')
expect(toastErrorMock).toHaveBeenCalledWith(
@@ -131,7 +134,7 @@ describe('DuplicateAppModal', () => {
expect(screen.queryByPlaceholderText('app.iconPicker.search')).not.toBeInTheDocument()
})
expect(onConfirm).not.toHaveBeenCalled()
- expect(screen.getByRole('textbox', { name: /appCustomize\.subTitle/ })).toHaveValue('Demo App')
+ expect(screen.getByRole('textbox', { name: /newApp\.name/ })).toHaveValue('Demo App')
await user.click(screen.getByRole('button', { name: /(?:^|\.)duplicate(?=$|:)/ }))
expect(onConfirm).toHaveBeenCalledWith({
@@ -201,7 +204,7 @@ describe('DuplicateAppModal', () => {
/>,
)
- await user.click(screen.getByRole('textbox', { name: /appCustomize\.subTitle/ }))
+ await user.click(screen.getByRole('textbox', { name: /newApp\.name/ }))
await user.keyboard('{Enter}')
expect(onConfirm).not.toHaveBeenCalled()
diff --git a/web/app/components/app/duplicate-modal/index.tsx b/web/app/components/app/duplicate-modal/index.tsx
index 0c0c9aeece6..2f3bf5d87ed 100644
--- a/web/app/components/app/duplicate-modal/index.tsx
+++ b/web/app/components/app/duplicate-modal/index.tsx
@@ -11,7 +11,8 @@ import {
DialogHeader,
DialogTitle,
} from '@langgenius/dify-ui/dialog'
-import { Field, FieldLabel } from '@langgenius/dify-ui/field'
+import { Field } from '@langgenius/dify-ui/field'
+import { Fieldset, FieldsetLegend } from '@langgenius/dify-ui/fieldset'
import { Input } from '@langgenius/dify-ui/input'
import { useQuery } from '@tanstack/react-query'
import { useAtomValue } from 'jotai'
@@ -125,29 +126,32 @@ const DuplicateAppModal = ({
}}
>
<DialogBody>
- <IconPicker value={pickerValue} onValueChange={setSelectedIcon}>
- <Field name="name">
- <FieldLabel className="system-md-medium">
- {t(($) => $['appCustomize.subTitle'], { ns: 'explore' })}
- </FieldLabel>
- <div className="flex items-center justify-between space-x-2">
+ <Fieldset>
+ <FieldsetLegend className="system-md-medium">
+ {t(($) => $['appCustomize.subTitle'], { ns: 'explore' })}
+ </FieldsetLegend>
+ <div className="flex items-center justify-between space-x-2">
+ <IconPicker value={pickerValue} onValueChange={setSelectedIcon}>
<IconPickerTrigger
- aria-label={`${t(($) => $['operation.edit'], { ns: 'common' })} ${t(($) => $['appCustomize.subTitle'], { ns: 'explore' })}`}
+ aria-label={t(($) => $['iconPicker.title'], { ns: 'app' })}
className="shrink-0 cursor-pointer rounded-[10px]"
>
<IconPickerIcon size="large" />
</IconPickerTrigger>
+ <IconPickerContent />
+ </IconPicker>
+ <Field name="name" className="grow">
<Input
+ aria-label={t(($) => $['newApp.name'], { ns: 'app' })}
autoComplete="off"
value={name}
onChange={(e) => setName(e.target.value)}
className="h-10"
placeholder={t(($) => $['placeholder.input'], { ns: 'common' }) || ''}
/>
- </div>
- </Field>
- <IconPickerContent />
- </IconPicker>
+ </Field>
+ </div>
+ </Fieldset>
{isAppsFull && <AppsFull className="mt-4" loc="app-duplicate-create" />}
</DialogBody>
<DialogFooter>
diff --git a/web/app/components/app/switch-app-modal/__tests__/index.spec.tsx b/web/app/components/app/switch-app-modal/__tests__/index.spec.tsx
index 07308590b9e..300f960dd34 100644
--- a/web/app/components/app/switch-app-modal/__tests__/index.spec.tsx
+++ b/web/app/components/app/switch-app-modal/__tests__/index.spec.tsx
@@ -173,7 +173,8 @@ describe('SwitchAppModal', () => {
it('should validate blank names and submit the current field value with Enter', async () => {
const user = userEvent.setup()
renderComponent()
- const nameInput = screen.getByDisplayValue('Demo App(copy)')
+ const nameInput = screen.getByRole('textbox', { name: 'app.newApp.name' })
+ expect(screen.getByRole('group', { name: 'app.switchLabel' })).toContainElement(nameInput)
await user.clear(nameInput)
await user.type(nameInput, ' {Enter}')
expect(await screen.findByText('explore.appCustomize.nameRequired')).toBeVisible()
diff --git a/web/app/components/app/switch-app-modal/index.tsx b/web/app/components/app/switch-app-modal/index.tsx
index e1e325afee7..552c9e46a37 100644
--- a/web/app/components/app/switch-app-modal/index.tsx
+++ b/web/app/components/app/switch-app-modal/index.tsx
@@ -29,7 +29,8 @@ import {
DialogHeader,
DialogTitle,
} from '@langgenius/dify-ui/dialog'
-import { Field, FieldError, FieldLabel } from '@langgenius/dify-ui/field'
+import { Field, FieldError } from '@langgenius/dify-ui/field'
+import { Fieldset, FieldsetLegend } from '@langgenius/dify-ui/fieldset'
import { Form } from '@langgenius/dify-ui/form'
import { Input } from '@langgenius/dify-ui/input'
import { useMutation, useQuery, useSuspenseQuery } from '@tanstack/react-query'
@@ -213,39 +214,41 @@ function SwitchAppSession({
/>
</DialogHeader>
<DialogBody>
- <IconPicker value={appIcon} onValueChange={setAppIcon}>
+ <Fieldset className="grid grid-cols-[auto_minmax(0,1fr)] items-center gap-x-2 gap-y-1">
+ <FieldsetLegend className="col-span-2 mb-0 block py-2 text-sm leading-5 font-medium text-text-primary">
+ {t(($) => $.switchLabel, { ns: 'app' })}
+ </FieldsetLegend>
+ <IconPicker value={appIcon} onValueChange={setAppIcon}>
+ <IconPickerTrigger
+ disabled={isPending}
+ aria-label={t(($) => $['iconPicker.title'], { ns: 'app' })}
+ className="shrink-0 cursor-pointer rounded-[10px]"
+ >
+ <IconPickerIcon size="large" />
+ </IconPickerTrigger>
+ <IconPickerContent />
+ </IconPicker>
<Field
name="name"
+ className="contents"
validate={(value) =>
typeof value === 'string' && !value.trim()
? t(($) => $['appCustomize.nameRequired'], { ns: 'explore' })
: null
}
>
- <FieldLabel className="block py-2 text-sm leading-5 font-medium text-text-primary">
- {t(($) => $.switchLabel, { ns: 'app' })}
- </FieldLabel>
- <div className="flex items-center justify-between space-x-2">
- <IconPickerTrigger
- disabled={isPending}
- aria-label={t(($) => $['iconPicker.title'], { ns: 'app' })}
- className="shrink-0 cursor-pointer rounded-[10px]"
- >
- <IconPickerIcon size="large" />
- </IconPickerTrigger>
- <Input
- ref={nameInputRef}
- required
- readOnly={isPending}
- defaultValue={`${sourceApp.name}(copy)`}
- placeholder={t(($) => $['newApp.appNamePlaceholder'], { ns: 'app' }) || ''}
- className="h-10 grow"
- />
- </div>
- <FieldError />
+ <Input
+ aria-label={t(($) => $['newApp.name'], { ns: 'app' })}
+ ref={nameInputRef}
+ required
+ readOnly={isPending}
+ defaultValue={`${sourceApp.name}(copy)`}
+ placeholder={t(($) => $['newApp.appNamePlaceholder'], { ns: 'app' }) || ''}
+ className="h-10 grow"
+ />
+ <FieldError className="col-span-2" />
</Field>
- <IconPickerContent />
- </IconPicker>
+ </Fieldset>
{isAppsFull && <AppsFull className="mt-4" loc="app-switch" />}
</DialogBody>
<DialogFooter>
diff --git a/web/app/components/apps/__tests__/app-card.spec.tsx b/web/app/components/apps/__tests__/app-card.spec.tsx
index 28a2c07b907..a900ea6554e 100644
--- a/web/app/components/apps/__tests__/app-card.spec.tsx
+++ b/web/app/components/apps/__tests__/app-card.spec.tsx
@@ -694,7 +694,7 @@ describe('AppCard', () => {
await chooseAction(user, 'app.editApp')
const dialog = await screen.findByRole('dialog', { name: 'app.editAppTitle' })
expect(screen.queryByRole('menu')).not.toBeInTheDocument()
- const name = within(dialog).getByRole('textbox', { name: 'app.newApp.captionName' })
+ const name = within(dialog).getByRole('textbox', { name: 'app.newApp.name' })
const description = within(dialog).getByRole('textbox', {
name: 'app.newApp.captionDescription',
})
@@ -727,29 +727,27 @@ describe('AppCard', () => {
{
action: 'app.editApp',
title: 'app.editAppTitle',
- label: 'app.newApp.captionName',
initial: 'Test App',
},
{
action: 'app.duplicate',
title: 'app.duplicateTitle',
- label: 'explore.appCustomize.subTitle',
initial: 'Test App',
},
])(
'discards unsubmitted name changes when reopening $action',
- async ({ action, title, label, initial }) => {
+ async ({ action, title, initial }) => {
const user = userEvent.setup()
render(<AppCard app={mockApp} />)
await chooseAction(user, action)
const dialog = await screen.findByRole('dialog', { name: title })
- const input = within(dialog).getByRole('textbox', { name: label })
+ const input = within(dialog).getByRole('textbox', { name: 'app.newApp.name' })
await user.clear(input)
await user.type(input, 'Unsaved name')
await user.click(within(dialog).getByRole('button', { name: 'common.operation.cancel' }))
await waitFor(() => expect(dialog).not.toBeInTheDocument())
await chooseAction(user, action)
- expect(await screen.findByRole('textbox', { name: label })).toHaveValue(initial)
+ expect(await screen.findByRole('textbox', { name: 'app.newApp.name' })).toHaveValue(initial)
expect(api.update).not.toHaveBeenCalled()
expect(api.copy).not.toHaveBeenCalled()
},
@@ -760,7 +758,7 @@ describe('AppCard', () => {
render(<AppCard app={mockApp} />)
await chooseAction(user, 'app.duplicate')
const dialog = await screen.findByRole('dialog', { name: 'app.duplicateTitle' })
- const name = within(dialog).getByRole('textbox', { name: 'explore.appCustomize.subTitle' })
+ const name = within(dialog).getByRole('textbox', { name: 'app.newApp.name' })
await user.clear(name)
await user.type(name, 'Copied App')
await user.click(within(dialog).getByRole('button', { name: 'app.duplicate' }))
@@ -790,7 +788,7 @@ describe('AppCard', () => {
render(<AppCard app={createMockApp({ mode })} />)
await chooseAction(user, 'app.switch')
const dialog = await screen.findByRole('dialog', { name: 'app.switch' })
- const name = within(dialog).getByRole('textbox', { name: 'app.switchLabel' })
+ const name = within(dialog).getByRole('textbox', { name: 'app.newApp.name' })
await user.clear(name)
await user.type(name, 'Converted App')
await user.click(within(dialog).getByRole('button', { name: 'app.switchStart' }))
diff --git a/web/app/components/apps/__tests__/list.spec.tsx b/web/app/components/apps/__tests__/list.spec.tsx
index dfc246fefe5..347618bf75d 100644
--- a/web/app/components/apps/__tests__/list.spec.tsx
+++ b/web/app/components/apps/__tests__/list.spec.tsx
@@ -394,9 +394,7 @@ it('opens a real blank-app form from the first empty state', async () => {
const { user } = await setup()
await user.click(screen.getByRole('button', { name: /app.newApp.startFromBlank/ }))
const dialog = await screen.findByRole('dialog', { name: 'app.newApp.startFromBlank' })
- expect(
- within(dialog).getByRole('textbox', { name: 'app.newApp.captionName' }),
- ).toBeInTheDocument()
+ expect(within(dialog).getByRole('textbox', { name: 'app.newApp.name' })).toBeInTheDocument()
})
it('opens DSL import with the file dropped on the app list', async () => {
diff --git a/web/app/components/explore/create-app-modal/__tests__/index.spec.tsx b/web/app/components/explore/create-app-modal/__tests__/index.spec.tsx
index aa66065b13e..ffb624f20a9 100644
--- a/web/app/components/explore/create-app-modal/__tests__/index.spec.tsx
+++ b/web/app/components/explore/create-app-modal/__tests__/index.spec.tsx
@@ -79,6 +79,19 @@ describe('CreateAppModal', () => {
mockAppCount = 1
})
+ it('names the app controls separately and associates the answer icon switch with its label and description', async () => {
+ const user = userEvent.setup()
+ await setup({ isEditModal: true })
+
+ const group = screen.getByRole('group', { name: 'app.newApp.captionName' })
+ expect(within(group).getByRole('textbox', { name: 'app.newApp.name' })).toHaveValue('Test App')
+ expect(within(group).getByRole('button', { name: 'app.iconPicker.title' })).toBeEnabled()
+ const answerIcon = screen.getByRole('switch', { name: 'app.answerIcon.title' })
+ expect(answerIcon).toHaveAccessibleDescription('app.answerIcon.descriptionInExplore')
+ await user.click(screen.getByText('app.answerIcon.title'))
+ expect(answerIcon).toBeChecked()
+ })
+
it.each([
{ appIconType: null, appIcon: null, appIconBackground: null },
{
diff --git a/web/app/components/explore/create-app-modal/index.tsx b/web/app/components/explore/create-app-modal/index.tsx
index 2660bbb98ea..e3d7df1e9ba 100644
--- a/web/app/components/explore/create-app-modal/index.tsx
+++ b/web/app/components/explore/create-app-modal/index.tsx
@@ -16,6 +16,8 @@ import {
DialogHeader,
DialogTitle,
} from '@langgenius/dify-ui/dialog'
+import { Field, FieldDescription, FieldLabel } from '@langgenius/dify-ui/field'
+import { Fieldset, FieldsetLegend } from '@langgenius/dify-ui/fieldset'
import { Input } from '@langgenius/dify-ui/input'
import { Kbd, KbdGroup } from '@langgenius/dify-ui/kbd'
import { Switch } from '@langgenius/dify-ui/switch'
@@ -75,7 +77,6 @@ const CreateAppModal = ({
confirmLoading,
onHide,
}: CreateAppModalProps) => {
- const nameInputId = React.useId()
const descriptionInputId = React.useId()
const maxActiveRequestsInputId = React.useId()
const { t } = useTranslation(['app', 'common', 'explore'])
@@ -219,13 +220,10 @@ const CreateAppModal = ({
</DialogHeader>
<DialogBody>
{/* icon & name */}
- <div className="pt-2">
- <label
- htmlFor={nameInputId}
- className="block py-2 text-sm leading-5 font-medium text-text-primary"
- >
+ <Fieldset className="pt-2">
+ <FieldsetLegend className="mb-0 block py-2 text-sm leading-5 font-medium text-text-primary">
{t(($) => $['newApp.captionName'], { ns: 'app' })}
- </label>
+ </FieldsetLegend>
<div className="flex items-center justify-between space-x-2">
<IconPicker value={pickerValue} onValueChange={setSelectedIcon}>
<IconPickerTrigger
@@ -236,15 +234,17 @@ const CreateAppModal = ({
</IconPickerTrigger>
<IconPickerContent />
</IconPicker>
- <Input
- id={nameInputId}
- value={name}
- onChange={(e) => setName(e.target.value)}
- placeholder={t(($) => $['newApp.appNamePlaceholder'], { ns: 'app' }) || ''}
- className="h-10 grow"
- />
+ <Field name="name" className="grow">
+ <Input
+ aria-label={t(($) => $['newApp.name'], { ns: 'app' })}
+ value={name}
+ onChange={(e) => setName(e.target.value)}
+ placeholder={t(($) => $['newApp.appNamePlaceholder'], { ns: 'app' }) || ''}
+ className="h-10 grow"
+ />
+ </Field>
</div>
- </div>
+ </Fieldset>
{/* description */}
<div className="pt-2">
<label
@@ -264,20 +264,20 @@ const CreateAppModal = ({
{/* answer icon */}
{isEditModal &&
(appMode === 'chat' || appMode === 'advanced-chat' || appMode === 'agent-chat') && (
- <div className="pt-2">
+ <Field name="use_icon_as_answer_icon" className="gap-0 pt-2">
<div className="flex items-center justify-between">
- <div className="py-2 text-sm leading-5 font-medium text-text-primary">
+ <FieldLabel className="py-2 text-sm leading-5 font-medium text-text-primary">
{t(($) => $['answerIcon.title'], { ns: 'app' })}
- </div>
+ </FieldLabel>
<Switch
checked={useIconAsAnswerIcon}
onCheckedChange={(v) => setUseIconAsAnswerIcon(v)}
/>
</div>
- <p className="body-xs-regular text-text-tertiary">
+ <FieldDescription className="py-0">
{t(($) => $['answerIcon.descriptionInExplore'], { ns: 'app' })}
- </p>
- </div>
+ </FieldDescription>
+ </Field>
)}
{isEditModal && (
<div className="pt-2">
diff --git a/web/app/components/workflow/nodes/agent-v2/components/__tests__/agent-orchestrate-panel-content.spec.tsx b/web/app/components/workflow/nodes/agent-v2/components/__tests__/agent-orchestrate-panel-content.spec.tsx
index d714058c826..a1d05794a71 100644
--- a/web/app/components/workflow/nodes/agent-v2/components/__tests__/agent-orchestrate-panel-content.spec.tsx
+++ b/web/app/components/workflow/nodes/agent-v2/components/__tests__/agent-orchestrate-panel-content.spec.tsx
@@ -484,14 +484,26 @@ describe('Inline Agent configure workspace', () => {
it('does not unlock a new build run when an older completion refresh resolves', async () => {
const user = userEvent.setup()
+ // Advance the delayed refresh without spending the test budget on real timers.
+ const completeAndRefresh = async (index = 0) => {
+ vi.useFakeTimers()
+ try {
+ await complete(index)
+ await act(async () => {
+ await vi.advanceTimersByTimeAsync(1000)
+ })
+ } finally {
+ vi.useRealTimers()
+ }
+ }
const refreshed = createDeferred<AgentBuildDraftResponse>()
renderWorkspace()
await sendBuild(user)
await waitFor(() => expect(ssePost).toHaveBeenCalledOnce())
await receive()
api.loadBuildDraft.mockReturnValue(refreshed.promise)
- await complete()
- await waitFor(() => expect(api.loadBuildDraft).toHaveBeenCalledTimes(2), { timeout: 2000 })
+ await completeAndRefresh()
+ expect(api.loadBuildDraft).toHaveBeenCalledTimes(2)
await sendBuild(user, 'Improve the reviewer')
await waitFor(() => expect(ssePost).toHaveBeenCalledTimes(2))
await act(async () => refreshed.resolve(createBuildDraft('Old completion')))
@@ -500,8 +512,8 @@ describe('Inline Agent configure workspace', () => {
expect(promptEditor()).not.toHaveTextContent('Old completion')
await receive(1, 'build-conversation', 'Improved reviewer')
api.loadBuildDraft.mockResolvedValue(createBuildDraft('Improved instructions'))
- await complete(1)
- await waitFor(() => expect(applyButton()).toBeEnabled(), { timeout: 2000 })
+ await completeAndRefresh(1)
+ await waitFor(() => expect(applyButton()).toBeEnabled())
})
it('unlocks draft actions after the chat stream fails', async () => {
diff --git a/web/features/home/home-content/__tests__/home-content.spec.tsx b/web/features/home/home-content/__tests__/home-content.spec.tsx
index 4143896ff3a..fa4da1d648f 100644
--- a/web/features/home/home-content/__tests__/home-content.spec.tsx
+++ b/web/features/home/home-content/__tests__/home-content.spec.tsx
@@ -1090,7 +1090,7 @@ describe('HomeContent', () => {
renderHomeContent({ hasEditPermission: true })
await user.click(screen.getByRole('button', { name: 'Alpha' }))
const dialog = await screen.findByRole('dialog', { name: /explore.appCustomize.title/ })
- const name = within(dialog).getByRole('textbox', { name: 'app.newApp.captionName' })
+ const name = within(dialog).getByRole('textbox', { name: 'app.newApp.name' })
await user.clear(name)
await user.type(name, 'My imported app')
const create = within(dialog).getByRole('button', { name: /common.operation.create/ })
diff --git a/web/i18n/locales/ar-TN/app.json b/web/i18n/locales/ar-TN/app.json
index 47083eeaf75..8f38ee4858d 100644
--- a/web/i18n/locales/ar-TN/app.json
+++ b/web/i18n/locales/ar-TN/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} نتيجة",
"newApp.foundResults": "{{count}} نتائج",
"newApp.import": "استيراد",
+ "newApp.name": "اسم التطبيق",
"newApp.nameNotEmpty": "لا يمكن أن يكون الاسم فارغًا",
"newApp.noIdeaTip": "لا توجد أفكار؟ تحقق من قوالبنا",
"newApp.noTemplateFound": "لم يتم العثور على قوالب",
diff --git a/web/i18n/locales/az-AZ/app.json b/web/i18n/locales/az-AZ/app.json
index 056cce30230..eb16ef0b5e7 100644
--- a/web/i18n/locales/az-AZ/app.json
+++ b/web/i18n/locales/az-AZ/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} nəticə",
"newApp.foundResults": "{{count}} nəticə",
"newApp.import": "İdxal et",
+ "newApp.name": "Tətbiqin adı",
"newApp.nameNotEmpty": "Ad boş ola bilməz",
"newApp.noIdeaTip": "Fikriniz yoxdur? Şablonlarımıza baxın",
"newApp.noTemplateFound": "Şablon tapılmadı",
diff --git a/web/i18n/locales/de-DE/app.json b/web/i18n/locales/de-DE/app.json
index 264914754e4..3dd89ee4721 100644
--- a/web/i18n/locales/de-DE/app.json
+++ b/web/i18n/locales/de-DE/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Ergebnis",
"newApp.foundResults": "{{count}} Befund",
"newApp.import": "Importieren",
+ "newApp.name": "App-Name",
"newApp.nameNotEmpty": "Name darf nicht leer sein",
"newApp.noIdeaTip": "Keine Ideen? Schauen Sie sich unsere Vorlagen an",
"newApp.noTemplateFound": "Keine Vorlagen gefunden",
diff --git a/web/i18n/locales/en-US/app.json b/web/i18n/locales/en-US/app.json
index c9ac9f0755b..0328b0d4fd6 100644
--- a/web/i18n/locales/en-US/app.json
+++ b/web/i18n/locales/en-US/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Result",
"newApp.foundResults": "{{count}} Results",
"newApp.import": "Import",
+ "newApp.name": "App name",
"newApp.nameNotEmpty": "Name cannot be empty",
"newApp.noIdeaTip": "No ideas? Check out our templates",
"newApp.noTemplateFound": "No templates found",
diff --git a/web/i18n/locales/es-ES/app.json b/web/i18n/locales/es-ES/app.json
index 7d418ecaa78..b7e1743e677 100644
--- a/web/i18n/locales/es-ES/app.json
+++ b/web/i18n/locales/es-ES/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Resultado",
"newApp.foundResults": "{{count}} Resultados",
"newApp.import": "Importación",
+ "newApp.name": "Nombre de la aplicación",
"newApp.nameNotEmpty": "El nombre no puede estar vacío",
"newApp.noIdeaTip": "¿No tienes ideas? Echa un vistazo a nuestras plantillas",
"newApp.noTemplateFound": "No se han encontrado plantillas",
diff --git a/web/i18n/locales/fa-IR/app.json b/web/i18n/locales/fa-IR/app.json
index 7ca885a401a..15196959f28 100644
--- a/web/i18n/locales/fa-IR/app.json
+++ b/web/i18n/locales/fa-IR/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} نتیجه",
"newApp.foundResults": "{{count}} نتیجه",
"newApp.import": "واردات",
+ "newApp.name": "نام برنامه",
"newApp.nameNotEmpty": "نام نمی‌تواند خالی باشد",
"newApp.noIdeaTip": "ایده ای ندارید؟ قالب های ما را بررسی کنید",
"newApp.noTemplateFound": "هیچ الگویی یافت نشد",
diff --git a/web/i18n/locales/fr-FR/app.json b/web/i18n/locales/fr-FR/app.json
index 80ce57cce21..3b5af969f3c 100644
--- a/web/i18n/locales/fr-FR/app.json
+++ b/web/i18n/locales/fr-FR/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Résultat",
"newApp.foundResults": "{{count}} Résultats",
"newApp.import": "Importation",
+ "newApp.name": "Nom de l’application",
"newApp.nameNotEmpty": "Le nom ne peut pas être vide",
"newApp.noIdeaTip": "Pas d’idées ? Consultez nos modèles",
"newApp.noTemplateFound": "Aucun modèle trouvé",
diff --git a/web/i18n/locales/hi-IN/app.json b/web/i18n/locales/hi-IN/app.json
index 9bdcde41d2c..2896365823a 100644
--- a/web/i18n/locales/hi-IN/app.json
+++ b/web/i18n/locales/hi-IN/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} परिणाम",
"newApp.foundResults": "{{count}} परिणाम",
"newApp.import": "आयात",
+ "newApp.name": "ऐप का नाम",
"newApp.nameNotEmpty": "नाम खाली नहीं हो सकता",
"newApp.noIdeaTip": "कोई विचार नहीं? हमारे टेम्प्लेट देखें",
"newApp.noTemplateFound": "कोई टेम्पलेट नहीं मिला",
diff --git a/web/i18n/locales/id-ID/app.json b/web/i18n/locales/id-ID/app.json
index a1d919d426a..c9e091c8c58 100644
--- a/web/i18n/locales/id-ID/app.json
+++ b/web/i18n/locales/id-ID/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "Hasil {{count}}",
"newApp.foundResults": "Hasil {{count}}",
"newApp.import": "Mengimpor",
+ "newApp.name": "Nama aplikasi",
"newApp.nameNotEmpty": "Nama tidak boleh kosong",
"newApp.noIdeaTip": "Tidak ada ide? Lihat templat kami",
"newApp.noTemplateFound": "Tidak ada templat yang ditemukan",
diff --git a/web/i18n/locales/it-IT/app.json b/web/i18n/locales/it-IT/app.json
index 74116adadbc..7b38704ed9f 100644
--- a/web/i18n/locales/it-IT/app.json
+++ b/web/i18n/locales/it-IT/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Risultato",
"newApp.foundResults": "{{count}} Risultati",
"newApp.import": "Importazione",
+ "newApp.name": "Nome dell’app",
"newApp.nameNotEmpty": "Il nome non può essere vuoto",
"newApp.noIdeaTip": "Non hai idee? Dai un'occhiata ai nostri modelli",
"newApp.noTemplateFound": "Nessun modello trovato",
diff --git a/web/i18n/locales/ja-JP/app.json b/web/i18n/locales/ja-JP/app.json
index 04cb804db30..b701c7c5571 100644
--- a/web/i18n/locales/ja-JP/app.json
+++ b/web/i18n/locales/ja-JP/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}}件の結果",
"newApp.foundResults": "{{count}}件の結果",
"newApp.import": "輸入",
+ "newApp.name": "アプリ名",
"newApp.nameNotEmpty": "名前を入力してください",
"newApp.noIdeaTip": "アイデアがありませんか?テンプレートをご覧ください",
"newApp.noTemplateFound": "テンプレートが見つかりません",
diff --git a/web/i18n/locales/ko-KR/app.json b/web/i18n/locales/ko-KR/app.json
index d0c9e516e96..f0b190f8fca 100644
--- a/web/i18n/locales/ko-KR/app.json
+++ b/web/i18n/locales/ko-KR/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} 결과",
"newApp.foundResults": "{{count}} 결과",
"newApp.import": "가져오기",
+ "newApp.name": "앱 이름",
"newApp.nameNotEmpty": "이름을 입력하세요",
"newApp.noIdeaTip": "아이디어가 없으신가요? 템플릿을 확인해 보세요",
"newApp.noTemplateFound": "템플릿을 찾을 수 없습니다.",
diff --git a/web/i18n/locales/lo-LA/app.json b/web/i18n/locales/lo-LA/app.json
index 6a1b5ae9726..9c38d3f91f6 100644
--- a/web/i18n/locales/lo-LA/app.json
+++ b/web/i18n/locales/lo-LA/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} ຜົນລາຍການ",
"newApp.foundResults": "{{count}} ຜົນລາຍການ",
"newApp.import": "ນຳເຂົ້າ",
+ "newApp.name": "ຊື່ແອັບ",
"newApp.nameNotEmpty": "ຊື່ບໍ່ສາມາດຫວ່າງໄດ້",
"newApp.noIdeaTip": "ບໍ່ມີໄອເດຍບໍ? ເບິ່ງແມ່ແບບຂອງພວກເຮົາ",
"newApp.noTemplateFound": "ບໍ່ພົບແມ່ແບບ",
diff --git a/web/i18n/locales/nl-NL/app.json b/web/i18n/locales/nl-NL/app.json
index 90805d69975..58b6dba1abd 100644
--- a/web/i18n/locales/nl-NL/app.json
+++ b/web/i18n/locales/nl-NL/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Result",
"newApp.foundResults": "{{count}} Results",
"newApp.import": "Import",
+ "newApp.name": "Appnaam",
"newApp.nameNotEmpty": "Name cannot be empty",
"newApp.noIdeaTip": "No ideas? Check out our templates",
"newApp.noTemplateFound": "No templates found",
diff --git a/web/i18n/locales/pl-PL/app.json b/web/i18n/locales/pl-PL/app.json
index 78963ea1f03..d4b13ba04a5 100644
--- a/web/i18n/locales/pl-PL/app.json
+++ b/web/i18n/locales/pl-PL/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Wynik",
"newApp.foundResults": "{{count}} Wyniki",
"newApp.import": "Import",
+ "newApp.name": "Nazwa aplikacji",
"newApp.nameNotEmpty": "Nazwa nie może być pusta",
"newApp.noIdeaTip": "Nie masz pomysłów? Sprawdź nasze szablony",
"newApp.noTemplateFound": "Nie znaleziono szablonów",
diff --git a/web/i18n/locales/pt-BR/app.json b/web/i18n/locales/pt-BR/app.json
index 44a22896a85..1c929b5f139 100644
--- a/web/i18n/locales/pt-BR/app.json
+++ b/web/i18n/locales/pt-BR/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Resultado",
"newApp.foundResults": "{{count}} Resultados",
"newApp.import": "Importação",
+ "newApp.name": "Nome do aplicativo",
"newApp.nameNotEmpty": "O nome não pode estar vazio",
"newApp.noIdeaTip": "Sem ideias? Confira nossos modelos",
"newApp.noTemplateFound": "Nenhum modelo encontrado",
diff --git a/web/i18n/locales/ro-RO/app.json b/web/i18n/locales/ro-RO/app.json
index 0296e97d749..2ec218b17bf 100644
--- a/web/i18n/locales/ro-RO/app.json
+++ b/web/i18n/locales/ro-RO/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Rezultat",
"newApp.foundResults": "{{count}} Rezultatele",
"newApp.import": "Importa",
+ "newApp.name": "Numele aplicației",
"newApp.nameNotEmpty": "Numele nu poate fi gol",
"newApp.noIdeaTip": "Nicio idee? Consultați șabloanele noastre",
"newApp.noTemplateFound": "Nu s-au găsit șabloane",
diff --git a/web/i18n/locales/ru-RU/app.json b/web/i18n/locales/ru-RU/app.json
index 9e36913bf98..515f8930636 100644
--- a/web/i18n/locales/ru-RU/app.json
+++ b/web/i18n/locales/ru-RU/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Результат",
"newApp.foundResults": "{{count}} Результаты",
"newApp.import": "Импорт",
+ "newApp.name": "Название приложения",
"newApp.nameNotEmpty": "Имя не может быть пустым",
"newApp.noIdeaTip": "Нет идей? Ознакомьтесь с нашими шаблонами",
"newApp.noTemplateFound": "Шаблоны не найдены",
diff --git a/web/i18n/locales/sl-SI/app.json b/web/i18n/locales/sl-SI/app.json
index b96384f62b3..b8400d51c2a 100644
--- a/web/i18n/locales/sl-SI/app.json
+++ b/web/i18n/locales/sl-SI/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Rezultat",
"newApp.foundResults": "{{count}} Rezultati",
"newApp.import": "Uvoz",
+ "newApp.name": "Ime aplikacije",
"newApp.nameNotEmpty": "Ime ne sme biti prazno",
"newApp.noIdeaTip": "Nimate idej? Oglejte si naše predloge",
"newApp.noTemplateFound": "Predloge niso bile najdene",
diff --git a/web/i18n/locales/th-TH/app.json b/web/i18n/locales/th-TH/app.json
index 483a0ec8f51..f3e8652ecf0 100644
--- a/web/i18n/locales/th-TH/app.json
+++ b/web/i18n/locales/th-TH/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} ผล",
"newApp.foundResults": "{{count}} ผลลัพธ์",
"newApp.import": "นําเข้า",
+ "newApp.name": "ชื่อแอป",
"newApp.nameNotEmpty": "ชื่อต้องไม่ว่างเปล่า",
"newApp.noIdeaTip": "ไม่มีความคิด? ดูเทมเพลตของเรา",
"newApp.noTemplateFound": "ไม่พบเทมเพลต",
diff --git a/web/i18n/locales/tr-TR/app.json b/web/i18n/locales/tr-TR/app.json
index 645f4ddf567..99c82efc8a5 100644
--- a/web/i18n/locales/tr-TR/app.json
+++ b/web/i18n/locales/tr-TR/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Sonuç",
"newApp.foundResults": "{{count}} Sonuç",
"newApp.import": "İçe Aktar",
+ "newApp.name": "Uygulama adı",
"newApp.nameNotEmpty": "İsim boş olamaz",
"newApp.noIdeaTip": "Fikriniz yok mu? Şablonlarımıza göz atın",
"newApp.noTemplateFound": "Şablon bulunamadı",
diff --git a/web/i18n/locales/uk-UA/app.json b/web/i18n/locales/uk-UA/app.json
index d1465ccbf2d..6e843a1e9a8 100644
--- a/web/i18n/locales/uk-UA/app.json
+++ b/web/i18n/locales/uk-UA/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Результат",
"newApp.foundResults": "{{count}} Результатів",
"newApp.import": "Імпорт",
+ "newApp.name": "Назва застосунку",
"newApp.nameNotEmpty": "Назва не може бути порожньою",
"newApp.noIdeaTip": "Немає ідей? Перегляньте наші шаблони",
"newApp.noTemplateFound": "Не знайдено шаблонів",
diff --git a/web/i18n/locales/vi-VN/app.json b/web/i18n/locales/vi-VN/app.json
index 1c475e47d0e..e34ce52297c 100644
--- a/web/i18n/locales/vi-VN/app.json
+++ b/web/i18n/locales/vi-VN/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} Kết quả",
"newApp.foundResults": "{{count}} Kết quả",
"newApp.import": "Nhập khẩu",
+ "newApp.name": "Tên ứng dụng",
"newApp.nameNotEmpty": "Tên không được để trống",
"newApp.noIdeaTip": "Không có ý tưởng? Kiểm tra các mẫu của chúng tôi",
"newApp.noTemplateFound": "Không tìm thấy mẫu",
diff --git a/web/i18n/locales/zh-Hans/app.json b/web/i18n/locales/zh-Hans/app.json
index 559f993fb6d..4933b1f226a 100644
--- a/web/i18n/locales/zh-Hans/app.json
+++ b/web/i18n/locales/zh-Hans/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}} 个结果",
"newApp.foundResults": "{{count}} 个结果",
"newApp.import": "导入",
+ "newApp.name": "应用名称",
"newApp.nameNotEmpty": "名称不能为空",
"newApp.noIdeaTip": "没有想法?试试我们的模板",
"newApp.noTemplateFound": "未找到模板",
diff --git a/web/i18n/locales/zh-Hant/app.json b/web/i18n/locales/zh-Hant/app.json
index a6a4d6b59ce..c467b4c04da 100644
--- a/web/i18n/locales/zh-Hant/app.json
+++ b/web/i18n/locales/zh-Hant/app.json
@@ -197,6 +197,7 @@
"newApp.foundResult": "{{count}}結果",
"newApp.foundResults": "{{count}}結果",
"newApp.import": "進口",
+ "newApp.name": "應用程式名稱",
"newApp.nameNotEmpty": "名稱不能為空",
"newApp.noIdeaTip": "沒有想法?查看我們的範本",
"newApp.noTemplateFound": "未找到範本",
diff --git a/web/i18n/resources.generated.d.ts b/web/i18n/resources.generated.d.ts
index e8e43050a13..3fa85d97dcb 100644
--- a/web/i18n/resources.generated.d.ts
+++ b/web/i18n/resources.generated.d.ts
@@ -726,6 +726,7 @@ export default interface Resources {
'newApp.foundResult': '{{count}} Result'
'newApp.foundResults': '{{count}} Results'
'newApp.import': 'Import'
+ 'newApp.name': 'App name'
'newApp.nameNotEmpty': 'Name cannot be empty'
'newApp.noIdeaTip': 'No ideas? Check out our templates'
'newApp.noTemplateFound': 'No templates found'