Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix(api): enforce admin and RBAC permissions on tool OAuth custom client GET endpoint (#40944) (#40945)
Pranav Agarwal43b6d8e32e78
diff --git a/api/controllers/console/workspace/tool_providers.py b/api/controllers/console/workspace/tool_providers.pyindex a02e603373d..cb61f1582b6 100644--- a/api/controllers/console/workspace/tool_providers.py+++ b/api/controllers/console/workspace/tool_providers.py@@ -1296,6 +1296,8 @@ class ToolOAuthCustomClient(Resource):)@setup_required@login_required+ @is_admin_or_owner_required+ @rbac_permission_required(RBACResourceScope.WORKSPACE, RBACPermission.CREDENTIAL_MANAGE, resource_required=False)@account_initialization_required@with_current_tenant_iddef get(self, current_tenant_id: str, provider: str):diff --git a/api/tests/unit_tests/controllers/console/test_workspace_credential_mutation_permissions.py b/api/tests/unit_tests/controllers/console/test_workspace_credential_mutation_permissions.pyindex 321c957e79a..2f66ace3177 100644--- a/api/tests/unit_tests/controllers/console/test_workspace_credential_mutation_permissions.py+++ b/api/tests/unit_tests/controllers/console/test_workspace_credential_mutation_permissions.py@@ -7,7 +7,7 @@ from controllers.common.wraps import RBACPermission, RBACResourceScopefrom controllers.console.datasets.data_source import DataSourceApifrom controllers.console.workspace.model_providers import ModelProviderCredentialApifrom controllers.console.workspace.models import ModelProviderModelCredentialApi-from controllers.console.workspace.tool_providers import ToolBuiltinProviderAddApi+from controllers.console.workspace.tool_providers import ToolBuiltinProviderAddApi, ToolOAuthCustomClient@pytest.mark.parametrize(@@ -50,3 +50,18 @@ def test_model_provider_credential_get_requires_admin_and_rbac(assert rbac_config["resource_type"] == RBACResourceScope.WORKSPACEassert rbac_config["scene"] == RBACPermission.CREDENTIAL_MANAGEassert rbac_config["resource_required"] is False+++def test_tool_oauth_custom_client_get_requires_admin_and_rbac() -> None:+ """GET endpoint that returns custom OAuth client params must enforce+ the same admin + RBAC gates as its sibling POST and DELETE methods."""+ method = ToolOAuthCustomClient.get++ legacy_wrapper = unwrap(method, stop=lambda wrapper: "is_admin_or_owner_required" in wrapper.__code__.co_qualname)+ assert "is_admin_or_owner_required" in legacy_wrapper.__code__.co_qualname++ rbac_wrapper = unwrap(method, stop=lambda wrapper: "rbac_permission_required" in wrapper.__code__.co_qualname)+ rbac_config = getclosurevars(rbac_wrapper).nonlocals+ assert rbac_config["resource_type"] == RBACResourceScope.WORKSPACE+ assert rbac_config["scene"] == RBACPermission.CREDENTIAL_MANAGE+ assert rbac_config["resource_required"] is False