Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix(redis): reject subscription close signals when receiving (#42799)
-LAN-4b89972f552c
diff --git a/api/libs/broadcast_channel/redis/_subscription.py b/api/libs/broadcast_channel/redis/_subscription.pyindex c155b9e1973..94af7a784c3 100644--- a/api/libs/broadcast_channel/redis/_subscription.py+++ b/api/libs/broadcast_channel/redis/_subscription.py@@ -196,6 +196,8 @@ class RedisSubscriptionBase(Subscription):except queue.Empty:return None+ if item == SIG_CLOSE:+ raise SubscriptionClosedError(f"The Redis {self._get_subscription_type()} subscription is closed")return item@overridediff --git a/api/services/workflow_event_snapshot_service.py b/api/services/workflow_event_snapshot_service.pyindex 5fb86206ec9..b25079b8762 100644--- a/api/services/workflow_event_snapshot_service.py+++ b/api/services/workflow_event_snapshot_service.py@@ -43,6 +43,7 @@ from graphon.enums import WorkflowExecutionStatus, WorkflowNodeExecutionStatusfrom graphon.runtime import GraphRuntimeStatefrom graphon.runtime.graph_runtime_state_protocol import ReadOnlyVariablePoolfrom graphon.workflow_type_encoder import WorkflowRuntimeTypeConverter+from libs.broadcast_channel.exc import SubscriptionClosedErrorfrom libs.datetime_utils import to_utc_timestampfrom models.human_input import HumanInputFormfrom models.model import AppMode, Message@@ -669,6 +670,8 @@ def _start_buffering(subscription) -> BufferState:except queue.Full:continuelogger.warning("Dropped buffered workflow event, total_dropped=%s", dropped_count)+ except SubscriptionClosedError:+ passexcept Exception:logger.exception("Failed while buffering workflow events")finally:diff --git a/api/tests/test_containers_integration_tests/libs/broadcast_channel/redis/test_sharded_channel.py b/api/tests/test_containers_integration_tests/libs/broadcast_channel/redis/test_sharded_channel.pyindex 84c1d0ca41b..7e0ed7cd366 100644--- a/api/tests/test_containers_integration_tests/libs/broadcast_channel/redis/test_sharded_channel.py+++ b/api/tests/test_containers_integration_tests/libs/broadcast_channel/redis/test_sharded_channel.py@@ -237,6 +237,7 @@ class TestShardedRedisBroadcastChannelIntegration:def consumer_thread() -> set[bytes]:received_msgs: set[bytes] = set()with subscription:+ subscription.receive(timeout=0.1)consumer_ready.set()while True:try:@@ -260,7 +261,10 @@ class TestShardedRedisBroadcastChannelIntegration:for future in as_completed(producer_futures, timeout=30.0):sent_msgs.update(future.result())- consumer_received_msgs = consumer_future.result(timeout=60.0)+ try:+ consumer_received_msgs = consumer_future.result(timeout=60.0)+ finally:+ subscription.close()assert sent_msgs == consumer_received_msgsdiff --git a/api/tests/unit_tests/libs/broadcast_channel/redis/test_channel_unit_tests.py b/api/tests/unit_tests/libs/broadcast_channel/redis/test_channel_unit_tests.pyindex 2a9bc002607..a7b32d986c4 100644--- a/api/tests/unit_tests/libs/broadcast_channel/redis/test_channel_unit_tests.py+++ b/api/tests/unit_tests/libs/broadcast_channel/redis/test_channel_unit_tests.py@@ -1441,6 +1441,12 @@ class TestRedisSubscriptionCommon:with pytest.raises(SubscriptionClosedError):subscription.receive()+ def test_receive_does_not_leak_close_signal(self, subscription, subscription_params):+ subscription._queue.put_nowait(SIG_CLOSE)++ with pytest.raises(SubscriptionClosedError):+ subscription.receive()+# ==================== Table-driven Tests ====================@pytest.mark.parametrize(diff --git a/api/tests/unit_tests/services/workflow/test_workflow_event_snapshot_service.py b/api/tests/unit_tests/services/workflow/test_workflow_event_snapshot_service.pyindex 9f914556800..e52ce4ca02d 100644--- a/api/tests/unit_tests/services/workflow/test_workflow_event_snapshot_service.py+++ b/api/tests/unit_tests/services/workflow/test_workflow_event_snapshot_service.py@@ -27,6 +27,7 @@ from core.workflow.nodes.human_input.enums import ValueSourceTypefrom core.workflow.nodes.human_input.pause_reason import HumanInputRequiredfrom graphon.enums import WorkflowExecutionStatus, WorkflowNodeExecutionStatusfrom graphon.runtime import GraphRuntimeState, VariablePool+from libs.broadcast_channel.exc import SubscriptionClosedErrorfrom libs.datetime_utils import to_utc_timestampfrom models.enums import ConversationFromSource, CreatorUserRolefrom models.human_input import HumanInputForm, HumanInputFormRecipient, RecipientType@@ -701,6 +702,17 @@ def test_start_buffering_should_set_done_event_when_subscription_raises() -> Nonassert finished is True+def test_start_buffering_should_treat_closed_subscription_as_done(caplog: pytest.LogCaptureFixture) -> None:+ class Subscription:+ def receive(self, timeout: int = 1) -> bytes | None:+ raise SubscriptionClosedError("closed")++ buffer_state = service_module._start_buffering(Subscription())++ assert buffer_state.done_event.wait(timeout=1) is True+ assert "Failed while buffering workflow events" not in caplog.text++def test_build_workflow_event_stream_should_emit_ping_and_terminal_snapshot_event(monkeypatch: pytest.MonkeyPatch,unbound_session_factory: sessionmaker[Session],