Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix: parse Redis Sentinel and Cluster nodes safely (#42111)
Harsh Kashyap4cc2f632b8cd
diff --git a/api/extensions/ext_redis.py b/api/extensions/ext_redis.pyindex 0cf256af804..7cdce7191fd 100644--- a/api/extensions/ext_redis.py+++ b/api/extensions/ext_redis.py@@ -371,6 +371,18 @@ def _get_base_redis_params() -> RedisBaseParamsDict:)+def _parse_redis_nodes(value: str) -> list[tuple[str, int]]:+ nodes = []+ for raw_node in value.split(","):+ host, separator, port = raw_node.strip().rpartition(":")+ if not separator or not host or not port:+ raise ValueError(f"Invalid Redis node: {raw_node}")+ if host.startswith("[") and host.endswith("]"):+ host = host[1:-1]+ nodes.append((host, int(port)))+ return nodes++def _create_sentinel_client(redis_params: RedisBaseParamsDict) -> Union[redis.Redis, RedisCluster]:"""Create Redis client using Sentinel configuration."""if not dify_config.REDIS_SENTINELS:@@ -379,7 +391,7 @@ def _create_sentinel_client(redis_params: RedisBaseParamsDict) -> Union[redis.Reif not dify_config.REDIS_SENTINEL_SERVICE_NAME:raise ValueError("REDIS_SENTINEL_SERVICE_NAME must be set when REDIS_USE_SENTINEL is True")- sentinel_hosts = [(node.split(":")[0], int(node.split(":")[1])) for node in dify_config.REDIS_SENTINELS.split(",")]+ sentinel_hosts = _parse_redis_nodes(dify_config.REDIS_SENTINELS)health_params = _get_connection_health_params()@@ -409,10 +421,7 @@ def _create_cluster_client() -> Union[redis.Redis, RedisCluster]:if not dify_config.REDIS_CLUSTERS:raise ValueError("REDIS_CLUSTERS must be set when REDIS_USE_CLUSTERS is True")- nodes = [- ClusterNode(host=node.split(":")[0], port=int(node.split(":")[1]))- for node in dify_config.REDIS_CLUSTERS.split(",")- ]+ nodes = [ClusterNode(host=host, port=port) for host, port in _parse_redis_nodes(dify_config.REDIS_CLUSTERS)]cluster_kwargs: dict[str, Any] = {"startup_nodes": nodes,diff --git a/api/tests/unit_tests/extensions/test_redis.py b/api/tests/unit_tests/extensions/test_redis.pyindex 05e14b9a83d..f86420b2b63 100644--- a/api/tests/unit_tests/extensions/test_redis.py+++ b/api/tests/unit_tests/extensions/test_redis.py@@ -10,6 +10,7 @@ from extensions.ext_redis import (_get_cluster_connection_health_params,_get_connection_health_params,_normalize_redis_key_prefix,+ _parse_redis_nodes,_serialize_redis_name,redis_fallback,)@@ -78,6 +79,14 @@ class TestGetBaseRedisParams:assert params["encoding"] == "utf-8"+class TestParseRedisNodes:+ def test_trims_nodes(self):+ assert _parse_redis_nodes("redis-a:6379, redis-b:6380") == [("redis-a", 6379), ("redis-b", 6380)]++ def test_supports_bracketed_ipv6(self):+ assert _parse_redis_nodes("[2001:db8::10]:6379") == [("2001:db8::10", 6379)]++class TestRedisFallback:def test_redis_fallback_success(self):@redis_fallback(default_return=None)