Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(test): return inserted primary keys from add_texts (#41037)

Byron.wang584b62adc5ce
diff --git a/api/providers/vdb/vdb-milvus/src/dify_vdb_milvus/milvus_vector.py b/api/providers/vdb/vdb-milvus/src/dify_vdb_milvus/milvus_vector.py
index 5a8a1b7cd33..18113c6831b 100644
--- a/api/providers/vdb/vdb-milvus/src/dify_vdb_milvus/milvus_vector.py
+++ b/api/providers/vdb/vdb-milvus/src/dify_vdb_milvus/milvus_vector.py
@@ -160,8 +160,8 @@ class MilvusVector(BaseVector):
# Insert into the collection.
batch_insert_list = insert_dict_list[i : i + 1000]
try:
- ids = self._client.insert(collection_name=self._collection_name, data=batch_insert_list)
- pks.extend(ids)
+ result = self._client.insert(collection_name=self._collection_name, data=batch_insert_list)
+ pks.extend(result.get("ids", []))
except MilvusException as e:
logger.exception("Failed to insert batch starting at entity: %s/%s", i, total_count)
raise e
diff --git a/api/providers/vdb/vdb-milvus/tests/unit_tests/test_milvus.py b/api/providers/vdb/vdb-milvus/tests/unit_tests/test_milvus.py
index 8e97ea26090..6dc05ca8b80 100644
--- a/api/providers/vdb/vdb-milvus/tests/unit_tests/test_milvus.py
+++ b/api/providers/vdb/vdb-milvus/tests/unit_tests/test_milvus.py
@@ -31,7 +31,7 @@ def _build_fake_pymilvus_modules():
return_value={"fields": [{"name": "id"}, {"name": "content"}, {"name": "metadata"}]}
)
self.get_server_version = MagicMock(return_value="2.5.0")
- self.insert = MagicMock(return_value=[1])
+ self.insert = MagicMock(return_value={"insert_count": 1, "ids": [1], "cost": 0})
self.query = MagicMock(return_value=[])
self.delete = MagicMock()
self.drop_collection = MagicMock()
@@ -263,7 +263,10 @@ def test_add_texts_batches_and_raises_milvus_exception(milvus_module):
vector = milvus_module.MilvusVector.__new__(milvus_module.MilvusVector)
vector._collection_name = "collection_1"
vector._client = MagicMock()
- vector._client.insert.side_effect = [["id-1"], ["id-2"]]
+ vector._client.insert.side_effect = [
+ {"insert_count": 1000, "ids": ["id-1"], "cost": 0},
+ {"insert_count": 1, "ids": ["id-2"], "cost": 0},
+ ]
docs = [Document(page_content=f"text-{i}", metadata={"doc_id": f"d-{i}"}) for i in range(1001)]
embeddings = [[0.1, 0.2] for _ in range(1001)]