Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix(files): apply media limits to remote upload preflight (#44273)
Winoren61e284681bdf
diff --git a/api/services/remote_file_service.py b/api/services/remote_file_service.pyindex efed48c73d2..602a0628405 100644--- a/api/services/remote_file_service.py+++ b/api/services/remote_file_service.py@@ -113,7 +113,7 @@ class RemoteFileService:raise RemoteFileInvalidResponseError("The remote response contains an invalid filename")if not self._files.is_file_size_within_limit(- extension=file_info.extension,+ extension=file_info.extension.lstrip(".").lower(),file_size=file_info.size,):raise FileTooLargeError()diff --git a/api/tests/unit_tests/services/test_remote_file_service.py b/api/tests/unit_tests/services/test_remote_file_service.pyindex d96f39df1a6..753e86857fa 100644--- a/api/tests/unit_tests/services/test_remote_file_service.py+++ b/api/tests/unit_tests/services/test_remote_file_service.py@@ -222,7 +222,7 @@ def test_upload_reuses_get_fallback_content_and_returns_signed_result(call("HEAD", url=REMOTE_URL),call("GET", url=REMOTE_URL, timeout=3, follow_redirects=True),]- size_check.assert_called_once_with(extension=".pdf", file_size=14)+ size_check.assert_called_once_with(extension="pdf", file_size=14)upload.assert_called_once_with(filename="report.pdf",content=b"remote content",@@ -369,10 +369,69 @@ def test_upload_rejects_file_that_exceeds_size_limit(with pytest.raises(FileTooLargeError):remote_file_service.upload_from_url(url=REMOTE_URL, user=_account())- size_check.assert_called_once_with(extension=".pdf", file_size=1024)+ size_check.assert_called_once_with(extension="pdf", file_size=1024)upload.assert_not_called()[email protected]("filename", ["clip.mp4", "clip.MP4", "sound.wav", "image.png"])+def test_upload_applies_media_limit_before_downloading(+ filename: str,+ remote_file_service: RemoteFileService,+ storage: Storage,+ sqlite_session: Session,+ config_overrides: Callable[..., None],+) -> None:+ config_overrides(+ UPLOAD_FILE_SIZE_LIMIT=1,+ UPLOAD_VIDEO_FILE_SIZE_LIMIT=3,+ UPLOAD_AUDIO_FILE_SIZE_LIMIT=3,+ UPLOAD_IMAGE_FILE_SIZE_LIMIT=3,+ )+ content = b"a" * (2 * 1024 * 1024)+ url = f"https://example.com/{filename}"+ head_response = httpx.Response(+ 200,+ request=httpx.Request("HEAD", url),+ headers={"Content-Length": str(len(content))},+ )+ get_response = httpx.Response(200, request=httpx.Request("GET", url), content=content)+ with patch(+ "services.remote_file_service.remote_fetcher.make_request",+ side_effect=[head_response, get_response],+ ) as make_request:+ result = remote_file_service.upload_from_url(url=url, user=_account())++ assert make_request.call_args_list == [call("HEAD", url=url), call("GET", url=url)]+ upload_file = sqlite_session.get(UploadFile, result.id)+ assert upload_file is not None+ assert upload_file.extension == filename.rsplit(".", 1)[1].lower()+ assert upload_file.size == len(content)+ assert storage.load_once(upload_file.key) == content+++def test_upload_rejects_oversized_media_before_get(+ remote_file_service: RemoteFileService,+ config_overrides: Callable[..., None],+) -> None:+ config_overrides(UPLOAD_FILE_SIZE_LIMIT=3, UPLOAD_VIDEO_FILE_SIZE_LIMIT=1)+ content = b"a" * (2 * 1024 * 1024)+ url = "https://example.com/clip.mp4"+ head_response = httpx.Response(+ 200,+ request=httpx.Request("HEAD", url),+ headers={"Content-Length": str(len(content))},+ )+ get_response = httpx.Response(200, request=httpx.Request("GET", url), content=content)+ with patch(+ "services.remote_file_service.remote_fetcher.make_request",+ side_effect=[head_response, get_response],+ ) as make_request:+ with pytest.raises(FileTooLargeError):+ remote_file_service.upload_from_url(url=url, user=_account())++ make_request.assert_called_once_with("HEAD", url=url)++def test_upload_parameterized_content_type_uses_media_extension_and_mimetype(remote_file_service: RemoteFileService,upload: MagicMock,@@ -394,7 +453,7 @@ def test_upload_parameterized_content_type_uses_media_extension_and_mimetype():result = remote_file_service.upload_from_url(url=url, user=_account())- size_check.assert_called_once_with(extension=".pdf", file_size=len(content))+ size_check.assert_called_once_with(extension="pdf", file_size=len(content))assert upload.call_args.kwargs["filename"] == "download.pdf"assert upload.call_args.kwargs["mimetype"] == "application/pdf"upload_file = sqlite_session.get(UploadFile, result.id)