Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

refactor(web): remove duplicate dataset title update (#40023)

yyh685e291e654f
diff --git a/web/app/components/datasets/list/__tests__/datasets.spec.tsx b/web/app/components/datasets/list/__tests__/datasets.spec.tsx
index 3e5e7e3e697..af9d39914be 100644
--- a/web/app/components/datasets/list/__tests__/datasets.spec.tsx
+++ b/web/app/components/datasets/list/__tests__/datasets.spec.tsx
@@ -1,6 +1,6 @@
import type { DataSet, DataSetListResponse } from '@/models/datasets'
import type { useDatasetList } from '@/service/knowledge/use-dataset'
-import { render, screen, waitFor } from '@testing-library/react'
+import { render, screen } from '@testing-library/react'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { IndexingType } from '@/app/components/datasets/create/step-two'
import { STEP_BY_STEP_TOUR_TARGETS } from '@/app/components/step-by-step-tour/target-registry'
@@ -185,7 +185,6 @@ describe('Datasets', () => {
beforeEach(() => {
vi.clearAllMocks()
intersectionObserverCallback = null
- document.title = ''
vi.stubGlobal('IntersectionObserver', MockIntersectionObserver)
})
@@ -249,15 +248,6 @@ describe('Datasets', () => {
})
})
- describe('Document Title', () => {
- it('should set document title on mount', async () => {
- render(<Datasets {...defaultProps} />)
- await waitFor(() => {
- expect(document.title).toContain('dataset.knowledge')
- })
- })
- })
-
describe('Loading States', () => {
it('should show dataset card skeletons while initial dataset list is loading', () => {
render(
diff --git a/web/app/components/datasets/list/datasets.tsx b/web/app/components/datasets/list/datasets.tsx
index c83df61bf85..28c7fbee3c9 100644
--- a/web/app/components/datasets/list/datasets.tsx
+++ b/web/app/components/datasets/list/datasets.tsx
@@ -47,10 +47,6 @@ const Datasets = ({
const showDatasetSkeleton =
!isFetchingNextPage && (isLoading || (isPlaceholderData && isFetching && datasets.length === 0))
- useEffect(() => {
- document.title = `${t(($) => $.knowledge, { ns: 'dataset' })} - Dify`
- }, [t])
-
useEffect(() => {
if (anchorRef.current) {
observerRef.current = new IntersectionObserver(