Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix: catch ValueError instead of bare except in account CLI commands (#40356)
chelsealong6aa3fa519313
diff --git a/api/commands/account.py b/api/commands/account.pyindex 9ea52dfd248..6751361a1a0 100644--- a/api/commands/account.py+++ b/api/commands/account.py@@ -33,7 +33,7 @@ def reset_password(email, new_password, password_confirm):try:valid_password(new_password)- except:+ except ValueError:click.echo(click.style(f"Invalid password. Must match {password_pattern}", fg="red"))return@@ -75,7 +75,7 @@ def reset_email(email, new_email, email_confirm):try:email_validate(normalized_new_email)- except:+ except ValueError:click.echo(click.style(f"Invalid email: {new_email}", fg="red"))returndiff --git a/api/tests/unit_tests/commands/test_account_commands.py b/api/tests/unit_tests/commands/test_account_commands.pynew file mode 100644index 00000000000..bbcc5d3e704--- /dev/null+++ b/api/tests/unit_tests/commands/test_account_commands.py@@ -0,0 +1,38 @@+from unittest.mock import Mock++import pytest+from click.testing import CliRunner++from commands.account import reset_email, reset_password+++def test_reset_password_does_not_swallow_keyboard_interrupt(monkeypatch: pytest.MonkeyPatch) -> None:+ monkeypatch.setattr(+ "commands.account.AccountService.get_account_by_email_with_case_fallback",+ Mock(return_value=Mock()),+ )+ monkeypatch.setattr("commands.account.valid_password", Mock(side_effect=KeyboardInterrupt))++ result = CliRunner().invoke(+ reset_password,+ ["--email", "[email protected]", "--new-password", "whatever", "--password-confirm", "whatever"],+ )++ assert not isinstance(result.exception, SystemExit) or result.exception.code != 0+ assert "Invalid password" not in result.output+++def test_reset_email_does_not_swallow_keyboard_interrupt(monkeypatch: pytest.MonkeyPatch) -> None:+ monkeypatch.setattr(+ "commands.account.AccountService.get_account_by_email_with_case_fallback",+ Mock(return_value=Mock()),+ )+ monkeypatch.setattr("commands.account.email_validate", Mock(side_effect=KeyboardInterrupt))++ result = CliRunner().invoke(+ reset_email,+ ["--email", "[email protected]", "--new-email", "[email protected]", "--email-confirm", "[email protected]"],+ )++ assert not isinstance(result.exception, SystemExit) or result.exception.code != 0+ assert "Invalid email" not in result.output