Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

test(web): exercise installation, logout and settings owners (#44812)

Stephen Zhou6f30f45d792e
diff --git a/web/app/components/header/account-menu/__tests__/index.spec.tsx b/web/app/components/header/account-menu/__tests__/index.spec.tsx
index 024bb7433ec..7b4a6c981ab 100644
--- a/web/app/components/header/account-menu/__tests__/index.spec.tsx
+++ b/web/app/components/header/account-menu/__tests__/index.spec.tsx
@@ -1,19 +1,44 @@
-import { screen, waitFor } from '@testing-library/react'
+import { QueryClientProvider } from '@tanstack/react-query'
+import { screen, waitFor, within } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { renderToString } from 'react-dom/server'
import AccountAvatar from '@/app/account/(commonLayout)/avatar'
+import {
+ OAUTH_REGISTRATION_GA_SENT_KEY,
+ REGISTRATION_SUCCESS_STORAGE_KEY,
+} from '@/app/components/base/amplitude/registration-session-state'
import AccountSection from '@/app/components/main-nav/components/account-section'
import EducationUserInfo from '@/app/education/user-info'
-import { useLogout } from '@/service/use-common'
import { createAccountProfileQueryClient } from '@/test/console/account-profile'
import { renderWithConsoleQuery as renderWithConsoleQueryWithoutUrlState } from '@/test/console/query-data'
import { createNuqsTestRenderer } from '@/test/nuqs-testing'
import AccountMenu from '../index'
-vi.mock('@/service/use-common', async (importOriginal) => ({
- ...(await importOriginal<typeof import('@/service/use-common')>()),
- useLogout: vi.fn(),
-}))
+const { logout } = vi.hoisted(() => ({ logout: vi.fn() }))
+
+vi.mock('@/service/console', async (importOriginal) => {
+ const actual = await importOriginal<typeof import('@/service/console')>()
+ const { withConsoleResponses } = await import('@/test/console/service-responses')
+ return {
+ ...actual,
+ consoleQuery: withConsoleResponses(actual.consoleQuery, { 'logout.post': logout }),
+ }
+})
+
+vi.mock('@/app/components/base/amplitude/utils', () => ({ resetUser: vi.fn() }))
+
+function seedSession() {
+ window.sessionStorage.setItem(
+ REGISTRATION_SUCCESS_STORAGE_KEY,
+ JSON.stringify({
+ registrationId: 'registration-1',
+ occurredAt: Date.now(),
+ method: 'oauth',
+ attribution: {},
+ }),
+ )
+ window.sessionStorage.setItem(OAUTH_REGISTRATION_GA_SENT_KEY, 'true')
+}
vi.mock('next-themes', () => ({
useTheme: () => ({ theme: 'system', setTheme: vi.fn() }),
@@ -49,15 +74,12 @@ const renderAccountMenu = () => {
}
describe('AccountMenu', () => {
- const mockLogout = vi.fn()
-
beforeEach(() => {
- vi.clearAllMocks()
- vi.mocked(useLogout).mockReturnValue({
- mutate: mockLogout,
- } as unknown as ReturnType<typeof useLogout>)
+ logout.mockResolvedValue({ result: 'success' })
})
+ afterEach(() => vi.restoreAllMocks())
+
it('keeps the account identity in the compact trigger accessible name', () => {
const queryClient = createAccountProfileQueryClient(userProfile)
@@ -88,19 +110,21 @@ describe('AccountMenu', () => {
it('keeps the composed trigger disabled in server-rendered markup', () => {
const html = renderToString(
- <AccountMenu
- trigger={({ ariaLabel }) => (
- <button type="button" aria-label={ariaLabel}>
- Current account
- </button>
- )}
- />,
+ <QueryClientProvider client={createAccountProfileQueryClient(userProfile)}>
+ <AccountMenu
+ trigger={({ ariaLabel }) => (
+ <button type="button" aria-label={ariaLabel}>
+ Current account
+ </button>
+ )}
+ />
+ </QueryClientProvider>,
)
const container = document.createElement('div')
container.innerHTML = html
expect(
- container.querySelector('button[aria-label="accountSettings.account.account"]'),
+ within(container).getByRole('button', { name: 'accountSettings.account.account' }),
).toBeDisabled()
})
@@ -120,6 +144,8 @@ describe('AccountMenu', () => {
'logs out through the shared session boundary from %s',
async (surface) => {
const user = userEvent.setup()
+ const replace = vi.spyOn(window.location, 'replace').mockImplementation(() => {})
+ seedSession()
if (surface === 'main navigation') {
renderAccountMenu()
} else {
@@ -144,7 +170,10 @@ describe('AccountMenu', () => {
name: 'common.userProfile.logout',
}),
)
- expect(mockLogout).toHaveBeenCalledExactlyOnceWith()
+ await waitFor(() => expect(replace).toHaveBeenCalledExactlyOnceWith('/signin'))
+ expect(logout).toHaveBeenCalledOnce()
+ expect(window.sessionStorage.getItem(REGISTRATION_SUCCESS_STORAGE_KEY)).toBeNull()
+ expect(window.sessionStorage.getItem(OAUTH_REGISTRATION_GA_SENT_KEY)).toBeNull()
},
)
})
diff --git a/web/app/components/workflow/hooks/__tests__/use-node-plugin-installation.spec.ts b/web/app/components/workflow/hooks/__tests__/use-node-plugin-installation.spec.ts
index 67356c66883..ab75f286351 100644
--- a/web/app/components/workflow/hooks/__tests__/use-node-plugin-installation.spec.ts
+++ b/web/app/components/workflow/hooks/__tests__/use-node-plugin-installation.spec.ts
@@ -1,13 +1,10 @@
import type { CommonNodeType } from '../../types'
-import { QueryClient } from '@tanstack/react-query'
+import { zTriggerProviderApiEntity } from '@dify/contracts/api/console/workspaces/zod.gen'
import { act, waitFor } from '@testing-library/react'
import { createDatasourceProvider } from '@/app/components/rag-pipeline/__tests__/datasource-fixtures'
import { CollectionType } from '@/app/components/tools/types'
-import { consoleQuery } from '@/service/console'
-import { seedAccountProfileQuery } from '@/test/console/account-profile'
import { createConsoleQueryWrapper } from '@/test/console/query-data'
import { createToolProviderFixture } from '@/test/console/tool-provider-fixture'
-import { createTestQueryClient } from '@/test/query-client'
import { renderWorkflowHook as renderHookBase } from '../../__tests__/workflow-test-env'
import { BlockEnum } from '../../types'
import { useNodePluginInstallation } from '../use-node-plugin-installation'
@@ -17,7 +14,6 @@ const mockCustomTools = vi.fn()
const mockWorkflowTools = vi.fn()
const mockMcpTools = vi.fn()
const mockTriggerPlugins = vi.fn()
-const mockInvalidateTriggers = vi.fn()
let mockWorkspacePermissionKeys = ['plugin.install']
const renderWorkflowHook: typeof renderHookBase = (callback, options) => {
@@ -28,11 +24,6 @@ const renderWorkflowHook: typeof renderHookBase = (callback, options) => {
return renderHookBase(callback, { ...options, queryClient })
}
-vi.mock('@/service/use-triggers', () => ({
- useAllTriggerPlugins: (enabled: boolean) => mockTriggerPlugins(enabled),
- useInvalidateAllTriggerPlugins: () => mockInvalidateTriggers,
-}))
-
const makeToolNode = (overrides: Partial<CommonNodeType> = {}) =>
({
type: BlockEnum.Tool,
@@ -76,11 +67,24 @@ const matchedTool = createToolProviderFixture({
plugin_unique_identifier: '[email protected]',
})
-const matchedTriggerProvider = {
- id: 'trigger-provider',
+const matchedTriggerProvider = zTriggerProviderApiEntity.parse({
name: 'trigger-provider',
+ author: 'Dify',
+ label: { en_US: 'Mail events' },
+ description: { en_US: 'Receive new messages' },
plugin_id: 'trigger-plugin',
-}
+ plugin_unique_identifier: '[email protected]',
+ supported_creation_methods: ['MANUAL'],
+ events: [
+ {
+ name: 'received',
+ identity: { author: 'Dify', name: 'received', label: { en_US: 'Message received' } },
+ description: { en_US: 'A new message has arrived' },
+ parameters: [],
+ output_schema: { type: 'object', properties: { message: { type: 'string' } } },
+ },
+ ],
+})
const matchedDataSource = createDatasourceProvider({
provider: 'knowledge-provider',
@@ -90,14 +94,12 @@ const matchedDataSource = createDatasourceProvider({
describe('useNodePluginInstallation', () => {
beforeEach(() => {
- vi.clearAllMocks()
mockWorkspacePermissionKeys = ['plugin.install']
mockBuiltInTools.mockReturnValue(new Promise(() => {}))
mockCustomTools.mockReturnValue(new Promise(() => {}))
mockWorkflowTools.mockReturnValue(new Promise(() => {}))
mockMcpTools.mockReturnValue(new Promise(() => {}))
- mockTriggerPlugins.mockReturnValue({ data: undefined, isLoading: false })
- mockInvalidateTriggers.mockReset()
+ mockTriggerPlugins.mockReset().mockResolvedValue([])
})
it('should return the noop installation state for non plugin-dependent nodes', () => {
@@ -109,41 +111,35 @@ describe('useNodePluginInstallation', () => {
} as CommonNodeType),
)
- expect(result.current).toEqual({
+ expect(result.current).toMatchObject({
isChecking: false,
isMissing: false,
uniqueIdentifier: undefined,
canInstall: false,
- onInstallSuccess: expect.any(Function),
shouldDim: false,
})
})
- it('should report loading and invalidate built-in tools while the collection is resolving', () => {
- const queryClient = createTestQueryClient()
- seedAccountProfileQuery(queryClient)
- const builtInToolsKey = consoleQuery.workspaces.current.tools.builtin.get.queryKey()
- const customToolsKey = consoleQuery.workspaces.current.tools.api.get.queryKey()
- queryClient.setQueryData(customToolsKey, [])
-
- const { result } = renderWorkflowHook(() => useNodePluginInstallation(makeToolNode()), {
- queryClient,
+ it('should report loading and refresh built-in tools after installation', async () => {
+ let resolve!: (providers: (typeof matchedTool)[]) => void
+ const promise = new Promise<(typeof matchedTool)[]>((finish) => {
+ resolve = finish
})
+ mockBuiltInTools.mockReturnValueOnce(promise).mockResolvedValue([matchedTool])
+ const { result } = renderWorkflowHook(() => useNodePluginInstallation(makeToolNode()))
- expect(mockBuiltInTools).toHaveBeenCalledTimes(1)
- expect(mockCustomTools).not.toHaveBeenCalled()
expect(result.current.isChecking).toBe(true)
expect(result.current.isMissing).toBe(false)
- expect(result.current.uniqueIdentifier).toBe('[email protected]')
expect(result.current.canInstall).toBe(true)
expect(result.current.shouldDim).toBe(true)
+ await act(async () => resolve([]))
+ await waitFor(() => expect(result.current.isMissing).toBe(true))
- act(() => {
- result.current.onInstallSuccess()
- })
+ act(() => result.current.onInstallSuccess())
- expect(queryClient.getQueryState(builtInToolsKey)?.isInvalidated).toBe(true)
- expect(queryClient.getQueryState(customToolsKey)?.isInvalidated).toBe(false)
+ await waitFor(() => expect(result.current.shouldDim).toBe(false))
+ expect(result.current.isMissing).toBe(false)
+ expect(result.current.isChecking).toBe(false)
})
it.each([
@@ -195,34 +191,36 @@ describe('useNodePluginInstallation', () => {
expect(result.current.canInstall).toBe(false)
})
- it('should flag missing trigger plugins and invalidate trigger data after installation', () => {
- mockTriggerPlugins.mockReturnValue({ data: [matchedTriggerProvider], isLoading: false })
+ it('should clear missing trigger and dimming state when installation refreshes the provider', async () => {
+ const unrelatedProvider = {
+ ...matchedTriggerProvider,
+ name: 'calendar-provider',
+ plugin_id: 'calendar-plugin',
+ plugin_unique_identifier: '[email protected]',
+ }
+ mockTriggerPlugins
+ .mockResolvedValueOnce([unrelatedProvider])
+ .mockResolvedValue([unrelatedProvider, matchedTriggerProvider])
+ const { result } = renderWorkflowHook(() => useNodePluginInstallation(makeTriggerNode()))
- const { result } = renderWorkflowHook(() =>
- useNodePluginInstallation(
- makeTriggerNode({
- provider_id: 'missing-trigger',
- provider_name: 'missing-trigger',
- plugin_id: 'missing-trigger',
- }),
- ),
- )
-
- expect(mockTriggerPlugins).toHaveBeenCalledWith(true)
+ await waitFor(() => expect(result.current.isMissing).toBe(true))
expect(result.current.isChecking).toBe(false)
- expect(result.current.isMissing).toBe(true)
expect(result.current.shouldDim).toBe(true)
+ expect(result.current.canInstall).toBe(true)
- act(() => {
- result.current.onInstallSuccess()
- })
+ act(() => result.current.onInstallSuccess())
- expect(mockInvalidateTriggers).toHaveBeenCalled()
+ await waitFor(() => expect(result.current.shouldDim).toBe(false))
+ expect(result.current.isMissing).toBe(false)
+ expect(result.current.isChecking).toBe(false)
})
- it('should treat the trigger plugin list as still loading when it has not resolved yet', () => {
- mockTriggerPlugins.mockReturnValue({ data: undefined, isLoading: true })
-
+ it('should treat the trigger plugin list as still loading when it has not resolved yet', async () => {
+ let resolve!: (providers: (typeof matchedTriggerProvider)[]) => void
+ const promise = new Promise<(typeof matchedTriggerProvider)[]>((finish) => {
+ resolve = finish
+ })
+ mockTriggerPlugins.mockReturnValueOnce(promise)
const { result } = renderWorkflowHook(() =>
useNodePluginInstallation(
makeTriggerNode({ plugin_unique_identifier: undefined, plugin_id: 'trigger-plugin' }),
@@ -231,9 +229,12 @@ describe('useNodePluginInstallation', () => {
expect(result.current.isChecking).toBe(true)
expect(result.current.isMissing).toBe(false)
- expect(result.current.uniqueIdentifier).toBe('trigger-plugin')
expect(result.current.canInstall).toBe(false)
expect(result.current.shouldDim).toBe(true)
+ await act(async () => resolve([matchedTriggerProvider]))
+ await waitFor(() => expect(result.current.isChecking).toBe(false))
+ expect(result.current.isMissing).toBe(false)
+ expect(result.current.shouldDim).toBe(false)
})
it('should track missing and matched data source providers based on workflow store state', () => {
@@ -257,16 +258,9 @@ describe('useNodePluginInstallation', () => {
expect(missingRender.result.current.isMissing).toBe(true)
expect(missingRender.result.current.shouldDim).toBe(true)
- const queryClient = new QueryClient({
- defaultOptions: { queries: { staleTime: Infinity, retry: false } },
- })
- seedAccountProfileQuery(queryClient)
- const catalogKey = consoleQuery.rag.pipelines.datasourcePlugins.get.queryKey()
- queryClient.setQueryData(catalogKey, [matchedDataSource])
const matchedRender = renderWorkflowHook(
() => useNodePluginInstallation(makeDataSourceNode()),
{
- queryClient,
initialStoreState: {
dataSourceList: [matchedDataSource],
},
@@ -275,13 +269,6 @@ describe('useNodePluginInstallation', () => {
expect(matchedRender.result.current.isMissing).toBe(false)
expect(matchedRender.result.current.shouldDim).toBe(false)
-
- act(() => {
- matchedRender.result.current.onInstallSuccess()
- })
-
- expect(queryClient.getQueryState(catalogKey)?.isInvalidated).toBe(true)
- queryClient.clear()
})
it('should keep data sources in checking state before the list is loaded', () => {
@@ -295,9 +282,13 @@ describe('useNodePluginInstallation', () => {
vi.mock('@/service/console', async (importOriginal) => {
const actual = await importOriginal<typeof import('@/service/console')>()
- const { withConsoleResponses } = await import('@/test/console/service-responses')
+ const { withConsoleResponses, withConsoleClientResponses } =
+ await import('@/test/console/service-responses')
return {
...actual,
+ consoleClient: withConsoleClientResponses(actual.consoleClient, {
+ 'workspaces.current.triggers.get': (input) => mockTriggerPlugins(input),
+ }),
consoleQuery: withConsoleResponses(actual.consoleQuery, {
'workspaces.current.tools.builtin.get': (input) => mockBuiltInTools(input),
'workspaces.current.tools.api.get': (input) => mockCustomTools(input),
diff --git a/web/app/components/workflow/nodes/data-source/__tests__/node.spec.tsx b/web/app/components/workflow/nodes/data-source/__tests__/node.spec.tsx
index f57d94b5591..8d6694b8fa0 100644
--- a/web/app/components/workflow/nodes/data-source/__tests__/node.spec.tsx
+++ b/web/app/components/workflow/nodes/data-source/__tests__/node.spec.tsx
@@ -1,79 +1,139 @@
import type { DataSourceNodeType } from '../types'
-import { screen, waitFor } from '@testing-library/react'
+import { useQuery } from '@tanstack/react-query'
+import { act, screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
+import { createDatasourceProvider } from '@/app/components/rag-pipeline/__tests__/datasource-fixtures'
import { renderWorkflowComponent } from '@/app/components/workflow/__tests__/workflow-test-env'
import { BlockEnum } from '@/app/components/workflow/types'
import { consoleQuery } from '@/service/console'
-import { createAccountProfileQueryClient } from '@/test/console/account-profile'
+import { createConsoleQueryWrapper } from '@/test/console/query-data'
+import { createPluginEntity } from '@/test/fixtures/plugin'
import Node from '../node'
-const mocks = vi.hoisted(() => ({
- permissions: ['plugin.install'] as string[],
+const requests = vi.hoisted(() => ({
+ manifest: vi.fn(),
install: vi.fn(),
- refetch: vi.fn(),
- reset: vi.fn(),
+ catalog: vi.fn(),
}))
-vi.mock('@/context/permission-state', async () => {
- const { createPermissionStateModuleMock } = await import('@/test/console/state-fixture')
- return createPermissionStateModuleMock(() => ({ workspacePermissionKeys: mocks.permissions }))
+
+vi.mock('@/service/console', async (importOriginal) => {
+ const actual = await importOriginal<typeof import('@/service/console')>()
+ const { withConsoleResponses, withConsoleClientResponses } =
+ await import('@/test/console/service-responses')
+ return {
+ ...actual,
+ consoleQuery: withConsoleResponses(actual.consoleQuery, {
+ 'workspaces.current.plugin.list.installations.ids.post': requests.manifest,
+ 'rag.pipelines.datasourcePlugins.get': requests.catalog,
+ }),
+ consoleClient: withConsoleClientResponses(actual.consoleClient, {
+ 'workspaces.current.plugin.install.marketplace.post': requests.install,
+ }),
+ }
})
-vi.mock('@/service/use-plugins', () => ({
- useCheckInstalled: () => ({ data: { plugins: [] }, isLoading: false, refetch: mocks.refetch }),
- useInstallPackageFromMarketPlace: () => ({
- mutate: mocks.install,
- isPending: false,
- reset: mocks.reset,
- }),
-}))
+const provider = createDatasourceProvider()
const data: DataSourceNodeType = {
title: 'Datasource',
desc: '',
type: BlockEnum.DataSource,
- plugin_id: 'plugin-id',
+ plugin_id: provider.plugin_id,
provider_type: 'local_file',
- provider_name: 'file',
+ provider_name: provider.provider,
datasource_name: 'local-file',
datasource_label: 'Local File',
datasource_parameters: {},
datasource_configurations: {},
- plugin_unique_identifier: '[email protected]',
+ plugin_unique_identifier: provider.plugin_unique_identifier,
+}
+
+// Subscribe to the pipeline catalog so invalidation must deliver fresh data.
+function DatasourceCatalog() {
+ const { data: providers } = useQuery(
+ consoleQuery.rag.pipelines.datasourcePlugins.get.queryOptions(),
+ )
+ return (
+ <output aria-label="Datasource catalog">
+ {providers?.map((item) => item.provider).join(', ')}
+ </output>
+ )
}
beforeEach(() => {
- mocks.permissions = ['plugin.install']
- mocks.refetch.mockReset().mockResolvedValue({ data: { plugins: [] } })
- mocks.install.mockReset().mockImplementation((_id, options) => {
- void options.onSuccess({ all_installed: true })
- })
+ requests.manifest.mockReset().mockResolvedValue({ plugins: [] })
+ requests.install.mockReset().mockResolvedValue({ all_installed: true, task_id: '' })
+ requests.catalog.mockReset().mockResolvedValue([])
})
-it('installs the missing datasource package and invalidates the datasource catalog on success', async () => {
+it('installs the missing datasource package, hides installation and refreshes the subscribed catalog', async () => {
const user = userEvent.setup()
- const queryClient = createAccountProfileQueryClient()
- const catalogKey = consoleQuery.rag.pipelines.datasourcePlugins.get.queryKey()
- queryClient.setQueryData(catalogKey, [])
- renderWorkflowComponent(<Node id="data-source-node" data={data} />, {
- queryClient,
- initialStoreState: { dataSourceList: [] },
+ const { queryClient } = createConsoleQueryWrapper({ workspacePermissionKeys: ['plugin.install'] })
+ queryClient.setQueryData(consoleQuery.rag.pipelines.datasourcePlugins.get.queryKey(), [])
+ requests.manifest.mockResolvedValueOnce({ plugins: [] }).mockResolvedValue({
+ plugins: [
+ createPluginEntity({
+ plugin_id: provider.plugin_id,
+ plugin_unique_identifier: provider.plugin_unique_identifier,
+ }),
+ ],
+ })
+ requests.install.mockImplementation(async () => {
+ requests.catalog.mockResolvedValue([provider])
+ return { all_installed: true, task_id: '' }
})
+ renderWorkflowComponent(
+ <>
+ <Node id="data-source-node" data={data} />
+ <DatasourceCatalog />
+ </>,
+ {
+ queryClient,
+ initialStoreState: { dataSourceList: [] },
+ },
+ )
+ // Settle the initial empty catalog fetch before installation can change the server response.
+ await act(async () => {
+ await queryClient.query(consoleQuery.rag.pipelines.datasourcePlugins.get.queryOptions())
+ })
+ expect(screen.getByLabelText('Datasource catalog')).toBeEmptyDOMElement()
await user.click(
- screen.getByRole('button', {
+ await screen.findByRole('button', {
name: 'workflowAgent.nodes.agent.pluginInstaller.install',
}),
)
- expect(mocks.install).toHaveBeenCalledWith('[email protected]', expect.any(Object))
- await waitFor(() => expect(queryClient.getQueryState(catalogKey)?.isInvalidated).toBe(true))
- expect(mocks.refetch).toHaveBeenCalledOnce()
+ expect(requests.install).toHaveBeenCalledExactlyOnceWith({
+ body: { plugin_unique_identifiers: [provider.plugin_unique_identifier] },
+ })
+ await waitFor(() => expect(screen.getByLabelText('Datasource catalog')).toHaveTextContent('file'))
+ await waitFor(() =>
+ expect(
+ screen.queryByRole('button', { name: /pluginInstaller.install/ }),
+ ).not.toBeInTheDocument(),
+ )
})
it('does not offer installation without workspace install permission', () => {
- mocks.permissions = []
+ const { queryClient } = createConsoleQueryWrapper({ workspacePermissionKeys: [] })
+ const pluginIds = Array.from(
+ new Set(
+ [data.plugin_unique_identifier, data.plugin_id, data.provider_name].filter(
+ (item): item is string => Boolean(item),
+ ),
+ ),
+ )
+ // Resolve the manifest before render so query loading cannot hide a permission regression.
+ queryClient.setQueryData(
+ consoleQuery.workspaces.current.plugin.list.installations.ids.post.queryKey({
+ input: { body: { plugin_ids: pluginIds } },
+ }),
+ { plugins: [] },
+ )
renderWorkflowComponent(<Node id="data-source-node" data={data} />, {
+ queryClient,
initialStoreState: { dataSourceList: [] },
})
expect(screen.queryByRole('button', { name: /pluginInstaller.install/ })).not.toBeInTheDocument()
- expect(mocks.install).not.toHaveBeenCalled()
+ expect(requests.install).not.toHaveBeenCalled()
})
diff --git a/web/features/new-rag/settings/__tests__/form.spec.tsx b/web/features/new-rag/settings/__tests__/form.spec.tsx
index ce17e953a7e..5ef2501b098 100644
--- a/web/features/new-rag/settings/__tests__/form.spec.tsx
+++ b/web/features/new-rag/settings/__tests__/form.spec.tsx
@@ -12,24 +12,35 @@ import type {
} from '@dify/contracts/api/console/knowledge-fs/types.gen'
import type { AccountWithRoleResponse } from '@dify/contracts/api/console/workspaces/types.gen'
import type { QueryClient } from '@tanstack/react-query'
-import type { ComponentProps, ReactNode } from 'react'
import { settings as settingsContract } from '@dify/contracts/api/console/knowledge-fs/orpc.gen'
import {
zKnowledgeFsSettingsResponse,
zKnowledgeFsSpaceDetailResponse,
} from '@dify/contracts/api/console/knowledge-fs/zod.gen'
-import { act, fireEvent, screen, waitFor, within } from '@testing-library/react'
+import { useQuery } from '@tanstack/react-query'
+import { act, screen, waitFor, within } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
+import { emojiCatalogOptions } from '@/app/components/base/icon-picker/emoji-data'
import { consoleQuery } from '@/service/console'
import { validateDefinedErrors } from '@/service/console/defined-errors'
import { createHttpError } from '@/service/http-error'
-import { createConsoleQueryClient, renderWithConsoleQuery } from '@/test/console/query-data'
+import {
+ createCatalogModelFixture,
+ createModelCatalogFixture,
+ seedModelProviderQueries,
+} from '@/test/console/model-provider'
+import {
+ createConsoleQueryClient,
+ renderWithConsoleQuery as renderConsole,
+} from '@/test/console/query-data'
+import { createNuqsTestRenderer } from '@/test/nuqs-testing'
import { KnowledgeSettingsPage } from '../page'
const serviceMock = vi.hoisted(() => ({
deleteSpace: vi.fn(),
getMigration: vi.fn(),
getSpace: vi.fn(),
+ getSpaces: vi.fn(),
patchExternalAccess: vi.fn(),
patchSettings: vi.fn(),
patchSpace: vi.fn(),
@@ -67,6 +78,7 @@ vi.mock('@/service/console', async (importOriginal) => {
return {
...actual,
consoleQuery: withConsoleResponses(actual.consoleQuery, {
+ 'knowledgeFs.spaces.get': serviceMock.getSpaces,
[`${space}.delete`]: serviceMock.deleteSpace,
[`${space}.externalAccess.get`]: async () => knowledgeQueryMock.externalAccess,
[`${space}.externalAccess.put`]: serviceMock.patchExternalAccess,
@@ -78,108 +90,70 @@ vi.mock('@/service/console', async (importOriginal) => {
[`${space}.settings.migrations.byMigrationId.get`]: serviceMock.getMigration,
[`${space}.settings.patch`]: serviceMock.patchSettings,
'workspaces.current.members.get': async () => ({ accounts: membersQueryMock.accounts }),
- 'workspaces.current.models.modelTypes.byModelType.get': async () => ({ data: [] }),
}),
}
})
-// The model selector loads provider catalogs and has its own suite; this stub keeps the
-// selection contract (value, change, and ARIA wiring) that the settings form owns.
-vi.mock('@/app/components/header/account-setting/model-provider-page/model-selector', () => ({
- ModelSelector: ({
- ariaDescribedBy,
- ariaInvalid,
- ariaLabelledBy,
- ariaRequired,
- value,
- onValueChange,
- disabled,
- }: {
- ariaDescribedBy?: string
- ariaInvalid?: boolean
- ariaLabelledBy?: string
- ariaRequired?: boolean
- value?: { model: string; provider: string }
- onValueChange?: (model: { model: string; plugin_id: string; provider: string }) => void
- disabled?: boolean
- }) => {
- const popupId = `${ariaLabelledBy ?? 'model-selector'}-popup`
- return (
- <>
- <button
- type="button"
- aria-controls={popupId}
- aria-expanded="false"
- aria-describedby={ariaDescribedBy}
- aria-labelledby={ariaLabelledBy}
- data-invalid={ariaInvalid ? '' : undefined}
- data-required={ariaRequired ? '' : undefined}
- disabled={disabled}
- onClick={() =>
- onValueChange?.({
- model: 'openrouter/auto',
- plugin_id: 'langgenius/openrouter',
- provider: 'langgenius/openrouter/openrouter',
- })
- }
- >
- {value ? `${value.provider}:${value.model}` : 'select-model'}
- </button>
- <span id={popupId} hidden />
- </>
- )
- },
-}))
-
-// The real picker needs emoji data and canvas cropping and is covered by its browser suite; this
-// stub preserves its trigger/content/value contract.
-vi.mock('@/app/components/base/icon-picker', async () => {
- const { createContext, use, useState } = await import('react')
- type Selection = { background: string; icon: string; type: 'emoji' }
- const PickerContext = createContext<{
- open: boolean
- setOpen: (open: boolean) => void
- onValueChange: (selection: Selection) => void
- } | null>(null)
- return {
- IconPicker: ({
- onValueChange,
- children,
- }: {
- onValueChange: (selection: Selection) => void
- children: ReactNode
- }) => {
- const [open, setOpen] = useState(false)
- return <PickerContext value={{ open, setOpen, onValueChange }}>{children}</PickerContext>
- },
- IconPickerTrigger: ({ children, ...props }: ComponentProps<'button'>) => {
- const picker = use(PickerContext)
- return (
- <button type="button" {...props} onClick={() => picker?.setOpen(true)}>
- {children}
- </button>
- )
- },
- IconPickerContent: () => {
- const picker = use(PickerContext)
- return picker?.open ? (
- <button
- type="button"
- onClick={() =>
- picker.onValueChange({ background: '#FCE7F6', icon: 'camera', type: 'emoji' })
- }
- >
- Select camera style
- </button>
- ) : null
- },
- }
-})
-
vi.mock('@/app/notifications', () => ({
toast: toastMock,
}))
+const renderWithConsoleQuery = createNuqsTestRenderer(renderConsole)
+const modelCatalog = [
+ createModelCatalogFixture({
+ provider: 'langgenius/openai/openai',
+ models: [
+ createCatalogModelFixture({ model: 'gpt-4o', label: { en_US: 'gpt-4o' } }),
+ ...['text-embedding-3-large', 'text-embedding-3-small'].map((model) =>
+ createCatalogModelFixture({
+ model,
+ label: { en_US: model },
+ model_type: 'text-embedding',
+ }),
+ ),
+ ],
+ }),
+ createModelCatalogFixture({
+ provider: 'langgenius/openrouter/openrouter',
+ label: { en_US: 'OpenRouter' },
+ models: [
+ createCatalogModelFixture({ model: 'openrouter/auto', label: { en_US: 'openrouter/auto' } }),
+ ],
+ }),
+ createModelCatalogFixture({
+ provider: 'langgenius/cohere/cohere',
+ label: { en_US: 'Cohere' },
+ models: ['rerank-english-v3.0', 'rerank-v3.5'].map((model) =>
+ createCatalogModelFixture({
+ model,
+ label: { en_US: model },
+ model_type: 'rerank',
+ }),
+ ),
+ }),
+]
+
+async function chooseModel(user: ReturnType<typeof userEvent.setup>, model = 'openrouter/auto') {
+ const picker = await screen.findByRole('dialog', { name: 'plugin.detailPanel.configureModel' })
+ await user.click(within(picker).getByRole('button', { name: model }))
+ await waitFor(() =>
+ expect(
+ screen.queryByRole('dialog', { name: 'plugin.detailPanel.configureModel' }),
+ ).not.toBeInTheDocument(),
+ )
+}
+
+async function chooseIcon(user: ReturnType<typeof userEvent.setup>) {
+ await user.click(screen.getByRole('radio', { name: 'app.iconPicker.color.pink' }))
+ await user.click(screen.getByRole('gridcell', { name: 'Video camera' }))
+ await user.click(screen.getByRole('button', { name: 'app.iconPicker.ok' }))
+ await waitFor(() =>
+ expect(
+ screen.queryByRole('radio', { name: 'app.iconPicker.color.pink' }),
+ ).not.toBeInTheDocument(),
+ )
+}
+
const space = {
control_space_id: 'space-1',
created_at: '2026-07-28T00:00:00Z',
@@ -234,7 +208,7 @@ const settings = {
rerank: {
enabled: true,
model: {
- model: 'rerank-v3',
+ model: 'rerank-english-v3.0',
pluginId: 'langgenius/cohere',
provider: 'cohere',
},
@@ -295,10 +269,24 @@ const spacesListPage = () => ({
page: 1,
})
+function KnowledgeSpaceList({ keyword }: { keyword: string }) {
+ const { data } = useQuery(
+ consoleQuery.knowledgeFs.spaces.get.queryOptions({
+ input: { query: { query: keyword } },
+ }),
+ )
+ return (
+ <output aria-label={`Knowledge list: ${keyword || 'all'}`}>
+ {data?.data.map((item) => item.technical_summary?.name).join(', ')}
+ </output>
+ )
+}
+
async function renderForm({
accountProfile = {},
externalAccess: externalAccessOverride = externalAccess,
members = [],
+ listKeywords = [],
permissions = [],
queryClient: queryClientOverride,
settings: settingsOverride = settings,
@@ -315,6 +303,7 @@ async function renderForm({
}>
externalAccess?: typeof externalAccess
members?: AccountWithRoleResponse[]
+ listKeywords?: string[]
permissions?: KnowledgeFsPermissionResponse[]
queryClient?: QueryClient
settings?: KnowledgeFsSettingsResponse
@@ -328,21 +317,42 @@ async function renderForm({
const queryClient = queryClientOverride ?? createConsoleQueryClient()
queryClient.setQueryData(queryKeys.externalAccess(), externalAccessOverride)
queryClient.setQueryData(queryKeys.permissions(), { data: permissions })
+ seedModelProviderQueries(queryClient, modelCatalog)
+ queryClient.setQueryData(emojiCatalogOptions.queryKey, [
+ {
+ id: 'objects',
+ label: 'Objects',
+ items: [
+ { emoji: '📷', label: 'Camera', version: 0.6 },
+ { emoji: '📹', label: 'Video camera', version: 0.6 },
+ ],
+ },
+ ])
seedSettings(queryClient, settingsOverride)
seedSpace(queryClient, spaceOverride)
- const view = renderWithConsoleQuery(<KnowledgeSettingsPage knowledgeSpaceId="space-1" />, {
- accountProfile: {
- avatar: '',
- avatar_url: null,
- email: '[email protected]',
- id: 'user-1',
- is_password_set: false,
- name: 'Test User',
- timezone: 'Asia/Shanghai',
- ...accountProfile,
+ for (const keyword of listKeywords)
+ queryClient.setQueryData(queryKeys.spacesList(keyword), spacesListPage())
+ const view = renderWithConsoleQuery(
+ <>
+ <KnowledgeSettingsPage knowledgeSpaceId="space-1" />
+ {listKeywords.map((keyword) => (
+ <KnowledgeSpaceList key={keyword} keyword={keyword} />
+ ))}
+ </>,
+ {
+ accountProfile: {
+ avatar: '',
+ avatar_url: null,
+ email: '[email protected]',
+ id: 'user-1',
+ is_password_set: false,
+ name: 'Test User',
+ timezone: 'Asia/Shanghai',
+ ...accountProfile,
+ },
+ queryClient,
},
- queryClient,
- })
+ )
await waitFor(() => expect(queryClient.isFetching()).toBe(0))
return view
}
@@ -387,7 +397,7 @@ async function editAllSettings(user: ReturnType<typeof userEvent.setup>) {
await user.type(description, 'Draft documentation')
expectNoWrites()
await user.click(screen.getByRole('button', { name: 'datasetSettings.form.nameAndIcon' }))
- await user.click(screen.getByRole('button', { name: 'Select camera style' }))
+ await chooseIcon(user)
expectNoWrites()
await user.click(screen.getByRole('button', { name: /datasetSettings\.form\.permissionsOnlyMe/ }))
const picker = screen.getByRole('dialog', { name: 'datasetSettings.form.permissions' })
@@ -401,11 +411,12 @@ async function editAllSettings(user: ReturnType<typeof userEvent.setup>) {
await user.click(screen.getByRole('switch', { name }))
expectNoWrites()
}
- for (const name of [
- 'knowledgeSettings.settings.systemReasoningModelLabel',
- 'modelProvider.modelProvider.rerankModel.key',
- ]) {
- await user.click(screen.getByRole('button', { name }))
+ for (const [name, model] of [
+ ['knowledgeSettings.settings.systemReasoningModelLabel', 'openrouter/auto'],
+ ['modelProvider.modelProvider.rerankModel.key', 'rerank-v3.5'],
+ ] as const) {
+ await user.click(screen.getByRole('button', { name: new RegExp(name) }))
+ await chooseModel(user, model)
expectNoWrites()
}
await user.click(screen.getByText('knowledgeSpace.settings.retrievalMode.deep'))
@@ -426,9 +437,13 @@ async function editAllSettings(user: ReturnType<typeof userEvent.setup>) {
describe('KnowledgeSettingsPage workflows', () => {
beforeEach(() => {
- vi.resetAllMocks()
+ Object.values(serviceMock).forEach((mock) => mock.mockReset())
serviceMock.deleteSpace.mockResolvedValue(undefined)
serviceMock.getSpace.mockImplementation(async () => knowledgeQueryMock.space)
+ serviceMock.getSpaces.mockImplementation(async () => ({
+ ...spacesListPage(),
+ data: [{ ...knowledgeQueryMock.space!, linked_apps: 0, tags: [] }],
+ }))
serviceMock.patchExternalAccess.mockImplementation(
async ({ body }: { body: KnowledgeFsExternalAccessPayload }) => {
const current = knowledgeQueryMock.externalAccess!
@@ -532,11 +547,13 @@ describe('KnowledgeSettingsPage workflows', () => {
expect(toastMock.success).toHaveBeenCalledWith('common.api.actionSuccess')
})
- it('marks every cached knowledge-space list variant stale after saving basic information', async () => {
+ it('refreshes every subscribed knowledge-space list variant after saving basic information', async () => {
const user = userEvent.setup()
- const { queryClient } = await renderForm()
- const listKeys = [queryKeys.spacesList(''), queryKeys.spacesList('camera')]
- for (const queryKey of listKeys) queryClient.setQueryData(queryKey, spacesListPage())
+ await renderForm({ listKeywords: ['', 'camera'] })
+ for (const label of ['all', 'camera'])
+ expect(screen.getByLabelText(`Knowledge list: ${label}`)).toHaveTextContent(
+ 'Camera Technical Spec',
+ )
const nameInput = screen.getByRole('textbox', { name: 'datasetSettings.form.name' })
await user.clear(nameInput)
@@ -544,8 +561,12 @@ describe('KnowledgeSettingsPage workflows', () => {
await saveChanges(user)
await waitFor(() => expect(toastMock.success).toHaveBeenCalledWith('common.api.actionSuccess'))
- for (const queryKey of listKeys)
- expect(queryClient.getQueryState(queryKey)?.isInvalidated).toBe(true)
+ await waitFor(() => {
+ for (const label of ['all', 'camera'])
+ expect(screen.getByLabelText(`Knowledge list: ${label}`)).toHaveTextContent(
+ 'Updated camera specs',
+ )
+ })
})
it('keeps fields locked while Cancel refreshes the saved server data', async () => {
@@ -634,9 +655,7 @@ describe('KnowledgeSettingsPage workflows', () => {
name: 'datasetSettings.form.nameAndIcon',
})
await user.click(iconButton)
- await user.click(screen.getByRole('button', { name: 'Select camera style' }))
-
- expect(iconButton.firstElementChild?.firstElementChild).toHaveStyle({ background: '#FCE7F6' })
+ await chooseIcon(user)
await user.click(
screen.getByRole('button', {
@@ -647,21 +666,27 @@ describe('KnowledgeSettingsPage workflows', () => {
await waitFor(() => {
expect(serviceMock.patchSpace).toHaveBeenCalledWith({
body: {
- icon: 'camera',
- icon_background: '#FCE7F6',
+ icon: '📹',
+ icon_background: '#FDF2FA',
},
params: { control_space_id: 'space-1' },
})
})
+ await user.click(iconButton)
+ expect(screen.getByRole('radio', { name: 'app.iconPicker.color.pink' })).toBeChecked()
+ expect(
+ screen.getByText('app.iconPicker.currentEmoji:{"emoji":"Video camera"}'),
+ ).toBeInTheDocument()
})
it('restores a saved emoji background style from the space detail', async () => {
+ const user = userEvent.setup()
await renderForm({
space: {
...space,
technical_summary: {
...space.technical_summary,
- icon_background: '#D3F8DF',
+ icon_background: '#F3FEE7',
},
},
})
@@ -669,7 +694,8 @@ describe('KnowledgeSettingsPage workflows', () => {
const iconButton = screen.getByRole('button', {
name: 'datasetSettings.form.nameAndIcon',
})
- expect(iconButton.firstElementChild?.firstElementChild).toHaveStyle({ background: '#D3F8DF' })
+ await user.click(iconButton)
+ expect(screen.getByRole('radio', { name: 'app.iconPicker.color.green' })).toBeChecked()
})
it('accepts 2000 description characters and blocks 2001 with a field error', async () => {
@@ -683,7 +709,8 @@ describe('KnowledgeSettingsPage workflows', () => {
name: 'knowledgeSettings.settings.saveChanges',
})
const invalidDescription = '知'.repeat(2001)
- fireEvent.change(descriptionInput, { target: { value: invalidDescription } })
+ await user.clear(descriptionInput)
+ await user.paste(invalidDescription)
expect(descriptionInput).toHaveValue(invalidDescription)
expect(descriptionInput).toHaveAttribute('aria-invalid', 'true')
@@ -694,12 +721,14 @@ describe('KnowledgeSettingsPage workflows', () => {
expect(serviceMock.patchSpace).not.toHaveBeenCalled()
const boundaryDescription = '知'.repeat(2000)
- fireEvent.change(descriptionInput, { target: { value: `${boundaryDescription} ` } })
+ await user.clear(descriptionInput)
+ await user.paste(`${boundaryDescription} `)
expect(descriptionInput).toHaveAttribute('aria-invalid', 'true')
expect(saveButton).toBeDisabled()
expect(serviceMock.patchSpace).not.toHaveBeenCalled()
- fireEvent.change(descriptionInput, { target: { value: boundaryDescription } })
+ await user.clear(descriptionInput)
+ await user.paste(boundaryDescription)
expect(descriptionInput).not.toHaveAttribute('aria-invalid', 'true')
expect(saveButton).toBeEnabled()
await user.click(saveButton)
@@ -947,11 +976,11 @@ describe('KnowledgeSettingsPage workflows', () => {
expect(routerMock.replace).toHaveBeenCalledWith('/datasets?view=agent')
})
- it('marks cached knowledge-space lists stale before returning after deletion', async () => {
+ it('refreshes subscribed knowledge-space lists after deletion and returns to knowledge', async () => {
const user = userEvent.setup()
- const { queryClient } = await renderForm()
- const listKey = queryKeys.spacesList('')
- queryClient.setQueryData(listKey, spacesListPage())
+ serviceMock.getSpaces.mockResolvedValue({ ...spacesListPage(), data: [] })
+ await renderForm({ listKeywords: [''] })
+ expect(screen.getByLabelText('Knowledge list: all')).toHaveTextContent('Camera Technical Spec')
await user.click(screen.getByRole('button', { name: 'common.operation.delete' }))
const dialog = await screen.findByRole('alertdialog')
@@ -959,7 +988,7 @@ describe('KnowledgeSettingsPage workflows', () => {
await user.click(within(dialog).getByRole('button', { name: 'common.operation.confirm' }))
await waitFor(() => expect(routerMock.replace).toHaveBeenCalledWith('/datasets?view=agent'))
- expect(queryClient.getQueryState(listKey)?.isInvalidated).toBe(true)
+ await waitFor(() => expect(screen.getByLabelText('Knowledge list: all')).toBeEmptyDOMElement())
})
it('keeps a failed deletion inline and retries with the same confirmed name', async () => {
@@ -1037,9 +1066,10 @@ describe('KnowledgeSettingsPage workflows', () => {
await user.click(
screen.getByRole('button', {
- name: 'knowledgeSettings.settings.systemReasoningModelLabel',
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
}),
)
+ await chooseModel(user, 'openrouter/auto')
expectNoWrites()
await saveChanges(user)
@@ -1077,9 +1107,10 @@ describe('KnowledgeSettingsPage workflows', () => {
)
await renderForm()
const selector = screen.getByRole('button', {
- name: 'knowledgeSettings.settings.systemReasoningModelLabel',
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
})
await user.click(selector)
+ await chooseModel(user)
expectNoWrites()
await saveChanges(user)
@@ -1132,9 +1163,10 @@ describe('KnowledgeSettingsPage workflows', () => {
)
await renderForm()
const selector = screen.getByRole('button', {
- name: 'knowledgeSettings.settings.systemReasoningModelLabel',
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
})
await user.click(selector)
+ await chooseModel(user)
expectNoWrites()
await saveChanges(user)
const reload = await screen.findByRole('button', {
@@ -1155,6 +1187,7 @@ describe('KnowledgeSettingsPage workflows', () => {
expect(selector).not.toHaveTextContent('openrouter/auto')
expect(serviceMock.patchSettings).toHaveBeenCalledTimes(1)
await user.click(selector)
+ await chooseModel(user)
await saveChanges(user)
await waitFor(() => expect(serviceMock.patchSettings).toHaveBeenCalledTimes(2))
expect(serviceMock.patchSettings.mock.calls[1]?.[0].body).toMatchObject({
@@ -1203,8 +1236,18 @@ describe('KnowledgeSettingsPage workflows', () => {
)
const search = within(picker).getByRole('searchbox', { name: 'common.operation.search' })
- await user.type(search, 'Team')
- expect(await within(picker).findByRole('button', { name: /Team Member/ })).toBeInTheDocument()
+ vi.useFakeTimers({ shouldAdvanceTime: true })
+ try {
+ const searchUser = userEvent.setup({ advanceTimers: vi.advanceTimersByTime })
+ await searchUser.type(search, 'Team')
+ await act(async () => vi.advanceTimersByTimeAsync(500))
+ expect(within(picker).getByRole('button', { name: /Team Member/ })).toBeInTheDocument()
+ expect(
+ within(picker).queryByRole('button', { name: /Workspace owner/ }),
+ ).not.toBeInTheDocument()
+ } finally {
+ vi.useRealTimers()
+ }
expect(screen.queryByRole('button', { name: 'common.operation.add' })).not.toBeInTheDocument()
})
@@ -1319,9 +1362,10 @@ describe('KnowledgeSettingsPage workflows', () => {
await user.click(
screen.getByRole('button', {
- name: 'knowledgeSettings.settings.embeddingModelLabel',
+ name: /knowledgeSettings\.settings\.embeddingModelLabel/,
}),
)
+ await chooseModel(user, 'text-embedding-3-small')
const dialog = await screen.findByRole('alertdialog')
expect(serviceMock.patchSettings).not.toHaveBeenCalled()
await user.click(within(dialog).getByRole('button', { name: 'common.operation.confirm' }))
@@ -1332,9 +1376,9 @@ describe('KnowledgeSettingsPage workflows', () => {
expect(serviceMock.patchSettings).toHaveBeenCalledWith({
body: {
embedding: {
- model: 'openrouter/auto',
- pluginId: 'langgenius/openrouter',
- provider: 'openrouter',
+ model: 'text-embedding-3-small',
+ pluginId: 'langgenius/openai',
+ provider: 'openai',
},
expectedRevision: 5,
},
@@ -1438,15 +1482,16 @@ describe('KnowledgeSettingsPage workflows', () => {
})
expect(
- screen.queryByRole('switch', { name: 'modelProvider.modelProvider.rerankModel.key' }),
+ screen.queryByRole('switch', { name: /modelProvider\.modelProvider\.rerankModel\.key/ }),
).not.toBeInTheDocument()
const rerankSelector = screen.getByRole('button', {
- name: 'modelProvider.modelProvider.rerankModel.key',
+ name: /modelProvider\.modelProvider\.rerankModel\.key/,
})
expect(rerankSelector).toHaveAccessibleDescription(
'knowledgeSettings.settings.rerankModelRequired',
)
await user.click(rerankSelector)
+ await chooseModel(user, 'rerank-v3.5')
expectNoWrites()
await saveChanges(user)
@@ -1464,9 +1509,9 @@ describe('KnowledgeSettingsPage workflows', () => {
rerank: {
enabled: true,
model: {
- model: 'openrouter/auto',
- pluginId: 'langgenius/openrouter',
- provider: 'openrouter',
+ model: 'rerank-v3.5',
+ pluginId: 'langgenius/cohere',
+ provider: 'cohere',
},
},
scoreThreshold: expect.objectContaining({ stage: 'rerank' }),
@@ -1548,19 +1593,19 @@ describe('KnowledgeSettingsPage workflows', () => {
'datasetSettings.form.embeddingModel · modelProvider.modelProvider.systemReasoningModel.key · modelProvider.modelProvider.rerankModel.key',
)
const reasoningSelector = screen.getByRole('button', {
- name: 'knowledgeSettings.settings.systemReasoningModelLabel',
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
})
expect(reasoningSelector).toHaveAccessibleDescription(
'knowledgeSettings.settings.systemReasoningModelRequired',
)
const embeddingSelector = screen.getByRole('button', {
- name: 'knowledgeSettings.settings.embeddingModelLabel',
+ name: /knowledgeSettings\.settings\.embeddingModelLabel/,
})
expect(embeddingSelector).toHaveAccessibleDescription(
'knowledgeSettings.settings.embeddingModelRequired',
)
const rerankSelector = screen.getByRole('button', {
- name: 'modelProvider.modelProvider.rerankModel.key',
+ name: /modelProvider\.modelProvider\.rerankModel\.key/,
})
expect(rerankSelector).toHaveAccessibleDescription(
'knowledgeSettings.settings.rerankModelRequired',
@@ -1574,19 +1619,22 @@ describe('KnowledgeSettingsPage workflows', () => {
await user.click(
screen.getByRole('button', {
- name: 'knowledgeSettings.settings.systemReasoningModelLabel',
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
}),
)
+ await chooseModel(user, 'openrouter/auto')
expect(
screen.queryByText('knowledgeSettings.settings.systemReasoningModelRequired'),
).not.toBeInTheDocument()
expect(embeddingSelector).toBeEnabled()
await user.click(embeddingSelector)
+ await chooseModel(user, 'text-embedding-3-small')
expect(
screen.queryByText('knowledgeSettings.settings.embeddingModelRequired'),
).not.toBeInTheDocument()
expect(serviceMock.patchSettings).not.toHaveBeenCalled()
await user.click(rerankSelector)
+ await chooseModel(user, 'rerank-v3.5')
expect(
screen.queryByText('knowledgeSettings.settings.rerankModelRequired'),
).not.toBeInTheDocument()
@@ -1624,11 +1672,13 @@ describe('KnowledgeSettingsPage workflows', () => {
expect(screen.queryByRole('status')).not.toBeInTheDocument()
expect(
- screen.getByRole('button', { name: 'knowledgeSettings.settings.embeddingModelLabel' }),
+ screen.getByRole('button', {
+ name: /knowledgeSettings\.settings\.embeddingModelLabel/,
+ }),
).toHaveTextContent(settings.embedding.model)
expect(
screen.getByRole('button', {
- name: 'knowledgeSettings.settings.systemReasoningModelLabel',
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
}),
).toHaveTextContent(settings.retrieval.reasoning_model.model)
expectNoWrites()
@@ -1699,6 +1749,7 @@ describe('KnowledgeSettingsPage workflows', () => {
})
it('normalizes split Knowledge FS provider identities for the model selector', async () => {
+ const user = userEvent.setup()
await renderForm({
settings: {
...settings,
@@ -1715,9 +1766,19 @@ describe('KnowledgeSettingsPage workflows', () => {
expect(
screen.getByRole('button', {
- name: 'knowledgeSettings.settings.systemReasoningModelLabel',
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
}),
- ).toBeInTheDocument()
+ ).toHaveTextContent('openrouter/auto')
+ await user.click(
+ screen.getByRole('button', {
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
+ }),
+ )
+ const picker = await screen.findByRole('dialog', { name: 'plugin.detailPanel.configureModel' })
+ expect(within(picker).getByRole('button', { name: 'openrouter/auto' })).toHaveAttribute(
+ 'aria-current',
+ 'true',
+ )
})
it('changes the reasoning model without confirmation and saves its normalized provider only on Save', async () => {
@@ -1725,9 +1786,10 @@ describe('KnowledgeSettingsPage workflows', () => {
await renderForm()
const selector = screen.getByRole('button', {
- name: 'knowledgeSettings.settings.systemReasoningModelLabel',
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
})
await user.click(selector)
+ await chooseModel(user, 'openrouter/auto')
expect(screen.queryByRole('alertdialog')).not.toBeInTheDocument()
expect(selector).toHaveTextContent('openrouter/auto')
@@ -1782,9 +1844,10 @@ describe('KnowledgeSettingsPage workflows', () => {
await user.click(
screen.getByRole('button', {
- name: 'knowledgeSettings.settings.systemReasoningModelLabel',
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
}),
)
+ await chooseModel(user, 'openrouter/auto')
expectNoWrites()
await saveChanges(user)
@@ -1835,9 +1898,10 @@ describe('KnowledgeSettingsPage workflows', () => {
await user.click(
screen.getByRole('button', {
- name: 'knowledgeSettings.settings.systemReasoningModelLabel',
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
}),
)
+ await chooseModel(user, 'openrouter/auto')
expectNoWrites()
await saveChanges(user)
@@ -1875,8 +1939,8 @@ describe('KnowledgeSettingsPage workflows', () => {
body: {
name: 'Draft camera specs',
description: 'Draft documentation',
- icon: 'camera',
- icon_background: '#FCE7F6',
+ icon: '📹',
+ icon_background: '#FDF2FA',
visibility: 'partial_members',
},
params: { control_space_id: 'space-1' },
@@ -1907,9 +1971,9 @@ describe('KnowledgeSettingsPage workflows', () => {
rerank: {
enabled: true,
model: {
- model: 'openrouter/auto',
- pluginId: 'langgenius/openrouter',
- provider: 'openrouter',
+ model: 'rerank-v3.5',
+ pluginId: 'langgenius/cohere',
+ provider: 'cohere',
},
},
scoreThreshold: { enabled: true, stage: 'rerank', value: 0.72 },
@@ -1930,8 +1994,9 @@ describe('KnowledgeSettingsPage workflows', () => {
await renderForm({ accountProfile: { id: 'owner-1' }, members: [teamMember] })
const { name, description, topK, threshold } = await editAllSettings(user)
await user.click(
- screen.getByRole('button', { name: 'knowledgeSettings.settings.embeddingModelLabel' }),
+ screen.getByRole('button', { name: /knowledgeSettings\.settings\.embeddingModelLabel/ }),
)
+ await chooseModel(user, 'text-embedding-3-small')
const confirmation = await screen.findByRole('alertdialog')
await user.click(within(confirmation).getByRole('button', { name: 'common.operation.confirm' }))
expectNoWrites()
@@ -1947,14 +2012,16 @@ describe('KnowledgeSettingsPage workflows', () => {
screen.getByRole('button', { name: /datasetSettings\.form\.permissionsOnlyMe/ }),
).toBeInTheDocument()
expect(
- screen.getByRole('button', { name: 'knowledgeSettings.settings.systemReasoningModelLabel' }),
+ screen.getByRole('button', {
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
+ }),
).toHaveTextContent('gpt-4o')
expect(
- screen.getByRole('button', { name: 'knowledgeSettings.settings.embeddingModelLabel' }),
+ screen.getByRole('button', { name: /knowledgeSettings\.settings\.embeddingModelLabel/ }),
).toHaveTextContent('text-embedding-3-large')
expect(
- screen.getByRole('button', { name: 'modelProvider.modelProvider.rerankModel.key' }),
- ).toHaveTextContent('rerank-v3')
+ screen.getByRole('button', { name: /modelProvider\.modelProvider\.rerankModel\.key/ }),
+ ).toHaveTextContent('rerank-english-v3.0')
expect(screen.getByRole('switch', { name: 'knowledgeSpace.apiAgentAccess' })).toHaveAttribute(
'aria-checked',
'true',
@@ -1974,7 +2041,7 @@ describe('KnowledgeSettingsPage workflows', () => {
expectNoWrites()
})
- it('locks every section and already-open icon selection until the whole save finishes', async () => {
+ it('locks every section until the whole save finishes', async () => {
const user = userEvent.setup()
let finishSave!: () => void
const originalSave = serviceMock.patchSpace.getMockImplementation()!
@@ -1989,7 +2056,13 @@ describe('KnowledgeSettingsPage workflows', () => {
await user.clear(name)
await user.type(name, 'Saving camera specs')
await user.click(screen.getByRole('button', { name: 'datasetSettings.form.nameAndIcon' }))
- expect(screen.getByRole('button', { name: 'Select camera style' })).toBeInTheDocument()
+ expect(screen.getByRole('radio', { name: 'app.iconPicker.color.lightBlue' })).toBeChecked()
+ await user.keyboard('{Escape}')
+ await waitFor(() =>
+ expect(
+ screen.queryByRole('radio', { name: 'app.iconPicker.color.lightBlue' }),
+ ).not.toBeInTheDocument(),
+ )
await saveChanges(user)
await waitFor(() => expect(serviceMock.patchSpace).toHaveBeenCalledOnce())
@@ -2008,7 +2081,7 @@ describe('KnowledgeSettingsPage workflows', () => {
'common.operation.cancel',
'common.operation.delete',
])
- expect(screen.getByRole('button', { name: label })).toBeDisabled()
+ expect(screen.getByRole('button', { name: new RegExp(label) })).toBeDisabled()
expect(
screen.getByRole('button', { name: /datasetSettings\.form\.permissionsOnlyMe/ }),
).toBeDisabled()
@@ -2020,10 +2093,14 @@ describe('KnowledgeSettingsPage workflows', () => {
expect(screen.getByRole('switch', { name: label })).toHaveAttribute('aria-disabled', 'true')
await user.click(screen.getByRole('switch', { name: 'knowledgeSpace.apiAgentAccess' }))
await user.click(
- screen.getByRole('button', { name: 'knowledgeSettings.settings.systemReasoningModelLabel' }),
+ screen.getByRole('button', {
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
+ }),
)
- const openIconChoice = screen.queryByRole('button', { name: 'Select camera style' })
- if (openIconChoice) await user.click(openIconChoice)
+ await user.click(screen.getByRole('button', { name: 'datasetSettings.form.nameAndIcon' }))
+ expect(
+ screen.queryByRole('radio', { name: 'app.iconPicker.color.pink' }),
+ ).not.toBeInTheDocument()
expect(serviceMock.patchExternalAccess).not.toHaveBeenCalled()
expect(serviceMock.patchSettings).not.toHaveBeenCalled()
expect(
@@ -2103,14 +2180,18 @@ describe('KnowledgeSettingsPage workflows', () => {
})
await renderForm()
await user.click(
- screen.getByRole('button', { name: 'knowledgeSettings.settings.embeddingModelLabel' }),
+ screen.getByRole('button', { name: /knowledgeSettings\.settings\.embeddingModelLabel/ }),
)
+ await chooseModel(user, 'text-embedding-3-small')
const confirmation = await screen.findByRole('alertdialog')
await user.click(within(confirmation).getByRole('button', { name: 'common.operation.confirm' }))
expectNoWrites()
await user.click(
- screen.getByRole('button', { name: 'knowledgeSettings.settings.systemReasoningModelLabel' }),
+ screen.getByRole('button', {
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
+ }),
)
+ await chooseModel(user, 'openrouter/auto')
const topK = screen.getByRole('textbox', { name: 'knowledgeSpace.settings.topKLabel' })
await user.clear(topK)
await user.type(topK, '8')
@@ -2123,9 +2204,9 @@ describe('KnowledgeSettingsPage workflows', () => {
body: {
expectedRevision: 5,
embedding: {
- model: 'openrouter/auto',
- pluginId: 'langgenius/openrouter',
- provider: 'openrouter',
+ model: 'text-embedding-3-small',
+ pluginId: 'langgenius/openai',
+ provider: 'openai',
},
},
params: { control_space_id: 'space-1' },
@@ -2279,9 +2360,10 @@ describe('KnowledgeSettingsPage workflows', () => {
.mockResolvedValueOnce({ ...migration, checkpoint: 'activated', run_state: 'succeeded' })
await renderForm()
const reasoning = screen.getByRole('button', {
- name: 'knowledgeSettings.settings.systemReasoningModelLabel',
+ name: /knowledgeSettings\.settings\.systemReasoningModelLabel/,
})
await user.click(reasoning)
+ await chooseModel(user)
expectNoWrites()
await saveChanges(user)