Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(rbac): grant agent access to all legacy roles (#41511)

Wu Tianwei7167d7d66289
diff --git a/api/services/enterprise/rbac_service.py b/api/services/enterprise/rbac_service.py
index b3d1bfac0fd..bf95b8650b1 100644
--- a/api/services/enterprise/rbac_service.py
+++ b/api/services/enterprise/rbac_service.py
@@ -464,6 +464,7 @@ _LEGACY_WORKSPACE_NORMAL_KEYS: list[str] = [
"plugin.install",
"credential.use",
"app_library.access",
+ "agent.manage",
]
_LEGACY_WORKSPACE_DATASET_OPERATOR_KEYS: list[str] = [
@@ -471,6 +472,7 @@ _LEGACY_WORKSPACE_DATASET_OPERATOR_KEYS: list[str] = [
"plugin.install",
"dataset.create_and_management",
"dataset.external.connect",
+ "agent.manage",
]
_LEGACY_APP_OWNER_KEYS: list[str] = [
diff --git a/api/tests/unit_tests/services/enterprise/test_rbac_service.py b/api/tests/unit_tests/services/enterprise/test_rbac_service.py
index 432466a9975..0ce4390fd0c 100644
--- a/api/tests/unit_tests/services/enterprise/test_rbac_service.py
+++ b/api/tests/unit_tests/services/enterprise/test_rbac_service.py
@@ -1128,16 +1128,12 @@ class TestListOption:
class TestLegacyAgentManageKey:
def test_legacy_agent_manage_key_membership(self):
- # Mirrors the builtin roles in the rbac service, which grant agent.manage
- # to owner/admin/editor only.
+ # Preserve Agent access for every legacy role while external RBAC is disabled.
for keys in (
svc._LEGACY_WORKSPACE_OWNER_KEYS,
svc._LEGACY_WORKSPACE_ADMIN_KEYS,
svc._LEGACY_WORKSPACE_EDITOR_KEYS,
- ):
- assert "agent.manage" in keys
- for keys in (
svc._LEGACY_WORKSPACE_NORMAL_KEYS,
svc._LEGACY_WORKSPACE_DATASET_OPERATOR_KEYS,
):
- assert "agent.manage" not in keys
+ assert "agent.manage" in keys