Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(web): name external retrieval close action (#40317)

yyh764d9b5fbef1
diff --git a/web/app/components/datasets/hit-testing/__tests__/modify-external-retrieval-modal.spec.tsx b/web/app/components/datasets/hit-testing/__tests__/modify-external-retrieval-modal.spec.tsx
index 6fb5bad0b87..c01f38d154d 100644
--- a/web/app/components/datasets/hit-testing/__tests__/modify-external-retrieval-modal.spec.tsx
+++ b/web/app/components/datasets/hit-testing/__tests__/modify-external-retrieval-modal.spec.tsx
@@ -2,14 +2,6 @@ import { fireEvent, render, screen } from '@testing-library/react'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import ModifyExternalRetrievalModal from '../modify-external-retrieval-modal'
-vi.mock('@/app/components/base/action-button', () => ({
- default: ({ children, onClick }: { children: React.ReactNode; onClick: () => void }) => (
- <button data-testid="action-button" onClick={onClick}>
- {children}
- </button>
- ),
-}))
-
vi.mock('../../external-knowledge-base/create/RetrievalSettings', () => ({
default: ({
topK,
@@ -67,7 +59,7 @@ describe('ModifyExternalRetrievalModal', () => {
it('should call onClose when close button clicked', () => {
render(<ModifyExternalRetrievalModal {...defaultProps} />)
- fireEvent.click(screen.getByTestId('action-button'))
+ fireEvent.click(screen.getByRole('button', { name: 'common.operation.close' }))
expect(defaultProps.onClose).toHaveBeenCalled()
})
diff --git a/web/app/components/datasets/hit-testing/modify-external-retrieval-modal.tsx b/web/app/components/datasets/hit-testing/modify-external-retrieval-modal.tsx
index 996b81d55e7..18012cf851d 100644
--- a/web/app/components/datasets/hit-testing/modify-external-retrieval-modal.tsx
+++ b/web/app/components/datasets/hit-testing/modify-external-retrieval-modal.tsx
@@ -55,8 +55,12 @@ const ModifyExternalRetrievalModal: React.FC<ModifyExternalRetrievalModalProps>
<div className="grow system-xl-semibold text-text-primary">
{t(($) => $.settingTitle, { ns: 'datasetHitTesting' })}
</div>
- <ActionButton className="ml-auto" onClick={onClose}>
- <RiCloseLine className="size-4 shrink-0" />
+ <ActionButton
+ aria-label={t(($) => $['operation.close'], { ns: 'common' })}
+ className="ml-auto"
+ onClick={onClose}
+ >
+ <RiCloseLine aria-hidden className="size-4 shrink-0" />
</ActionButton>
</div>
<div className="flex flex-col items-start justify-center gap-4 self-stretch p-4 pt-2">