Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(web): label the Notion page search field (#44290)

yyh76d0cfcd5cd0
diff --git a/web/app/components/base/notion-page-selector/__tests__/base.spec.tsx b/web/app/components/base/notion-page-selector/__tests__/base.spec.tsx
index f3adfb578d5..9216974e35e 100644
--- a/web/app/components/base/notion-page-selector/__tests__/base.spec.tsx
+++ b/web/app/components/base/notion-page-selector/__tests__/base.spec.tsx
@@ -191,11 +191,14 @@ describe('NotionPageSelector Base', () => {
const user = userEvent.setup()
render(<NotionPageSelector credentialList={mockCredentialList} onSelect={vi.fn()} />)
- const searchInput = screen.getByPlaceholderText('common.dataSource.notion.selector.searchPages')
+ const searchName = 'common.dataSource.notion.selector.searchPages'
+ const searchInput = screen.getByRole('textbox', { name: searchName })
await user.type(searchInput, 'no-such-page')
+ expect(screen.getByRole('textbox', { name: searchName })).toHaveValue('no-such-page')
expect(screen.getByText('common.dataSource.notion.selector.noSearchResult')).toBeInTheDocument()
await user.click(screen.getByRole('button', { name: 'common.operation.clear' }))
+ expect(screen.getByRole('textbox', { name: searchName })).toHaveValue('')
expect(screen.getByText('Root 1')).toBeInTheDocument()
})
diff --git a/web/app/components/base/notion-page-selector/search-input/index.tsx b/web/app/components/base/notion-page-selector/search-input/index.tsx
index c871b0e6c94..ac8a6c1cda9 100644
--- a/web/app/components/base/notion-page-selector/search-input/index.tsx
+++ b/web/app/components/base/notion-page-selector/search-input/index.tsx
@@ -22,6 +22,7 @@ const SearchInput = ({ value, onChange }: SearchInputProps) => {
<div className={cn('flex h-8 w-50 items-center rounded-lg bg-components-input-bg-normal p-2')}>
<div className="mr-0.5 i-ri-search-line size-4 shrink-0 text-components-input-text-placeholder" />
<input
+ aria-label={safePlaceholderText}
className="min-w-0 grow appearance-none border-0 bg-transparent px-1 text-[13px] leading-4 text-components-input-text-filled outline-0 placeholder:text-components-input-text-placeholder"
value={value}
onChange={(e: ChangeEvent<HTMLInputElement>) => onChange(e.target.value)}