Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(api): end_date filter in feedback export excludes the entire end date (#40114)

Pranav Agarwal7f15f506f8fa
diff --git a/api/services/feedback_service.py b/api/services/feedback_service.py
index 6e60a026ce2..af231394953 100644
--- a/api/services/feedback_service.py
+++ b/api/services/feedback_service.py
@@ -1,7 +1,7 @@
import csv
import io
import json
-from datetime import datetime
+from datetime import datetime, timedelta
from flask import Response
from sqlalchemy import or_, select
@@ -75,8 +75,8 @@ class FeedbackService:
if end_date:
try:
- end_dt = datetime.strptime(end_date, "%Y-%m-%d")
- stmt = stmt.where(MessageFeedback.created_at <= end_dt)
+ end_dt = datetime.strptime(end_date, "%Y-%m-%d") + timedelta(days=1)
+ stmt = stmt.where(MessageFeedback.created_at < end_dt)
except ValueError:
raise ValueError(f"Invalid end_date format: {end_date}. Use YYYY-MM-DD")
diff --git a/api/tests/unit_tests/services/test_feedback_service.py b/api/tests/unit_tests/services/test_feedback_service.py
index 36022936ba7..8e2899e4211 100644
--- a/api/tests/unit_tests/services/test_feedback_service.py
+++ b/api/tests/unit_tests/services/test_feedback_service.py
@@ -242,3 +242,23 @@ class TestFeedbackService:
dislike_feedback = next(item for item in feedback_data if item["feedback_rating_raw"] == "dislike")
assert like_feedback["feedback_rating"] == "👍"
assert dislike_feedback["feedback_rating"] == "👎"
+
+
+class TestEndDateBoundary:
+ """Verify that end_date includes feedback from the entire day (fix for #40050)."""
+
+ def test_end_date_includes_entire_day(self):
+ from datetime import timedelta
+
+ end_date = "2026-08-05"
+ end_dt = datetime.strptime(end_date, "%Y-%m-%d") + timedelta(days=1)
+
+ assert end_dt == datetime(2026, 8, 6, 0, 0, 0)
+ assert datetime(2026, 8, 5, 14, 30, 0) < end_dt
+ assert datetime(2026, 8, 5, 23, 59, 59) < end_dt
+ assert not (datetime(2026, 8, 6, 0, 0, 1) < end_dt)
+
+ def test_start_date_includes_midnight(self):
+ start_dt = datetime.strptime("2026-08-01", "%Y-%m-%d")
+ assert start_dt == datetime(2026, 8, 1, 0, 0, 0)
+ assert datetime(2026, 8, 1, 0, 0, 0) >= start_dt