Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(api): populate permission keys on the starred app list (#43870)

Aniket7f7d8aa61992
diff --git a/api/services/app/console_service.py b/api/services/app/console_service.py
index 8f633d7ed2e..25bc6a3b3e9 100644
--- a/api/services/app/console_service.py
+++ b/api/services/app/console_service.py
@@ -296,16 +296,15 @@ class ConsoleAppService:
return self._transfers.check_dependencies(context, app_id)
def list_apps(self, context: RequestContext, params: AppListParams | StarredAppListParams) -> AppPage:
- permissions = None
+ permissions = self._access.permissions(context)
if isinstance(params, AppListParams):
- permissions = self._access.permissions(context)
params = permissions.filter_list(params)
page = self._apps.list_apps(context, params)
if not page.data:
return page
app_ids = [app.id for app in page.data]
modes = self._access.access_modes(app_ids)
- keys = permissions.keys_for(app_ids) if permissions is not None else {}
+ keys = permissions.keys_for(app_ids)
return replace(
page,
data=[
diff --git a/api/tests/unit_tests/services/app/test_console_service.py b/api/tests/unit_tests/services/app/test_console_service.py
index 94030e89eae..6455fbb61f0 100644
--- a/api/tests/unit_tests/services/app/test_console_service.py
+++ b/api/tests/unit_tests/services/app/test_console_service.py
@@ -296,10 +296,14 @@ def test_empty_list_skips_external_enrichment(ports: Ports) -> None:
def test_starred_list_preserves_existing_visibility_contract(ports: Ports) -> None:
- service, _, access, _, _ = ports
- page = service.list_apps(CONTEXT, StarredAppListParams())
- assert page.data[0].permission_keys == []
- assert access.calls == [("modes", ["app"])]
+ service, apps, access, _, _ = ports
+ params = StarredAppListParams()
+ page = service.list_apps(CONTEXT, params)
+ assert page.data[0].permission_keys == ["app.preview"]
+ assert access.calls == [("permissions", CONTEXT, None), ("modes", ["app"])]
+ # visibility filtering is still skipped for starred lists
+ _, _, listed_params = apps.calls[0]
+ assert listed_params is params
def test_recent_uses_list_visibility_and_permission_keys(ports: Ports) -> None: