Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

test: use SQLite sessions in libs (#39089)

Asuka Minato8629b91517ee
diff --git a/api/tests/unit_tests/libs/test_workspace_member_helper.py b/api/tests/unit_tests/libs/test_workspace_member_helper.py
index f4933e7f594..d7f14b878a9 100644
--- a/api/tests/unit_tests/libs/test_workspace_member_helper.py
+++ b/api/tests/unit_tests/libs/test_workspace_member_helper.py
@@ -1,22 +1,65 @@
-"""Unit tests for require_workspace_member."""
+"""SQLite-backed unit tests for workspace membership enforcement."""
from __future__ import annotations
import uuid
-from unittest.mock import MagicMock, patch
+from collections.abc import Iterator
+from dataclasses import dataclass
+from unittest.mock import Mock
import pytest
+from sqlalchemy import event
+from sqlalchemy.orm import Session
from werkzeug.exceptions import Forbidden
+from libs import oauth_bearer
from libs.oauth_bearer import AuthContext, Scope, SubjectType, TokenType, require_workspace_member
+from models.account import Account, AccountStatus, Tenant, TenantAccountJoin, TenantAccountRole
+pytestmark = pytest.mark.usefixtures("community_edition")
-def _ctx(verified: dict[str, bool] | None = None, *, account: bool = True) -> AuthContext:
+
+@dataclass(frozen=True)
+class Database:
+ """Real ORM binding and executed-statement log for one isolated test."""
+
+ session: Session
+ statements: list[str]
+
+
+def database(sqlite_session: Session, monkeypatch: pytest.MonkeyPatch) -> Iterator[Database]:
+ statements: list[str] = []
+
+ def record_statement(_connection, _cursor, statement, _parameters, _context, _executemany) -> None:
+ statements.append(statement)
+
+ engine = sqlite_session.get_bind()
+ event.listen(engine, "before_cursor_execute", record_statement)
+ binding = Database(session=sqlite_session, statements=statements)
+ monkeypatch.setattr(oauth_bearer, "db", binding)
+ try:
+ yield binding
+ finally:
+ event.remove(engine, "before_cursor_execute", record_statement)
+
+
+def community_edition(monkeypatch: pytest.MonkeyPatch) -> None:
+ monkeypatch.setattr(oauth_bearer.dify_config, "ENTERPRISE_ENABLED", False)
+
+
+def _ctx(
+ verified: dict[str, bool] | None = None,
+ *,
+ account_id: uuid.UUID | None = None,
+ account: bool = True,
+) -> AuthContext:
return AuthContext(
subject_type=SubjectType.ACCOUNT if account else SubjectType.EXTERNAL_SSO,
subject_email="[email protected]",
subject_issuer=None,
- account_id=uuid.uuid4() if account else None,
+ account_id=account_id or (uuid.uuid4() if account else None),
client_id="difyctl",
scopes=frozenset({Scope.FULL}),
token_id=uuid.uuid4(),
@@ -27,68 +70,130 @@ def _ctx(verified: dict[str, bool] | None = None, *, account: bool = True) -> Au
)
-@patch("libs.oauth_bearer.dify_config")
-def test_skips_when_enterprise_enabled(mock_cfg):
- mock_cfg.ENTERPRISE_ENABLED = True
- require_workspace_member(_ctx(), "t1")
+def _persist_membership(
+ session: Session,
+ *,
+ account_id: uuid.UUID,
+ tenant_id: str,
+ status: AccountStatus = AccountStatus.ACTIVE,
+) -> None:
+ account = _account(account_id, status=status)
+ tenant = Tenant(name=f"Tenant {tenant_id}")
+ tenant.id = tenant_id
+ membership = TenantAccountJoin(
+ tenant_id=tenant_id,
+ account_id=account_id.hex,
+ role=TenantAccountRole.NORMAL,
+ )
+ session.add_all([account, tenant, membership])
+ session.commit()
+
+
+def _account(account_id: uuid.UUID, *, status: AccountStatus = AccountStatus.ACTIVE) -> Account:
+ account = Account(name="Workspace member", email=f"{account_id}@example.com", status=status)
+ # SQLite's StringUUID adapter binds UUID objects as compact hex, while
+ # PostgreSQL binds their dashed string form. Persist the SQLite-bound form
+ # so the production query can keep accepting the AuthContext UUID object.
+ account.id = account_id.hex
+ return account
+
+
+def test_skips_when_enterprise_enabled(database: Database, monkeypatch: pytest.MonkeyPatch) -> None:
+ monkeypatch.setattr(oauth_bearer.dify_config, "ENTERPRISE_ENABLED", True)
+ before = len(database.statements)
+
+ require_workspace_member(_ctx(), "tenant-1")
+
+ assert len(database.statements) == before
+
+
+def test_skips_for_external_sso(database: Database) -> None:
+ before = len(database.statements)
+
+ require_workspace_member(_ctx(account=False), "tenant-1")
+ assert len(database.statements) == before
-@patch("libs.oauth_bearer.dify_config")
-def test_skips_for_external_sso(mock_cfg):
- mock_cfg.ENTERPRISE_ENABLED = False
- require_workspace_member(_ctx(account=False), "t1")
+def test_uses_cached_allow_without_database_access(database: Database) -> None:
+ before = len(database.statements)
-@patch("libs.oauth_bearer.db")
-@patch("libs.oauth_bearer.dify_config")
-def test_uses_cached_ok_no_db_access(mock_cfg, mock_db):
- mock_cfg.ENTERPRISE_ENABLED = False
- require_workspace_member(_ctx({"t1": True}), "t1")
- mock_db.session.execute.assert_not_called()
+ require_workspace_member(_ctx({"tenant-1": True}), "tenant-1")
+ assert len(database.statements) == before
+
+
+def test_uses_cached_denial_without_database_access(database: Database) -> None:
+ before = len(database.statements)
-@patch("libs.oauth_bearer.db")
-@patch("libs.oauth_bearer.dify_config")
-def test_uses_cached_denied(mock_cfg, mock_db):
- mock_cfg.ENTERPRISE_ENABLED = False
with pytest.raises(Forbidden, match="workspace_membership_revoked"):
- require_workspace_member(_ctx({"t1": False}), "t1")
- mock_db.session.execute.assert_not_called()
+ require_workspace_member(_ctx({"tenant-1": False}), "tenant-1")
+
+ assert len(database.statements) == before
-@patch("libs.oauth_bearer.record_layer0_verdict")
-@patch("libs.oauth_bearer.db")
-@patch("libs.oauth_bearer.dify_config")
-def test_denies_when_no_membership(mock_cfg, mock_db, mock_record):
- mock_cfg.ENTERPRISE_ENABLED = False
- mock_db.session.execute.return_value.scalar_one_or_none.return_value = None
[email protected]("database")
+def test_denies_when_membership_is_absent(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ record_verdict = Mock()
+ monkeypatch.setattr(oauth_bearer, "record_layer0_verdict", record_verdict)
+
with pytest.raises(Forbidden, match="workspace_membership_revoked"):
- require_workspace_member(_ctx({}), "t1")
- mock_record.assert_called_once_with("h1", "t1", False)
-
-
-@patch("libs.oauth_bearer.record_layer0_verdict")
-@patch("libs.oauth_bearer.db")
-@patch("libs.oauth_bearer.dify_config")
-def test_denies_when_account_inactive(mock_cfg, mock_db, mock_record):
- mock_cfg.ENTERPRISE_ENABLED = False
- mock_db.session.execute.side_effect = [
- MagicMock(scalar_one_or_none=MagicMock(return_value="join-id")),
- MagicMock(scalar_one_or_none=MagicMock(return_value="banned")),
- ]
+ require_workspace_member(_ctx(), "tenant-1")
+
+ record_verdict.assert_called_once_with("h1", "tenant-1", False)
+
+
+def test_denies_membership_from_another_tenant(
+ database: Database,
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ account_id = uuid.uuid4()
+ requested_tenant_member_id = uuid.uuid4()
+ status_decoy_id = uuid.uuid4()
+ _persist_membership(database.session, account_id=account_id, tenant_id="tenant-2")
+ _persist_membership(database.session, account_id=requested_tenant_member_id, tenant_id="tenant-1")
+ database.session.add(_account(status_decoy_id, status=AccountStatus.BANNED))
+ database.session.commit()
+ record_verdict = Mock()
+ monkeypatch.setattr(oauth_bearer, "record_layer0_verdict", record_verdict)
+
with pytest.raises(Forbidden, match="workspace_membership_revoked"):
- require_workspace_member(_ctx({}), "t1")
- mock_record.assert_called_once_with("h1", "t1", False)
-
-
-@patch("libs.oauth_bearer.record_layer0_verdict")
-@patch("libs.oauth_bearer.db")
-@patch("libs.oauth_bearer.dify_config")
-def test_allows_active_member(mock_cfg, mock_db, mock_record):
- mock_cfg.ENTERPRISE_ENABLED = False
- mock_db.session.execute.side_effect = [
- MagicMock(scalar_one_or_none=MagicMock(return_value="join-id")),
- MagicMock(scalar_one_or_none=MagicMock(return_value="active")),
- ]
- require_workspace_member(_ctx({}), "t1")
- mock_record.assert_called_once_with("h1", "t1", True)
+ require_workspace_member(_ctx(account_id=account_id), "tenant-1")
+
+ record_verdict.assert_called_once_with("h1", "tenant-1", False)
+
+
+def test_denies_when_account_is_inactive(
+ database: Database,
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ account_id = uuid.uuid4()
+ _persist_membership(
+ database.session,
+ account_id=account_id,
+ tenant_id="tenant-1",
+ status=AccountStatus.BANNED,
+ )
+ record_verdict = Mock()
+ monkeypatch.setattr(oauth_bearer, "record_layer0_verdict", record_verdict)
+
+ with pytest.raises(Forbidden, match="workspace_membership_revoked"):
+ require_workspace_member(_ctx(account_id=account_id), "tenant-1")
+
+ record_verdict.assert_called_once_with("h1", "tenant-1", False)
+
+
+def test_allows_active_member_and_records_verdict(
+ database: Database,
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
+ account_id = uuid.uuid4()
+ _persist_membership(database.session, account_id=account_id, tenant_id="tenant-1")
+ record_verdict = Mock()
+ monkeypatch.setattr(oauth_bearer, "record_layer0_verdict", record_verdict)
+
+ require_workspace_member(_ctx(account_id=account_id), "tenant-1")
+
+ record_verdict.assert_called_once_with("h1", "tenant-1", True)