Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
refactor(api): enable strict typing for app/service test files (#44816)
Felix Shi876ba3a93ff8
diff --git a/api/tests/unit_tests/core/app/app_config/features/file_upload/test_manager.py b/api/tests/unit_tests/core/app/app_config/features/file_upload/test_manager.pyindex 11b53dd0f97..ef704688897 100644--- a/api/tests/unit_tests/core/app/app_config/features/file_upload/test_manager.py+++ b/api/tests/unit_tests/core/app/app_config/features/file_upload/test_manager.py@@ -3,7 +3,7 @@ from graphon.file import FileTransferMethod, FileUploadConfig, ImageConfigfrom graphon.model_runtime.entities.message_entities import ImagePromptMessageContent-def test_convert_with_vision():+def test_convert_with_vision() -> None:config = {"file_upload": {"enabled": True,@@ -25,7 +25,7 @@ def test_convert_with_vision():assert result == expected-def test_convert_without_vision():+def test_convert_without_vision() -> None:config = {"file_upload": {"enabled": True,@@ -42,14 +42,14 @@ def test_convert_without_vision():assert result == expected-def test_validate_and_set_defaults():+def test_validate_and_set_defaults() -> None:config = {}result, keys = FileUploadConfigManager.validate_and_set_defaults(config)assert "file_upload" in resultassert keys == ["file_upload"]-def test_validate_and_set_defaults_with_existing_config():+def test_validate_and_set_defaults_with_existing_config() -> None:config = {"file_upload": {"enabled": True,diff --git a/api/tests/unit_tests/core/app/apps/chat/test_generate_response_converter.py b/api/tests/unit_tests/core/app/apps/chat/test_generate_response_converter.pyindex 600815645d9..59628439150 100644--- a/api/tests/unit_tests/core/app/apps/chat/test_generate_response_converter.py+++ b/api/tests/unit_tests/core/app/apps/chat/test_generate_response_converter.py@@ -1,6 +1,8 @@from collections.abc import Generator-from core.app.apps.chat.generate_response_converter import ChatAppGenerateResponseConverter+from core.app.apps.chat.generate_response_converter import (+ ChatAppGenerateResponseConverter,+)from core.app.entities.task_entities import (ChatbotAppBlockingResponse,ChatbotAppStreamResponse,@@ -12,7 +14,7 @@ from core.app.entities.task_entities import (class TestChatAppGenerateResponseConverter:- def test_convert_blocking_simple_response_metadata(self):+ def test_convert_blocking_simple_response_metadata(self) -> None:data = ChatbotAppBlockingResponse.Data(id="msg-1",mode="chat",@@ -28,7 +30,7 @@ class TestChatAppGenerateResponseConverter:assert "usage" not in response["metadata"]- def test_convert_stream_responses(self):+ def test_convert_stream_responses(self) -> None:def stream() -> Generator[ChatbotAppStreamResponse]:yield ChatbotAppStreamResponse(conversation_id="c1",@@ -57,9 +59,12 @@ class TestChatAppGenerateResponseConverter:full = list(ChatAppGenerateResponseConverter.convert_stream_full_response(stream()))assert full[0] == "ping"+ assert isinstance(full[1], dict)assert full[1]["event"] == "message"+ assert isinstance(full[2], dict)assert full[2]["event"] == "error"simple = list(ChatAppGenerateResponseConverter.convert_stream_simple_response(stream()))assert simple[0] == "ping"+ assert isinstance(simple[-1], dict)assert simple[-1]["event"] == "message_end"diff --git a/api/tests/unit_tests/core/app/apps/common/test_graph_runtime_state_support.py b/api/tests/unit_tests/core/app/apps/common/test_graph_runtime_state_support.pyindex 74a58b06962..bd2893f6f30 100644--- a/api/tests/unit_tests/core/app/apps/common/test_graph_runtime_state_support.py+++ b/api/tests/unit_tests/core/app/apps/common/test_graph_runtime_state_support.py@@ -1,8 +1,10 @@-from types import SimpleNamespace-import pytest+from core.app.apps.base_app_queue_manager import AppQueueManager, PublishFromfrom core.app.apps.common.graph_runtime_state_support import GraphRuntimeStateSupport+from core.app.entities.app_invoke_entities import ChatAppGenerateEntity+from core.app.entities.queue_entities import AppQueueEvent+from core.app.task_pipeline.based_generate_task_pipeline import BasedGenerateTaskPipelinefrom core.workflow.system_variables import build_system_variablesfrom core.workflow.variable_pool_initializer import add_variables_to_poolfrom graphon.runtime import RuntimeState, VariablePool@@ -14,13 +16,30 @@ def _make_state(workflow_run_id: str | None) -> RuntimeState:return RuntimeState(workflow_id="test-workflow", variable_pool=variable_pool, start_at=0.0)+class _QueueManager(AppQueueManager):+ """Expose a fixed runtime state without Redis or a live task queue."""++ def __init__(self, graph_runtime_state: RuntimeState | None) -> None:+ self.graph_runtime_state = graph_runtime_state++ def _publish(self, event: AppQueueEvent, pub_from: PublishFrom) -> None:+ raise NotImplementedError("The runtime state stub never publishes queue events")+++class _Pipeline(BasedGenerateTaskPipeline[ChatAppGenerateEntity]):+ """Pipeline stand-in carrying the queue manager the mixin reads from."""++ def __init__(self, *, queue_state: RuntimeState | None) -> None:+ self.queue_manager = _QueueManager(queue_state)++class _StubPipeline(GraphRuntimeStateSupport):- def __init__(self, *, cached_state: RuntimeState | None, queue_state: RuntimeState | None):+ def __init__(self, *, cached_state: RuntimeState | None, queue_state: RuntimeState | None) -> None:self._graph_runtime_state = cached_state- self._base_task_pipeline = SimpleNamespace(queue_manager=SimpleNamespace(graph_runtime_state=queue_state))+ self._base_task_pipeline = _Pipeline(queue_state=queue_state)-def test_ensure_graph_runtime_initialized_caches_explicit_state():+def test_ensure_graph_runtime_initialized_caches_explicit_state() -> None:explicit_state = _make_state("run-explicit")pipeline = _StubPipeline(cached_state=None, queue_state=None)@@ -30,7 +49,7 @@ def test_ensure_graph_runtime_initialized_caches_explicit_state():assert pipeline._graph_runtime_state is explicit_state-def test_resolve_graph_runtime_state_reads_from_queue_when_cache_empty():+def test_resolve_graph_runtime_state_reads_from_queue_when_cache_empty() -> None:queued_state = _make_state("run-queue")pipeline = _StubPipeline(cached_state=None, queue_state=queued_state)@@ -40,14 +59,14 @@ def test_resolve_graph_runtime_state_reads_from_queue_when_cache_empty():assert pipeline._graph_runtime_state is queued_state-def test_resolve_graph_runtime_state_raises_when_no_state_available():+def test_resolve_graph_runtime_state_raises_when_no_state_available() -> None:pipeline = _StubPipeline(cached_state=None, queue_state=None)with pytest.raises(ValueError, match="graph runtime state not initialized\\."):pipeline._resolve_graph_runtime_state()-def test_extract_workflow_run_id_returns_value():+def test_extract_workflow_run_id_returns_value() -> None:state = _make_state("run-identifier")pipeline = _StubPipeline(cached_state=state, queue_state=None)@@ -56,7 +75,7 @@ def test_extract_workflow_run_id_returns_value():assert run_id == "run-identifier"-def test_extract_workflow_run_id_raises_when_missing():+def test_extract_workflow_run_id_raises_when_missing() -> None:state = _make_state(None)pipeline = _StubPipeline(cached_state=state, queue_state=None)diff --git a/api/tests/unit_tests/core/app/apps/pipeline/test_pipeline_config_manager.py b/api/tests/unit_tests/core/app/apps/pipeline/test_pipeline_config_manager.pyindex a24aec4cb92..64347ec775a 100644--- a/api/tests/unit_tests/core/app/apps/pipeline/test_pipeline_config_manager.py+++ b/api/tests/unit_tests/core/app/apps/pipeline/test_pipeline_config_manager.py@@ -10,7 +10,7 @@ from models.model import AppModefrom models.workflow import Workflow, WorkflowType-def test_get_pipeline_config(mocker: MockerFixture):+def test_get_pipeline_config(mocker: MockerFixture) -> None:pipeline = Pipeline(tenant_id="tenant", name="Pipeline", description="")pipeline.id = "pipe1"workflow = Workflow.new(@@ -43,7 +43,7 @@ def test_get_pipeline_config(mocker: MockerFixture):assert result.rag_pipeline_variables == ["var1"]-def test_config_validate_filters_related_keys(mocker: MockerFixture):+def test_config_validate_filters_related_keys(mocker: MockerFixture) -> None:config = {"file_upload": {"enabled": True},"tts": {"enabled": True},diff --git a/api/tests/unit_tests/core/app/apps/pipeline/test_pipeline_queue_manager.py b/api/tests/unit_tests/core/app/apps/pipeline/test_pipeline_queue_manager.pyindex bdc6d48e945..2a7376a35a6 100644--- a/api/tests/unit_tests/core/app/apps/pipeline/test_pipeline_queue_manager.py+++ b/api/tests/unit_tests/core/app/apps/pipeline/test_pipeline_queue_manager.py@@ -17,19 +17,22 @@ from core.app.entities.queue_entities import (from graphon.model_runtime.entities.llm_entities import LLMResult-def test_publish_sets_stop_listen_and_raises_on_stopped(mocker: MockerFixture):+def test_publish_sets_stop_listen_and_raises_on_stopped(mocker: MockerFixture) -> None:manager = PipelineQueueManager(task_id="t", user_id="u", invoke_from=InvokeFrom.WEB_APP, app_mode="rag")manager._q = mocker.MagicMock()manager.stop_listen = mocker.MagicMock()manager._is_stopped = mocker.MagicMock(return_value=True)with pytest.raises(GenerateTaskStoppedError):- manager._publish(QueueStopEvent(stopped_by=QueueStopEvent.StopBy.USER_MANUAL), PublishFrom.APPLICATION_MANAGER)+ manager._publish(+ QueueStopEvent(stopped_by=QueueStopEvent.StopBy.USER_MANUAL),+ PublishFrom.APPLICATION_MANAGER,+ )manager.stop_listen.assert_called_once()-def test_publish_stop_events_trigger_stop_listen(mocker: MockerFixture):+def test_publish_stop_events_trigger_stop_listen(mocker: MockerFixture) -> None:manager = PipelineQueueManager(task_id="t", user_id="u", invoke_from=InvokeFrom.WEB_APP, app_mode="rag")manager._q = mocker.MagicMock()manager.stop_listen = mocker.MagicMock()@@ -47,7 +50,7 @@ def test_publish_stop_events_trigger_stop_listen(mocker: MockerFixture):manager.stop_listen.assert_called_once()-def test_publish_non_stop_event_no_stop_listen(mocker: MockerFixture):+def test_publish_non_stop_event_no_stop_listen(mocker: MockerFixture) -> None:manager = PipelineQueueManager(task_id="t", user_id="u", invoke_from=InvokeFrom.WEB_APP, app_mode="rag")manager._q = mocker.MagicMock()manager.stop_listen = mocker.MagicMock()diff --git a/api/tests/unit_tests/core/app/apps/workflow/test_app_config_manager.py b/api/tests/unit_tests/core/app/apps/workflow/test_app_config_manager.pyindex ace1a934d6b..07569ed00c6 100644--- a/api/tests/unit_tests/core/app/apps/workflow/test_app_config_manager.py+++ b/api/tests/unit_tests/core/app/apps/workflow/test_app_config_manager.py@@ -1,3 +1,4 @@+from collections.abc import Callablefrom unittest.mock import patchfrom core.app.apps.workflow.app_config_manager import WorkflowAppConfigManager@@ -15,7 +16,7 @@ def _workflow() -> Workflow:class TestWorkflowAppConfigManager:- def test_get_app_config(self):+ def test_get_app_config(self) -> None:app_model = _app()workflow = _workflow()@@ -34,18 +35,11 @@ class TestWorkflowAppConfigManager:assert app_config.workflow_id == "wf-1"assert app_config.app_mode == AppMode.WORKFLOW- def test_config_validate_filters_keys(self):- def _add_key(key, value):- def _inner[**P](*args: P.args, **kwargs: P.kwargs):+ def test_config_validate_filters_keys(self) -> None:+ def _add_key(key: str, value: object) -> Callable[..., tuple[dict[str, object], list[str]]]:+ def _inner(config: dict[str, object], **_: object) -> tuple[dict[str, object], list[str]]:# Support both positional and keyword arguments for config- if "config" in kwargs:- config = kwargs["config"]- elif len(args) > 0:- config = args[0]- else:- config = {}- config[key] = value- return config, [key]+ return {**config, key: value}, [key]return _innerdiff --git a/api/tests/unit_tests/pyrefly.toml b/api/tests/unit_tests/pyrefly.tomlindex d4a8c53f9cc..3b2bbdfe43d 100644--- a/api/tests/unit_tests/pyrefly.toml+++ b/api/tests/unit_tests/pyrefly.toml@@ -142,7 +142,6 @@ project-excludes = ["core/app/app_config/common/sensitive_word_avoidance/test_manager.py","core/app/app_config/easy_ui_based_app/model_config/test_converter.py","core/app/app_config/easy_ui_based_app/variables/test_manager.py",- "core/app/app_config/features/file_upload/test_manager.py","core/app/app_config/features/suggested_questions_after_answer/test_manager.py","core/app/apps/advanced_chat/test_app_config_manager.py","core/app/apps/advanced_chat/test_app_generator.py",@@ -159,15 +158,11 @@ project-excludes = ["core/app/apps/chat/test_app_config_manager.py","core/app/apps/chat/test_app_generator.py","core/app/apps/test_base_app_runner.py",- "core/app/apps/chat/test_generate_response_converter.py",- "core/app/apps/common/test_graph_runtime_state_support.py","core/app/apps/common/test_workflow_response_converter.py","core/app/apps/completion/test_app_config_manager.py","core/app/apps/completion/test_app_generator.py","core/app/apps/completion/test_generate_response_converter.py",- "core/app/apps/pipeline/test_pipeline_config_manager.py","core/app/apps/pipeline/test_pipeline_generator.py",- "core/app/apps/pipeline/test_pipeline_queue_manager.py","core/app/apps/pipeline/test_pipeline_runner.py","core/app/apps/test_base_app_generator.py","core/app/apps/test_base_app_queue_manager.py",@@ -178,7 +173,6 @@ project-excludes = ["core/app/apps/workflow/test_app_generator.py","core/app/apps/test_workflow_app_runner.py","core/app/apps/workflow/test_active_workflow_tasks.py",- "core/app/apps/workflow/test_app_config_manager.py","core/app/apps/workflow/test_app_queue_manager.py","core/app/apps/workflow/test_command_channels.py","core/app/apps/workflow/test_generate_response_converter.py",@@ -401,15 +395,12 @@ project-excludes = ["services/agent/test_skill_package_service.py","services/agent/test_workflow_publish_service.py","../helpers/unit/services/controller_api.py",- "services/data_migration/test_entities.py","services/data_migration/test_export_service.py","services/data_migration/test_import_service.py",- "services/data_migration/test_package_service.py","../helpers/unit/services/dataset_service_test_helpers.py","../helpers/unit/services/document_service_validation.py","services/enterprise/test_account_deletion_sync.py","services/enterprise/test_plugin_manager_service.py",- "services/enterprise/test_base.py","../helpers/unit/services/hit_service.py","services/plugin/test_plugin_parameter_service.py","services/rag_pipeline/test_pipeline_generate_service.py",@@ -436,7 +427,6 @@ project-excludes = ["services/test_credit_pool_service.py","services/knowledge/test_dataset_service.py","services/data_source/test_provider_service.py",- "services/retention/conversation/test_message_export_service.py","services/knowledge/external/test_service.py","services/test_file_service.py","services/test_human_input_delivery_test_service.py",diff --git a/api/tests/unit_tests/services/data_migration/test_entities.py b/api/tests/unit_tests/services/data_migration/test_entities.pyindex b81b6c38f96..02956cca070 100644--- a/api/tests/unit_tests/services/data_migration/test_entities.py+++ b/api/tests/unit_tests/services/data_migration/test_entities.py@@ -11,7 +11,7 @@ from services.data_migration.entities import ()-def test_import_options_defaults_match_spec():+def test_import_options_defaults_match_spec() -> None:options = ImportOptions()assert options.create_app_api_token_on_import is False@@ -19,12 +19,12 @@ def test_import_options_defaults_match_spec():assert options.conflict_strategy == ConflictStrategy.FAIL-def test_metadata_requires_version():+def test_metadata_requires_version() -> None:with pytest.raises(MigrationDataError, match="metadata.version"):MigrationMetadata.from_mapping({})-def test_metadata_parses_source_tenants_and_import_options():+def test_metadata_parses_source_tenants_and_import_options() -> None:metadata = MigrationMetadata.from_mapping({"version": "1",@@ -44,7 +44,7 @@ def test_metadata_parses_source_tenants_and_import_options():assert metadata.import_options.id_strategy == IdStrategy.PRESERVE_ID-def test_import_options_invalid_strategy_raises_domain_error():+def test_import_options_invalid_strategy_raises_domain_error() -> None:with pytest.raises(MigrationDataError, match="id_strategy"):ImportOptions.from_mapping({"id_strategy": "unknown"})@@ -58,12 +58,12 @@ def test_import_options_invalid_strategy_raises_domain_error():ImportOptions.from_mapping({"conflict_strategy": "replace"})-def test_metadata_rejects_invalid_target_tenant_shape():+def test_metadata_rejects_invalid_target_tenant_shape() -> None:with pytest.raises(MigrationDataError, match="target_tenant"):MigrationMetadata.from_mapping({"version": "1", "target_tenant": "prod"})-def test_migration_package_sections_must_be_lists_of_objects():+def test_migration_package_sections_must_be_lists_of_objects() -> None:with pytest.raises(MigrationDataError, match="workflows"):MigrationPackage.from_mapping({"metadata": {"version": "1"}, "workflows": {"id": "app-1"}})diff --git a/api/tests/unit_tests/services/data_migration/test_package_service.py b/api/tests/unit_tests/services/data_migration/test_package_service.pyindex 3e85fff1ec0..e9963fac994 100644--- a/api/tests/unit_tests/services/data_migration/test_package_service.py+++ b/api/tests/unit_tests/services/data_migration/test_package_service.py@@ -7,7 +7,7 @@ from services.data_migration.entities import MigrationDataErrorfrom services.data_migration.package_service import MigrationPackageService-def test_load_package_rejects_branch_draft_shape(tmp_path: Path):+def test_load_package_rejects_branch_draft_shape(tmp_path: Path) -> None:package_file = tmp_path / "draft.json"package_file.write_text(json.dumps({"workflows": [], "tools": []}), encoding="utf-8")@@ -15,15 +15,18 @@ def test_load_package_rejects_branch_draft_shape(tmp_path: Path):MigrationPackageService().load_package(package_file)-def test_load_package_rejects_unsupported_version(tmp_path: Path):+def test_load_package_rejects_unsupported_version(tmp_path: Path) -> None:package_file = tmp_path / "future.json"- package_file.write_text(json.dumps({"metadata": {"version": "999", "source_scope": "single"}}), encoding="utf-8")+ package_file.write_text(+ json.dumps({"metadata": {"version": "999", "source_scope": "single"}}),+ encoding="utf-8",+ )with pytest.raises(MigrationDataError, match="Unsupported migration package version"):MigrationPackageService().load_package(package_file)-def test_save_package_writes_versioned_shape(tmp_path: Path):+def test_save_package_writes_versioned_shape(tmp_path: Path) -> None:output_file = tmp_path / "migration-data.json"package = MigrationPackageService().build_empty_package(source_tenant_id="tenant-1",@@ -41,7 +44,7 @@ def test_save_package_writes_versioned_shape(tmp_path: Path):assert data["dependencies"] == []-def test_save_package_without_overwrite_fails_when_file_exists(tmp_path: Path):+def test_save_package_without_overwrite_fails_when_file_exists(tmp_path: Path) -> None:output_file = tmp_path / "migration-data.json"output_file.write_text("{}", encoding="utf-8")package = MigrationPackageService().build_empty_package(diff --git a/api/tests/unit_tests/services/enterprise/test_base.py b/api/tests/unit_tests/services/enterprise/test_base.pyindex a98a9e97e2a..76348705578 100644--- a/api/tests/unit_tests/services/enterprise/test_base.py+++ b/api/tests/unit_tests/services/enterprise/test_base.py@@ -4,6 +4,7 @@ This test module verifies that the W3C traceparent header is properlygenerated and included in HTTP requests made by EnterpriseRequest."""+from collections.abc import Iteratorfrom unittest.mock import MagicMock, patchimport pytest@@ -15,7 +16,7 @@ class TestTraceparentPropagation:"""Unit tests for traceparent header propagation."""@pytest.fixture- def mock_enterprise_config(self):+ def mock_enterprise_config(self) -> Iterator[None]:"""Mock EnterpriseRequest configuration."""with (patch.object(EnterpriseRequest, "base_url", "https://enterprise-api.example.com"),@@ -25,7 +26,7 @@ class TestTraceparentPropagation:yield@pytest.fixture- def mock_httpx_client(self):+ def mock_httpx_client(self) -> Iterator[MagicMock]:"""Mock httpx.Client for testing."""with patch("services.enterprise.base.httpx.Client", autospec=True) as mock_client_class:mock_client = MagicMock()@@ -39,13 +40,17 @@ class TestTraceparentPropagation:yield mock_client- def test_traceparent_header_included_when_generated(self, mock_enterprise_config, mock_httpx_client):+ def test_traceparent_header_included_when_generated(+ self, mock_enterprise_config: None, mock_httpx_client: MagicMock+ ) -> None:"""Test that traceparent header is included when successfully generated."""# Arrangeexpected_traceparent = "00-5b8aa5a2d2c872e8321cf37308d69df2-051581bf3bb55c45-01"with patch(- "services.enterprise.base.generate_traceparent_header", return_value=expected_traceparent, autospec=True+ "services.enterprise.base.generate_traceparent_header",+ return_value=expected_traceparent,+ autospec=True,):# ActEnterpriseRequest.send_request("GET", "/test")diff --git a/api/tests/unit_tests/services/retention/conversation/test_message_export_service.py b/api/tests/unit_tests/services/retention/conversation/test_message_export_service.pyindex d409d3dd25f..4666e012569 100644--- a/api/tests/unit_tests/services/retention/conversation/test_message_export_service.py+++ b/api/tests/unit_tests/services/retention/conversation/test_message_export_service.py@@ -2,10 +2,12 @@ import datetimeimport pytest-from services.retention.conversation.message_export_service import AppMessageExportService+from services.retention.conversation.message_export_service import (+ AppMessageExportService,+)-def test_validate_export_filename_accepts_relative_path():+def test_validate_export_filename_accepts_relative_path() -> None:assert AppMessageExportService.validate_export_filename("exports/2026/test01") == "exports/2026/test01"@@ -22,7 +24,7 @@ def test_validate_export_filename_accepts_relative_path():"a" * 1025,],)-def test_validate_export_filename_rejects_invalid_values(filename: str):+def test_validate_export_filename_rejects_invalid_values(filename: str) -> None:with pytest.raises(ValueError,match=(@@ -37,7 +39,7 @@ def test_validate_export_filename_rejects_invalid_values(filename: str):AppMessageExportService.validate_export_filename(filename)-def test_service_derives_output_names_from_filename_base():+def test_service_derives_output_names_from_filename_base() -> None:service = AppMessageExportService(app_id="736b9b03-20f2-4697-91da-8d00f6325900",start_from=None,