Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(web): close agent slash menu on immediate focus exit (#42867)

yyh8778c6b985d5
diff --git a/web/features/agent-v2/agent-detail/configure/components/__tests__/agent-prompt-editor.spec.tsx b/web/features/agent-v2/agent-detail/configure/components/__tests__/agent-prompt-editor.spec.tsx
index cef864631d8..70f8212c43c 100644
--- a/web/features/agent-v2/agent-detail/configure/components/__tests__/agent-prompt-editor.spec.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/__tests__/agent-prompt-editor.spec.tsx
@@ -1209,12 +1209,17 @@ describe('AgentPromptEditor', () => {
try {
renderAgentPromptEditor('Review /')
- await openSlashMenuFromEditor()
+ const textbox = screen.getByRole('textbox')
+ textbox.focus()
+ expect(textbox).toHaveFocus()
+
+ await openSlashMenuFromEditor(textbox)
expect(
screen.getByRole('button', { name: /agentDetail\.configure\.skills\.label/i }),
).toBeInTheDocument()
- fireEvent.focusIn(outsideButton)
+ outsideButton.focus()
+ expect(outsideButton).toHaveFocus()
await waitFor(() => {
expect(
diff --git a/web/features/agent-v2/agent-detail/configure/components/orchestrate/prompt-editor/index.tsx b/web/features/agent-v2/agent-detail/configure/components/orchestrate/prompt-editor/index.tsx
index 133418c4501..3c9b8715894 100644
--- a/web/features/agent-v2/agent-detail/configure/components/orchestrate/prompt-editor/index.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/orchestrate/prompt-editor/index.tsx
@@ -849,7 +849,7 @@ export function AgentPromptEditor() {
[configuredReferenceIds, t, tools],
)
- useEffect(() => {
+ useLayoutEffect(() => {
if (!isSlashMenuOpen) return
const rootElement = positioningRootRef.current