Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

refactor(api): enable strict typing for tool/retrieval test files (#44822)

Felix Shi88450956962d
diff --git a/api/tests/unit_tests/core/plugin/impl/test_tool.py b/api/tests/unit_tests/core/plugin/impl/test_tool.py
index 3ae3cc18e4b..dbb3f13278e 100644
--- a/api/tests/unit_tests/core/plugin/impl/test_tool.py
+++ b/api/tests/unit_tests/core/plugin/impl/test_tool.py
@@ -1,3 +1,4 @@
+from collections.abc import Callable
from types import SimpleNamespace
from pytest_mock import MockerFixture
@@ -17,14 +18,19 @@ def _tool_provider(name: str = "provider") -> SimpleNamespace:
class TestPluginToolManager:
- def test_fetch_tool_providers(self, mocker: MockerFixture):
+ def test_fetch_tool_providers(self, mocker: MockerFixture) -> None:
manager = PluginToolManager()
provider = _tool_provider("remote")
mocker.patch("core.plugin.impl.tool.resolve_dify_schema_refs", return_value={"resolved": True})
- def fake_request(method, path, type_, **kwargs):
- transformer = kwargs["transformer"]
- payload = {
+ def fake_request(
+ method: str,
+ path: str,
+ type_: object,
+ transformer: Callable[[dict[str, object]], dict[str, object]],
+ **kwargs: object,
+ ) -> list[SimpleNamespace]:
+ payload: dict[str, object] = {
"data": [
{
"declaration": {
@@ -35,7 +41,13 @@ class TestPluginToolManager:
]
}
transformed = transformer(payload)
- assert transformed["data"][0]["declaration"]["tools"][0]["output_schema"] == {"resolved": True}
+ data = transformed["data"]
+ assert isinstance(data, list)
+ declaration = data[0]["declaration"]
+ assert isinstance(declaration, dict)
+ tools = declaration["tools"]
+ assert isinstance(tools, list)
+ assert tools[0]["output_schema"] == {"resolved": True}
return [provider]
request_mock = mocker.patch.object(manager, "_request_with_plugin_daemon_response", side_effect=fake_request)
@@ -46,20 +58,31 @@ class TestPluginToolManager:
assert result[0].declaration.identity.name == "org/plugin/remote"
assert result[0].declaration.tools[0].identity.provider == "org/plugin/remote"
- def test_fetch_tool_provider(self, mocker: MockerFixture):
+ def test_fetch_tool_provider(self, mocker: MockerFixture) -> None:
manager = PluginToolManager()
provider = _tool_provider("provider")
mocker.patch("core.plugin.impl.tool.resolve_dify_schema_refs", return_value={"resolved": True})
- def fake_request(method, path, type_, **kwargs):
- transformer = kwargs["transformer"]
- payload = {
+ def fake_request(
+ method: str,
+ path: str,
+ type_: object,
+ transformer: Callable[[dict[str, object]], dict[str, object]],
+ **kwargs: object,
+ ) -> SimpleNamespace:
+ payload: dict[str, object] = {
"data": {
"declaration": {"tools": [{"identity": {"provider": "old"}, "output_schema": {"$ref": "#/x"}}]}
}
}
transformed = transformer(payload)
- assert transformed["data"]["declaration"]["tools"][0]["output_schema"] == {"resolved": True}
+ data = transformed["data"]
+ assert isinstance(data, dict)
+ declaration = data["declaration"]
+ assert isinstance(declaration, dict)
+ tools = declaration["tools"]
+ assert isinstance(tools, list)
+ assert tools[0]["output_schema"] == {"resolved": True}
return provider
request_mock = mocker.patch.object(manager, "_request_with_plugin_daemon_response", side_effect=fake_request)
@@ -70,7 +93,7 @@ class TestPluginToolManager:
assert result.declaration.identity.name == "org/plugin/provider"
assert result.declaration.tools[0].identity.provider == "org/plugin/provider"
- def test_invoke_merges_chunks(self, mocker: MockerFixture):
+ def test_invoke_merges_chunks(self, mocker: MockerFixture) -> None:
manager = PluginToolManager()
stream_mock = mocker.patch.object(
manager, "_request_with_plugin_daemon_response_stream", return_value=iter(["chunk"])
@@ -94,7 +117,7 @@ class TestPluginToolManager:
assert merge_mock.call_count == 1
assert stream_mock.call_args.kwargs["headers"]["X-Plugin-ID"] == "org/plugin"
- def test_validate_credentials_paths(self, mocker: MockerFixture):
+ def test_validate_credentials_paths(self, mocker: MockerFixture) -> None:
manager = PluginToolManager()
stream_mock = mocker.patch.object(manager, "_request_with_plugin_daemon_response_stream")
@@ -110,7 +133,7 @@ class TestPluginToolManager:
stream_mock.return_value = iter([])
assert manager.validate_datasource_credentials("tenant-1", "user-1", "org/plugin/provider", {"k": "v"}) is False
- def test_get_runtime_parameters_paths(self, mocker: MockerFixture):
+ def test_get_runtime_parameters_paths(self, mocker: MockerFixture) -> None:
manager = PluginToolManager()
stream_mock = mocker.patch.object(manager, "_request_with_plugin_daemon_response_stream")
diff --git a/api/tests/unit_tests/pyrefly.toml b/api/tests/unit_tests/pyrefly.toml
index fa892553724..f2af3fdc2b9 100644
--- a/api/tests/unit_tests/pyrefly.toml
+++ b/api/tests/unit_tests/pyrefly.toml
@@ -242,7 +242,6 @@ project-excludes = [
"core/plugin/impl/test_exc.py",
"core/plugin/impl/test_model.py",
"core/plugin/impl/test_oauth.py",
- "core/plugin/impl/test_tool.py",
"core/plugin/impl/test_trigger.py",
"core/plugin/backwards_invocation/test_app.py",
"core/plugin/backwards_invocation/test_model.py",
@@ -290,7 +289,6 @@ project-excludes = [
"core/tools/builtin_tool/test_provider.py",
"core/tools/builtin_tool/providers/time/tools/test_localtime_to_timestamp.py",
"core/tools/custom_tool/test_tool.py",
- "core/tools/custom_tool/test_provider.py",
"core/tools/utils/test_dataset_retriever_tool.py",
"core/tools/mcp_tool/test_tool.py",
"core/tools/mcp_tool/test_provider.py",
@@ -430,7 +428,6 @@ project-excludes = [
"../helpers/unit/services/hit_service.py",
"services/plugin/test_plugin_parameter_service.py",
"services/errors/test_plugin.py",
- "services/rag_pipeline/pipeline_template/built_in/test_built_in_retrieval.py",
"services/rag_pipeline/pipeline_template/test_pipeline_template_base.py",
"services/rag_pipeline/test_pipeline_generate_service.py",
"services/rag_pipeline/test_rag_pipeline_dsl_service.py",
diff --git a/api/tests/unit_tests/services/rag_pipeline/pipeline_template/built_in/test_built_in_retrieval.py b/api/tests/unit_tests/services/rag_pipeline/pipeline_template/built_in/test_built_in_retrieval.py
index 9ea47c0a141..a4aed538fcb 100644
--- a/api/tests/unit_tests/services/rag_pipeline/pipeline_template/built_in/test_built_in_retrieval.py
+++ b/api/tests/unit_tests/services/rag_pipeline/pipeline_template/built_in/test_built_in_retrieval.py
@@ -99,7 +99,7 @@ def test_get_builtin_data_reads_from_file_and_caches(mocker: MockerFixture) -> N
mock_app,
)
- test_data = {"pipeline_templates": {"en-US": {"templates": []}}}
+ test_data: dict[str, object] = {"pipeline_templates": {"en-US": {"templates": list[object]()}}}
mocker.patch(
"services.rag_pipeline.pipeline_template.built_in.built_in_retrieval.Path.read_text",
return_value=json.dumps(test_data),
@@ -115,7 +115,7 @@ def test_get_builtin_data_reads_from_file_and_caches(mocker: MockerFixture) -> N
def test_get_builtin_data_returns_cache_on_second_call(mocker: MockerFixture) -> None:
- cached_data = {"pipeline_templates": {"en-US": {}}}
+ cached_data: dict[str, object] = {"pipeline_templates": {"en-US": {}}}
BuiltInPipelineTemplateRetrieval.builtin_data = cached_data
result = BuiltInPipelineTemplateRetrieval._get_builtin_data()