Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

test: construct real datasource plugin and message fixtures (#43149)

Asuka Minato8db1712ccd8e
diff --git a/api/tests/unit_tests/core/datasource/local_file/test_local_file_plugin.py b/api/tests/unit_tests/core/datasource/local_file/test_local_file_plugin.py
index 5bf7362a8a2..374b7b9cd31 100644
--- a/api/tests/unit_tests/core/datasource/local_file/test_local_file_plugin.py
+++ b/api/tests/unit_tests/core/datasource/local_file/test_local_file_plugin.py
@@ -1,26 +1,24 @@
-from unittest.mock import MagicMock
-
from core.datasource.__base.datasource_runtime import DatasourceRuntime
from core.datasource.entities.datasource_entities import (
- DatasourceEntity,
DatasourceProviderType,
)
from core.datasource.local_file.local_file_plugin import LocalFileDatasourcePlugin
+from tests.unit_tests.core.datasource.factories import datasource_entity
class TestLocalFileDatasourcePlugin:
def test_init(self):
# Arrange
- mock_entity = MagicMock(spec=DatasourceEntity)
- mock_runtime = MagicMock(spec=DatasourceRuntime)
+ entity = datasource_entity("test_name")
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
tenant_id = "test-tenant-id"
icon = "test-icon"
plugin_unique_identifier = "test-plugin-id"
# Act
plugin = LocalFileDatasourcePlugin(
- entity=mock_entity,
- runtime=mock_runtime,
+ entity=entity,
+ runtime=runtime,
tenant_id=tenant_id,
icon=icon,
plugin_unique_identifier=plugin_unique_identifier,
@@ -29,16 +27,16 @@ class TestLocalFileDatasourcePlugin:
# Assert
assert plugin.tenant_id == tenant_id
assert plugin.plugin_unique_identifier == plugin_unique_identifier
- assert plugin.entity == mock_entity
- assert plugin.runtime == mock_runtime
+ assert plugin.entity == entity
+ assert plugin.runtime == runtime
assert plugin.icon == icon
def test_datasource_provider_type(self):
# Arrange
- mock_entity = MagicMock(spec=DatasourceEntity)
- mock_runtime = MagicMock(spec=DatasourceRuntime)
+ entity = datasource_entity("test_name")
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
plugin = LocalFileDatasourcePlugin(
- entity=mock_entity, runtime=mock_runtime, tenant_id="test", icon="test", plugin_unique_identifier="test"
+ entity=entity, runtime=runtime, tenant_id="test", icon="test", plugin_unique_identifier="test"
)
# Act & Assert
@@ -46,11 +44,11 @@ class TestLocalFileDatasourcePlugin:
def test_get_icon_url(self):
# Arrange
- mock_entity = MagicMock(spec=DatasourceEntity)
- mock_runtime = MagicMock(spec=DatasourceRuntime)
+ entity = datasource_entity("test_name")
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
icon = "test-icon"
plugin = LocalFileDatasourcePlugin(
- entity=mock_entity, runtime=mock_runtime, tenant_id="test", icon=icon, plugin_unique_identifier="test"
+ entity=entity, runtime=runtime, tenant_id="test", icon=icon, plugin_unique_identifier="test"
)
# Act & Assert
diff --git a/api/tests/unit_tests/core/datasource/online_document/test_online_document_plugin.py b/api/tests/unit_tests/core/datasource/online_document/test_online_document_plugin.py
index e3a217725ac..84160355297 100644
--- a/api/tests/unit_tests/core/datasource/online_document/test_online_document_plugin.py
+++ b/api/tests/unit_tests/core/datasource/online_document/test_online_document_plugin.py
@@ -2,19 +2,18 @@ from unittest.mock import MagicMock, patch
from core.datasource.__base.datasource_runtime import DatasourceRuntime
from core.datasource.entities.datasource_entities import (
- DatasourceEntity,
- DatasourceIdentity,
DatasourceProviderType,
GetOnlineDocumentPageContentRequest,
)
from core.datasource.online_document.online_document_plugin import OnlineDocumentDatasourcePlugin
+from tests.unit_tests.core.datasource.factories import datasource_entity
class TestOnlineDocumentDatasourcePlugin:
def test_init(self):
# Arrange
- entity = MagicMock(spec=DatasourceEntity)
- runtime = MagicMock(spec=DatasourceRuntime)
+ entity = datasource_entity("test_name")
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
tenant_id = "test_tenant"
icon = "test_icon"
plugin_unique_identifier = "test_plugin_id"
@@ -37,13 +36,10 @@ class TestOnlineDocumentDatasourcePlugin:
def test_get_online_document_pages(self):
# Arrange
- entity = MagicMock(spec=DatasourceEntity)
- identity = MagicMock(spec=DatasourceIdentity)
- entity.identity = identity
- identity.provider = "test_provider"
- identity.name = "test_name"
+ entity = datasource_entity("test_name")
+ entity.identity.provider = "test_provider"
- runtime = MagicMock(spec=DatasourceRuntime)
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
runtime.credentials = {"api_key": "test_key"}
tenant_id = "test_tenant"
@@ -88,13 +84,10 @@ class TestOnlineDocumentDatasourcePlugin:
def test_get_online_document_page_content(self):
# Arrange
- entity = MagicMock(spec=DatasourceEntity)
- identity = MagicMock(spec=DatasourceIdentity)
- entity.identity = identity
- identity.provider = "test_provider"
- identity.name = "test_name"
+ entity = datasource_entity("test_name")
+ entity.identity.provider = "test_provider"
- runtime = MagicMock(spec=DatasourceRuntime)
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
runtime.credentials = {"api_key": "test_key"}
tenant_id = "test_tenant"
@@ -110,7 +103,9 @@ class TestOnlineDocumentDatasourcePlugin:
)
user_id = "test_user"
- datasource_parameters = MagicMock(spec=GetOnlineDocumentPageContentRequest)
+ datasource_parameters = GetOnlineDocumentPageContentRequest(
+ workspace_id="workspace-1", page_id="page-1", type="page"
+ )
provider_type = "test_type"
mock_generator = MagicMock()
@@ -138,8 +133,8 @@ class TestOnlineDocumentDatasourcePlugin:
def test_datasource_provider_type(self):
# Arrange
- entity = MagicMock(spec=DatasourceEntity)
- runtime = MagicMock(spec=DatasourceRuntime)
+ entity = datasource_entity("test_name")
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
plugin = OnlineDocumentDatasourcePlugin(
entity=entity, runtime=runtime, tenant_id="test", icon="test", plugin_unique_identifier="test"
)
diff --git a/api/tests/unit_tests/core/datasource/online_document/test_online_document_provider.py b/api/tests/unit_tests/core/datasource/online_document/test_online_document_provider.py
index cfdd05e0b2e..1a110dd70fd 100644
--- a/api/tests/unit_tests/core/datasource/online_document/test_online_document_provider.py
+++ b/api/tests/unit_tests/core/datasource/online_document/test_online_document_provider.py
@@ -1,43 +1,40 @@
-from unittest.mock import MagicMock
-
import pytest
from core.datasource.entities.datasource_entities import (
- DatasourceEntity,
- DatasourceProviderEntityWithPlugin,
DatasourceProviderType,
)
from core.datasource.online_document.online_document_plugin import OnlineDocumentDatasourcePlugin
from core.datasource.online_document.online_document_provider import OnlineDocumentDatasourcePluginProviderController
+from tests.unit_tests.core.datasource.factories import datasource_entity, provider_entity
class TestOnlineDocumentDatasourcePluginProviderController:
def test_init(self):
# Arrange
- mock_entity = MagicMock(spec=DatasourceProviderEntityWithPlugin)
+ entity = provider_entity(DatasourceProviderType.ONLINE_DOCUMENT)
plugin_id = "test_plugin_id"
plugin_unique_identifier = "test_plugin_uid"
tenant_id = "test_tenant_id"
# Act
controller = OnlineDocumentDatasourcePluginProviderController(
- entity=mock_entity,
+ entity=entity,
plugin_id=plugin_id,
plugin_unique_identifier=plugin_unique_identifier,
tenant_id=tenant_id,
)
# Assert
- assert controller.entity == mock_entity
+ assert controller.entity == entity
assert controller.plugin_id == plugin_id
assert controller.plugin_unique_identifier == plugin_unique_identifier
assert controller.tenant_id == tenant_id
def test_provider_type(self):
# Arrange
- mock_entity = MagicMock(spec=DatasourceProviderEntityWithPlugin)
+ entity = provider_entity(DatasourceProviderType.ONLINE_DOCUMENT)
controller = OnlineDocumentDatasourcePluginProviderController(
- entity=mock_entity, plugin_id="test", plugin_unique_identifier="test", tenant_id="test"
+ entity=entity, plugin_id="test", plugin_unique_identifier="test", tenant_id="test"
)
# Assert
@@ -45,22 +42,17 @@ class TestOnlineDocumentDatasourcePluginProviderController:
def test_get_datasource_success(self):
# Arrange
- from core.datasource.entities.datasource_entities import DatasourceIdentity
-
- mock_datasource_entity = MagicMock(spec=DatasourceEntity)
- mock_datasource_entity.identity = MagicMock(spec=DatasourceIdentity)
- mock_datasource_entity.identity.name = "target_datasource"
+ source = datasource_entity("target_datasource")
- mock_entity = MagicMock(spec=DatasourceProviderEntityWithPlugin)
- mock_entity.datasources = [mock_datasource_entity]
- mock_entity.identity = MagicMock()
- mock_entity.identity.icon = "test_icon"
+ entity = provider_entity(DatasourceProviderType.ONLINE_DOCUMENT)
+ entity.datasources = [source]
+ entity.identity.icon = "test_icon"
plugin_unique_identifier = "test_plugin_uid"
tenant_id = "test_tenant_id"
controller = OnlineDocumentDatasourcePluginProviderController(
- entity=mock_entity,
+ entity=entity,
plugin_id="test_plugin_id",
plugin_unique_identifier=plugin_unique_identifier,
tenant_id=tenant_id,
@@ -71,7 +63,7 @@ class TestOnlineDocumentDatasourcePluginProviderController:
# Assert
assert isinstance(result, OnlineDocumentDatasourcePlugin)
- assert result.entity == mock_datasource_entity
+ assert result.entity == source
assert result.tenant_id == tenant_id
assert result.icon == "test_icon"
assert result.plugin_unique_identifier == plugin_unique_identifier
@@ -79,17 +71,13 @@ class TestOnlineDocumentDatasourcePluginProviderController:
def test_get_datasource_not_found(self):
# Arrange
- from core.datasource.entities.datasource_entities import DatasourceIdentity
-
- mock_datasource_entity = MagicMock(spec=DatasourceEntity)
- mock_datasource_entity.identity = MagicMock(spec=DatasourceIdentity)
- mock_datasource_entity.identity.name = "other_datasource"
+ source = datasource_entity("other_datasource")
- mock_entity = MagicMock(spec=DatasourceProviderEntityWithPlugin)
- mock_entity.datasources = [mock_datasource_entity]
+ entity = provider_entity(DatasourceProviderType.ONLINE_DOCUMENT)
+ entity.datasources = [source]
controller = OnlineDocumentDatasourcePluginProviderController(
- entity=mock_entity,
+ entity=entity,
plugin_id="test_plugin_id",
plugin_unique_identifier="test_plugin_uid",
tenant_id="test_tenant_id",
diff --git a/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_plugin.py b/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_plugin.py
index 6c8b644871c..59f6e8a29b8 100644
--- a/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_plugin.py
+++ b/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_plugin.py
@@ -2,20 +2,19 @@ from unittest.mock import MagicMock, patch
from core.datasource.__base.datasource_runtime import DatasourceRuntime
from core.datasource.entities.datasource_entities import (
- DatasourceEntity,
- DatasourceIdentity,
DatasourceProviderType,
OnlineDriveBrowseFilesRequest,
OnlineDriveDownloadFileRequest,
)
from core.datasource.online_drive.online_drive_plugin import OnlineDriveDatasourcePlugin
+from tests.unit_tests.core.datasource.factories import datasource_entity
class TestOnlineDriveDatasourcePlugin:
def test_init(self):
# Arrange
- entity = MagicMock(spec=DatasourceEntity)
- runtime = MagicMock(spec=DatasourceRuntime)
+ entity = datasource_entity("test_name")
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
tenant_id = "test_tenant"
icon = "test_icon"
plugin_unique_identifier = "test_plugin_id"
@@ -38,13 +37,10 @@ class TestOnlineDriveDatasourcePlugin:
def test_online_drive_browse_files(self):
# Arrange
- entity = MagicMock(spec=DatasourceEntity)
- identity = MagicMock(spec=DatasourceIdentity)
- entity.identity = identity
- identity.provider = "test_provider"
- identity.name = "test_name"
+ entity = datasource_entity("test_name")
+ entity.identity.provider = "test_provider"
- runtime = MagicMock(spec=DatasourceRuntime)
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
runtime.credentials = {"token": "test_token"}
tenant_id = "test_tenant"
@@ -60,7 +56,7 @@ class TestOnlineDriveDatasourcePlugin:
)
user_id = "test_user"
- request = MagicMock(spec=OnlineDriveBrowseFilesRequest)
+ request = OnlineDriveBrowseFilesRequest(prefix="folder-1")
provider_type = "test_type"
mock_generator = MagicMock()
@@ -86,13 +82,10 @@ class TestOnlineDriveDatasourcePlugin:
def test_online_drive_download_file(self):
# Arrange
- entity = MagicMock(spec=DatasourceEntity)
- identity = MagicMock(spec=DatasourceIdentity)
- entity.identity = identity
- identity.provider = "test_provider"
- identity.name = "test_name"
+ entity = datasource_entity("test_name")
+ entity.identity.provider = "test_provider"
- runtime = MagicMock(spec=DatasourceRuntime)
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
runtime.credentials = {"token": "test_token"}
tenant_id = "test_tenant"
@@ -108,7 +101,7 @@ class TestOnlineDriveDatasourcePlugin:
)
user_id = "test_user"
- request = MagicMock(spec=OnlineDriveDownloadFileRequest)
+ request = OnlineDriveDownloadFileRequest(id="file-1")
provider_type = "test_type"
mock_generator = MagicMock()
@@ -134,8 +127,8 @@ class TestOnlineDriveDatasourcePlugin:
def test_datasource_provider_type(self):
# Arrange
- entity = MagicMock(spec=DatasourceEntity)
- runtime = MagicMock(spec=DatasourceRuntime)
+ entity = datasource_entity("test_name")
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
plugin = OnlineDriveDatasourcePlugin(
entity=entity, runtime=runtime, tenant_id="test", icon="test", plugin_unique_identifier="test"
)
diff --git a/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_provider.py b/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_provider.py
index 2824ddd8ed1..480dd13e575 100644
--- a/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_provider.py
+++ b/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_provider.py
@@ -1,39 +1,38 @@
-from unittest.mock import MagicMock
-
import pytest
-from core.datasource.entities.datasource_entities import DatasourceProviderEntityWithPlugin, DatasourceProviderType
+from core.datasource.entities.datasource_entities import DatasourceProviderType
from core.datasource.online_drive.online_drive_plugin import OnlineDriveDatasourcePlugin
from core.datasource.online_drive.online_drive_provider import OnlineDriveDatasourcePluginProviderController
+from tests.unit_tests.core.datasource.factories import datasource_entity, provider_entity
class TestOnlineDriveDatasourcePluginProviderController:
def test_init(self):
# Arrange
- mock_entity = MagicMock(spec=DatasourceProviderEntityWithPlugin)
+ entity = provider_entity(DatasourceProviderType.ONLINE_DRIVE)
plugin_id = "test_plugin_id"
plugin_unique_identifier = "test_plugin_unique_identifier"
tenant_id = "test_tenant_id"
# Act
controller = OnlineDriveDatasourcePluginProviderController(
- entity=mock_entity,
+ entity=entity,
plugin_id=plugin_id,
plugin_unique_identifier=plugin_unique_identifier,
tenant_id=tenant_id,
)
# Assert
- assert controller.entity == mock_entity
+ assert controller.entity == entity
assert controller.plugin_id == plugin_id
assert controller.plugin_unique_identifier == plugin_unique_identifier
assert controller.tenant_id == tenant_id
def test_provider_type(self):
# Arrange
- mock_entity = MagicMock(spec=DatasourceProviderEntityWithPlugin)
+ entity = provider_entity(DatasourceProviderType.ONLINE_DRIVE)
controller = OnlineDriveDatasourcePluginProviderController(
- entity=mock_entity, plugin_id="id", plugin_unique_identifier="unique_id", tenant_id="tenant"
+ entity=entity, plugin_id="id", plugin_unique_identifier="unique_id", tenant_id="tenant"
)
# Act & Assert
@@ -41,18 +40,17 @@ class TestOnlineDriveDatasourcePluginProviderController:
def test_get_datasource_success(self):
# Arrange
- mock_datasource_entity = MagicMock()
- mock_datasource_entity.identity.name = "test_datasource"
+ source = datasource_entity("test_datasource")
- mock_entity = MagicMock()
- mock_entity.datasources = [mock_datasource_entity]
- mock_entity.identity.icon = "test_icon"
+ entity = provider_entity(DatasourceProviderType.ONLINE_DRIVE)
+ entity.datasources = [source]
+ entity.identity.icon = "test_icon"
plugin_unique_identifier = "test_plugin_unique_identifier"
tenant_id = "test_tenant_id"
controller = OnlineDriveDatasourcePluginProviderController(
- entity=mock_entity, plugin_id="id", plugin_unique_identifier=plugin_unique_identifier, tenant_id=tenant_id
+ entity=entity, plugin_id="id", plugin_unique_identifier=plugin_unique_identifier, tenant_id=tenant_id
)
# Act
@@ -60,7 +58,7 @@ class TestOnlineDriveDatasourcePluginProviderController:
# Assert
assert isinstance(datasource, OnlineDriveDatasourcePlugin)
- assert datasource.entity == mock_datasource_entity
+ assert datasource.entity == source
assert datasource.tenant_id == tenant_id
assert datasource.icon == "test_icon"
assert datasource.plugin_unique_identifier == plugin_unique_identifier
@@ -68,14 +66,13 @@ class TestOnlineDriveDatasourcePluginProviderController:
def test_get_datasource_not_found(self):
# Arrange
- mock_datasource_entity = MagicMock()
- mock_datasource_entity.identity.name = "other_datasource"
+ source = datasource_entity("other_datasource")
- mock_entity = MagicMock()
- mock_entity.datasources = [mock_datasource_entity]
+ entity = provider_entity(DatasourceProviderType.ONLINE_DRIVE)
+ entity.datasources = [source]
controller = OnlineDriveDatasourcePluginProviderController(
- entity=mock_entity, plugin_id="id", plugin_unique_identifier="unique_id", tenant_id="tenant"
+ entity=entity, plugin_id="id", plugin_unique_identifier="unique_id", tenant_id="tenant"
)
# Act & Assert
diff --git a/api/tests/unit_tests/core/datasource/test_errors.py b/api/tests/unit_tests/core/datasource/test_errors.py
index 95986415b16..7b7e2536dd2 100644
--- a/api/tests/unit_tests/core/datasource/test_errors.py
+++ b/api/tests/unit_tests/core/datasource/test_errors.py
@@ -1,5 +1,3 @@
-from unittest.mock import MagicMock
-
from core.datasource.entities.datasource_entities import DatasourceInvokeMeta
from core.datasource.errors import (
DatasourceApiSchemaError,
@@ -50,9 +48,9 @@ class TestErrors:
assert isinstance(error, ValueError)
def test_datasource_engine_invoke_error(self):
- mock_meta = MagicMock(spec=DatasourceInvokeMeta)
- error = DatasourceEngineInvokeError(meta=mock_meta)
- assert error.meta == mock_meta
+ meta = DatasourceInvokeMeta.error_instance("Invoke failed")
+ error = DatasourceEngineInvokeError(meta=meta)
+ assert error.meta == meta
assert isinstance(error, Exception)
def test_datasource_engine_invoke_error_init(self):
diff --git a/api/tests/unit_tests/core/datasource/utils/test_message_transformer.py b/api/tests/unit_tests/core/datasource/utils/test_message_transformer.py
index 30ecb5b4003..20bf200bdeb 100644
--- a/api/tests/unit_tests/core/datasource/utils/test_message_transformer.py
+++ b/api/tests/unit_tests/core/datasource/utils/test_message_transformer.py
@@ -1,4 +1,4 @@
-from unittest.mock import MagicMock, patch
+from unittest.mock import patch
import pytest
@@ -198,17 +198,18 @@ class TestDatasourceFileMessageTransformer:
def test_transform_file_tool_file_image(self):
# Setup
- mock_file = MagicMock(spec=File)
- mock_file.transfer_method = FileTransferMethod.TOOL_FILE
- mock_file.related_id = "related_123"
- mock_file.extension = ".png"
- mock_file.type = FileType.IMAGE
+ file = File(
+ transfer_method=FileTransferMethod.TOOL_FILE,
+ reference="related_123",
+ extension=".png",
+ file_type=FileType.IMAGE,
+ )
messages = [
DatasourceMessage(
type=DatasourceMessage.MessageType.FILE,
message=DatasourceMessage.TextMessage(text="ignored"),
- meta={"file": mock_file},
+ meta={"file": file},
)
]
@@ -226,17 +227,18 @@ class TestDatasourceFileMessageTransformer:
def test_transform_file_tool_file_binary(self):
# Setup
- mock_file = MagicMock(spec=File)
- mock_file.transfer_method = FileTransferMethod.TOOL_FILE
- mock_file.related_id = "related_456"
- mock_file.extension = ".txt"
- mock_file.type = FileType.DOCUMENT
+ file = File(
+ transfer_method=FileTransferMethod.TOOL_FILE,
+ reference="related_456",
+ extension=".txt",
+ file_type=FileType.DOCUMENT,
+ )
messages = [
DatasourceMessage(
type=DatasourceMessage.MessageType.FILE,
message=DatasourceMessage.TextMessage(text="ignored"),
- meta={"file": mock_file},
+ meta={"file": file},
)
]
@@ -254,13 +256,16 @@ class TestDatasourceFileMessageTransformer:
def test_transform_file_other_transfer_method(self):
# Setup
- mock_file = MagicMock(spec=File)
- mock_file.transfer_method = FileTransferMethod.REMOTE_URL
+ file = File(
+ transfer_method=FileTransferMethod.REMOTE_URL,
+ remote_url="https://example.com/image.png",
+ file_type=FileType.IMAGE,
+ )
msg = DatasourceMessage(
type=DatasourceMessage.MessageType.FILE,
message=DatasourceMessage.TextMessage(text="remote image"),
- meta={"file": mock_file},
+ meta={"file": file},
)
messages = [msg]
diff --git a/api/tests/unit_tests/core/datasource/website_crawl/test_website_crawl_plugin.py b/api/tests/unit_tests/core/datasource/website_crawl/test_website_crawl_plugin.py
index 2945eb55236..82d00533cd9 100644
--- a/api/tests/unit_tests/core/datasource/website_crawl/test_website_crawl_plugin.py
+++ b/api/tests/unit_tests/core/datasource/website_crawl/test_website_crawl_plugin.py
@@ -1,33 +1,32 @@
from collections.abc import Generator
-from unittest.mock import MagicMock, patch
+from unittest.mock import patch
import pytest
from core.datasource.__base.datasource_runtime import DatasourceRuntime
from core.datasource.entities.datasource_entities import (
- DatasourceEntity,
DatasourceProviderType,
WebsiteCrawlMessage,
)
from core.datasource.website_crawl.website_crawl_plugin import WebsiteCrawlDatasourcePlugin
+from tests.unit_tests.core.datasource.factories import datasource_entity
class TestWebsiteCrawlDatasourcePlugin:
@pytest.fixture
- def mock_entity(self):
- entity = MagicMock(spec=DatasourceEntity)
- entity.identity = MagicMock()
+ def entity(self):
+ entity = datasource_entity("test_name")
entity.identity.provider = "test-provider"
entity.identity.name = "test-name"
return entity
@pytest.fixture
- def mock_runtime(self):
- runtime = MagicMock(spec=DatasourceRuntime)
+ def runtime(self):
+ runtime = DatasourceRuntime(tenant_id="test_tenant")
runtime.credentials = {"api_key": "test-key"}
return runtime
- def test_init(self, mock_entity, mock_runtime):
+ def test_init(self, entity, runtime):
# Arrange
tenant_id = "test-tenant-id"
icon = "test-icon"
@@ -35,8 +34,8 @@ class TestWebsiteCrawlDatasourcePlugin:
# Act
plugin = WebsiteCrawlDatasourcePlugin(
- entity=mock_entity,
- runtime=mock_runtime,
+ entity=entity,
+ runtime=runtime,
tenant_id=tenant_id,
icon=icon,
plugin_unique_identifier=plugin_unique_identifier,
@@ -45,24 +44,24 @@ class TestWebsiteCrawlDatasourcePlugin:
# Assert
assert plugin.tenant_id == tenant_id
assert plugin.plugin_unique_identifier == plugin_unique_identifier
- assert plugin.entity == mock_entity
- assert plugin.runtime == mock_runtime
+ assert plugin.entity == entity
+ assert plugin.runtime == runtime
assert plugin.icon == icon
- def test_datasource_provider_type(self, mock_entity, mock_runtime):
+ def test_datasource_provider_type(self, entity, runtime):
# Arrange
plugin = WebsiteCrawlDatasourcePlugin(
- entity=mock_entity, runtime=mock_runtime, tenant_id="test", icon="test", plugin_unique_identifier="test"
+ entity=entity, runtime=runtime, tenant_id="test", icon="test", plugin_unique_identifier="test"
)
# Act & Assert
assert plugin.datasource_provider_type() == DatasourceProviderType.WEBSITE_CRAWL
- def test_get_website_crawl(self, mock_entity, mock_runtime):
+ def test_get_website_crawl(self, entity, runtime):
# Arrange
plugin = WebsiteCrawlDatasourcePlugin(
- entity=mock_entity,
- runtime=mock_runtime,
+ entity=entity,
+ runtime=runtime,
tenant_id="test-tenant-id",
icon="test-icon",
plugin_unique_identifier="test-plugin-id",
@@ -72,12 +71,12 @@ class TestWebsiteCrawlDatasourcePlugin:
datasource_parameters = {"url": "https://example.com"}
provider_type = "firecrawl"
- mock_message = MagicMock(spec=WebsiteCrawlMessage)
+ message = WebsiteCrawlMessage()
# Mock PluginDatasourceManager
with patch("core.datasource.website_crawl.website_crawl_plugin.PluginDatasourceManager") as mock_manager_class:
mock_manager = mock_manager_class.return_value
- mock_manager.get_website_crawl.return_value = (msg for msg in [mock_message])
+ mock_manager.get_website_crawl.return_value = (msg for msg in [message])
# Act
result = plugin.get_website_crawl(
@@ -88,7 +87,7 @@ class TestWebsiteCrawlDatasourcePlugin:
assert isinstance(result, Generator)
messages = list(result)
assert len(messages) == 1
- assert messages[0] == mock_message
+ assert messages[0] == message
mock_manager.get_website_crawl.assert_called_once_with(
tenant_id="test-tenant-id",
diff --git a/api/tests/unit_tests/core/datasource/website_crawl/test_website_crawl_provider.py b/api/tests/unit_tests/core/datasource/website_crawl/test_website_crawl_provider.py
index b7822ba8004..78891e089a9 100644
--- a/api/tests/unit_tests/core/datasource/website_crawl/test_website_crawl_provider.py
+++ b/api/tests/unit_tests/core/datasource/website_crawl/test_website_crawl_provider.py
@@ -1,25 +1,23 @@
-from unittest.mock import MagicMock, patch
-
import pytest
from core.datasource.__base.datasource_runtime import DatasourceRuntime
from core.datasource.entities.datasource_entities import (
- DatasourceProviderEntityWithPlugin,
DatasourceProviderType,
)
+from core.datasource.website_crawl.website_crawl_plugin import WebsiteCrawlDatasourcePlugin
from core.datasource.website_crawl.website_crawl_provider import WebsiteCrawlDatasourcePluginProviderController
+from tests.unit_tests.core.datasource.factories import datasource_entity, provider_entity
class TestWebsiteCrawlDatasourcePluginProviderController:
@pytest.fixture
- def mock_entity(self):
- entity = MagicMock(spec=DatasourceProviderEntityWithPlugin)
+ def entity(self):
+ entity = provider_entity(DatasourceProviderType.WEBSITE_CRAWL)
entity.datasources = []
- entity.identity = MagicMock()
entity.identity.icon = "test-icon"
return entity
- def test_init(self, mock_entity):
+ def test_init(self, entity):
# Arrange
plugin_id = "test-plugin-id"
plugin_unique_identifier = "test-unique-id"
@@ -27,67 +25,59 @@ class TestWebsiteCrawlDatasourcePluginProviderController:
# Act
controller = WebsiteCrawlDatasourcePluginProviderController(
- entity=mock_entity,
+ entity=entity,
plugin_id=plugin_id,
plugin_unique_identifier=plugin_unique_identifier,
tenant_id=tenant_id,
)
# Assert
- assert controller.entity == mock_entity
+ assert controller.entity == entity
assert controller.plugin_id == plugin_id
assert controller.plugin_unique_identifier == plugin_unique_identifier
assert controller.tenant_id == tenant_id
- def test_provider_type(self, mock_entity):
+ def test_provider_type(self, entity):
# Arrange
controller = WebsiteCrawlDatasourcePluginProviderController(
- entity=mock_entity, plugin_id="test", plugin_unique_identifier="test", tenant_id="test"
+ entity=entity, plugin_id="test", plugin_unique_identifier="test", tenant_id="test"
)
# Act & Assert
assert controller.provider_type == DatasourceProviderType.WEBSITE_CRAWL
- def test_get_datasource_success(self, mock_entity):
+ def test_get_datasource_success(self, entity):
# Arrange
datasource_name = "test-datasource"
tenant_id = "test-tenant-id"
plugin_unique_identifier = "test-unique-id"
- mock_datasource_entity = MagicMock()
- mock_datasource_entity.identity = MagicMock()
- mock_datasource_entity.identity.name = datasource_name
- mock_entity.datasources = [mock_datasource_entity]
+ source = datasource_entity(datasource_name)
+ entity.datasources = [source]
controller = WebsiteCrawlDatasourcePluginProviderController(
- entity=mock_entity, plugin_id="test", plugin_unique_identifier=plugin_unique_identifier, tenant_id=tenant_id
+ entity=entity, plugin_id="test", plugin_unique_identifier=plugin_unique_identifier, tenant_id=tenant_id
)
# Act
- with patch(
- "core.datasource.website_crawl.website_crawl_provider.WebsiteCrawlDatasourcePlugin"
- ) as mock_plugin_class:
- mock_plugin_instance = mock_plugin_class.return_value
- result = controller.get_datasource(datasource_name)
-
- # Assert
- assert result == mock_plugin_instance
- mock_plugin_class.assert_called_once()
- args, kwargs = mock_plugin_class.call_args
- assert kwargs["entity"] == mock_datasource_entity
- assert isinstance(kwargs["runtime"], DatasourceRuntime)
- assert kwargs["runtime"].tenant_id == tenant_id
- assert kwargs["tenant_id"] == tenant_id
- assert kwargs["icon"] == "test-icon"
- assert kwargs["plugin_unique_identifier"] == plugin_unique_identifier
-
- def test_get_datasource_not_found(self, mock_entity):
+ result = controller.get_datasource(datasource_name)
+
+ # Assert
+ assert isinstance(result, WebsiteCrawlDatasourcePlugin)
+ assert result.entity is source
+ assert isinstance(result.runtime, DatasourceRuntime)
+ assert result.runtime.tenant_id == tenant_id
+ assert result.tenant_id == tenant_id
+ assert result.icon == "test-icon"
+ assert result.plugin_unique_identifier == plugin_unique_identifier
+
+ def test_get_datasource_not_found(self, entity):
# Arrange
datasource_name = "non-existent"
- mock_entity.datasources = []
+ entity.datasources = []
controller = WebsiteCrawlDatasourcePluginProviderController(
- entity=mock_entity, plugin_id="test", plugin_unique_identifier="test", tenant_id="test"
+ entity=entity, plugin_id="test", plugin_unique_identifier="test", tenant_id="test"
)
# Act & Assert