Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
test(web): exercise image upload behavior in Browser Mode (#45513)
Stephen Zhou92fd1124c621
diff --git a/web/app/components/base/image-uploader/__tests__/image-fixtures.ts b/web/app/components/base/image-uploader/__tests__/image-fixtures.tsnew file mode 100644index 00000000000..8062dec5f05--- /dev/null+++ b/web/app/components/base/image-uploader/__tests__/image-fixtures.ts@@ -0,0 +1,32 @@+import type { ImageFile } from '@/types/app'+import { TransferMethod } from '@/types/app'++// A decodable 1×1 PNG: image rendering and FileReader stay real without network traffic.+const png =+ 'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+aen0AAAAASUVORK5CYII='+export const imageUrl = `data:image/png;base64,${png}`+export const brokenImageUrl = 'data:image/png;base64,broken'+export const imageFile = () =>+ new File([Uint8Array.from(atob(png), (c) => c.charCodeAt(0))], 'sample.png', {+ type: 'image/png',+ })++export const localImage = (overrides: Partial<ImageFile> = {}): ImageFile => ({+ type: TransferMethod.local_file,+ _id: 'local-image',+ fileId: 'uploaded-image',+ file: imageFile(),+ progress: 100,+ url: '',+ base64Url: imageUrl,+ ...overrides,+})++export const remoteImage = (overrides: Partial<ImageFile> = {}): ImageFile => ({+ type: TransferMethod.remote_url,+ _id: 'remote-image',+ fileId: '',+ progress: 100,+ url: imageUrl,+ ...overrides,+})diff --git a/web/app/components/base/image-uploader/__tests__/image-link-input.browser.spec.tsx b/web/app/components/base/image-uploader/__tests__/image-link-input.browser.spec.tsxnew file mode 100644index 00000000000..0fa9f644066--- /dev/null+++ b/web/app/components/base/image-uploader/__tests__/image-link-input.browser.spec.tsx@@ -0,0 +1,61 @@+import type { ImageFile } from '@/types/app'+import { useState } from 'react'+import { page } from 'vite-plus/test/browser'+import { render } from 'vitest-browser-react'+import { TransferMethod } from '@/types/app'+import ImageLinkInput from '../image-link-input'++function LinkExample({ disabled = false }: { disabled?: boolean }) {+ const [file, setFile] = useState<ImageFile>()+ return (+ <>+ <ImageLinkInput disabled={disabled} onUpload={setFile} />+ <output aria-label="Submitted image">{file && JSON.stringify(file)}</output>+ </>+ )+}++it.each([+ ['https://example.com/image.png', 0],+ ['http://example.com/image.png', 0],+ ['ftp://files.example.com/image.png', 0],+ ['not-a-valid-url', -1],+ ['example.com/image.png', -1],+])('submits %s with its upload eligibility', async (url, progress) => {+ await page.viewport(640, 480)+ const screen = await render(<LinkExample />)+ const submit = screen.getByRole('button', { name: 'common.operation.ok' })+ await expect.element(submit).toBeDisabled()+ await screen.getByRole('textbox').fill(url)+ await submit.click()+ await expect+ .element(screen.getByRole('status', { name: 'Submitted image' }))+ .not.toBeEmptyDOMElement()+ const result = JSON.parse(+ screen.getByRole('status', { name: 'Submitted image' }).element().textContent!,+ )+ expect(result).toEqual({+ _id: expect.any(String),+ type: TransferMethod.remote_url,+ url,+ progress,+ fileId: '',+ })+})++it('keeps the entered URL through a disabled transition and disables submission after clearing', async () => {+ await page.viewport(640, 480)+ const screen = await render(<LinkExample disabled />)+ const input = screen.getByRole('textbox')+ const submit = screen.getByRole('button', { name: 'common.operation.ok' })+ await input.fill('https://example.com/image.png')+ await expect.element(submit).toBeDisabled()+ await expect.element(screen.getByRole('status')).toBeEmptyDOMElement()+ await screen.rerender(<LinkExample />)+ await submit.click()+ await expect+ .poll(() => JSON.parse(screen.getByRole('status').element().textContent!).url)+ .toBe('https://example.com/image.png')+ await input.fill('')+ await expect.element(submit).toBeDisabled()+})diff --git a/web/app/components/base/image-uploader/__tests__/image-link-input.spec.tsx b/web/app/components/base/image-uploader/__tests__/image-link-input.spec.tsxdeleted file mode 100644index e76fe56d084..00000000000--- a/web/app/components/base/image-uploader/__tests__/image-link-input.spec.tsx+++ /dev/null@@ -1,43 +0,0 @@-import { render, screen } from '@testing-library/react'-import userEvent from '@testing-library/user-event'-import { TransferMethod } from '@/types/app'-import ImageLinkInput from '../image-link-input'--it.each([- ['https://example.com/image.png', 0],- ['http://example.com/image.png', 0],- ['ftp://files.example.com/image.png', 0],- ['not-a-valid-url', -1],- ['example.com/image.png', -1],-])('submits %s with upload status %s', async (url, progress) => {- const user = userEvent.setup()- const onUpload = vi.fn()- render(<ImageLinkInput onUpload={onUpload} />)- expect(screen.getByRole('button', { name: 'common.operation.ok' })).toBeDisabled()- await user.type(screen.getByRole('textbox'), url)- await user.click(screen.getByRole('button', { name: 'common.operation.ok' }))- expect(onUpload).toHaveBeenCalledExactlyOnceWith(- expect.objectContaining({- type: TransferMethod.remote_url,- url,- progress,- fileId: '',- }),- )-})--it('prevents submission while disabled and allows the entered URL after re-enabling', async () => {- const user = userEvent.setup()- const onUpload = vi.fn()- const { rerender } = render(<ImageLinkInput onUpload={onUpload} disabled />)- await user.type(screen.getByRole('textbox'), 'https://example.com/image.png')- await user.click(screen.getByRole('button', { name: 'common.operation.ok' }))- expect(onUpload).not.toHaveBeenCalled()- rerender(<ImageLinkInput onUpload={onUpload} />)- await user.click(screen.getByRole('button', { name: 'common.operation.ok' }))- expect(onUpload).toHaveBeenCalledExactlyOnceWith(- expect.objectContaining({ url: 'https://example.com/image.png', progress: 0 }),- )- await user.clear(screen.getByRole('textbox'))- expect(screen.getByRole('button', { name: 'common.operation.ok' })).toBeDisabled()-})diff --git a/web/app/components/base/image-uploader/__tests__/image-list.browser.spec.tsx b/web/app/components/base/image-uploader/__tests__/image-list.browser.spec.tsxnew file mode 100644index 00000000000..3be86221966--- /dev/null+++ b/web/app/components/base/image-uploader/__tests__/image-list.browser.spec.tsx@@ -0,0 +1,152 @@+import type { ImageFile } from '@/types/app'+import { useState } from 'react'+import { page, userEvent } from 'vite-plus/test/browser'+import { render } from 'vitest-browser-react'+import { createReactI18nextMock } from '@/test/i18n-mock'+import ImageList from '../image-list'+import { brokenImageUrl, imageUrl, localImage, remoteImage } from './image-fixtures'++vi.mock('react-i18next', () =>+ createReactI18nextMock({+ 'imageGallery.previewImage': 'Preview image {{index}} of {{total}}',+ }),+)++function ListExample({ initial, readonly = false }: { initial: ImageFile[]; readonly?: boolean }) {+ const [files, setFiles] = useState(initial)+ const update = (id: string, progress: number) =>+ setFiles((files) => files.map((file) => (file._id === id ? { ...file, progress } : file)))+ return (+ <>+ <ImageList+ list={files}+ readonly={readonly}+ onRemove={(id) => setFiles((files) => files.filter((file) => file._id !== id))}+ onReUpload={(id) => update(id, 45)}+ onImageLinkLoadSuccess={(id) => update(id, 100)}+ onImageLinkLoadError={(id) => update(id, -1)}+ />+ <output aria-label="Current images">+ {JSON.stringify(files.map(({ _id, progress }) => ({ id: _id, progress })))}+ </output>+ </>+ )+}++it.each([+ ['local', localImage()],+ ['remote', remoteImage()],+])('opens the decoded %s image, closes the actual preview, and can reopen it', async (_, file) => {+ await page.viewport(800, 600)+ const screen = await render(<ListExample initial={[file]} />)+ const preview = screen.getByRole('button', { name: 'Preview image 1 of 1' })+ const thumbnail = preview.getByRole('presentation')+ await expect.element(thumbnail).toHaveAttribute('src', imageUrl)+ await expect.poll(() => (thumbnail.element() as HTMLImageElement).naturalWidth).toBe(1)+ await preview.click()+ const dialog = page.getByRole('dialog', { name: 'workflow.common.preview' })+ const image = dialog.getByRole('presentation')+ await expect.element(image).toHaveAttribute('src', imageUrl)+ await expect.poll(() => (image.element() as HTMLImageElement).naturalWidth).toBe(1)+ await userEvent.keyboard('{Escape}')+ await expect.element(dialog).not.toBeInTheDocument()+ await preview.click()+ await expect.element(dialog).toBeVisible()+ await dialog.getByRole('button', { name: 'common.operation.cancel' }).click()+ await expect.element(dialog).not.toBeInTheDocument()+})++it('removes the hovered image by its ID and updates the remaining preview position', async () => {+ await page.viewport(800, 600)+ const screen = await render(<ListExample initial={[localImage(), remoteImage()]} />)+ const first = screen.getByRole('button', { name: 'Preview image 1 of 2' })+ await first.hover()+ await screen.getByRole('button', { name: 'common.operation.remove' }).click()+ await expect.element(screen.getByRole('listitem')).toBeVisible()+ await expect+ .element(screen.getByRole('status'))+ .toHaveTextContent('[{"id":"remote-image","progress":100}]')+ await expect.element(screen.getByRole('button', { name: 'Preview image 1 of 1' })).toBeVisible()+})++it('keeps readonly thumbnails previewable without exposing removal on hover', async () => {+ await page.viewport(800, 600)+ const screen = await render(<ListExample initial={[localImage()]} readonly />)+ await screen.getByRole('button', { name: 'Preview image 1 of 1' }).hover()+ await expect+ .element(screen.getByRole('button', { name: 'common.operation.remove' }))+ .not.toBeInTheDocument()+})++it.each([+ ['decodable', imageUrl, 1],+ ['invalid', brokenImageUrl, 0],+] as const)(+ 'keeps a local upload pending and unavailable for preview with %s image bytes',+ async (_, source, width) => {+ await page.viewport(800, 600)+ const screen = await render(+ <ListExample initial={[localImage({ progress: 50, base64Url: source })]} readonly />,+ )+ const thumbnail = screen.getByRole('img', { name: 'sample.png' })+ await expect.element(thumbnail).toBeVisible()+ await expect.poll(() => (thumbnail.element() as HTMLImageElement).complete).toBe(true)+ expect((thumbnail.element() as HTMLImageElement).naturalWidth).toBe(width)+ await expect.element(screen.getByText('50%')).toBeVisible()+ await expect.element(screen.getByRole('button')).not.toBeInTheDocument()+ await expect+ .element(screen.getByRole('status'))+ .toHaveTextContent('[{"id":"local-image","progress":50}]')+ },+)++it('retries the failed local file and replaces the error action with its upload progress', async () => {+ await page.viewport(800, 600)+ const screen = await render(<ListExample initial={[localImage({ progress: -1 })]} readonly />)+ await screen.getByRole('button', { name: 'common.operation.retry' }).click()+ await expect.element(screen.getByText('45%')).toBeVisible()+ await expect.element(screen.getByRole('button')).not.toBeInTheDocument()+ await expect+ .element(screen.getByRole('status'))+ .toHaveTextContent('[{"id":"local-image","progress":45}]')+})++it('makes a remote image previewable only after native decoding succeeds', async () => {+ await page.viewport(800, 600)+ const screen = await render(<ListExample initial={[remoteImage({ progress: 0 })]} />)+ await expect.element(screen.getByRole('button', { name: 'Preview image 1 of 1' })).toBeVisible()+ await expect+ .element(screen.getByRole('status'))+ .toHaveTextContent('[{"id":"remote-image","progress":100}]')+ await expect.element(screen.getByTestId('image-loader')).not.toBeInTheDocument()+})++it('keeps native decoding errors unavailable for preview and removable', async () => {+ await page.viewport(800, 600)+ const screen = await render(+ <ListExample initial={[remoteImage({ url: brokenImageUrl, progress: 0 })]} />,+ )+ await expect+ .element(screen.getByRole('status'))+ .toHaveTextContent('[{"id":"remote-image","progress":-1}]')+ await expect+ .element(screen.getByRole('button', { name: 'Preview image 1 of 1' }))+ .not.toBeInTheDocument()+ await expect.element(screen.getByTestId('image-loader')).not.toBeInTheDocument()+ await screen.getByRole('button', { name: 'common.operation.remove' }).click()+ await expect.element(screen.getByRole('listitem')).not.toBeInTheDocument()+})++it('does not turn a failed remote image into success when its bytes decode', async () => {+ await page.viewport(800, 600)+ const screen = await render(<ListExample initial={[remoteImage({ progress: -1 })]} />)+ const thumbnail = screen.getByRole('presentation')+ await expect.element(thumbnail).toBeVisible()+ await expect.poll(() => (thumbnail.element() as HTMLImageElement).naturalWidth).toBe(1)+ await expect+ .element(screen.getByRole('status'))+ .toHaveTextContent('[{"id":"remote-image","progress":-1}]')+ await expect+ .element(screen.getByRole('button', { name: 'Preview image 1 of 1' }))+ .not.toBeInTheDocument()+})diff --git a/web/app/components/base/image-uploader/__tests__/image-list.spec.tsx b/web/app/components/base/image-uploader/__tests__/image-list.spec.tsxdeleted file mode 100644index 7320ece3264..00000000000--- a/web/app/components/base/image-uploader/__tests__/image-list.spec.tsx+++ /dev/null@@ -1,249 +0,0 @@-import type { ImageFile } from '@/types/app'-import { fireEvent, render, screen, within } from '@testing-library/react'-import userEvent from '@testing-library/user-event'-import { createReactI18nextMock } from '@/test/i18n-mock'-import { TransferMethod } from '@/types/app'-import ImageList from '../image-list'--vi.mock('react-i18next', () =>- createReactI18nextMock({- 'imageGallery.previewImage': 'Preview image {{index}} of {{total}}',- }),-)--const previewButtonName = 'Preview image 1 of 1'--const createLocalFile = (overrides: Partial<ImageFile> = {}): ImageFile => ({- type: TransferMethod.local_file,- _id: 'local-file',- fileId: 'file-id',- progress: 100,- url: '',- base64Url: 'data:image/png;base64,abc123',- ...overrides,-})--const createRemoteFile = (overrides: Partial<ImageFile> = {}): ImageFile => ({- type: TransferMethod.remote_url,- _id: 'remote-file',- fileId: '',- progress: 100,- url: 'https://example.com/image.png',- ...overrides,-})--describe('ImageList', () => {- beforeEach(() => {- vi.clearAllMocks()- })-- describe('Rendering', () => {- it('should use base64Url as src for local files', () => {- const list = [createLocalFile({ _id: 'file-1', base64Url: 'data:image/png;base64,xyz' })]- const { container } = render(<ImageList list={list} />)-- expect(container.querySelector('img')).toHaveAttribute('src', 'data:image/png;base64,xyz')- })-- it('should use url as src for remote files', () => {- const list = [createRemoteFile({ _id: 'file-1', url: 'https://example.com/img.jpg' })]- const { container } = render(<ImageList list={list} />)-- expect(container.querySelector('img')).toHaveAttribute('src', 'https://example.com/img.jpg')- })-- it('should use the file name for a non-interactive local thumbnail', () => {- const file = new File(['test'], 'my-image.png', { type: 'image/png' })- const list = [createLocalFile({ _id: 'file-1', file, progress: 50 })]- render(<ImageList list={list} />)-- expect(screen.getByRole('img', { name: 'my-image.png' })).toBeInTheDocument()- })- })-- describe('Props', () => {- it('should not show remove buttons when readonly', () => {- const list = [createLocalFile({ _id: 'file-1' })]- render(<ImageList list={list} readonly onRemove={vi.fn()} />)-- expect(- screen.queryByRole('button', { name: 'common.operation.remove' }),- ).not.toBeInTheDocument()- })- })-- describe('Local File Progress', () => {- it('should show progress percentage when local file is uploading', () => {- const list = [createLocalFile({ _id: 'file-1', progress: 45 })]- render(<ImageList list={list} />)-- expect(screen.getByText(/^45\s*%$/)).toBeInTheDocument()- })-- it('should show retry icon when local file upload fails (progress -1)', () => {- const onReUpload = vi.fn()- const list = [createLocalFile({ _id: 'file-1', progress: -1 })]- render(<ImageList list={list} onReUpload={onReUpload} readonly />)-- expect(screen.getByRole('button', { name: 'common.operation.retry' })).toBeInTheDocument()- expect(within(screen.getByRole('listitem')).getAllByRole('button')).toHaveLength(1)- expect(screen.queryByText(/\d+\s*%/)).not.toBeInTheDocument()- })- })-- describe('Remote URL Progress', () => {- it('should show loading spinner when remote file is loading (progress 0)', () => {- const list = [createRemoteFile({ _id: 'file-1', progress: 0 })]- render(<ImageList list={list} />)-- // Loading spinner has animate-spin class- expect(screen.getByTestId('image-loader')).toBeInTheDocument()- })-- it('should show error indicator when remote file fails (progress -1)', () => {- const list = [createRemoteFile({ _id: 'file-1', progress: -1 })]- render(<ImageList list={list} />)- expect(screen.getByTestId('image-error-container')).toBeInTheDocument()- })- })-- describe('User Interactions', () => {- it('should call onRemove when remove button is clicked', async () => {- const user = userEvent.setup()- const onRemove = vi.fn()- const list = [createLocalFile({ _id: 'file-1' })]- render(<ImageList list={list} onRemove={onRemove} />)-- await user.click(screen.getByRole('button', { name: 'common.operation.remove' }))-- expect(onRemove).toHaveBeenCalledTimes(1)- expect(onRemove).toHaveBeenCalledWith('file-1')- })-- it('should call onReUpload when retry icon is clicked on failed local file', async () => {- const user = userEvent.setup()- const onReUpload = vi.fn()- const list = [createLocalFile({ _id: 'file-1', progress: -1 })]- render(<ImageList list={list} onReUpload={onReUpload} />)- await user.click(screen.getByRole('button', { name: 'common.operation.retry' }))- expect(onReUpload).toHaveBeenCalledWith('file-1')- })-- it('should not expose a preview action for an in-progress image', () => {- const list = [createLocalFile({ _id: 'file-1', progress: 50 })]- render(<ImageList list={list} readonly />)-- expect(screen.queryByRole('button')).not.toBeInTheDocument()- expect(screen.queryByTestId('image-preview-container')).not.toBeInTheDocument()- })-- it('should close image preview when cancel is clicked', async () => {- const user = userEvent.setup()- const list = [createRemoteFile({ _id: 'file-1', progress: 100 })]- render(<ImageList list={list} />)-- // Open preview- await user.click(screen.getByRole('button', { name: previewButtonName }))- expect(screen.getByTestId('image-preview-image')).toHaveAttribute('src', list[0]!.url)-- // Close preview- const closeButton = screen.getByRole('button', { name: 'common.operation.cancel' })- await user.click(closeButton)- expect(screen.queryByTestId('image-preview-container')).not.toBeInTheDocument()- })-- it('should open preview with base64Url for completed local file', async () => {- const user = userEvent.setup()- const list = [- createLocalFile({- _id: 'file-1',- progress: 100,- base64Url: 'data:image/png;base64,localdata',- }),- ]- render(<ImageList list={list} />)-- await user.click(screen.getByRole('button', { name: previewButtonName }))-- const previewImage = screen.getByTestId('image-preview-image')- expect(previewImage).toBeInTheDocument()- expect(previewImage).toHaveAttribute('src', 'data:image/png;base64,localdata')- })- })-- describe('Image Load Events', () => {- it('should call onImageLinkLoadSuccess for remote URL on load when progress is not -1', () => {- const onImageLinkLoadSuccess = vi.fn()- const list = [createRemoteFile({ _id: 'file-1', progress: 0 })]- const { container } = render(- <ImageList list={list} onImageLinkLoadSuccess={onImageLinkLoadSuccess} />,- )-- const img = container.querySelector('img')!- fireEvent.load(img)- expect(onImageLinkLoadSuccess).toHaveBeenCalledWith('file-1')- })-- it('should not call onImageLinkLoadSuccess for remote URL when progress is -1', () => {- const onImageLinkLoadSuccess = vi.fn()- const list = [createRemoteFile({ _id: 'file-1', progress: -1 })]- const { container } = render(- <ImageList list={list} onImageLinkLoadSuccess={onImageLinkLoadSuccess} />,- )-- const img = container.querySelector('img')!- fireEvent.load(img)-- expect(onImageLinkLoadSuccess).not.toHaveBeenCalled()- })-- it('should not call onImageLinkLoadSuccess for local file type', () => {- const onImageLinkLoadSuccess = vi.fn()- const list = [createLocalFile({ _id: 'file-1', progress: 50 })]- const { container } = render(- <ImageList list={list} onImageLinkLoadSuccess={onImageLinkLoadSuccess} />,- )-- const img = container.querySelector('img')!- fireEvent.load(img)-- expect(onImageLinkLoadSuccess).not.toHaveBeenCalled()- })-- it('should call onImageLinkLoadError for remote URL on error', () => {- const onImageLinkLoadError = vi.fn()- const list = [createRemoteFile({ _id: 'file-1', progress: 0 })]- const { container } = render(- <ImageList list={list} onImageLinkLoadError={onImageLinkLoadError} />,- )-- const img = container.querySelector('img')!- fireEvent.error(img)-- expect(onImageLinkLoadError).toHaveBeenCalledWith('file-1')- })-- it('should not call onImageLinkLoadError for local file type', () => {- const onImageLinkLoadError = vi.fn()- const list = [createLocalFile({ _id: 'file-1', progress: 50 })]- const { container } = render(- <ImageList list={list} onImageLinkLoadError={onImageLinkLoadError} />,- )-- const img = container.querySelector('img')!- fireEvent.error(img)-- expect(onImageLinkLoadError).not.toHaveBeenCalled()- })- })-- describe('Edge Cases', () => {- it('should handle list with mixed local and remote files', () => {- const list = [createLocalFile({ _id: 'local-1' }), createRemoteFile({ _id: 'remote-1' })]- render(<ImageList list={list} />)- expect(screen.getAllByRole('listitem')).toHaveLength(2)- expect(screen.getByRole('button', { name: 'Preview image 1 of 2' })).toBeInTheDocument()- expect(screen.getByRole('button', { name: 'Preview image 2 of 2' })).toBeInTheDocument()- })- })-})diff --git a/web/app/components/base/image-uploader/__tests__/text-generation-image-uploader.browser.spec.tsx b/web/app/components/base/image-uploader/__tests__/text-generation-image-uploader.browser.spec.tsxnew file mode 100644index 00000000000..b41113535a3--- /dev/null+++ b/web/app/components/base/image-uploader/__tests__/text-generation-image-uploader.browser.spec.tsx@@ -0,0 +1,172 @@+import type { ImageFile, VisionSettings } from '@/types/app'+import { useState } from 'react'+import { page, userEvent } from 'vite-plus/test/browser'+import { render } from 'vitest-browser-react'+import { toast } from '@/app/notifications'+import { AppToaster } from '@/app/notifications/app-toaster'+import { Resolution, TransferMethod } from '@/types/app'+import TextGenerationImageUploader from '../text-generation-image-uploader'+import { brokenImageUrl, imageFile, imageUrl } from './image-fixtures'++vi.mock('@/next/navigation', () => ({ useParams: () => ({ token: 'shared-app' }) }))+const api = vi.hoisted(() => ({+ upload:+ vi.fn<+ (options: { data: FormData }, isPublic?: boolean, url?: string) => Promise<{ id: string }>+ >(),+}))+vi.mock('@/service/base', () => ({ upload: api.upload }))++const createSettings = (overrides: Partial<VisionSettings> = {}): VisionSettings => ({+ enabled: true,+ number_limits: 3,+ detail: Resolution.high,+ transfer_methods: [TransferMethod.local_file],+ image_file_size_limit: 10,+ ...overrides,+})++function UploadExample({+ settings = createSettings(),+ disabled = false,+}: {+ settings?: VisionSettings+ disabled?: boolean+}) {+ const [files, setFiles] = useState<ImageFile[]>([])+ return (+ <>+ <TextGenerationImageUploader+ settings={settings}+ disabled={disabled}+ onFilesChange={setFiles}+ />+ <output aria-label="Published images">+ {JSON.stringify(+ files.map(({ fileId, type, progress, url }) => ({ fileId, type, progress, url })),+ )}+ </output>+ <AppToaster timeout={0} />+ </>+ )+}++beforeEach(() => api.upload.mockResolvedValue({ id: 'uploaded-image' }))+afterEach(() => toast.dismiss())++it.each([+ [+ TransferMethod.local_file,+ 'common.imageUploader.uploadFromComputer',+ 'common.imageUploader.pasteImageLink',+ ],+ [+ TransferMethod.remote_url,+ 'common.imageUploader.pasteImageLink',+ 'common.imageUploader.uploadFromComputer',+ ],+])('offers only the configured method %s', async (method, visible, hidden) => {+ await page.viewport(800, 600)+ const screen = await render(+ <UploadExample settings={createSettings({ transfer_methods: [method] })} />,+ )+ await expect.element(screen.getByText(visible)).toBeVisible()+ await expect.element(screen.getByText(hidden)).not.toBeInTheDocument()+})++it('publishes actual local bytes as a completed, decoded preview', async () => {+ await page.viewport(800, 600)+ const screen = await render(<UploadExample />)+ await screen.getByLabelText('common.imageUploader.uploadFromComputer').upload(imageFile())+ await expect+ .element(screen.getByRole('status', { name: 'Published images' }))+ .toHaveTextContent(+ JSON.stringify([+ { fileId: 'uploaded-image', type: TransferMethod.local_file, progress: 100, url: imageUrl },+ ]),+ )+ await screen.getByRole('button', { name: /imageGallery.previewImage/ }).click()+ const image = page.getByRole('dialog').getByRole('presentation')+ await expect.element(image).toBeVisible()+ await expect.poll(() => (image.element() as HTMLImageElement).naturalWidth).toBe(1)+})++it('explains a numeric string size limit and leaves the published list empty', async () => {+ await page.viewport(800, 600)+ const screen = await render(+ <UploadExample settings={createSettings({ image_file_size_limit: '1' })} />,+ )+ await screen+ .getByLabelText('common.imageUploader.uploadFromComputer')+ .upload(new File([new Uint8Array(1024 * 1024 + 1)], 'large.png', { type: 'image/png' }))+ await expect.element(page.getByText(/common.imageUploader.uploadFromComputerLimit/)).toBeVisible()+ await expect+ .element(screen.getByRole('status', { name: 'Published images' }))+ .toHaveTextContent('[]')+ expect(api.upload).not.toHaveBeenCalled()+})++it('publishes an invalid remote link, enforces the count limit and recovers after removal', async () => {+ await page.viewport(800, 600)+ const screen = await render(+ <UploadExample+ settings={createSettings({+ number_limits: 1,+ transfer_methods: [TransferMethod.local_file, TransferMethod.remote_url],+ })}+ />,+ )+ const paste = screen.getByRole('button', { name: 'common.imageUploader.pasteImageLink' })+ await paste.click()+ const input = page.getByPlaceholder('common.imageUploader.pasteImageLinkInputPlaceholder')+ await input.fill(brokenImageUrl)+ await page.getByRole('button', { name: 'common.operation.ok' }).click()+ await expect.element(input).not.toBeInTheDocument()+ await expect+ .element(screen.getByRole('status', { name: 'Published images' }))+ .toHaveTextContent(+ JSON.stringify([+ { fileId: '', type: TransferMethod.remote_url, progress: -1, url: brokenImageUrl },+ ]),+ )+ await expect+ .element(screen.getByLabelText('common.imageUploader.uploadFromComputer'))+ .toBeDisabled()+ await expect.element(paste).toBeDisabled()+ await screen.getByRole('button', { name: 'common.operation.remove' }).click()+ await expect.element(screen.getByRole('listitem')).not.toBeInTheDocument()+ await expect+ .element(screen.getByRole('status', { name: 'Published images' }))+ .toHaveTextContent('[]')+ await expect+ .element(screen.getByLabelText('common.imageUploader.uploadFromComputer'))+ .toBeEnabled()+ await expect.element(paste).toBeEnabled()+ // Removal also restores the real popover and its Escape focus handoff.+ await paste.click()+ await expect.element(input).toBeVisible()+ await userEvent.keyboard('{Escape}')+ await expect.element(input).not.toBeInTheDocument()+ await expect.element(paste).toHaveFocus()+})++it('disables both native upload entry points', async () => {+ await page.viewport(800, 600)+ const screen = await render(+ <UploadExample+ disabled+ settings={createSettings({+ transfer_methods: [TransferMethod.local_file, TransferMethod.remote_url],+ })}+ />,+ )+ await expect+ .element(screen.getByLabelText('common.imageUploader.uploadFromComputer'))+ .toBeDisabled()+ await expect+ .element(screen.getByRole('button', { name: 'common.imageUploader.pasteImageLink' }))+ .toBeDisabled()+ await expect+ .element(page.getByPlaceholder('common.imageUploader.pasteImageLinkInputPlaceholder'))+ .not.toBeInTheDocument()+})diff --git a/web/app/components/base/image-uploader/__tests__/text-generation-image-uploader.spec.tsx b/web/app/components/base/image-uploader/__tests__/text-generation-image-uploader.spec.tsxdeleted file mode 100644index 6b7712b4d8b..00000000000--- a/web/app/components/base/image-uploader/__tests__/text-generation-image-uploader.spec.tsx+++ /dev/null@@ -1,139 +0,0 @@-import type { VisionSettings } from '@/types/app'-import { act, fireEvent, render, screen, waitFor } from '@testing-library/react'-import userEvent from '@testing-library/user-event'-import { Resolution, TransferMethod } from '@/types/app'-import TextGenerationImageUploader from '../text-generation-image-uploader'-import { imageUpload } from '../utils'--vi.mock('../utils', async (importOriginal) => ({- ...(await importOriginal<typeof import('../utils')>()),- imageUpload: vi.fn(),-}))-const upload = vi.mocked(imageUpload)-beforeEach(() => vi.resetAllMocks())--const createSettings = (overrides: Partial<VisionSettings> = {}): VisionSettings => ({- enabled: true,- number_limits: 3,- detail: Resolution.high,- transfer_methods: [TransferMethod.local_file],- image_file_size_limit: 10,- ...overrides,-})--it.each([- [- TransferMethod.local_file,- 'common.imageUploader.uploadFromComputer',- 'common.imageUploader.pasteImageLink',- ],- [- TransferMethod.remote_url,- 'common.imageUploader.pasteImageLink',- 'common.imageUploader.uploadFromComputer',- ],-])('offers the configured upload method %s', (method, visible, hidden) => {- render(- <TextGenerationImageUploader- settings={createSettings({ transfer_methods: [method] })}- onFilesChange={vi.fn()}- />,- )- expect(screen.getByText(visible)).toBeInTheDocument()- expect(screen.queryByText(hidden)).not.toBeInTheDocument()-})--it('uploads through the real local hook and publishes completed files', async () => {- const user = userEvent.setup()- const onFilesChange = vi.fn()- render(<TextGenerationImageUploader settings={createSettings()} onFilesChange={onFilesChange} />)- const file = new File(['image'], 'sample.png', { type: 'image/png' })- await user.upload(screen.getByTestId('local-file-input'), file)- await waitFor(() => expect(upload).toHaveBeenCalledOnce())- expect(upload.mock.calls[0]![0].file).toBe(file)- act(() => upload.mock.calls[0]![0].onSuccessCallback({ id: 'uploaded-image' }))- await waitFor(() =>- expect(onFilesChange).toHaveBeenLastCalledWith([- expect.objectContaining({- file,- fileId: 'uploaded-image',- type: TransferMethod.local_file,- progress: 100,- }),- ]),- )-})--it('rejects images above a numeric string size limit without uploading', async () => {- const user = userEvent.setup()- const onFilesChange = vi.fn()- render(- <TextGenerationImageUploader- settings={createSettings({ image_file_size_limit: '1' })}- onFilesChange={onFilesChange}- />,- )- const file = new File([new Uint8Array(1024 * 1024 + 1)], 'large.png', { type: 'image/png' })- await user.upload(screen.getByTestId('local-file-input'), file)- expect(upload).not.toHaveBeenCalled()- expect(onFilesChange).toHaveBeenLastCalledWith([])-})--it('publishes remote image load state, enforces the limit, and re-enables uploads after removal', async () => {- const user = userEvent.setup()- const onFilesChange = vi.fn()- render(- <TextGenerationImageUploader- settings={createSettings({- number_limits: 1,- transfer_methods: [TransferMethod.local_file, TransferMethod.remote_url],- })}- onFilesChange={onFilesChange}- />,- )- await user.click(screen.getByText('common.imageUploader.pasteImageLink'))- await user.type(- await screen.findByPlaceholderText('common.imageUploader.pasteImageLinkInputPlaceholder'),- 'https://example.com/image.png',- )- await user.click(screen.getByRole('button', { name: 'common.operation.ok' }))- await waitFor(() =>- expect(onFilesChange).toHaveBeenLastCalledWith([- expect.objectContaining({- type: TransferMethod.remote_url,- url: 'https://example.com/image.png',- progress: 0,- }),- ]),- )- expect(screen.getByTestId('local-file-input')).toBeDisabled()- await user.click(screen.getByText('common.imageUploader.pasteImageLink'))- expect(- screen.queryByPlaceholderText('common.imageUploader.pasteImageLinkInputPlaceholder'),- ).not.toBeInTheDocument()- // Native image load/error events are supplied by the browser, not user input.- const image = screen.getByRole('presentation')- fireEvent.error(image)- expect(onFilesChange).toHaveBeenLastCalledWith([expect.objectContaining({ progress: -1 })])- await user.click(screen.getByRole('button', { name: 'common.operation.remove' }))- expect(onFilesChange).toHaveBeenLastCalledWith([])- expect(screen.getByTestId('local-file-input')).toBeEnabled()-})--it('blocks both upload entry points when disabled', async () => {- const user = userEvent.setup()- render(- <TextGenerationImageUploader- disabled- settings={createSettings({- transfer_methods: [TransferMethod.local_file, TransferMethod.remote_url],- })}- onFilesChange={vi.fn()}- />,- )- expect(screen.getByTestId('local-file-input')).toBeDisabled()- await user.click(screen.getByText('common.imageUploader.pasteImageLink'))- expect(- screen.queryByPlaceholderText('common.imageUploader.pasteImageLinkInputPlaceholder'),- ).not.toBeInTheDocument()-})diff --git a/web/app/components/base/image-uploader/__tests__/uploader.browser.spec.tsx b/web/app/components/base/image-uploader/__tests__/uploader.browser.spec.tsxnew file mode 100644index 00000000000..3e717886d6b--- /dev/null+++ b/web/app/components/base/image-uploader/__tests__/uploader.browser.spec.tsx@@ -0,0 +1,94 @@+import type { ImageFile } from '@/types/app'+import { useState } from 'react'+import { page } from 'vite-plus/test/browser'+import { render } from 'vitest-browser-react'+import { TransferMethod } from '@/types/app'+import Uploader from '../uploader'+import { imageFile, imageUrl } from './image-fixtures'++vi.mock('@/next/navigation', () => ({ useParams: () => ({ token: 'shared-app' }) }))+const api = vi.hoisted(() => ({+ upload:+ vi.fn<+ (options: { data: FormData }, isPublic?: boolean, url?: string) => Promise<{ id: string }>+ >(),+}))+vi.mock('@/service/base', () => ({ upload: api.upload }))++function UploaderExample({ disabled = false }: { disabled?: boolean }) {+ const [file, setFile] = useState<ImageFile>()+ const [open, setOpen] = useState(true)+ return (+ <>+ <section aria-label="Image picker" hidden={!open}>+ <Uploader+ disabled={disabled}+ onUpload={setFile}+ closePopover={() => setOpen(false)}+ limit={3}+ >+ {() => <span>Upload image</span>}+ </Uploader>+ </section>+ {!open && (+ <button type="button" onClick={() => setOpen(true)}>+ Choose another image+ </button>+ )}+ <output aria-label="Uploaded image">{file && JSON.stringify(file)}</output>+ </>+ )+}++beforeEach(() => api.upload.mockResolvedValue({ id: 'uploaded-image' }))++it('reads native file bytes, uploads them to the public endpoint and accepts the same file again', async () => {+ await page.viewport(800, 600)+ const screen = await render(<UploaderExample />)+ const input = screen.getByLabelText('Upload image')+ const file = imageFile()+ await input.upload(file)+ const saved = screen.getByRole('status', { name: 'Uploaded image' })+ await expect.element(saved).toBeVisible()+ await expect.poll(() => JSON.parse(saved.element().textContent!).progress).toBe(100)+ const result = JSON.parse(saved.element().textContent!)+ expect(result).toMatchObject({+ fileId: 'uploaded-image',+ type: TransferMethod.local_file,+ base64Url: imageUrl,+ url: imageUrl,+ })+ await expect.element(screen.getByLabelText('Image picker')).not.toBeVisible()+ await expect.element(screen.getByRole('button', { name: 'Choose another image' })).toBeVisible()+ expect(api.upload).toHaveBeenCalledWith(+ expect.objectContaining({ data: expect.any(FormData) }),+ true,+ undefined,+ )+ const uploaded = api.upload.mock.calls[0]![0].data.get('file')+ expect(uploaded).toBeInstanceOf(File)+ expect(await (uploaded as File).bytes()).toEqual(await file.bytes())+ expect((uploaded as File).name).toBe('sample.png')++ await screen.getByRole('button', { name: 'Choose another image' }).click()+ await expect.element(input).toBeVisible()+ await input.click()+ await expect.element(input).toHaveValue('')+ api.upload.mockResolvedValueOnce({ id: 'uploaded-again' })+ await input.upload(file)+ await expect.poll(() => JSON.parse(saved.element().textContent!).fileId).toBe('uploaded-again')+ await expect.element(screen.getByLabelText('Image picker')).not.toBeVisible()+ await expect.element(screen.getByRole('button', { name: 'Choose another image' })).toBeVisible()+})++it('exposes disabled file selection without publishing or closing', async () => {+ await page.viewport(800, 600)+ const screen = await render(<UploaderExample disabled />)+ await expect.element(screen.getByLabelText('Upload image')).toBeDisabled()+ await expect.element(screen.getByRole('status', { name: 'Uploaded image' })).toBeEmptyDOMElement()+ await expect.element(screen.getByLabelText('Image picker')).toBeVisible()+ await expect+ .element(screen.getByRole('button', { name: 'Choose another image' }))+ .not.toBeInTheDocument()+ expect(api.upload).not.toHaveBeenCalled()+})diff --git a/web/app/components/base/image-uploader/__tests__/uploader.spec.tsx b/web/app/components/base/image-uploader/__tests__/uploader.spec.tsxdeleted file mode 100644index 203ed05e021..00000000000--- a/web/app/components/base/image-uploader/__tests__/uploader.spec.tsx+++ /dev/null@@ -1,66 +0,0 @@-import { render, screen, waitFor } from '@testing-library/react'-import userEvent from '@testing-library/user-event'-// oxlint-disable-next-line no-restricted-imports -- Isolate the existing upload transport used by the uploader under test.-import { upload } from '@/service/base'-import { TransferMethod } from '@/types/app'-import Uploader from '../uploader'--vi.mock('@/next/navigation', () => ({ useParams: () => ({ token: 'shared-app' }) }))-vi.mock('@/service/base', () => ({ upload: vi.fn() }))--beforeEach(() => {- vi.mocked(upload).mockResolvedValue({ id: 'uploaded-image' })-})--it('uploads a selected image through the real hook and permits selecting the same file again', async () => {- const user = userEvent.setup()- const onUpload = vi.fn()- const closePopover = vi.fn()- render(- <Uploader onUpload={onUpload} closePopover={closePopover} limit={3}>- {() => <span>Upload image</span>}- </Uploader>,- )- const input = screen.getByLabelText('Upload image') as HTMLInputElement- const file = new File(['image'], 'demo.png', { type: 'image/png' })-- await user.upload(input, file)- await waitFor(() =>- expect(onUpload).toHaveBeenLastCalledWith(- expect.objectContaining({- file,- fileId: 'uploaded-image',- type: TransferMethod.local_file,- progress: 100,- }),- ),- )- expect(closePopover).toHaveBeenCalledTimes(1)- expect(upload).toHaveBeenCalledWith(- expect.objectContaining({ data: expect.any(FormData) }),- true,- undefined,- )-- await user.upload(input, file)- await waitFor(() => expect(upload).toHaveBeenCalledTimes(2))- await waitFor(() => expect(onUpload).toHaveBeenCalledTimes(4))- expect(closePopover).toHaveBeenCalledTimes(2)-})--it('blocks file selection when disabled', async () => {- const user = userEvent.setup()- const onUpload = vi.fn()- const closePopover = vi.fn()- render(- <Uploader disabled onUpload={onUpload} closePopover={closePopover}>- {() => <span>Upload image</span>}- </Uploader>,- )- const input = screen.getByLabelText('Upload image') as HTMLInputElement- expect(input).toBeDisabled()- await user.upload(input, new File(['image'], 'demo.png', { type: 'image/png' }))- expect(upload).not.toHaveBeenCalled()- expect(onUpload).not.toHaveBeenCalled()- expect(closePopover).not.toHaveBeenCalled()-})