Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix(api): protect workspace credential mutations (#40790)
WH-209996bfcf20cda1
diff --git a/api/controllers/console/datasets/data_source.py b/api/controllers/console/datasets/data_source.pyindex 9cf8420c251..e0f857c1582 100644--- a/api/controllers/console/datasets/data_source.py+++ b/api/controllers/console/datasets/data_source.py@@ -36,6 +36,7 @@ from ..wraps import (RBACPermission,RBACResourceScope,account_initialization_required,+ is_admin_or_owner_required,model_validate,rbac_permission_required,setup_required,@@ -187,6 +188,8 @@ class DataSourceApi(Resource):@setup_required@login_required+ @is_admin_or_owner_required+ @rbac_permission_required(RBACResourceScope.WORKSPACE, RBACPermission.CREDENTIAL_MANAGE, resource_required=False)@account_initialization_required@console_ns.response(200, "Success", console_ns.models[SimpleResultResponse.__name__])@with_current_tenant_iddiff --git a/api/controllers/console/workspace/tool_providers.py b/api/controllers/console/workspace/tool_providers.pyindex 222ffd99a31..badfb21eed6 100644--- a/api/controllers/console/workspace/tool_providers.py+++ b/api/controllers/console/workspace/tool_providers.py@@ -580,6 +580,8 @@ class ToolBuiltinProviderAddApi(Resource):)@setup_required@login_required+ @is_admin_or_owner_required+ @rbac_permission_required(RBACResourceScope.WORKSPACE, RBACPermission.CREDENTIAL_CREATE, resource_required=False)@account_initialization_required@with_current_user@with_current_tenant_iddiff --git a/api/tests/unit_tests/controllers/console/test_workspace_credential_mutation_permissions.py b/api/tests/unit_tests/controllers/console/test_workspace_credential_mutation_permissions.pynew file mode 100644index 00000000000..b7a6212cc75--- /dev/null+++ b/api/tests/unit_tests/controllers/console/test_workspace_credential_mutation_permissions.py@@ -0,0 +1,28 @@+from inspect import getclosurevars, unwrap+from types import FunctionType++import pytest++from controllers.common.wraps import RBACPermission, RBACResourceScope+from controllers.console.datasets.data_source import DataSourceApi+from controllers.console.workspace.tool_providers import ToolBuiltinProviderAddApi+++ ("method", "permission"),+ [+ (ToolBuiltinProviderAddApi.post, RBACPermission.CREDENTIAL_CREATE),+ (DataSourceApi.patch, RBACPermission.CREDENTIAL_MANAGE),+ ],+)+def test_workspace_credential_mutations_require_management_permission(+ method: FunctionType, permission: RBACPermission+) -> None:+ legacy_wrapper = unwrap(method, stop=lambda wrapper: "is_admin_or_owner_required" in wrapper.__code__.co_qualname)+ assert "is_admin_or_owner_required" in legacy_wrapper.__code__.co_qualname++ rbac_wrapper = unwrap(method, stop=lambda wrapper: "rbac_permission_required" in wrapper.__code__.co_qualname)+ rbac_config = getclosurevars(rbac_wrapper).nonlocals+ assert rbac_config["resource_type"] == RBACResourceScope.WORKSPACE+ assert rbac_config["scene"] == permission+ assert rbac_config["resource_required"] is Falsediff --git a/api/tests/unit_tests/controllers/console/workspace/test_tool_providers.py b/api/tests/unit_tests/controllers/console/workspace/test_tool_providers.pyindex 5d5f47333c0..8184adaad97 100644--- a/api/tests/unit_tests/controllers/console/workspace/test_tool_providers.py+++ b/api/tests/unit_tests/controllers/console/workspace/test_tool_providers.py@@ -336,6 +336,7 @@ def test_builtin_provider_add_passes_payload(app: Flask, controller_module: ModuleType, monkeypatch: pytest.MonkeyPatch):user = _mock_account()+ user.role = TenantAccountRole.ADMIN_set_current_account(monkeypatch, controller_module, user, "tenant-456")service_mock = MagicMock(return_value={"result": "success"})