Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
test(api): annotate six service and tool test modules for strict pyrefly (#45472)
Felix Shi976ea2487421
diff --git a/api/tests/unit_tests/core/tools/test_tool_label_manager.py b/api/tests/unit_tests/core/tools/test_tool_label_manager.pyindex 9543f49b92f..0cfe31418c0 100644--- a/api/tests/unit_tests/core/tools/test_tool_label_manager.py+++ b/api/tests/unit_tests/core/tools/test_tool_label_manager.py@@ -27,7 +27,7 @@ class _DatabaseBinding:# Create a mock class for testing abstract/base classesclass _ConcreteBuiltinToolProviderController(BuiltinToolProviderController):@override- def _validate_credentials(self, user_id: str, credentials: dict[str, Any]):+ def _validate_credentials(self, user_id: str, credentials: dict[str, Any]) -> None:return None@@ -45,14 +45,14 @@ def _workflow_controller(provider_id: str = "wf-1") -> WorkflowToolProviderContr# Test pure logic: filtering and deduplication-def test_tool_label_manager_filter_tool_labels():+def test_tool_label_manager_filter_tool_labels() -> None:filtered = ToolLabelManager.filter_tool_labels(["search", "search", "invalid", "news"])assert set(filtered) == {"search", "news"}assert len(filtered) == 2@pytest.mark.parametrize("sqlite_session", [(ToolLabelBinding,)], indirect=True)-def test_tool_label_manager_update_tool_labels_db(sqlite_session: Session):+def test_tool_label_manager_update_tool_labels_db(sqlite_session: Session) -> None:"""Test the database update logic for tool labels.Focus: Verify that labels are filtered, de-duplicated, and safely handled within a database session.@@ -77,7 +77,7 @@ def test_tool_label_manager_update_tool_labels_db(sqlite_session: Session):# Test error handling-def test_tool_label_manager_update_tool_labels_unsupported():+def test_tool_label_manager_update_tool_labels_unsupported() -> None:with pytest.raises(ValueError, match="Unsupported tool type"):ToolLabelManager.update_tool_labels(object(), ["search"]) # type: ignore[arg-type]@@ -86,7 +86,7 @@ def test_tool_label_manager_update_tool_labels_unsupported():@pytest.mark.parametrize("sqlite_session", [(ToolLabelBinding,)], indirect=True)def test_tool_label_manager_get_tool_labels_for_builtin_and_db(monkeypatch: pytest.MonkeyPatch, sqlite_engine: Engine, sqlite_session: Session-):+) -> None:# Mocking a property (@property) using PropertyMockwith patch.object(_ConcreteBuiltinToolProviderController,@@ -111,7 +111,7 @@ def test_tool_label_manager_get_tool_labels_for_builtin_and_db(assert set(labels) == {"search", "news"}-def test_tool_label_manager_get_tool_labels_unsupported():+def test_tool_label_manager_get_tool_labels_unsupported() -> None:"""Negative Test: Ensure get_tool_labels raises ValueError for unsupported controller types.This protects the internal API contract against accidental regressions during refactoring.@@ -125,7 +125,7 @@ def test_tool_label_manager_get_tool_labels_unsupported():@pytest.mark.parametrize("sqlite_session", [(ToolLabelBinding,)], indirect=True)def test_tool_label_manager_get_tools_labels_batch(monkeypatch: pytest.MonkeyPatch, sqlite_engine: Engine, sqlite_session: Session-):+) -> None:assert ToolLabelManager.get_tools_labels([]) == {}api = _api_controller("api-1")@@ -148,7 +148,7 @@ def test_tool_label_manager_get_tools_labels_batch(assert labels["wf-1"] == ["utilities"]-def test_tool_label_manager_get_tools_labels_unsupported():+def test_tool_label_manager_get_tools_labels_unsupported() -> None:"""Negative Test: Ensure get_tools_labels raises ValueError if the list containsunsupported controller types, even alongside valid ones.diff --git a/api/tests/unit_tests/core/tools/workflow_as_tool/test_provider.py b/api/tests/unit_tests/core/tools/workflow_as_tool/test_provider.pyindex 30513ad0deb..7089bd64cf2 100644--- a/api/tests/unit_tests/core/tools/workflow_as_tool/test_provider.py+++ b/api/tests/unit_tests/core/tools/workflow_as_tool/test_provider.py@@ -152,7 +152,7 @@ def _persist_provider_graph(return db_provider, app, account, workflow-def test_get_db_provider_tool_builds_entity(database_session: Session):+def test_get_db_provider_tool_builds_entity(database_session: Session) -> None:db_provider, app, user, _ = _persist_provider_graph(database_session,parameter_configuration=json.dumps(@@ -204,7 +204,7 @@ def test_get_db_provider_tool_builds_entity(database_session: Session):assert controller.provider_type == ToolProviderType.WORKFLOW-def test_get_tool_returns_hit_or_none():+def test_get_tool_returns_hit_or_none() -> None:controller = _controller()tool = _workflow_tool()controller.tools = [tool]@@ -213,7 +213,7 @@ def test_get_tool_returns_hit_or_none():assert controller.get_tool("missing") is None-def test_get_tools_returns_cached():+def test_get_tools_returns_cached() -> None:controller = _controller()cached_tools = [_workflow_tool("wf-cached", tenant_id="tenant-1")]controller.tools = cached_tools@@ -221,7 +221,7 @@ def test_get_tools_returns_cached():assert controller.get_tools("tenant-1") == cached_tools-def test_from_db_builds_controller(database_session: Session):+def test_from_db_builds_controller(database_session: Session) -> None:db_provider, app, user, workflow = _persist_provider_graph(database_session)with (@@ -248,7 +248,7 @@ def test_from_db_builds_controller(database_session: Session):assert built.tools[0].workflow_id == workflow.id-def test_get_tools_returns_empty_when_provider_missing(database_session: Session):+def test_get_tools_returns_empty_when_provider_missing(database_session: Session) -> None:db_provider, _, _, _ = _persist_provider_graph(database_session)controller = _controller(db_provider.id)controller.tools = None@@ -256,7 +256,7 @@ def test_get_tools_returns_empty_when_provider_missing(database_session: Sessionassert controller.get_tools(str(uuid.uuid4())) == []-def test_get_tools_raises_when_app_missing(database_session: Session):+def test_get_tools_raises_when_app_missing(database_session: Session) -> None:db_provider, _, _, _ = _persist_provider_graph(database_session,include_app=False,diff --git a/api/tests/unit_tests/pyrefly.toml b/api/tests/unit_tests/pyrefly.tomlindex d31fa9aba06..75a0b2b617f 100644--- a/api/tests/unit_tests/pyrefly.toml+++ b/api/tests/unit_tests/pyrefly.toml@@ -198,7 +198,6 @@ project-excludes = ["core/tools/test_tool_engine.py","core/tools/entities/test_tool_entities.py","core/tools/test_tool_file_manager.py",- "core/tools/test_tool_label_manager.py","core/tools/test_tool_manager.py","core/tools/utils/test_configuration.py","core/tools/utils/test_message_transformer.py",@@ -206,7 +205,6 @@ project-excludes = ["core/tools/utils/test_model_invocation_utils.py","core/tools/utils/test_parser.py","core/tools/utils/test_web_reader_tool.py",- "core/tools/workflow_as_tool/test_provider.py","core/tools/workflow_as_tool/test_tool.py","context/test_execution_context.py","context/test_flask_app_context.py",@@ -306,18 +304,15 @@ project-excludes = ["services/test_api_token_service.py","services/test_app_generate_service.py","services/test_app_service.py",- "services/test_app_task_service.py","services/test_async_workflow_service.py","services/test_billing_service.py","services/test_clear_free_plan_tenant_expired_logs.py",- "services/test_conversation_service.py","services/knowledge/test_dataset_service.py","services/data_source/test_provider_service.py","services/knowledge/external/test_service.py","services/test_file_service.py","services/test_human_input_delivery_test_service.py","services/test_knowledge_retrieval_inner_service.py",- "services/model_provider/test_service.py","services/trigger/test_schedule_service.py","services/test_snippet_dsl_service.py","services/test_snippet_generate_service.py",@@ -325,7 +320,6 @@ project-excludes = ["services/knowledge/summaries/test_adapters.py","services/trigger/test_trigger_provider_service.py","services/trigger/test_webhook_service.py",- "services/data_source/test_website_service.py","services/test_workflow_collaboration_service.py","services/test_workflow_node_execution_trace_service.py","services/test_workflow_service.py",diff --git a/api/tests/unit_tests/services/data_source/test_website_service.py b/api/tests/unit_tests/services/data_source/test_website_service.pyindex 2be7df041ff..1d1ef216606 100644--- a/api/tests/unit_tests/services/data_source/test_website_service.py+++ b/api/tests/unit_tests/services/data_source/test_website_service.py@@ -463,7 +463,12 @@ def test_get_crawl_status_typed_rejects_invalid_provider(monkeypatch: pytest.Mondef test_get_firecrawl_status_adds_time_consuming_when_completed_and_cached(monkeypatch: pytest.MonkeyPatch) -> None:firecrawl_instance = MagicMock()- firecrawl_instance.check_crawl_status.return_value = {"status": "completed", "total": 2, "current": 2, "data": []}+ firecrawl_instance.check_crawl_status.return_value = {+ "status": "completed",+ "total": 2,+ "current": 2,+ "data": list[dict[str, Any]](),+ }monkeypatch.setattr(website_service_module, "FirecrawlApp", MagicMock(return_value=firecrawl_instance))redis_mock = MagicMock()@@ -481,7 +486,12 @@ def test_get_firecrawl_status_adds_time_consuming_when_completed_and_cached(monkdef test_get_firecrawl_status_completed_without_cache_does_not_add_time(monkeypatch: pytest.MonkeyPatch) -> None:firecrawl_instance = MagicMock()- firecrawl_instance.check_crawl_status.return_value = {"status": "completed", "total": 1, "current": 1, "data": []}+ firecrawl_instance.check_crawl_status.return_value = {+ "status": "completed",+ "total": 1,+ "current": 1,+ "data": list[dict[str, Any]](),+ }monkeypatch.setattr(website_service_module, "FirecrawlApp", MagicMock(return_value=firecrawl_instance))redis_mock = MagicMock()@@ -536,8 +546,8 @@ def test_get_jinareader_status_completed_formats_processed_items(monkeypatch: py"data": {"status": "completed","urls": ["u1"],- "processed": {"u1": {}},- "failed": {},+ "processed": {"u1": dict[str, Any]()},+ "failed": dict[str, Any](),"duration": 1000,}}@@ -687,7 +697,7 @@ def test_get_jinareader_url_data_without_job_id_failure(monkeypatch: pytest.Monkdef test_get_jinareader_url_data_with_job_id_completed_returns_matching_item(monkeypatch: pytest.MonkeyPatch) -> None:- status_payload = {"data": {"status": "completed", "processed": {"u1": {}}}}+ status_payload = {"data": {"status": "completed", "processed": {"u1": dict[str, Any]()}}}processed_payload = {"data": {"processed": {"u1": {"data": {"url": "u", "title": "t"}}}}}post_mock = MagicMock(side_effect=[_DummyHttpxResponse(status_payload), _DummyHttpxResponse(processed_payload)])@@ -708,7 +718,7 @@ def test_get_jinareader_url_data_with_job_id_not_completed_raises(monkeypatch: pdef test_get_jinareader_url_data_with_job_id_completed_but_not_found_returns_none(monkeypatch: pytest.MonkeyPatch,) -> None:- status_payload = {"data": {"status": "completed", "processed": {"u1": {}}}}+ status_payload = {"data": {"status": "completed", "processed": {"u1": dict[str, Any]()}}}processed_payload = {"data": {"processed": {"u1": {"data": {"url": "other"}}}}}post_mock = MagicMock(side_effect=[_DummyHttpxResponse(status_payload), _DummyHttpxResponse(processed_payload)])diff --git a/api/tests/unit_tests/services/model_provider/test_service.py b/api/tests/unit_tests/services/model_provider/test_service.pyindex 4fcd5638c49..aa2418ab1d5 100644--- a/api/tests/unit_tests/services/model_provider/test_service.py+++ b/api/tests/unit_tests/services/model_provider/test_service.py@@ -1,4 +1,5 @@import types+from collections.abc import Callable, Sequencefrom types import SimpleNamespacefrom typing import Anyfrom unittest.mock import MagicMock, create_autospec@@ -9,15 +10,30 @@ from sqlalchemy.engine import Enginefrom sqlalchemy.exc import IntegrityErrorfrom sqlalchemy.orm import Session-from core.entities.model_entities import ModelStatus, ModelWithProviderEntity, SimpleModelProviderEntity+from core.entities.model_entities import (+ ModelStatus,+ ModelWithProviderEntity,+ SimpleModelProviderEntity,+)from core.entities.provider_configuration import ProviderConfigurations-from core.entities.provider_entities import CredentialConfiguration, CustomModelConfiguration+from core.entities.provider_entities import (+ CredentialConfiguration,+ CustomModelConfiguration,+)from core.plugin.entities.plugin import PluginInstallationSourcefrom core.plugin.entities.plugin_daemon import PluginModelProviderBindingfrom enums import DeploymentEditionfrom graphon.model_runtime.entities.common_entities import I18nObject-from graphon.model_runtime.entities.model_entities import FetchFrom, ModelType, ParameterRule, ParameterType-from graphon.model_runtime.entities.provider_entities import ConfigurateMethod, ProviderEntity+from graphon.model_runtime.entities.model_entities import (+ FetchFrom,+ ModelType,+ ParameterRule,+ ParameterType,+)+from graphon.model_runtime.entities.provider_entities import (+ ConfigurateMethod,+ ProviderEntity,+)from models.account import Account, TenantAccountRolefrom models.provider import (Provider,@@ -33,11 +49,64 @@ from services.model_provider import service as service_modulefrom services.model_provider.service import ModelProviderService, _ProviderSummaryState-def _create_service_with_mocked_manager() -> tuple[ModelProviderService, MagicMock]:- manager = MagicMock()+class _RecordingConfigurations:+ """Test double for ProviderConfigurations that records get_models calls."""++ def __init__(self) -> None:+ self.models: Sequence[object] = []+ self.get_models_impl: Callable[..., Sequence[object]] | None = None+ self.get_models_calls: list[dict[str, object]] = []++ def get_models(self, **kwargs: object) -> Sequence[object]:+ self.get_models_calls.append(kwargs)+ if self.get_models_impl is not None:+ return self.get_models_impl(**kwargs)+ return self.models+++class _RecordingProviderManager:+ """Test double for ProviderManager that records calls instead of using mocks."""++ def __init__(self, configurations: object | None = None) -> None:+ self.configurations: object = configurations if configurations is not None else _RecordingConfigurations()+ self.get_configurations_error: Exception | None = None+ self.get_configurations_calls: list[str] = []+ self.get_default_model_result: object | None = None+ self.get_default_model_error: Exception | None = None+ self.get_default_model_calls: list[dict[str, object]] = []+ self.update_default_model_record_calls: list[dict[str, object]] = []++ def get_configurations(self, tenant_id: str) -> object:+ self.get_configurations_calls.append(tenant_id)+ if self.get_configurations_error is not None:+ raise self.get_configurations_error+ return self.configurations++ def get_default_model(self, *, tenant_id: str, model_type: ModelType) -> object | None:+ self.get_default_model_calls.append({"tenant_id": tenant_id, "model_type": model_type})+ if self.get_default_model_error is not None:+ raise self.get_default_model_error+ return self.get_default_model_result++ def update_default_model_record(self, *, tenant_id: str, model_type: ModelType, provider: str, model: str) -> None:+ self.update_default_model_record_calls.append(+ {+ "tenant_id": tenant_id,+ "model_type": model_type,+ "provider": provider,+ "model": model,+ }+ )+++def _create_service_with_fake_manager(+ monkeypatch: pytest.MonkeyPatch,+) -> tuple[ModelProviderService, _RecordingProviderManager, _RecordingConfigurations]:+ configurations = _RecordingConfigurations()+ manager = _RecordingProviderManager(configurations)service = ModelProviderService()- service._get_provider_manager = MagicMock(return_value=manager)- return service, manager+ monkeypatch.setattr(service, "_get_provider_manager", lambda _tenant_id: manager)+ return service, manager, configurationsdef _build_available_llm(model: str) -> ModelWithProviderEntity:@@ -121,12 +190,17 @@ class TestModelProviderServiceCases:@staticmethod@pytest.mark.parametrize("has_active_models", [True, False])def test_initialize_default_llm_selects_first_active_model_once(- sqlite_session: Session, has_active_models: bool+ sqlite_session: Session,+ has_active_models: bool,+ monkeypatch: pytest.MonkeyPatch,) -> None:sqlite_session.add_all([TenantDefaultModel(- tenant_id="other-tenant", model_type=ModelType.LLM, provider_name="other", model_name="other-model"+ tenant_id="other-tenant",+ model_type=ModelType.LLM,+ provider_name="other",+ model_name="other-model",),TenantDefaultModel(tenant_id="tenant-1",@@ -137,10 +211,9 @@ class TestModelProviderServiceCases:])sqlite_session.commit()- service, manager = _create_service_with_mocked_manager()+ service, _manager, configurations = _create_service_with_fake_manager(monkeypatch)models = [_build_available_llm("gpt-4o-mini"), _build_available_llm("gpt-4o")] if has_active_models else []- configurations = manager.get_configurations.return_value- configurations.get_models.return_value = models+ configurations.models = modelsservice.initialize_default_llm("tenant-1")service.initialize_default_llm("tenant-1")@@ -152,33 +225,52 @@ class TestModelProviderServiceCases:if has_active_models:expected_defaults.add(("tenant-1", ModelType.LLM, "langgenius/openai/openai", "gpt-4o-mini"))assert {- (record.tenant_id, record.model_type, record.provider_name, record.model_name)+ (+ record.tenant_id,+ record.model_type,+ record.provider_name,+ record.model_name,+ )for record in sqlite_session.query(TenantDefaultModel).all()} == expected_defaults- assert configurations.get_models.call_count == (1 if has_active_models else 2)- configurations.get_models.assert_called_with(model_type=ModelType.LLM, only_active=True)+ assert len(configurations.get_models_calls) == (1 if has_active_models else 2)+ assert configurations.get_models_calls[-1] == {+ "model_type": ModelType.LLM,+ "only_active": True,+ }@staticmethod- def test_initialize_default_llm_preserves_existing_selection(sqlite_session: Session) -> None:+ def test_initialize_default_llm_preserves_existing_selection(+ sqlite_session: Session, monkeypatch: pytest.MonkeyPatch+ ) -> None:saved_default = TenantDefaultModel(- tenant_id="tenant-1", model_type=ModelType.LLM, provider_name="chosen-provider", model_name="chosen-model"+ tenant_id="tenant-1",+ model_type=ModelType.LLM,+ provider_name="chosen-provider",+ model_name="chosen-model",)sqlite_session.add(saved_default)sqlite_session.commit()- service, manager = _create_service_with_mocked_manager()+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)service.initialize_default_llm("tenant-1")- manager.get_configurations.assert_not_called()+ assert manager.get_configurations_calls == []sqlite_session.refresh(saved_default)- assert (saved_default.provider_name, saved_default.model_name) == ("chosen-provider", "chosen-model")+ assert (saved_default.provider_name, saved_default.model_name) == (+ "chosen-provider",+ "chosen-model",+ )@staticmethod@pytest.mark.parametrize("selection_time", ["discovery", "insert"])def test_initialize_default_llm_preserves_concurrent_selection(- sqlite_session: Session, sqlite_engine: Engine, selection_time: str+ sqlite_session: Session,+ sqlite_engine: Engine,+ selection_time: str,+ monkeypatch: pytest.MonkeyPatch,) -> None:- service, manager = _create_service_with_mocked_manager()+ service, _manager, configurations = _create_service_with_fake_manager(monkeypatch)selected = Falsedef save_selection() -> None:@@ -201,10 +293,15 @@ class TestModelProviderServiceCases:save_selection()return [_build_available_llm("gpt-4o-mini")]- manager.get_configurations.return_value.get_models.side_effect = discover_models+ configurations.get_models_impl = discover_modelsdef select_before_insert(- _connection: Any, _cursor: Any, statement: str, _parameters: Any, _context: Any, _executemany: bool+ _connection: Any,+ _cursor: Any,+ statement: str,+ _parameters: Any,+ _context: Any,+ _executemany: bool,) -> None:if (selection_time == "insert"@@ -222,12 +319,17 @@ class TestModelProviderServiceCases:defaults = sqlite_session.query(TenantDefaultModel).all()assert selectedassert len(defaults) == 1- assert (defaults[0].provider_name, defaults[0].model_name) == ("chosen-provider", "chosen-model")+ assert (defaults[0].provider_name, defaults[0].model_name) == (+ "chosen-provider",+ "chosen-model",+ )@staticmethod- def test_initialize_default_llm_propagates_database_failure(sqlite_session: Session, sqlite_engine: Engine) -> None:- service, manager = _create_service_with_mocked_manager()- manager.get_configurations.return_value.get_models.return_value = [_build_available_llm("gpt-4o-mini")]+ def test_initialize_default_llm_propagates_database_failure(+ sqlite_session: Session, sqlite_engine: Engine, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ service, _manager, configurations = _create_service_with_fake_manager(monkeypatch)+ configurations.models = [_build_available_llm("gpt-4o-mini")]with sqlite_engine.begin() as connection:connection.exec_driver_sql("CREATE TRIGGER reject_default_model BEFORE INSERT ON tenant_default_models "@@ -240,8 +342,10 @@ class TestModelProviderServiceCases:assert sqlite_session.query(TenantDefaultModel).count() == 0@staticmethod- def test_available_credentials_use_injected_query_for_admin_viewer() -> None:- service, manager = _create_service_with_mocked_manager()+ def test_available_credentials_use_injected_query_for_admin_viewer(+ monkeypatch: pytest.MonkeyPatch,+ ) -> None:+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)user = Account(name="Admin", email="[email protected]")user.id = "actor"user.role = TenantAccountRole.ADMIN@@ -252,27 +356,33 @@ class TestModelProviderServiceCases:query.list_models.assert_called_once_with(workspace_id="tenant", provider="openai", actor_id="actor")assert result == [CredentialConfiguration(credential_id="credential", credential_name="Shared credential")]- assert manager.mock_calls == []+ assert manager.get_configurations_calls == []class TestModelProviderServiceConfiguration:- def test__get_provider_configuration_should_return_configuration_when_provider_exists(self) -> None:- service, manager = _create_service_with_mocked_manager()+ def test__get_provider_configuration_should_return_configuration_when_provider_exists(+ self, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)provider_configuration = SimpleNamespace(name="provider-config")- manager.get_configurations.return_value = {"openai": provider_configuration}+ manager.configurations = {"openai": provider_configuration}result = service._get_provider_configuration(tenant_id="tenant-1", provider="openai")assert result is provider_configuration- def test__get_provider_configuration_should_raise_error_when_provider_is_missing(self) -> None:- service, manager = _create_service_with_mocked_manager()- manager.get_configurations.return_value = {}+ def test__get_provider_configuration_should_raise_error_when_provider_is_missing(+ self, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)+ manager.configurations = dict[str, Any]()with pytest.raises(ProviderNotFoundError, match="does not exist"):service._get_provider_configuration(tenant_id="tenant-1", provider="missing")- def test_get_provider_list_should_filter_by_model_type_and_build_no_configure_status(self) -> None:- service, manager = _create_service_with_mocked_manager()+ def test_get_provider_list_should_filter_by_model_type_and_build_no_configure_status(+ self, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)allowed = _build_provider_configuration(provider_name="openai",supported_model_types=[ModelType.LLM],@@ -283,7 +393,7 @@ class TestModelProviderServiceCases:supported_model_types=[ModelType.TEXT_EMBEDDING],custom_config_available=True,)- manager.get_configurations.return_value = {"openai": allowed, "embedding": filtered}+ manager.configurations = {"openai": allowed, "embedding": filtered}result = service.get_provider_list(tenant_id="tenant-1", model_type=ModelType.LLM)@@ -450,7 +560,11 @@ class TestModelProviderServiceCases:"fetch_plugin_model_providers",MagicMock(return_value=provider_entities),)- monkeypatch.setattr(ModelProviderService, "_load_provider_summary_states", MagicMock(return_value={}))+ monkeypatch.setattr(+ ModelProviderService,+ "_load_provider_summary_states",+ MagicMock(return_value={}),+ )monkeypatch.setattr(service_module, "is_filtered", MagicMock(return_value=False))providers, _ = ModelProviderService().get_provider_summary_list("tenant-1")@@ -463,7 +577,9 @@ class TestModelProviderServiceCases:"langgenius/unverified/openai": False,}- def test_model_provider_binding_without_verified_field_fails_closed(self) -> None:+ def test_model_provider_binding_without_verified_field_fails_closed(+ self,+ ) -> None:binding = PluginModelProviderBinding.model_validate({"provider": "openai",@@ -643,7 +759,14 @@ class TestModelProviderServiceCases:sqlite_session.commit()statements: list[str] = []- def capture_statement(_connection, _cursor, statement, _parameters, _context, _executemany) -> None:+ def capture_statement(+ _connection,+ _cursor,+ statement: str,+ _parameters,+ _context,+ _executemany,+ ) -> None:statements.append(statement)event.listen(sqlite_engine, "before_cursor_execute", capture_statement)@@ -679,7 +802,7 @@ class TestModelProviderServiceCases:assert "provider_model_credentials" in statements[2]def test_list_models_should_pass_filters_through(self, monkeypatch: pytest.MonkeyPatch) -> None:- service, manager = _create_service_with_mocked_manager()+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)filters: list[dict[str, object]] = []def get_models(_self: ProviderConfigurations, **kwargs: object) -> list[ModelWithProviderEntity]:@@ -687,13 +810,15 @@ class TestModelProviderServiceCases:return []monkeypatch.setattr(ProviderConfigurations, "get_models", get_models)- manager.get_configurations.return_value = ProviderConfigurations(tenant_id="tenant-1")+ manager.configurations = ProviderConfigurations(tenant_id="tenant-1")assert service.list_models("tenant-1", provider=None, model_type=ModelType.LLM) == []assert filters == [{"provider": None, "model_type": ModelType.LLM}]- def test_get_models_by_provider_should_wrap_model_entities_with_tenant_context(self) -> None:- service, manager = _create_service_with_mocked_manager()+ def test_get_models_by_provider_should_wrap_model_entities_with_tenant_context(+ self, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)class _Model:def __init__(self, model_name: str) -> None:@@ -723,7 +848,7 @@ class TestModelProviderServiceCases:provider_configurations = SimpleNamespace(get_models=MagicMock(return_value=[_Model("gpt-4o"), _Model("gpt-4o-mini")]))- manager.get_configurations.return_value = provider_configurations+ manager.configurations = provider_configurationsresult = service.get_models_by_provider(tenant_id="tenant-1", provider="openai")@@ -734,18 +859,32 @@ class TestModelProviderServiceCases:class TestModelProviderServiceDelegation:@pytest.mark.parametrize(- ("method_name", "method_kwargs", "provider_method_name", "provider_call_kwargs", "provider_return"),+ (+ "method_name",+ "method_kwargs",+ "provider_method_name",+ "provider_call_kwargs",+ "provider_return",+ ),[("get_provider_credential",- {"tenant_id": "tenant-1", "provider": "openai", "credential_id": "cred-1"},+ {+ "tenant_id": "tenant-1",+ "provider": "openai",+ "credential_id": "cred-1",+ },"get_provider_credential",{"credential_id": "cred-1"},{"token": "abc"},),("validate_provider_credentials",- {"tenant_id": "tenant-1", "provider": "openai", "credentials": {"token": "abc"}},+ {+ "tenant_id": "tenant-1",+ "provider": "openai",+ "credentials": {"token": "abc"},+ },"validate_provider_credentials",({"token": "abc"},),None,@@ -772,19 +911,31 @@ class TestModelProviderServiceCases:"credential_name": "B",},"update_provider_credential",- {"credential_id": "cred-1", "credentials": {"token": "abc"}, "credential_name": "B"},+ {+ "credential_id": "cred-1",+ "credentials": {"token": "abc"},+ "credential_name": "B",+ },None,),("remove_provider_credential",- {"tenant_id": "tenant-1", "provider": "openai", "credential_id": "cred-1"},+ {+ "tenant_id": "tenant-1",+ "provider": "openai",+ "credential_id": "cred-1",+ },"delete_provider_credential",{"credential_id": "cred-1"},None,),("switch_active_provider_credential",- {"tenant_id": "tenant-1", "provider": "openai", "credential_id": "cred-1"},+ {+ "tenant_id": "tenant-1",+ "provider": "openai",+ "credential_id": "cred-1",+ },"switch_active_provider_credential",{"credential_id": "cred-1"},None,@@ -823,7 +974,13 @@ class TestModelProviderServiceCases:assert result == "new-credential-id"@pytest.mark.parametrize(- ("method_name", "method_kwargs", "provider_method_name", "expected_kwargs", "provider_return"),+ (+ "method_name",+ "method_kwargs",+ "provider_method_name",+ "expected_kwargs",+ "provider_return",+ ),[("get_model_credential",@@ -835,7 +992,11 @@ class TestModelProviderServiceCases:"credential_id": "cred-1",},"get_custom_model_credential",- {"model_type": ModelType.LLM, "model": "gpt-4o", "credential_id": "cred-1"},+ {+ "model_type": ModelType.LLM,+ "model": "gpt-4o",+ "credential_id": "cred-1",+ },{"api_key": "x"},),(@@ -848,7 +1009,11 @@ class TestModelProviderServiceCases:"credentials": {"api_key": "x"},},"validate_custom_model_credentials",- {"model_type": ModelType.LLM, "model": "gpt-4o", "credentials": {"api_key": "x"}},+ {+ "model_type": ModelType.LLM,+ "model": "gpt-4o",+ "credentials": {"api_key": "x"},+ },None,),(@@ -901,7 +1066,11 @@ class TestModelProviderServiceCases:"credential_id": "cred-1",},"delete_custom_model_credential",- {"model_type": ModelType.LLM, "model": "gpt-4o", "credential_id": "cred-1"},+ {+ "model_type": ModelType.LLM,+ "model": "gpt-4o",+ "credential_id": "cred-1",+ },None,),(@@ -914,7 +1083,11 @@ class TestModelProviderServiceCases:"credential_id": "cred-1",},"switch_custom_model_credential",- {"model_type": ModelType.LLM, "model": "gpt-4o", "credential_id": "cred-1"},+ {+ "model_type": ModelType.LLM,+ "model": "gpt-4o",+ "credential_id": "cred-1",+ },None,),(@@ -927,7 +1100,11 @@ class TestModelProviderServiceCases:"credential_id": "cred-1",},"add_model_credential_to_model",- {"model_type": ModelType.LLM, "model": "gpt-4o", "credential_id": "cred-1"},+ {+ "model_type": ModelType.LLM,+ "model": "gpt-4o",+ "credential_id": "cred-1",+ },None,),(@@ -981,7 +1158,11 @@ class TestModelProviderServiceCases:"credential_id": "cred-1",},"get_custom_model_credential",- {"model_type": ModelType.LLM, "model": "gpt-4o", "credential_id": "cred-1"},+ {+ "model_type": ModelType.LLM,+ "model": "gpt-4o",+ "credential_id": "cred-1",+ },),("create_model_credential",@@ -1033,8 +1214,10 @@ class TestModelProviderServiceCases:getattr(provider_configuration, provider_method_name).assert_called_once_with(**expected_kwargs)class TestModelProviderServiceListingsAndDefaults:- def test_get_models_by_model_type_should_group_active_non_deprecated_models(self) -> None:- service, manager = _create_service_with_mocked_manager()+ def test_get_models_by_model_type_should_group_active_non_deprecated_models(+ self, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)openai_provider = SimpleNamespace(provider="openai",label=I18nObject(en_US="OpenAI"),@@ -1086,7 +1269,7 @@ class TestModelProviderServiceCases:),]provider_configurations = SimpleNamespace(get_models=MagicMock(return_value=models))- manager.get_configurations.return_value = provider_configurations+ manager.configurations = provider_configurationsresult = service.get_models_by_model_type(tenant_id="tenant-1", model_type=ModelType.LLM)@@ -1127,7 +1310,11 @@ class TestModelProviderServiceCases:provider_configuration = MagicMock()provider_configuration.get_current_credentials.return_value = credentialsprovider_configuration.get_model_schema.return_value = schema- monkeypatch.setattr(service, "_get_provider_configuration", MagicMock(return_value=provider_configuration))+ monkeypatch.setattr(+ service,+ "_get_provider_configuration",+ MagicMock(return_value=provider_configuration),+ )result = service.get_model_parameter_rules(tenant_id="tenant-1", provider="openai", model="gpt-4o")@@ -1145,7 +1332,9 @@ class TestModelProviderServiceCases:else:provider_configuration.get_model_schema.assert_not_called()- def test_get_default_model_selection_uses_saved_workspace_choice(self, sqlite_session: Session) -> None:+ def test_get_default_model_selection_uses_saved_workspace_choice(+ self, sqlite_session: Session, monkeypatch: pytest.MonkeyPatch+ ) -> None:sqlite_session.add(TenantDefaultModel(tenant_id="tenant-1",@@ -1155,52 +1344,56 @@ class TestModelProviderServiceCases:))sqlite_session.commit()- service, manager = _create_service_with_mocked_manager()+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)result = service.get_default_model_selection("tenant-1", ModelType.LLM, session=sqlite_session)assert result == ("langgenius/openai/openai", "gpt-4o")- manager.get_configurations.assert_not_called()+ assert manager.get_configurations_calls == []def test_get_default_model_selection_uses_first_active_model_without_writing(- self, sqlite_session: Session+ self, sqlite_session: Session, monkeypatch: pytest.MonkeyPatch) -> None:- service, manager = _create_service_with_mocked_manager()- configurations = manager.get_configurations.return_value- configurations.get_models.return_value = [- SimpleNamespace(model="gpt-4o", provider=SimpleNamespace(provider="langgenius/openai/openai"))+ service, _manager, configurations = _create_service_with_fake_manager(monkeypatch)+ configurations.models = [+ SimpleNamespace(+ model="gpt-4o",+ provider=SimpleNamespace(provider="langgenius/openai/openai"),+ )]result = service.get_default_model_selection("tenant-1", ModelType.LLM, session=sqlite_session)assert result == ("langgenius/openai/openai", "gpt-4o")- configurations.get_models.assert_called_once_with(model_type=ModelType.LLM, only_active=True)+ assert configurations.get_models_calls == [{"model_type": ModelType.LLM, "only_active": True}]assert sqlite_session.query(TenantDefaultModel).filter_by(tenant_id="tenant-1").first() is Nonedef test_get_default_model_selection_returns_none_when_provider_discovery_fails(- self, sqlite_session: Session+ self, sqlite_session: Session, monkeypatch: pytest.MonkeyPatch) -> None:- service, manager = _create_service_with_mocked_manager()- manager.get_configurations.side_effect = RuntimeError("provider unavailable")+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)+ manager.get_configurations_error = RuntimeError("provider unavailable")result = service.get_default_model_selection("tenant-1", ModelType.LLM, session=sqlite_session)assert result is None- def test_get_default_model_selection_returns_none_when_no_active_models(self, sqlite_session: Session) -> None:- service, manager = _create_service_with_mocked_manager()- manager.get_configurations.return_value.get_models.return_value = []+ def test_get_default_model_selection_returns_none_when_no_active_models(+ self, sqlite_session: Session, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ service, _manager, configurations = _create_service_with_fake_manager(monkeypatch)+ configurations.models = []result = service.get_default_model_selection("tenant-1", ModelType.LLM, session=sqlite_session)assert result is None- manager.get_configurations.return_value.get_models.assert_called_once_with(- model_type=ModelType.LLM, only_active=True- )+ assert configurations.get_models_calls == [{"model_type": ModelType.LLM, "only_active": True}]- def test_get_default_model_of_model_type_should_return_response_when_manager_returns_model(self) -> None:- service, manager = _create_service_with_mocked_manager()- manager.get_default_model.return_value = SimpleNamespace(+ def test_get_default_model_of_model_type_should_return_response_when_manager_returns_model(+ self, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)+ manager.get_default_model_result = SimpleNamespace(model="gpt-4o",model_type=ModelType.LLM,provider=SimpleNamespace(@@ -1216,19 +1409,23 @@ class TestModelProviderServiceCases:assert result is not Noneassert result.model == "gpt-4o"assert result.provider.provider == "openai"- manager.get_default_model.assert_called_once_with(tenant_id="tenant-1", model_type=ModelType.LLM)+ assert manager.get_default_model_calls == [{"tenant_id": "tenant-1", "model_type": ModelType.LLM}]- def test_get_default_model_of_model_type_should_return_none_when_manager_returns_none(self) -> None:- service, manager = _create_service_with_mocked_manager()- manager.get_default_model.return_value = None+ def test_get_default_model_of_model_type_should_return_none_when_manager_returns_none(+ self, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)result = service.get_default_model_of_model_type(tenant_id="tenant-1", model_type=ModelType.LLM)assert result is None+ assert manager.get_default_model_calls == [{"tenant_id": "tenant-1", "model_type": ModelType.LLM}]- def test_get_default_model_of_model_type_should_return_none_when_no_configuration_is_saved(self) -> None:- service, manager = _create_service_with_mocked_manager()- manager.get_default_model.side_effect = RuntimeError("boom")+ def test_get_default_model_of_model_type_should_return_none_when_no_configuration_is_saved(+ self, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)+ manager.get_default_model_error = RuntimeError("boom")result = service.get_default_model_of_model_type(tenant_id="tenant-1", model_type=ModelType.LLM)@@ -1236,10 +1433,16 @@ class TestModelProviderServiceCases:@pytest.mark.parametrize("error",- [ValueError("Invalid provider: langgenius/openai/openai"), RuntimeError("Plugin daemon unavailable")],+ [+ ValueError("Invalid provider: langgenius/openai/openai"),+ RuntimeError("Plugin daemon unavailable"),+ ],)def test_get_default_model_of_model_type_should_preserve_saved_configuration_on_provider_failure(- self, sqlite_session: Session, error: Exception+ self,+ sqlite_session: Session,+ error: Exception,+ monkeypatch: pytest.MonkeyPatch,) -> None:saved_model = TenantDefaultModel(tenant_id="tenant-1",@@ -1249,8 +1452,8 @@ class TestModelProviderServiceCases:)sqlite_session.add(saved_model)sqlite_session.commit()- service, manager = _create_service_with_mocked_manager()- manager.get_default_model.side_effect = error+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)+ manager.get_default_model_error = errorresult = service.get_default_model_of_model_type(tenant_id="tenant-1", model_type=ModelType.LLM)@@ -1273,7 +1476,11 @@ class TestModelProviderServiceCases:[("other-tenant", ModelType.LLM), ("tenant-1", ModelType.TEXT_EMBEDDING)],)def test_get_default_model_of_model_type_should_not_fall_back_to_another_tenant_or_model_type(- self, sqlite_session: Session, tenant_id: str, model_type: ModelType+ self,+ sqlite_session: Session,+ tenant_id: str,+ model_type: ModelType,+ monkeypatch: pytest.MonkeyPatch,) -> None:sqlite_session.add(TenantDefaultModel(@@ -1284,15 +1491,17 @@ class TestModelProviderServiceCases:))sqlite_session.commit()- service, manager = _create_service_with_mocked_manager()- manager.get_default_model.side_effect = ValueError("Invalid provider: langgenius/openai/openai")+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)+ manager.get_default_model_error = ValueError("Invalid provider: langgenius/openai/openai")result = service.get_default_model_of_model_type(tenant_id="tenant-1", model_type=ModelType.LLM)assert result is None- def test_update_default_model_of_model_type_should_delegate_to_provider_manager(self) -> None:- service, manager = _create_service_with_mocked_manager()+ def test_update_default_model_of_model_type_should_delegate_to_provider_manager(+ self, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ service, manager, _configurations = _create_service_with_fake_manager(monkeypatch)service.update_default_model_of_model_type(tenant_id="tenant-1",@@ -1301,12 +1510,14 @@ class TestModelProviderServiceCases:model="gpt-4o",)- manager.update_default_model_record.assert_called_once_with(- tenant_id="tenant-1",- model_type=ModelType.LLM,- provider="openai",- model="gpt-4o",- )+ assert manager.update_default_model_record_calls == [+ {+ "tenant_id": "tenant-1",+ "model_type": ModelType.LLM,+ "provider": "openai",+ "model": "gpt-4o",+ }+ ]def test_get_model_provider_icon_should_fetch_icon_bytes_from_factory(self,@@ -1314,9 +1525,16 @@ class TestModelProviderServiceCases:) -> None:service = ModelProviderService()factory_instance = MagicMock()- factory_instance.get_provider_icon.return_value = (b"icon-bytes", "image/png")+ factory_instance.get_provider_icon.return_value = (+ b"icon-bytes",+ "image/png",+ )factory_constructor = MagicMock(return_value=factory_instance)- monkeypatch.setattr(service_module, "create_plugin_model_provider_factory", factory_constructor)+ monkeypatch.setattr(+ service_module,+ "create_plugin_model_provider_factory",+ factory_constructor,+ )result = service.get_model_provider_icon(tenant_id="tenant-1",@@ -1335,7 +1553,11 @@ class TestModelProviderServiceCases:) -> None:service = ModelProviderService()provider_configuration = MagicMock()- monkeypatch.setattr(service, "_get_provider_configuration", MagicMock(return_value=provider_configuration))+ monkeypatch.setattr(+ service,+ "_get_provider_configuration",+ MagicMock(return_value=provider_configuration),+ )service.switch_preferred_provider(tenant_id="tenant-1",@@ -1360,7 +1582,11 @@ class TestModelProviderServiceCases:) -> None:service = ModelProviderService()provider_configuration = MagicMock()- monkeypatch.setattr(service, "_get_provider_configuration", MagicMock(return_value=provider_configuration))+ monkeypatch.setattr(+ service,+ "_get_provider_configuration",+ MagicMock(return_value=provider_configuration),+ )getattr(service, method_name)(tenant_id="tenant-1",@@ -1386,7 +1612,9 @@ class _FakeConfigurations:class TestModelProviderServiceSanitizationCases:@staticmethod@pytest.fixture- def service_with_fake_configurations(monkeypatch: pytest.MonkeyPatch) -> ModelProviderService:+ def service_with_fake_configurations(+ monkeypatch: pytest.MonkeyPatch,+ ) -> ModelProviderService:# Build a fake provider schema with minimal fields used by ProviderResponsefake_provider = types.SimpleNamespace(provider="langgenius/openai_api_compatible/openai_api_compatible",@@ -1444,7 +1672,9 @@ class TestModelProviderServiceSanitizationCases:return svc@staticmethod- def test_get_provider_list_strips_credentials(service_with_fake_configurations: ModelProviderService) -> None:+ def test_get_provider_list_strips_credentials(+ service_with_fake_configurations: ModelProviderService,+ ) -> None:providers = service_with_fake_configurations.get_provider_list(tenant_id="tenant-1", model_type=None)assert len(providers) == 1diff --git a/api/tests/unit_tests/services/test_app_task_service.py b/api/tests/unit_tests/services/test_app_task_service.pyindex dcb16e19f8c..48320d3c900 100644--- a/api/tests/unit_tests/services/test_app_task_service.py+++ b/api/tests/unit_tests/services/test_app_task_service.py@@ -39,7 +39,6 @@ from extensions.logstore.aliyun_logstore import AliyunLogStorefrom graphon.engine.command import AbortCommandfrom graphon.entities import WorkflowNodeExecutionfrom graphon.enums import WorkflowExecutionStatus, WorkflowNodeExecutionStatus-from graphon.enums import WorkflowType as _paused_workflow_stop_WorkflowTypefrom libs.broadcast_channel.redis.pubsub_channel import Topicfrom models import EndUserfrom models.enums import CreatorUserRole, WorkflowRunTriggeredFrom@@ -1128,7 +1127,7 @@ class TestPausedWorkflowStopCases:tenant_id="tenant-1",app_id="app-1",workflow_id="workflow-1",- type=_paused_workflow_stop_WorkflowType.WORKFLOW,+ type=ModelWorkflowType.WORKFLOW,triggered_from=WorkflowRunTriggeredFrom.APP_RUN,version="1",status=WorkflowExecutionStatus.PAUSED,@@ -1262,7 +1261,7 @@ class TestPausedWorkflowStopCases:tenant_id="tenant-1",app_id="app-1",workflow_id="workflow-1",- type=_paused_workflow_stop_WorkflowType.WORKFLOW,+ type=ModelWorkflowType.WORKFLOW,triggered_from=WorkflowRunTriggeredFrom.APP_RUN,version="1",status=WorkflowExecutionStatus.PAUSED,@@ -1316,7 +1315,7 @@ class TestPausedWorkflowStopCases:app_id="app-1",workflow_id="workflow-1",task_id=task_id,- type=_paused_workflow_stop_WorkflowType.WORKFLOW,+ type=ModelWorkflowType.WORKFLOW,triggered_from=WorkflowRunTriggeredFrom.APP_RUN,version="1",status=WorkflowExecutionStatus.RUNNING,diff --git a/api/tests/unit_tests/services/test_conversation_service.py b/api/tests/unit_tests/services/test_conversation_service.pyindex 21a1742b83e..4fc0197f1af 100644--- a/api/tests/unit_tests/services/test_conversation_service.py+++ b/api/tests/unit_tests/services/test_conversation_service.py@@ -61,7 +61,7 @@ class ConversationServiceTestDataFactory:"""@staticmethod- def create_account(account_id: str = ACCOUNT_ID, **kwargs) -> Account:+ def create_account(account_id: str = ACCOUNT_ID, **kwargs) -> Account: # pyrefly: ignore[implicit-any-parameter]"""Create an Account object.@@ -79,39 +79,44 @@ class ConversationServiceTestDataFactory:return account@staticmethod- def create_app(app_id: str = APP_ID, tenant_id: str = TENANT_ID, **kwargs) -> App:+ def create_app(+ app_id: str = APP_ID,+ tenant_id: str = TENANT_ID,+ name: str = "Test App",+ mode: AppMode = AppMode.CHAT,+ status: AppStatus = AppStatus.NORMAL,+ ) -> App:"""Create an App object.Args:app_id: Unique identifier for the apptenant_id: Tenant/workspace identifier- **kwargs: Additional attributes to set on the model+ name: Display name of the app+ mode: App mode+ status: App lifecycle statusReturns:App object with specified attributes"""- app = App(+ return App(id=app_id,tenant_id=tenant_id,- name=kwargs.get("name", "Test App"),- mode=kwargs.get("mode", AppMode.CHAT),- status=kwargs.get("status", AppStatus.NORMAL),+ name=name,+ mode=mode,+ status=status,description="",enable_site=False,enable_api=False,max_active_requests=None,)- for key, value in kwargs.items():- setattr(app, key, value)- return app@staticmethoddef create_conversation(conversation_id: str = CONVERSATION_ID,app_id: str = APP_ID,from_source: ConversationFromSource = ConversationFromSource.CONSOLE,- **kwargs,+ **kwargs, # pyrefly: ignore[implicit-any-parameter]) -> Conversation:"""Create a Conversation object.