Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
test(e2e): annotate two container service tests for strict pyrefly (#45335)
Felix Shi97a43bc0291e
diff --git a/api/tests/e2e_tests/containers/pyrefly.toml b/api/tests/e2e_tests/containers/pyrefly.tomlindex 33e15ec54f1..ae70d736794 100644--- a/api/tests/e2e_tests/containers/pyrefly.toml+++ b/api/tests/e2e_tests/containers/pyrefly.toml@@ -62,9 +62,7 @@ project-excludes = ["services/test_dataset_service_get_segments.py","services/test_dataset_service_permissions.py","services/test_dataset_service_retrieval.py",- "services/test_dataset_service_update_dataset.py","services/test_delete_archived_workflow_run.py",- "services/test_document_service_display_status.py","services/test_document_service_rename_document.py","services/test_end_user_service.py","services/test_feature_service.py",diff --git a/api/tests/e2e_tests/containers/services/test_dataset_service_update_dataset.py b/api/tests/e2e_tests/containers/services/test_dataset_service_update_dataset.pyindex fc67f0a4c65..080024deec6 100644--- a/api/tests/e2e_tests/containers/services/test_dataset_service_update_dataset.py+++ b/api/tests/e2e_tests/containers/services/test_dataset_service_update_dataset.py@@ -154,7 +154,7 @@ class TestDatasetServiceUpdateDataset:# ==================== External Dataset Tests ====================- def test_update_external_dataset_success(self, db_session_with_containers: Session):+ def test_update_external_dataset_success(self, db_session_with_containers: Session) -> None:"""Test successful update of external dataset."""user, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)dataset = DatasetUpdateTestDataFactory.create_dataset(@@ -202,7 +202,7 @@ class TestDatasetServiceUpdateDataset:assert updated_binding.external_knowledge_api_id == update_data["external_knowledge_api_id"]assert result.id == dataset.id- def test_update_external_dataset_missing_knowledge_id_error(self, db_session_with_containers: Session):+ def test_update_external_dataset_missing_knowledge_id_error(self, db_session_with_containers: Session) -> None:"""Test error when external knowledge id is missing."""user, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)dataset = DatasetUpdateTestDataFactory.create_dataset(@@ -226,7 +226,7 @@ class TestDatasetServiceUpdateDataset:assert "External knowledge id is required" in str(context.value)db_session_with_containers.rollback()- def test_update_external_dataset_missing_api_id_error(self, db_session_with_containers: Session):+ def test_update_external_dataset_missing_api_id_error(self, db_session_with_containers: Session) -> None:"""Test error when external knowledge api id is missing."""user, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)dataset = DatasetUpdateTestDataFactory.create_dataset(@@ -250,7 +250,7 @@ class TestDatasetServiceUpdateDataset:assert "External knowledge api id is required" in str(context.value)db_session_with_containers.rollback()- def test_update_external_dataset_binding_not_found_error(self, db_session_with_containers: Session):+ def test_update_external_dataset_binding_not_found_error(self, db_session_with_containers: Session) -> None:"""Test error when external knowledge binding is not found."""user, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)dataset = DatasetUpdateTestDataFactory.create_dataset(@@ -279,7 +279,7 @@ class TestDatasetServiceUpdateDataset:# ==================== Internal Dataset Basic Tests ====================- def test_update_internal_dataset_basic_success(self, db_session_with_containers: Session):+ def test_update_internal_dataset_basic_success(self, db_session_with_containers: Session) -> None:"""Test successful update of internal dataset with basic fields."""user, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)existing_binding_id = str(uuid4())@@ -314,7 +314,7 @@ class TestDatasetServiceUpdateDataset:assert dataset.embedding_model == "text-embedding-ada-002"assert result.id == dataset.id- def test_update_internal_dataset_filter_none_values(self, db_session_with_containers: Session):+ def test_update_internal_dataset_filter_none_values(self, db_session_with_containers: Session) -> None:"""Test that None values are filtered out except for description field."""user, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)existing_binding_id = str(uuid4())@@ -350,7 +350,7 @@ class TestDatasetServiceUpdateDataset:# ==================== Indexing Technique Switch Tests ====================- def test_update_internal_dataset_indexing_technique_to_economy(self, db_session_with_containers: Session):+ def test_update_internal_dataset_indexing_technique_to_economy(self, db_session_with_containers: Session) -> None:"""Test updating internal dataset indexing technique to economy."""user, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)existing_binding_id = str(uuid4())@@ -382,7 +382,9 @@ class TestDatasetServiceUpdateDataset:assert dataset.retrieval_model == "new_model"assert result.id == dataset.id- def test_update_internal_dataset_indexing_technique_to_high_quality(self, db_session_with_containers: Session):+ def test_update_internal_dataset_indexing_technique_to_high_quality(+ self, db_session_with_containers: Session+ ) -> None:"""Test updating internal dataset indexing technique to high_quality."""user, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)dataset = DatasetUpdateTestDataFactory.create_dataset(@@ -440,8 +442,8 @@ class TestDatasetServiceUpdateDataset:# ==================== Embedding Model Update Tests ====================def test_update_internal_dataset_keep_existing_embedding_model_when_indexing_technique_unchanged(- self, db_session_with_containers- ):+ self, db_session_with_containers: Session+ ) -> None:"""Test preserving embedding settings when indexing technique remains unchanged."""user, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)existing_binding_id = str(uuid4())@@ -473,7 +475,7 @@ class TestDatasetServiceUpdateDataset:assert dataset.retrieval_model == "new_model"assert result.id == dataset.id- def test_update_internal_dataset_embedding_model_update(self, db_session_with_containers: Session):+ def test_update_internal_dataset_embedding_model_update(self, db_session_with_containers: Session) -> None:"""Test updating internal dataset with new embedding model."""user, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)existing_binding_id = str(uuid4())@@ -539,7 +541,7 @@ class TestDatasetServiceUpdateDataset:# ==================== Error Handling Tests ====================- def test_update_dataset_not_found_error(self, db_session_with_containers: Session):+ def test_update_dataset_not_found_error(self, db_session_with_containers: Session) -> None:"""Test error when dataset is not found."""user, _ = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)update_data = {"name": "new_name"}@@ -549,7 +551,7 @@ class TestDatasetServiceUpdateDataset:assert "Dataset not found" in str(context.value)- def test_update_dataset_permission_error(self, db_session_with_containers: Session):+ def test_update_dataset_permission_error(self, db_session_with_containers: Session) -> None:"""Test error when user doesn't have permission."""owner, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers, role=TenantAccountRole.OWNER@@ -570,7 +572,7 @@ class TestDatasetServiceUpdateDataset:with pytest.raises(NoPermissionError):DatasetService.update_dataset(dataset.id, update_data, outsider, session=db_session_with_containers)- def test_update_internal_dataset_embedding_model_error(self, db_session_with_containers: Session):+ def test_update_internal_dataset_embedding_model_error(self, db_session_with_containers: Session) -> None:"""Test error when embedding model is not available."""user, tenant = DatasetUpdateTestDataFactory.create_account_with_tenant(db_session_with_containers)dataset = DatasetUpdateTestDataFactory.create_dataset(diff --git a/api/tests/e2e_tests/containers/services/test_document_service_display_status.py b/api/tests/e2e_tests/containers/services/test_document_service_display_status.pyindex 46b32dbaca9..18bd417101e 100644--- a/api/tests/e2e_tests/containers/services/test_document_service_display_status.py+++ b/api/tests/e2e_tests/containers/services/test_document_service_display_status.py@@ -10,7 +10,7 @@ from models.enums import DataSourceType, DocumentCreatedFrom, IndexingStatusfrom services.knowledge.dataset_service import DocumentService-def _create_dataset(db_session_with_containers) -> Dataset:+def _create_dataset(db_session_with_containers: Session) -> Dataset:dataset = Dataset(tenant_id=str(uuid4()),name=f"dataset-{uuid4()}",@@ -24,11 +24,11 @@ def _create_dataset(db_session_with_containers) -> Dataset:def _create_document(- db_session_with_containers,+ db_session_with_containers: Session,*,dataset_id: str,tenant_id: str,- indexing_status: str,+ indexing_status: IndexingStatus,enabled: bool = True,archived: bool = False,is_paused: bool = False,@@ -59,7 +59,7 @@ def _create_document(return document-def test_build_display_status_filters_available(db_session_with_containers: Session):+def test_build_display_status_filters_available(db_session_with_containers: Session) -> None:dataset = _create_dataset(db_session_with_containers)available_doc = _create_document(db_session_with_containers,@@ -98,7 +98,7 @@ def test_build_display_status_filters_available(db_session_with_containers: Sessassert [row.id for row in rows] == [available_doc.id]-def test_apply_display_status_filter_applies_when_status_present(db_session_with_containers: Session):+def test_apply_display_status_filter_applies_when_status_present(db_session_with_containers: Session) -> None:dataset = _create_dataset(db_session_with_containers)waiting_doc = _create_document(db_session_with_containers,@@ -122,7 +122,7 @@ def test_apply_display_status_filter_applies_when_status_present(db_session_withassert [row.id for row in rows] == [waiting_doc.id]-def test_apply_display_status_filter_returns_same_when_invalid(db_session_with_containers: Session):+def test_apply_display_status_filter_returns_same_when_invalid(db_session_with_containers: Session) -> None:dataset = _create_dataset(db_session_with_containers)doc1 = _create_document(db_session_with_containers,@@ -146,7 +146,7 @@ def test_apply_display_status_filter_returns_same_when_invalid(db_session_with_cassert {row.id for row in rows} == {doc1.id, doc2.id}-def test_normalize_display_status_alias_mapping():+def test_normalize_display_status_alias_mapping() -> None:"""Test that normalize_display_status maps aliases correctly."""assert DocumentService.normalize_display_status("ACTIVE") == "available"assert DocumentService.normalize_display_status("enabled") == "available"