Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

feat(ui): add reusable breadcrumbs and migrate Web navigation (#42534)

yyh9e13e339b8d5
diff --git a/lint.config.ts b/lint.config.ts
index bf84dec886b..e543a0a153f 100644
--- a/lint.config.ts
+++ b/lint.config.ts
@@ -1153,6 +1153,15 @@ export const lintConfig = {
{
files: ['packages/dify-ui/**/*.{js,cjs,mjs,jsx,ts,cts,mts,tsx}'],
rules: {
+ 'unicorn/import-style': [
+ 'error',
+ {
+ extendDefaultStyles: false,
+ styles: {
+ react: { namespace: true },
+ },
+ },
+ ],
'react/exhaustive-deps': [
'error',
{
diff --git a/packages/dify-ui/README.md b/packages/dify-ui/README.md
index d124e42c99f..e27216366bc 100644
--- a/packages/dify-ui/README.md
+++ b/packages/dify-ui/README.md
@@ -43,7 +43,7 @@ Import `styles.css` once from the consumer's root stylesheet or entrypoint.
| Form | `./form`, `./field`, `./fieldset`, `./input`, `./input-group`, `./textarea`, `./checkbox`, `./checkbox-group`, `./radio-group`, `./number-field`, `./select`, `./slider`, `./switch` |
| Layout | `./scroll-area` |
| Media | `./avatar` |
-| Navigation | `./file-tree`, `./pagination`, `./tabs` |
+| Navigation | `./breadcrumb`, `./file-tree`, `./pagination`, `./tabs` |
| Overlay and menu | `./alert-dialog`, `./context-menu`, `./dialog`, `./drawer`, `./dropdown-menu`, `./popover`, `./preview-card`, `./tooltip` |
| Search and pick | `./autocomplete`, `./combobox`, `./select` |
diff --git a/packages/dify-ui/docs/authoring.md b/packages/dify-ui/docs/authoring.md
index 536b744c872..20bcce9d05f 100644
--- a/packages/dify-ui/docs/authoring.md
+++ b/packages/dify-ui/docs/authoring.md
@@ -5,6 +5,14 @@ module-local and publish the complete surface through separate `export { ... }`
`export type { ... }` manifests at the bottom of the file. Do not mix scattered inline exports
with the manifest or use wildcard exports.
+## React imports
+
+Use React namespace imports throughout this package, including stories and tests. Use
+`import * as React from 'react'` when calling React runtime APIs, and
+`import type * as React from 'react'` when referencing only React types. A runtime namespace
+import also covers React types; do not add separate named type imports. JSX alone does not
+require an explicit React import.
+
## Subpaths and names
Every public primitive needs a matching `package.json#exports` subpath. Import relatively between
diff --git a/packages/dify-ui/package.json b/packages/dify-ui/package.json
index 8084254b75f..9d60deb5639 100644
--- a/packages/dify-ui/package.json
+++ b/packages/dify-ui/package.json
@@ -21,6 +21,10 @@
"types": "./src/avatar/index.tsx",
"import": "./src/avatar/index.tsx"
},
+ "./breadcrumb": {
+ "types": "./src/breadcrumb/index.tsx",
+ "import": "./src/breadcrumb/index.tsx"
+ },
"./button": {
"types": "./src/button/index.tsx",
"import": "./src/button/index.tsx"
diff --git a/packages/dify-ui/src/alert-dialog/index.tsx b/packages/dify-ui/src/alert-dialog/index.tsx
index 9789d2f6740..0e5f8ce2e73 100644
--- a/packages/dify-ui/src/alert-dialog/index.tsx
+++ b/packages/dify-ui/src/alert-dialog/index.tsx
@@ -1,8 +1,8 @@
'use client'
+import type * as React from 'react'
import type { ButtonProps } from '../button'
import { AlertDialog as BaseAlertDialog } from '@base-ui/react/alert-dialog'
-import * as React from 'react'
import { Button } from '../button'
import { cn } from '../cn'
import { modalBackdropClassName, modalPopupAnimationClassName } from '../overlay-shared'
diff --git a/packages/dify-ui/src/autocomplete/index.tsx b/packages/dify-ui/src/autocomplete/index.tsx
index 3d1fc3f4c29..6dd17fadd9f 100644
--- a/packages/dify-ui/src/autocomplete/index.tsx
+++ b/packages/dify-ui/src/autocomplete/index.tsx
@@ -1,10 +1,10 @@
'use client'
import type { VariantProps } from 'class-variance-authority'
+import type * as React from 'react'
import type { Placement } from '../placement'
import { Autocomplete as BaseAutocomplete } from '@base-ui/react/autocomplete'
import { cva } from 'class-variance-authority'
-import * as React from 'react'
import { cn } from '../cn'
import { textControlCompoundInputFocusClassName } from '../form-control-shared'
import {
diff --git a/packages/dify-ui/src/breadcrumb/__tests__/types.tsx b/packages/dify-ui/src/breadcrumb/__tests__/types.tsx
new file mode 100644
index 00000000000..69cfc7a45fe
--- /dev/null
+++ b/packages/dify-ui/src/breadcrumb/__tests__/types.tsx
@@ -0,0 +1,42 @@
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbLink,
+ BreadcrumbList,
+ BreadcrumbPage,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
+
+export function breadcrumbTypeContracts() {
+ const labelled = <Breadcrumb aria-label="Page path" />
+ const referenced = <Breadcrumb aria-labelledby="path-heading" />
+ const link = <BreadcrumbLink render={<a href="/projects" />} aria-current="page" />
+
+ // @ts-expect-error A navigation name must be supplied by the consumer.
+ const unnamed = <Breadcrumb />
+ // @ts-expect-error Choose one accessible naming mechanism.
+ const duplicateName = <Breadcrumb aria-label="Path" aria-labelledby="heading" />
+ // @ts-expect-error Structural parts do not expose render.
+ const rootRender = <Breadcrumb aria-label="Path" render={<div />} />
+ // @ts-expect-error List semantics are fixed.
+ const listRender = <BreadcrumbList render={<div />} />
+ // @ts-expect-error Item semantics are fixed.
+ const itemRender = <BreadcrumbItem render={<div />} />
+ // @ts-expect-error Use BreadcrumbLink for an interactive current page.
+ const pageRender = <BreadcrumbPage render={<a href="/projects" />} />
+ // @ts-expect-error Customize decorative content through children.
+ const separatorRender = <BreadcrumbSeparator render={<span />} />
+
+ return {
+ labelled,
+ referenced,
+ link,
+ unnamed,
+ duplicateName,
+ rootRender,
+ listRender,
+ itemRender,
+ pageRender,
+ separatorRender,
+ }
+}
diff --git a/packages/dify-ui/src/breadcrumb/index.stories.tsx b/packages/dify-ui/src/breadcrumb/index.stories.tsx
new file mode 100644
index 00000000000..13b2483cc98
--- /dev/null
+++ b/packages/dify-ui/src/breadcrumb/index.stories.tsx
@@ -0,0 +1,300 @@
+import type { Meta, StoryObj } from '@storybook/react-vite'
+import * as React from 'react'
+import { expect, waitFor, within } from 'storybook/test'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbLink,
+ BreadcrumbList,
+ BreadcrumbPage,
+ BreadcrumbSeparator,
+} from '.'
+import {
+ DropdownMenu,
+ DropdownMenuContent,
+ DropdownMenuItem,
+ DropdownMenuTrigger,
+} from '../dropdown-menu'
+import { IconButton } from '../icon-button'
+
+const meta = {
+ title: 'Base/UI/Breadcrumb',
+ component: Breadcrumb,
+ parameters: {
+ layout: 'centered',
+ a11y: { config: { rules: [{ id: 'color-contrast', enabled: true }] } },
+ docs: {
+ description: {
+ component:
+ 'Explicit navigation anatomy with a required localized aria-label or aria-labelledby. ' +
+ 'Separators are decorative list siblings. Only BreadcrumbLink supports render, for components that forward props and refs to an anchor. ' +
+ 'Current links remain interactive; BreadcrumbPage is static text. No route inference, automatic separators, truncation, or collapsing. ' +
+ 'The default layout is a single row with consistent typography and tertiary ancestor links / primary current text. ' +
+ 'Consumers own typography overrides, available width, and overflow handling.',
+ },
+ },
+ },
+ args: { 'aria-label': 'Breadcrumb' },
+ decorators: [
+ (Story) => (
+ <div className="bg-background-default p-6">
+ <Story />
+ </div>
+ ),
+ ],
+} satisfies Meta<typeof Breadcrumb>
+
+export default meta
+type Story = StoryObj<typeof Breadcrumb>
+
+export const Default: Story = {
+ render: (args) => (
+ <Breadcrumb {...args}>
+ <BreadcrumbList>
+ <BreadcrumbItem>
+ <BreadcrumbLink href="#home">Home</BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator />
+ <BreadcrumbItem>
+ <BreadcrumbLink href="#knowledge">Knowledge</BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator />
+ <BreadcrumbItem>
+ <BreadcrumbPage>Product documents</BreadcrumbPage>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
+ ),
+ play: async ({ canvas, userEvent }) => {
+ const navigation = within(canvas.getByRole('navigation', { name: 'Breadcrumb' }))
+ await expect(navigation.getAllByRole('listitem')).toHaveLength(3)
+ const home = navigation.getByRole('link', { name: 'Home' })
+ home.focus()
+ await userEvent.tab()
+ await expect(navigation.getByRole('link', { name: 'Knowledge' })).toHaveFocus()
+ await expect(navigation.getByText('Product documents')).toHaveAttribute('aria-current', 'page')
+ },
+}
+
+export const CurrentPageLink: Story = {
+ render: (args) => (
+ <Breadcrumb {...args}>
+ <BreadcrumbList>
+ <BreadcrumbItem>
+ <BreadcrumbLink href="#home">Home</BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator />
+ <BreadcrumbItem>
+ <BreadcrumbLink href="#documents" aria-current="page">
+ Documents
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
+ ),
+ play: async ({ canvas, userEvent }) => {
+ canvas.getByRole('link', { name: 'Home' }).focus()
+ await userEvent.tab()
+ const current = canvas.getByRole('link', { name: 'Documents', current: 'page' })
+ await expect(current).toHaveFocus()
+ await expect(current).toHaveAttribute('href', '#documents')
+ await expect(current).not.toHaveAttribute('aria-disabled')
+ },
+}
+
+function StoryLink({ children, ...props }: React.ComponentProps<'a'>) {
+ return <a {...props}>{children}</a>
+}
+
+function RenderLinkExample() {
+ const ref = React.useRef<HTMLAnchorElement>(null)
+ return (
+ <div className="flex flex-col gap-4">
+ <Breadcrumb aria-label="Project path">
+ <BreadcrumbList>
+ <BreadcrumbItem>
+ <BreadcrumbLink ref={ref} render={<StoryLink href="#projects" />}>
+ Projects
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator />
+ <BreadcrumbItem>
+ <BreadcrumbPage>Design system</BreadcrumbPage>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
+ <button
+ type="button"
+ className="self-start text-text-secondary underline focus-visible:outline-2"
+ onClick={() => ref.current?.focus()}
+ >
+ Focus project link
+ </button>
+ </div>
+ )
+}
+
+export const RenderLink: Story = {
+ render: () => <RenderLinkExample />,
+ play: async ({ canvas, userEvent }) => {
+ await userEvent.click(canvas.getByRole('button', { name: 'Focus project link' }))
+ await expect(canvas.getByRole('link', { name: 'Projects' })).toHaveFocus()
+ await expect(canvas.getByRole('link', { name: 'Projects' })).toHaveAttribute(
+ 'href',
+ '#projects',
+ )
+ },
+}
+
+export const LabelledBy: Story = {
+ render: () => (
+ <div className="flex flex-col gap-3">
+ <h2 id="breadcrumb-story-heading" className="system-md-medium text-text-primary">
+ Project location
+ </h2>
+ <Breadcrumb aria-labelledby="breadcrumb-story-heading">
+ <BreadcrumbList>
+ <BreadcrumbItem>
+ <BreadcrumbLink href="#projects">Projects</BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator />
+ <BreadcrumbItem>
+ <BreadcrumbPage>Design system</BreadcrumbPage>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
+ </div>
+ ),
+}
+
+export const RightToLeft: Story = {
+ render: () => (
+ <Breadcrumb dir="rtl" aria-label="مسار التنقل" lang="ar">
+ <BreadcrumbList>
+ <BreadcrumbItem>
+ <BreadcrumbLink href="#home">الرئيسية</BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator>
+ <span className="i-ri-arrow-left-s-line size-4" />
+ </BreadcrumbSeparator>
+ <BreadcrumbItem>
+ <BreadcrumbLink href="#knowledge">المعرفة</BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator>
+ <span className="i-ri-arrow-left-s-line size-4" />
+ </BreadcrumbSeparator>
+ <BreadcrumbItem>
+ <BreadcrumbPage>المستندات</BreadcrumbPage>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
+ ),
+}
+
+export const TruncatedLabel: Story = {
+ parameters: {
+ docs: {
+ description: {
+ story:
+ 'The consumer constrains one item and truncates its text, leaving the anchor focus outline and its full accessible name intact.',
+ },
+ },
+ },
+ render: (args) => (
+ <Breadcrumb {...args}>
+ <BreadcrumbList>
+ <BreadcrumbItem>
+ <BreadcrumbLink href="#home">Home</BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator />
+ <BreadcrumbItem className="max-w-40">
+ <BreadcrumbLink href="#research">
+ <span className="truncate">Research and development documentation</span>
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator />
+ <BreadcrumbItem>
+ <BreadcrumbPage>Overview</BreadcrumbPage>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
+ ),
+}
+
+export const CollapsedAncestors: Story = {
+ parameters: {
+ docs: {
+ description: {
+ story:
+ 'Collapsing is an explicit DropdownMenu composition. Its trigger owns the accessible name; hidden ancestors remain links. Escape restores focus to the trigger.',
+ },
+ },
+ },
+ render: (args) => (
+ <Breadcrumb {...args}>
+ <BreadcrumbList>
+ <BreadcrumbItem>
+ <BreadcrumbLink href="#home">Home</BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator />
+ <BreadcrumbItem>
+ <DropdownMenu>
+ <DropdownMenuTrigger
+ render={
+ <IconButton aria-label="Show ancestor pages">
+ <span aria-hidden className="i-ri-more-line size-4" />
+ </IconButton>
+ }
+ />
+ <DropdownMenuContent>
+ <DropdownMenuItem render={<a href="#projects" />}>Projects</DropdownMenuItem>
+ <DropdownMenuItem render={<a href="#knowledge" />}>Knowledge</DropdownMenuItem>
+ </DropdownMenuContent>
+ </DropdownMenu>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator />
+ <BreadcrumbItem>
+ <BreadcrumbPage>Documents</BreadcrumbPage>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
+ ),
+ play: async ({ canvas, canvasElement, userEvent }) => {
+ const trigger = canvas.getByRole('button', { name: 'Show ancestor pages' })
+ trigger.focus()
+ await userEvent.keyboard('{Enter}')
+ const body = within(canvasElement.ownerDocument.body)
+ await expect(await body.findByRole('menuitem', { name: 'Projects' })).toBeVisible()
+ await userEvent.keyboard('{Escape}')
+ await waitFor(() => expect(trigger).toHaveFocus())
+ },
+}
+
+export const Dark: Story = {
+ ...Default,
+ globals: { theme: 'dark' },
+}
+
+export const Typography: Story = {
+ parameters: {
+ docs: {
+ description: {
+ story:
+ 'Set typography on the list to change the size and weight of every item together. Links and current text inherit these styles.',
+ },
+ },
+ },
+ render: () => (
+ <Breadcrumb aria-label="Documentation path">
+ <BreadcrumbList className="text-lg/6 font-semibold">
+ <BreadcrumbItem>
+ <BreadcrumbLink href="#documentation">Documentation</BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator />
+ <BreadcrumbItem>
+ <BreadcrumbPage>Getting started</BreadcrumbPage>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
+ ),
+}
diff --git a/packages/dify-ui/src/breadcrumb/index.tsx b/packages/dify-ui/src/breadcrumb/index.tsx
new file mode 100644
index 00000000000..91fdf4bc092
--- /dev/null
+++ b/packages/dify-ui/src/breadcrumb/index.tsx
@@ -0,0 +1,97 @@
+'use client'
+
+import type * as React from 'react'
+import { mergeProps } from '@base-ui/react/merge-props'
+import { useRender } from '@base-ui/react/use-render'
+import { cn } from '../cn'
+
+type BreadcrumbName =
+ | { 'aria-label': string; 'aria-labelledby'?: never }
+ | { 'aria-label'?: never; 'aria-labelledby': string }
+
+type BreadcrumbProps = Omit<React.ComponentProps<'nav'>, 'aria-label' | 'aria-labelledby'> &
+ BreadcrumbName
+type BreadcrumbListProps = React.ComponentProps<'ol'>
+type BreadcrumbItemProps = React.ComponentProps<'li'>
+type BreadcrumbLinkProps = useRender.ComponentProps<'a'>
+type BreadcrumbPageProps = React.ComponentProps<'span'>
+type BreadcrumbSeparatorProps = React.ComponentProps<'li'>
+
+function Breadcrumb({ className, ...props }: BreadcrumbProps) {
+ return <nav className={cn('min-w-0', className)} {...props} />
+}
+
+function BreadcrumbList({ className, ...props }: BreadcrumbListProps) {
+ return (
+ <ol
+ className={cn(
+ 'flex min-w-0 items-center gap-1.5 system-sm-regular text-text-secondary',
+ className,
+ )}
+ {...props}
+ />
+ )
+}
+
+function BreadcrumbItem({ className, ...props }: BreadcrumbItemProps) {
+ return <li className={cn('flex min-w-0 items-center gap-1.5', className)} {...props} />
+}
+
+function BreadcrumbLink({ className, render, ...props }: BreadcrumbLinkProps) {
+ return useRender({
+ defaultTagName: 'a',
+ render,
+ props: mergeProps<'a'>(
+ {
+ className: cn(
+ 'inline-flex min-w-0 items-center gap-1 rounded-sm whitespace-nowrap text-text-tertiary hover:text-text-secondary focus-visible:ring-2 focus-visible:ring-state-accent-solid focus-visible:outline-hidden aria-[current=page]:text-text-primary',
+ className,
+ ),
+ },
+ props,
+ ),
+ })
+}
+
+function BreadcrumbPage({ className, ...props }: BreadcrumbPageProps) {
+ return (
+ <span
+ aria-current="page"
+ className={cn('min-w-0 whitespace-nowrap text-text-primary', className)}
+ {...props}
+ />
+ )
+}
+
+function BreadcrumbSeparator({ children = '/', className, ...props }: BreadcrumbSeparatorProps) {
+ return (
+ <li
+ role="presentation"
+ aria-hidden="true"
+ className={cn(
+ 'flex shrink-0 items-center justify-center text-text-quaternary select-none',
+ className,
+ )}
+ {...props}
+ >
+ {children}
+ </li>
+ )
+}
+
+export {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbLink,
+ BreadcrumbList,
+ BreadcrumbPage,
+ BreadcrumbSeparator,
+}
+export type {
+ BreadcrumbItemProps,
+ BreadcrumbLinkProps,
+ BreadcrumbListProps,
+ BreadcrumbPageProps,
+ BreadcrumbProps,
+ BreadcrumbSeparatorProps,
+}
diff --git a/packages/dify-ui/src/button/__tests__/index.spec.tsx b/packages/dify-ui/src/button/__tests__/index.spec.tsx
index e58d031af6d..4e871ad27c8 100644
--- a/packages/dify-ui/src/button/__tests__/index.spec.tsx
+++ b/packages/dify-ui/src/button/__tests__/index.spec.tsx
@@ -1,4 +1,4 @@
-import * as React from 'react'
+import type * as React from 'react'
import { userEvent } from 'vite-plus/test/browser'
import { render } from 'vitest-browser-react'
import { Button } from '../index'
diff --git a/packages/dify-ui/src/checkbox/index.tsx b/packages/dify-ui/src/checkbox/index.tsx
index 70222dee054..e7c57be6a84 100644
--- a/packages/dify-ui/src/checkbox/index.tsx
+++ b/packages/dify-ui/src/checkbox/index.tsx
@@ -1,8 +1,8 @@
'use client'
import type { Checkbox as BaseCheckboxNS } from '@base-ui/react/checkbox'
+import type * as React from 'react'
import { Checkbox as BaseCheckbox } from '@base-ui/react/checkbox'
-import * as React from 'react'
import { cn } from '../cn'
const checkboxRootClassName = cn(
diff --git a/packages/dify-ui/src/collapsible/index.stories.tsx b/packages/dify-ui/src/collapsible/index.stories.tsx
index b9a050abe0b..6949bff074d 100644
--- a/packages/dify-ui/src/collapsible/index.stories.tsx
+++ b/packages/dify-ui/src/collapsible/index.stories.tsx
@@ -1,6 +1,6 @@
import type { Meta, StoryObj } from '@storybook/react-vite'
import type { CollapsiblePanelProps } from '.'
-import { useState } from 'react'
+import * as React from 'react'
import { expect, waitFor } from 'storybook/test'
import { Collapsible, CollapsiblePanel, CollapsibleTrigger } from '.'
import { Button } from '../button'
@@ -156,7 +156,7 @@ export const IconButtonTrigger: Story = {
}
function ControlledDemo() {
- const [open, setOpen] = useState(true)
+ const [open, setOpen] = React.useState(true)
return (
<div className="flex flex-col items-start gap-3">
<Button variant="secondary" onClick={() => setOpen(true)}>
diff --git a/packages/dify-ui/src/combobox/index.tsx b/packages/dify-ui/src/combobox/index.tsx
index 4afcebf7f1f..624b680fd3f 100644
--- a/packages/dify-ui/src/combobox/index.tsx
+++ b/packages/dify-ui/src/combobox/index.tsx
@@ -1,10 +1,10 @@
'use client'
import type { VariantProps } from 'class-variance-authority'
+import type * as React from 'react'
import type { Placement } from '../placement'
import { Combobox as BaseCombobox } from '@base-ui/react/combobox'
import { cva } from 'class-variance-authority'
-import * as React from 'react'
import { cn } from '../cn'
import { formLabelClassName, textControlCompoundInputFocusClassName } from '../form-control-shared'
import {
diff --git a/packages/dify-ui/src/context-menu/__tests__/index.spec.tsx b/packages/dify-ui/src/context-menu/__tests__/index.spec.tsx
index 8112440167a..93d80a2c533 100644
--- a/packages/dify-ui/src/context-menu/__tests__/index.spec.tsx
+++ b/packages/dify-ui/src/context-menu/__tests__/index.spec.tsx
@@ -1,4 +1,4 @@
-import * as React from 'react'
+import type * as React from 'react'
import { render } from 'vitest-browser-react'
import {
ContextMenu,
diff --git a/packages/dify-ui/src/context-menu/index.tsx b/packages/dify-ui/src/context-menu/index.tsx
index b1ab0bf382a..9fa2088ce53 100644
--- a/packages/dify-ui/src/context-menu/index.tsx
+++ b/packages/dify-ui/src/context-menu/index.tsx
@@ -1,9 +1,9 @@
'use client'
+import type * as React from 'react'
import type { MenuItemVariant } from '../overlay-shared'
import type { Placement } from '../placement'
import { ContextMenu as BaseContextMenu } from '@base-ui/react/context-menu'
-import * as React from 'react'
import { cn } from '../cn'
import {
floatingGroupLabelClassName,
diff --git a/packages/dify-ui/src/dialog/index.tsx b/packages/dify-ui/src/dialog/index.tsx
index 7e957c2308a..2ec31a47cb5 100644
--- a/packages/dify-ui/src/dialog/index.tsx
+++ b/packages/dify-ui/src/dialog/index.tsx
@@ -1,7 +1,7 @@
'use client'
+import type * as React from 'react'
import { Dialog as BaseDialog } from '@base-ui/react/dialog'
-import * as React from 'react'
import { cn } from '../cn'
import { modalBackdropClassName, modalPopupAnimationClassName } from '../overlay-shared'
diff --git a/packages/dify-ui/src/drawer/index.tsx b/packages/dify-ui/src/drawer/index.tsx
index dce8bbd2e41..36e88c8d460 100644
--- a/packages/dify-ui/src/drawer/index.tsx
+++ b/packages/dify-ui/src/drawer/index.tsx
@@ -1,7 +1,7 @@
'use client'
+import type * as React from 'react'
import { Drawer as BaseDrawer } from '@base-ui/react/drawer'
-import * as React from 'react'
import { cn } from '../cn'
import { iconButtonVariants } from '../icon-button/variants'
diff --git a/packages/dify-ui/src/dropdown-menu/__tests__/index.spec.tsx b/packages/dify-ui/src/dropdown-menu/__tests__/index.spec.tsx
index 9d65d038177..1f0f19fc330 100644
--- a/packages/dify-ui/src/dropdown-menu/__tests__/index.spec.tsx
+++ b/packages/dify-ui/src/dropdown-menu/__tests__/index.spec.tsx
@@ -1,4 +1,4 @@
-import * as React from 'react'
+import type * as React from 'react'
import { render } from 'vitest-browser-react'
import {
DropdownMenu,
diff --git a/packages/dify-ui/src/dropdown-menu/index.tsx b/packages/dify-ui/src/dropdown-menu/index.tsx
index fb626a38261..a64ff26f80e 100644
--- a/packages/dify-ui/src/dropdown-menu/index.tsx
+++ b/packages/dify-ui/src/dropdown-menu/index.tsx
@@ -1,9 +1,9 @@
'use client'
+import type * as React from 'react'
import type { MenuItemVariant } from '../overlay-shared'
import type { Placement } from '../placement'
import { Menu } from '@base-ui/react/menu'
-import * as React from 'react'
import { cn } from '../cn'
import {
floatingGroupLabelClassName,
diff --git a/packages/dify-ui/src/icon-button/index.tsx b/packages/dify-ui/src/icon-button/index.tsx
index 49c26f865f4..42720c3cbcb 100644
--- a/packages/dify-ui/src/icon-button/index.tsx
+++ b/packages/dify-ui/src/icon-button/index.tsx
@@ -2,8 +2,8 @@
import type { Button as BaseButtonNS } from '@base-ui/react/button'
import type { VariantProps } from 'class-variance-authority'
+import type * as React from 'react'
import { Button as BaseButton } from '@base-ui/react/button'
-import * as React from 'react'
import { cn } from '../cn'
import { iconButtonVariants } from './variants'
diff --git a/packages/dify-ui/src/input-group/index.tsx b/packages/dify-ui/src/input-group/index.tsx
index 68cbe7113c9..ed134c51b42 100644
--- a/packages/dify-ui/src/input-group/index.tsx
+++ b/packages/dify-ui/src/input-group/index.tsx
@@ -2,9 +2,9 @@
import type { Input as BaseInputNS } from '@base-ui/react/input'
import type { VariantProps } from 'class-variance-authority'
+import type * as React from 'react'
import { Input as BaseInput } from '@base-ui/react/input'
import { cva } from 'class-variance-authority'
-import * as React from 'react'
import { cn } from '../cn'
const interactiveElementSelector =
diff --git a/packages/dify-ui/src/kbd/index.tsx b/packages/dify-ui/src/kbd/index.tsx
index 609d0d7a0fd..d0761481f3e 100644
--- a/packages/dify-ui/src/kbd/index.tsx
+++ b/packages/dify-ui/src/kbd/index.tsx
@@ -1,8 +1,8 @@
'use client'
import type { VariantProps } from 'class-variance-authority'
+import type * as React from 'react'
import { cva } from 'class-variance-authority'
-import * as React from 'react'
import { cn } from '../cn'
const kbdVariants = cva(
diff --git a/packages/dify-ui/src/number-field/index.tsx b/packages/dify-ui/src/number-field/index.tsx
index 4f6db3b8f85..132ce3c5549 100644
--- a/packages/dify-ui/src/number-field/index.tsx
+++ b/packages/dify-ui/src/number-field/index.tsx
@@ -1,9 +1,9 @@
'use client'
import type { VariantProps } from 'class-variance-authority'
+import type * as React from 'react'
import { NumberField as BaseNumberField } from '@base-ui/react/number-field'
import { cva } from 'class-variance-authority'
-import * as React from 'react'
import { cn } from '../cn'
import { textControlCompoundInputFocusClassName } from '../form-control-shared'
diff --git a/packages/dify-ui/src/popover/index.tsx b/packages/dify-ui/src/popover/index.tsx
index b5c6245cdf1..06f8ed2d67a 100644
--- a/packages/dify-ui/src/popover/index.tsx
+++ b/packages/dify-ui/src/popover/index.tsx
@@ -1,8 +1,8 @@
'use client'
+import type * as React from 'react'
import type { Placement } from '../placement'
import { Popover as BasePopover } from '@base-ui/react/popover'
-import * as React from 'react'
import { cn } from '../cn'
import { floatingPopupAnimationClassName } from '../overlay-shared'
import { parsePlacement } from '../placement'
diff --git a/packages/dify-ui/src/preview-card/__tests__/index.spec.tsx b/packages/dify-ui/src/preview-card/__tests__/index.spec.tsx
index 8d46b2cc842..2b6470fa73f 100644
--- a/packages/dify-ui/src/preview-card/__tests__/index.spec.tsx
+++ b/packages/dify-ui/src/preview-card/__tests__/index.spec.tsx
@@ -1,4 +1,4 @@
-import * as React from 'react'
+import type * as React from 'react'
import { render } from 'vitest-browser-react'
import {
PreviewCard,
diff --git a/packages/dify-ui/src/preview-card/index.tsx b/packages/dify-ui/src/preview-card/index.tsx
index 706479518a9..1ab4245babf 100644
--- a/packages/dify-ui/src/preview-card/index.tsx
+++ b/packages/dify-ui/src/preview-card/index.tsx
@@ -1,8 +1,8 @@
'use client'
+import type * as React from 'react'
import type { Placement } from '../placement'
import { PreviewCard as BasePreviewCard } from '@base-ui/react/preview-card'
-import * as React from 'react'
import { cn } from '../cn'
import { floatingPopupAnimationClassName } from '../overlay-shared'
import { parsePlacement } from '../placement'
diff --git a/packages/dify-ui/src/radio-group/index.tsx b/packages/dify-ui/src/radio-group/index.tsx
index 87e514cf69e..379f8b35c0d 100644
--- a/packages/dify-ui/src/radio-group/index.tsx
+++ b/packages/dify-ui/src/radio-group/index.tsx
@@ -2,9 +2,9 @@
import type { Radio as BaseRadioNS } from '@base-ui/react/radio'
import type { RadioGroup as BaseRadioGroupNS } from '@base-ui/react/radio-group'
+import type * as React from 'react'
import { Radio as BaseRadio } from '@base-ui/react/radio'
import { RadioGroup as BaseRadioGroup } from '@base-ui/react/radio-group'
-import * as React from 'react'
import { cn } from '../cn'
type RadioGroupProps<Value = string> = Omit<BaseRadioGroupNS.Props<Value>, 'className'> & {
diff --git a/packages/dify-ui/src/scroll-area/__tests__/index.spec.tsx b/packages/dify-ui/src/scroll-area/__tests__/index.spec.tsx
index 4d2c84371a4..4f451bb0e31 100644
--- a/packages/dify-ui/src/scroll-area/__tests__/index.spec.tsx
+++ b/packages/dify-ui/src/scroll-area/__tests__/index.spec.tsx
@@ -1,4 +1,4 @@
-import * as React from 'react'
+import type * as React from 'react'
import { render } from 'vitest-browser-react'
import {
ScrollArea,
diff --git a/packages/dify-ui/src/scroll-area/index.stories.tsx b/packages/dify-ui/src/scroll-area/index.stories.tsx
index d4531cd4f5f..d26d62badd7 100644
--- a/packages/dify-ui/src/scroll-area/index.stories.tsx
+++ b/packages/dify-ui/src/scroll-area/index.stories.tsx
@@ -1,5 +1,5 @@
import type { Meta, StoryObj } from '@storybook/react-vite'
-import * as React from 'react'
+import type * as React from 'react'
import {
ScrollArea,
ScrollAreaContent,
diff --git a/packages/dify-ui/src/segmented-control/__tests__/index.spec.tsx b/packages/dify-ui/src/segmented-control/__tests__/index.spec.tsx
index 84c8b3cda71..2e12732a9ec 100644
--- a/packages/dify-ui/src/segmented-control/__tests__/index.spec.tsx
+++ b/packages/dify-ui/src/segmented-control/__tests__/index.spec.tsx
@@ -1,4 +1,4 @@
-import * as React from 'react'
+import type * as React from 'react'
import { userEvent } from 'vite-plus/test/browser'
import { render } from 'vitest-browser-react'
import { SegmentedControl, SegmentedControlDivider, SegmentedControlItem } from '../index'
diff --git a/packages/dify-ui/src/segmented-control/index.tsx b/packages/dify-ui/src/segmented-control/index.tsx
index ea1cbdd8c81..5cfe9e71fee 100644
--- a/packages/dify-ui/src/segmented-control/index.tsx
+++ b/packages/dify-ui/src/segmented-control/index.tsx
@@ -2,9 +2,9 @@
import type { Radio as BaseRadioNS } from '@base-ui/react/radio'
import type { RadioGroup as BaseRadioGroupNS } from '@base-ui/react/radio-group'
+import type * as React from 'react'
import { Radio as BaseRadio } from '@base-ui/react/radio'
import { RadioGroup as BaseRadioGroup } from '@base-ui/react/radio-group'
-import * as React from 'react'
import { cn } from '../cn'
type SegmentedControlSelectionProps<Value> =
diff --git a/packages/dify-ui/src/select/index.tsx b/packages/dify-ui/src/select/index.tsx
index c273c61b165..cf9a7494a8f 100644
--- a/packages/dify-ui/src/select/index.tsx
+++ b/packages/dify-ui/src/select/index.tsx
@@ -2,10 +2,10 @@
import type { ComponentRenderFn, HTMLProps } from '@base-ui/react/types'
import type { VariantProps } from 'class-variance-authority'
+import type * as React from 'react'
import type { Placement } from '../placement'
import { Select as BaseSelect } from '@base-ui/react/select'
import { cva } from 'class-variance-authority'
-import * as React from 'react'
import { cn } from '../cn'
import { formLabelClassName } from '../form-control-shared'
import {
diff --git a/packages/dify-ui/src/spinner/index.tsx b/packages/dify-ui/src/spinner/index.tsx
index e5abe2e7809..6e420358c39 100644
--- a/packages/dify-ui/src/spinner/index.tsx
+++ b/packages/dify-ui/src/spinner/index.tsx
@@ -1,6 +1,6 @@
'use client'
-import type { ComponentProps } from 'react'
+import type * as React from 'react'
import { Progress as BaseProgress } from '@base-ui/react/progress'
import { cva } from 'class-variance-authority'
import { cn } from '../cn'
@@ -24,7 +24,7 @@ type SpinnerAppearanceProps = {
type SpinnerIconProps = SpinnerAppearanceProps
type SpinnerProps = SpinnerAppearanceProps &
- Pick<ComponentProps<'div'>, 'id' | 'aria-describedby'> &
+ Pick<React.ComponentProps<'div'>, 'id' | 'aria-describedby'> &
(
| { 'aria-label': string; 'aria-labelledby'?: never }
| { 'aria-label'?: never; 'aria-labelledby': string }
diff --git a/packages/dify-ui/src/status-dot/index.tsx b/packages/dify-ui/src/status-dot/index.tsx
index 66bb4252fc5..12992188f08 100644
--- a/packages/dify-ui/src/status-dot/index.tsx
+++ b/packages/dify-ui/src/status-dot/index.tsx
@@ -1,8 +1,8 @@
'use client'
import type { VariantProps } from 'class-variance-authority'
+import type * as React from 'react'
import { cva } from 'class-variance-authority'
-import * as React from 'react'
import { cn } from '../cn'
const statusDotVariants = cva('block shrink-0 border border-solid', {
diff --git a/packages/dify-ui/src/switch/index.tsx b/packages/dify-ui/src/switch/index.tsx
index dbc3683e686..2e9d59ef749 100644
--- a/packages/dify-ui/src/switch/index.tsx
+++ b/packages/dify-ui/src/switch/index.tsx
@@ -2,9 +2,9 @@
import type { Switch as BaseSwitchNS } from '@base-ui/react/switch'
import type { VariantProps } from 'class-variance-authority'
+import type * as React from 'react'
import { Switch as BaseSwitch } from '@base-ui/react/switch'
import { cva } from 'class-variance-authority'
-import * as React from 'react'
import { cn } from '../cn'
const switchRootStateClassName =
diff --git a/packages/dify-ui/src/textarea/__tests__/index.spec.tsx b/packages/dify-ui/src/textarea/__tests__/index.spec.tsx
index 6827cbcba6b..0c34a33d04e 100644
--- a/packages/dify-ui/src/textarea/__tests__/index.spec.tsx
+++ b/packages/dify-ui/src/textarea/__tests__/index.spec.tsx
@@ -1,4 +1,4 @@
-import * as React from 'react'
+import type * as React from 'react'
import { userEvent } from 'vite-plus/test/browser'
import { render } from 'vitest-browser-react'
import { Field, FieldDescription, FieldError, FieldLabel } from '../../field'
diff --git a/packages/dify-ui/src/textarea/index.tsx b/packages/dify-ui/src/textarea/index.tsx
index cbbad7cc52f..721b7389b23 100644
--- a/packages/dify-ui/src/textarea/index.tsx
+++ b/packages/dify-ui/src/textarea/index.tsx
@@ -2,9 +2,9 @@
import type { Field as BaseFieldNS } from '@base-ui/react/field'
import type { VariantProps } from 'class-variance-authority'
+import type * as React from 'react'
import { Field as BaseField } from '@base-ui/react/field'
import { cva } from 'class-variance-authority'
-import * as React from 'react'
import { cn } from '../cn'
import { textControlFocusClassName } from '../form-control-shared'
diff --git a/packages/dify-ui/src/toast/index.tsx b/packages/dify-ui/src/toast/index.tsx
index b0b11616889..b8f5689b6c1 100644
--- a/packages/dify-ui/src/toast/index.tsx
+++ b/packages/dify-ui/src/toast/index.tsx
@@ -6,8 +6,8 @@ import type {
ToastManagerUpdateOptions,
ToastObject,
} from '@base-ui/react/toast'
+import type * as React from 'react'
import { Toast as BaseToast } from '@base-ui/react/toast'
-import * as React from 'react'
import { cn } from '../cn'
import { iconButtonVariants } from '../icon-button/variants'
diff --git a/packages/dify-ui/src/tooltip/__tests__/index.spec.tsx b/packages/dify-ui/src/tooltip/__tests__/index.spec.tsx
index 0c81cc6398d..242e81dfeff 100644
--- a/packages/dify-ui/src/tooltip/__tests__/index.spec.tsx
+++ b/packages/dify-ui/src/tooltip/__tests__/index.spec.tsx
@@ -1,4 +1,4 @@
-import * as React from 'react'
+import type * as React from 'react'
import { render } from 'vitest-browser-react'
import { Tooltip, TooltipContent, TooltipTrigger } from '../index'
diff --git a/packages/dify-ui/src/tooltip/index.tsx b/packages/dify-ui/src/tooltip/index.tsx
index e2cc88ecbbc..84524b97796 100644
--- a/packages/dify-ui/src/tooltip/index.tsx
+++ b/packages/dify-ui/src/tooltip/index.tsx
@@ -1,8 +1,8 @@
'use client'
+import type * as React from 'react'
import type { Placement } from '../placement'
import { Tooltip as BaseTooltip } from '@base-ui/react/tooltip'
-import * as React from 'react'
import { cn } from '../cn'
import { parsePlacement } from '../placement'
diff --git a/packages/dify-ui/tsconfig.json b/packages/dify-ui/tsconfig.json
index c9c9e935410..b66b95b5df8 100644
--- a/packages/dify-ui/tsconfig.json
+++ b/packages/dify-ui/tsconfig.json
@@ -1,6 +1,7 @@
{
"extends": "@dify/tsconfig/react.json",
"compilerOptions": {
+ "noUncheckedSideEffectImports": true,
"types": ["vite-plus/test/globals", "vite-plus/test/matchers"]
},
"include": [
diff --git a/web/app/components/app-sidebar/app-detail-top.tsx b/web/app/components/app-sidebar/app-detail-top.tsx
index 7c719b58321..924ee5bded5 100644
--- a/web/app/components/app-sidebar/app-detail-top.tsx
+++ b/web/app/components/app-sidebar/app-detail-top.tsx
@@ -1,5 +1,12 @@
'use client'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbLink,
+ BreadcrumbList,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
import { DialogTrigger } from '@langgenius/dify-ui/dialog'
import { Kbd, KbdGroup } from '@langgenius/dify-ui/kbd'
import { Tooltip, TooltipContent, TooltipTrigger } from '@langgenius/dify-ui/tooltip'
@@ -35,27 +42,33 @@ export function AppDetailTop({ expand = true, onToggle }: AppDetailTopProps) {
return (
<div className="flex items-center py-2 pr-2 pl-1">
- <div className="flex min-w-0 flex-1 items-center gap-px">
- <Link
- href="/"
- aria-label={t(($) => $['mainNav.home'], { ns: 'common' })}
- className="flex shrink-0 items-center rounded-lg py-2 pr-1.5 pl-0.5 text-text-tertiary transition-colors hover:bg-background-default-hover hover:text-text-secondary"
- >
- <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
- <span aria-hidden className="i-custom-vender-main-nav-app-home size-4" />
- </Link>
- {expand && (
- <>
- <span className="shrink-0 system-md-regular text-text-quaternary">/</span>
- <Link
- href="/apps"
- className="shrink-0 truncate rounded-lg px-1.5 py-2 system-sm-semibold-uppercase text-text-secondary transition-colors hover:bg-background-default-hover hover:text-text-primary"
+ <Breadcrumb aria-label={t(($) => $['menus.apps'], { ns: 'common' })} className="flex-1">
+ <BreadcrumbList className="gap-px">
+ <BreadcrumbItem className="shrink-0">
+ <BreadcrumbLink
+ render={<Link href="/" />}
+ aria-label={t(($) => $['mainNav.home'], { ns: 'common' })}
+ className="gap-0 rounded-lg py-2 pr-1.5 pl-0.5 hover:bg-background-default-hover"
>
- {t(($) => $['menus.apps'], { ns: 'common' })}
- </Link>
- </>
- )}
- </div>
+ <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
+ <span aria-hidden className="i-custom-vender-main-nav-app-home size-4" />
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ {expand && (
+ <>
+ <BreadcrumbSeparator className="system-md-regular" />
+ <BreadcrumbItem className="shrink-0">
+ <BreadcrumbLink
+ render={<Link href="/apps" />}
+ className="rounded-lg px-1.5 py-2 system-sm-semibold-uppercase text-text-secondary hover:bg-background-default-hover hover:text-text-primary"
+ >
+ {t(($) => $['menus.apps'], { ns: 'common' })}
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ </>
+ )}
+ </BreadcrumbList>
+ </Breadcrumb>
{expand && (
<Tooltip>
<TooltipTrigger
diff --git a/web/app/components/app-sidebar/dataset-detail-top.tsx b/web/app/components/app-sidebar/dataset-detail-top.tsx
index b0056aa4b28..fa7cd8e562e 100644
--- a/web/app/components/app-sidebar/dataset-detail-top.tsx
+++ b/web/app/components/app-sidebar/dataset-detail-top.tsx
@@ -1,5 +1,12 @@
'use client'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbLink,
+ BreadcrumbList,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
import { DialogTrigger } from '@langgenius/dify-ui/dialog'
import { Kbd, KbdGroup } from '@langgenius/dify-ui/kbd'
import { Tooltip, TooltipContent, TooltipTrigger } from '@langgenius/dify-ui/tooltip'
@@ -35,27 +42,33 @@ export function DatasetDetailTop({ expand = true, onToggle }: DatasetDetailTopPr
return (
<div className="flex items-center py-2 pr-2 pl-1">
- <div className="flex min-w-0 flex-1 items-center gap-px">
- <Link
- href="/"
- aria-label={t(($) => $['mainNav.home'], { ns: 'common' })}
- className="flex shrink-0 items-center rounded-lg py-2 pr-1.5 pl-0.5 text-text-tertiary transition-colors hover:bg-background-default-hover hover:text-text-secondary"
- >
- <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
- <span aria-hidden className="i-custom-vender-main-nav-app-home size-4" />
- </Link>
- {expand && (
- <>
- <span className="shrink-0 system-md-regular text-text-quaternary">/</span>
- <Link
- href="/datasets"
- className="shrink-0 truncate rounded-lg px-1.5 py-2 system-sm-semibold-uppercase text-text-secondary transition-colors hover:bg-background-default-hover hover:text-text-primary"
+ <Breadcrumb aria-label={t(($) => $['menus.datasets'], { ns: 'common' })} className="flex-1">
+ <BreadcrumbList className="gap-px">
+ <BreadcrumbItem className="shrink-0">
+ <BreadcrumbLink
+ render={<Link href="/" />}
+ aria-label={t(($) => $['mainNav.home'], { ns: 'common' })}
+ className="gap-0 rounded-lg py-2 pr-1.5 pl-0.5 hover:bg-background-default-hover"
>
- {t(($) => $['menus.datasets'], { ns: 'common' })}
- </Link>
- </>
- )}
- </div>
+ <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
+ <span aria-hidden className="i-custom-vender-main-nav-app-home size-4" />
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ {expand && (
+ <>
+ <BreadcrumbSeparator className="system-md-regular" />
+ <BreadcrumbItem className="shrink-0">
+ <BreadcrumbLink
+ render={<Link href="/datasets" />}
+ className="rounded-lg px-1.5 py-2 system-sm-semibold-uppercase text-text-secondary hover:bg-background-default-hover hover:text-text-primary"
+ >
+ {t(($) => $['menus.datasets'], { ns: 'common' })}
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ </>
+ )}
+ </BreadcrumbList>
+ </Breadcrumb>
{expand && (
<Tooltip>
<TooltipTrigger
diff --git a/web/app/components/app/app-access-control/__tests__/add-member-or-group-pop.spec.tsx b/web/app/components/app/app-access-control/__tests__/add-member-or-group-pop.spec.tsx
index b39b3387084..a73299751a2 100644
--- a/web/app/components/app/app-access-control/__tests__/add-member-or-group-pop.spec.tsx
+++ b/web/app/components/app/app-access-control/__tests__/add-member-or-group-pop.spec.tsx
@@ -1,7 +1,7 @@
import type { AccessControlSubjects } from '../specific-groups-or-members'
import type { AccessControlAccount, AccessControlGroup, Subject } from '@/models/access-control'
import { RadioGroup } from '@langgenius/dify-ui/radio-group'
-import { screen } from '@testing-library/react'
+import { screen, within } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { useState } from 'react'
import { AccessMode, SubjectType } from '@/models/access-control'
@@ -241,7 +241,13 @@ describe('AddMemberOrGroupDialog', () => {
name: 'app.accessControlDialog.operateGroupAndMember.allMembers',
})
expect(allMembersButton).toBeInTheDocument()
- expect(screen.getByText(baseGroup.name)).toBeInTheDocument()
+ const path = within(
+ screen.getByRole('navigation', {
+ name: 'app.accessControlDialog.operateGroupAndMember.allMembers',
+ }),
+ )
+ expect(path.getAllByRole('listitem')).toHaveLength(2)
+ expect(path.getByText(baseGroup.name)).toHaveAttribute('aria-current', 'location')
expect(screen.getByRole('status')).toHaveTextContent(
'app.accessControlDialog.operateGroupAndMember.noResult',
)
diff --git a/web/app/components/app/app-access-control/__tests__/group-picker-layout.browser.spec.tsx b/web/app/components/app/app-access-control/__tests__/group-picker-layout.browser.spec.tsx
new file mode 100644
index 00000000000..84f27fe0d69
--- /dev/null
+++ b/web/app/components/app/app-access-control/__tests__/group-picker-layout.browser.spec.tsx
@@ -0,0 +1,62 @@
+import { render } from 'vitest-browser-react'
+import { SubjectType } from '@/models/access-control'
+import AddMemberOrGroupDialog from '../add-member-or-group-pop'
+
+const groupName =
+ 'Research and development platform engineering operations team supporting international infrastructure and customer experience across all business divisions'
+vi.mock('react-i18next', async () => {
+ const { createReactI18nextMock } = await import('@/test/i18n-mock')
+ return createReactI18nextMock({
+ 'common.operation.add': 'Add',
+ 'app.accessControlDialog.operateGroupAndMember.expand': 'Expand',
+ 'app.accessControlDialog.operateGroupAndMember.allMembers': 'All members',
+ 'app.accessControlDialog.operateGroupAndMember.searchPlaceholder': 'Search',
+ })
+})
+vi.mock('@/service/access-control', () => ({
+ useSearchForWhiteListCandidates: (query: { groupId?: string }) => ({
+ isLoading: false,
+ isFetchingNextPage: false,
+ fetchNextPage: vi.fn(),
+ data: {
+ pages: [
+ {
+ currPage: 1,
+ hasMore: false,
+ subjects: [
+ {
+ subjectId: query.groupId ? 'nested' : 'group',
+ subjectType: SubjectType.GROUP,
+ groupData: {
+ id: query.groupId ? 'nested' : 'group',
+ name: query.groupId ? 'Child group' : groupName,
+ groupSize: 1,
+ },
+ },
+ ],
+ },
+ ],
+ },
+ }),
+}))
+
+it('keeps a long group path between search and the next selectable row', async () => {
+ const screen = await render(
+ <AddMemberOrGroupDialog subjects={{ groups: [], members: [] }} onChange={() => {}} />,
+ )
+ await screen.getByRole('button', { name: 'Add', exact: true }).click()
+ await screen.getByRole('button', { name: 'Expand', exact: true }).click()
+
+ const navigation = screen.getByRole('navigation', { name: 'All members' }).element()
+ const text = document.createRange()
+ text.selectNodeContents(screen.getByText(groupName, { exact: true }).element())
+ const search = screen.getByRole('searchbox', { name: 'Search' }).element()
+ const nextRow = screen.getByRole('button', { name: 'Child group 1' }).element()
+
+ for (const line of text.getClientRects()) {
+ expect(line.top).toBeGreaterThanOrEqual(search.getBoundingClientRect().bottom)
+ expect(line.bottom).toBeLessThanOrEqual(nextRow.getBoundingClientRect().top)
+ expect(line.left).toBeGreaterThanOrEqual(navigation.getBoundingClientRect().left)
+ expect(line.right).toBeLessThanOrEqual(navigation.getBoundingClientRect().right)
+ }
+})
diff --git a/web/app/components/app/app-access-control/add-member-or-group-pop/breadcrumb.tsx b/web/app/components/app/app-access-control/add-member-or-group-pop/breadcrumb.tsx
index 235e82503aa..454429003de 100644
--- a/web/app/components/app/app-access-control/add-member-or-group-pop/breadcrumb.tsx
+++ b/web/app/components/app/app-access-control/add-member-or-group-pop/breadcrumb.tsx
@@ -1,4 +1,12 @@
import type { AccessControlGroup } from '@/models/access-control'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbList,
+ BreadcrumbPage,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
+import { Fragment } from 'react'
import { useTranslation } from 'react-i18next'
type SelectedGroupsBreadcrumbProps = {
@@ -18,43 +26,59 @@ export function SelectedGroupsBreadcrumb({ groups, onChange }: SelectedGroupsBre
const hasBreadcrumb = groups.length > 0
return (
- <div className="flex h-7 items-center gap-x-0.5 px-2 py-0.5">
- {hasBreadcrumb ? (
- <button
- type="button"
- className="cursor-pointer border-none bg-transparent p-0 text-left system-xs-regular text-text-accent focus-visible:ring-1 focus-visible:ring-components-input-border-active focus-visible:outline-hidden"
- onClick={handleReset}
- >
- {t(($) => $['accessControlDialog.operateGroupAndMember.allMembers'], { ns: 'app' })}
- </button>
- ) : (
- <span className="system-xs-regular text-text-tertiary">
- {t(($) => $['accessControlDialog.operateGroupAndMember.allMembers'], { ns: 'app' })}
- </span>
- )}
- {groups.map((group, index) => {
- const isLastGroup = index === groups.length - 1
-
- return (
- <div
- key={group.id}
- className="flex items-center gap-x-0.5 system-xs-regular text-text-tertiary"
- >
- <span>/</span>
- {isLastGroup ? (
- <span>{group.name}</span>
- ) : (
- <button
- type="button"
- className="cursor-pointer border-none bg-transparent p-0 text-left system-xs-regular text-text-accent focus-visible:ring-1 focus-visible:ring-components-input-border-active focus-visible:outline-hidden"
- onClick={() => handleBreadcrumbClick(index)}
- >
- {group.name}
- </button>
- )}
- </div>
- )
+ <Breadcrumb
+ aria-label={t(($) => $['accessControlDialog.operateGroupAndMember.allMembers'], {
+ ns: 'app',
})}
- </div>
+ className="flex min-h-7 items-center px-2 py-0.5"
+ >
+ <BreadcrumbList className="flex-1 gap-0.5 text-xs/4">
+ <BreadcrumbItem className="shrink-0">
+ {hasBreadcrumb ? (
+ <button
+ type="button"
+ className="min-w-0 cursor-pointer text-left wrap-anywhere text-text-accent focus-visible:ring-1 focus-visible:ring-components-input-border-active focus-visible:outline-hidden"
+ onClick={handleReset}
+ >
+ {t(($) => $['accessControlDialog.operateGroupAndMember.allMembers'], { ns: 'app' })}
+ </button>
+ ) : (
+ <BreadcrumbPage
+ aria-current="location"
+ className="wrap-anywhere whitespace-normal text-text-tertiary"
+ >
+ {t(($) => $['accessControlDialog.operateGroupAndMember.allMembers'], { ns: 'app' })}
+ </BreadcrumbPage>
+ )}
+ </BreadcrumbItem>
+ {groups.map((group, index) => {
+ const isLastGroup = index === groups.length - 1
+
+ return (
+ <Fragment key={group.id}>
+ <BreadcrumbSeparator className="text-text-tertiary" />
+ <BreadcrumbItem>
+ {isLastGroup ? (
+ <BreadcrumbPage
+ aria-current="location"
+ className="wrap-anywhere whitespace-normal text-text-tertiary"
+ >
+ {group.name}
+ </BreadcrumbPage>
+ ) : (
+ <button
+ type="button"
+ className="min-w-0 cursor-pointer text-left wrap-anywhere text-text-accent focus-visible:ring-1 focus-visible:ring-components-input-border-active focus-visible:outline-hidden"
+ onClick={() => handleBreadcrumbClick(index)}
+ >
+ {group.name}
+ </button>
+ )}
+ </BreadcrumbItem>
+ </Fragment>
+ )
+ })}
+ </BreadcrumbList>
+ </Breadcrumb>
)
}
diff --git a/web/app/components/app/app-access-control/add-member-or-group-pop/index.tsx b/web/app/components/app/app-access-control/add-member-or-group-pop/index.tsx
index e80cc9ce1d5..53c07cc0de3 100644
--- a/web/app/components/app/app-access-control/add-member-or-group-pop/index.tsx
+++ b/web/app/components/app/app-access-control/add-member-or-group-pop/index.tsx
@@ -155,12 +155,10 @@ export default function AddMemberOrGroupDialog({
/>
</div>
{shouldShowBreadcrumb && (
- <div className="flex h-7 items-center px-2 py-0.5">
- <SelectedGroupsBreadcrumb
- groups={selectedGroupsForBreadcrumb}
- onChange={setSelectedGroupsForBreadcrumb}
- />
- </div>
+ <SelectedGroupsBreadcrumb
+ groups={selectedGroupsForBreadcrumb}
+ onChange={setSelectedGroupsForBreadcrumb}
+ />
)}
{hasResults && (
<ul className="p-1">
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/bucket.spec.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/bucket.spec.tsx
deleted file mode 100644
index 98296d92ea9..00000000000
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/bucket.spec.tsx
+++ /dev/null
@@ -1,46 +0,0 @@
-import { fireEvent, render, screen } from '@testing-library/react'
-import { beforeEach, describe, expect, it, vi } from 'vite-plus/test'
-import Bucket from '../bucket'
-
-describe('Bucket', () => {
- const defaultProps = {
- bucketName: 'my-bucket',
- handleBackToBucketList: vi.fn(),
- handleClickBucketName: vi.fn(),
- }
-
- beforeEach(() => {
- vi.clearAllMocks()
- })
-
- it('should render bucket name', () => {
- render(<Bucket {...defaultProps} />)
- expect(screen.getByText('my-bucket'))!.toBeInTheDocument()
- })
-
- it('should call handleBackToBucketList on icon button click', () => {
- render(<Bucket {...defaultProps} />)
- fireEvent.click(
- screen.getByRole('button', { name: 'datasetPipeline.onlineDrive.breadcrumbs.allBuckets' }),
- )
- expect(defaultProps.handleBackToBucketList).toHaveBeenCalledOnce()
- })
-
- it('should call handleClickBucketName on name click', () => {
- render(<Bucket {...defaultProps} />)
- fireEvent.click(screen.getByText('my-bucket'))
- expect(defaultProps.handleClickBucketName).toHaveBeenCalledOnce()
- })
-
- it('should not call handleClickBucketName when disabled', () => {
- render(<Bucket {...defaultProps} disabled={true} />)
- fireEvent.click(screen.getByText('my-bucket'))
- expect(defaultProps.handleClickBucketName).not.toHaveBeenCalled()
- })
-
- it('should show separator by default', () => {
- render(<Bucket {...defaultProps} />)
- const separators = screen.getAllByText('/')
- expect(separators.length).toBeGreaterThanOrEqual(2) // One after icon, one after name
- })
-})
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/drive.spec.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/drive.spec.tsx
deleted file mode 100644
index fc76193e899..00000000000
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/drive.spec.tsx
+++ /dev/null
@@ -1,63 +0,0 @@
-import { fireEvent, render, screen } from '@testing-library/react'
-import { beforeEach, describe, expect, it, vi } from 'vite-plus/test'
-import Drive from '../drive'
-
-describe('Drive', () => {
- const defaultProps = {
- breadcrumbs: [] as string[],
- handleBackToRoot: vi.fn(),
- }
-
- beforeEach(() => {
- vi.clearAllMocks()
- })
-
- // Rendering: button text and separator visibility
- describe('Rendering', () => {
- it('should render "All Files" button text', () => {
- render(<Drive {...defaultProps} />)
-
- expect(screen.getByRole('button')).toHaveTextContent(
- 'datasetPipeline.onlineDrive.breadcrumbs.allFiles',
- )
- })
-
- it('should show separator "/" when breadcrumbs has items', () => {
- render(<Drive {...defaultProps} breadcrumbs={['Folder A']} />)
-
- expect(screen.getByText('/')).toBeInTheDocument()
- })
-
- it('should hide separator when breadcrumbs is empty', () => {
- render(<Drive {...defaultProps} breadcrumbs={[]} />)
-
- expect(screen.queryByText('/')).not.toBeInTheDocument()
- })
- })
-
- // Props: disabled state depends on breadcrumbs length
- describe('Props', () => {
- it('should disable button when breadcrumbs is empty', () => {
- render(<Drive {...defaultProps} breadcrumbs={[]} />)
-
- expect(screen.getByRole('button')).toBeDisabled()
- })
-
- it('should enable button when breadcrumbs has items', () => {
- render(<Drive {...defaultProps} breadcrumbs={['Folder A', 'Folder B']} />)
-
- expect(screen.getByRole('button')).not.toBeDisabled()
- })
- })
-
- // User interactions: clicking the root button
- describe('User Interactions', () => {
- it('should call handleBackToRoot on click when enabled', () => {
- render(<Drive {...defaultProps} breadcrumbs={['Folder A']} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- expect(defaultProps.handleBackToRoot).toHaveBeenCalledOnce()
- })
- })
-})
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/index.spec.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/index.spec.tsx
index 0b33f25a468..c64537ccbd9 100644
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/index.spec.tsx
+++ b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/index.spec.tsx
@@ -1,9 +1,9 @@
-import { fireEvent, render, screen } from '@testing-library/react'
-import * as React from 'react'
+import type { ComponentProps } from 'react'
+import { render, screen, within } from '@testing-library/react'
+import userEvent from '@testing-library/user-event'
import Breadcrumbs from '../index'
-// Mock store - context provider requires mocking
-const mockStoreState = {
+const store = {
hasBucket: false,
breadcrumbs: [] as string[],
prefix: [] as string[],
@@ -14,1017 +14,152 @@ const mockStoreState = {
setBucket: vi.fn(),
}
-const mockGetState = vi.fn(() => mockStoreState)
-const mockDataSourceStore = { getState: mockGetState }
-
vi.mock('../../../../../store', () => ({
- useDataSourceStore: () => mockDataSourceStore,
- useDataSourceStoreWithSelector: (selector: (s: typeof mockStoreState) => unknown) =>
- selector(mockStoreState),
+ useDataSourceStore: () => ({ getState: () => store }),
+ useDataSourceStoreWithSelector: (selector: (state: typeof store) => unknown) => selector(store),
}))
-type BreadcrumbsProps = React.ComponentProps<typeof Breadcrumbs>
-
-const createDefaultProps = (overrides?: Partial<BreadcrumbsProps>): BreadcrumbsProps => ({
- breadcrumbs: [],
- keywords: '',
- bucket: '',
- searchResultsLength: 0,
- isInPipeline: false,
- ...overrides,
-})
-
-const resetMockStoreState = () => {
- mockStoreState.hasBucket = false
- mockStoreState.breadcrumbs = []
- mockStoreState.prefix = []
- mockStoreState.setOnlineDriveFileList = vi.fn()
- mockStoreState.setSelectedFileIds = vi.fn()
- mockStoreState.setBreadcrumbs = vi.fn()
- mockStoreState.setPrefix = vi.fn()
- mockStoreState.setBucket = vi.fn()
-}
-
-const getDropdownTrigger = () => {
- return document.querySelector('[aria-haspopup="menu"]') as HTMLElement | null
+function renderPath(overrides: Partial<ComponentProps<typeof Breadcrumbs>> = {}) {
+ const props = {
+ breadcrumbs: ['Documents', 'Reports'],
+ keywords: '',
+ bucket: '',
+ searchResultsLength: 0,
+ isInPipeline: false,
+ ...overrides,
+ }
+ store.breadcrumbs = props.breadcrumbs
+ store.prefix = props.breadcrumbs.map((_, index) => `prefix-${index}`)
+ return render(<Breadcrumbs {...props} />)
}
-const openCollapsedBreadcrumbDropdown = () => {
- const dropdownTrigger = getDropdownTrigger()
- expect(dropdownTrigger).toBeInTheDocument()
- fireEvent.click(dropdownTrigger as HTMLElement)
-}
-
-describe('Breadcrumbs', () => {
- beforeEach(() => {
- vi.clearAllMocks()
- resetMockStoreState()
- })
-
- describe('Rendering', () => {
- describe('Search Results Display', () => {
- it('should show search results when keywords and searchResultsLength > 0', () => {
- const props = createDefaultProps({
- keywords: 'test',
- searchResultsLength: 5,
- breadcrumbs: ['folder1'],
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Search result text should be displayed
- // Assert - Search result text should be displayed
- expect(
- screen.getByText(/datasetPipeline\.onlineDrive\.breadcrumbs\.searchResult/),
- )!.toBeInTheDocument()
- })
-
- it('should not show search results when keywords is empty', () => {
- const props = createDefaultProps({
- keywords: '',
- searchResultsLength: 5,
- breadcrumbs: ['folder1'],
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.queryByText(/searchResult/)).not.toBeInTheDocument()
- })
-
- it('should not show search results when searchResultsLength is 0', () => {
- const props = createDefaultProps({
- keywords: 'test',
- searchResultsLength: 0,
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.queryByText(/searchResult/)).not.toBeInTheDocument()
- })
-
- it('should use bucket as folderName when breadcrumbs is empty', () => {
- const props = createDefaultProps({
- keywords: 'test',
- searchResultsLength: 5,
- breadcrumbs: [],
- bucket: 'my-bucket',
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Should use bucket name in search result
- // Assert - Should use bucket name in search result
- expect(screen.getByText(/searchResult.*my-bucket/i))!.toBeInTheDocument()
- })
-
- it('should use last breadcrumb as folderName when breadcrumbs exist', () => {
- const props = createDefaultProps({
- keywords: 'test',
- searchResultsLength: 5,
- breadcrumbs: ['folder1', 'folder2'],
- bucket: 'my-bucket',
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Should use last breadcrumb in search result
- // Assert - Should use last breadcrumb in search result
- expect(screen.getByText(/searchResult.*folder2/i))!.toBeInTheDocument()
- })
- })
-
- describe('All Buckets Title Display', () => {
- it('should show all buckets title when hasBucket=true, bucket is empty, and no breadcrumbs', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- breadcrumbs: [],
- bucket: '',
- keywords: '',
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(
- screen.getByText('datasetPipeline.onlineDrive.breadcrumbs.allBuckets'),
- )!.toBeInTheDocument()
- })
-
- it('should not show all buckets title when breadcrumbs exist', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- breadcrumbs: ['folder1'],
- bucket: '',
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(
- screen.queryByText('datasetPipeline.onlineDrive.breadcrumbs.allBuckets'),
- ).not.toBeInTheDocument()
- })
-
- it('should not show all buckets title when bucket is set', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- breadcrumbs: [],
- bucket: 'my-bucket',
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- // Assert - Should show bucket name instead
- expect(
- screen.queryByText('datasetPipeline.onlineDrive.breadcrumbs.allBuckets'),
- ).not.toBeInTheDocument()
- })
- })
-
- describe('Bucket Component Display', () => {
- it('should render Bucket component when hasBucket and bucket are set', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- bucket: 'test-bucket',
- breadcrumbs: [],
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Bucket name should be displayed
- // Assert - Bucket name should be displayed
- expect(screen.getByText('test-bucket'))!.toBeInTheDocument()
- })
-
- it('should not render Bucket when hasBucket is false', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- bucket: 'test-bucket',
- breadcrumbs: [],
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- // Assert - Bucket should not be displayed, Drive should be shown instead
- expect(screen.queryByText('test-bucket')).not.toBeInTheDocument()
- })
- })
-
- describe('Drive Component Display', () => {
- it('should render Drive component when hasBucket is false', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: [],
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - "All Files" should be displayed
- // Assert - "All Files" should be displayed
- expect(
- screen.getByText('datasetPipeline.onlineDrive.breadcrumbs.allFiles'),
- )!.toBeInTheDocument()
- })
-
- it('should not render Drive component when hasBucket is true', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- bucket: 'test-bucket',
- breadcrumbs: [],
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(
- screen.queryByText('datasetPipeline.onlineDrive.breadcrumbs.allFiles'),
- ).not.toBeInTheDocument()
- })
- })
-
- describe('BreadcrumbItem Display', () => {
- it('should render all breadcrumbs when not collapsed', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['folder1', 'folder2'],
- isInPipeline: false,
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.getByText('folder1'))!.toBeInTheDocument()
- expect(screen.getByText('folder2'))!.toBeInTheDocument()
- })
-
- it('should render last breadcrumb as active', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['folder1', 'folder2'],
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Last breadcrumb should have active styles
- const lastBreadcrumb = screen.getByText('folder2')
- expect(lastBreadcrumb)!.toHaveClass('system-sm-medium')
- expect(lastBreadcrumb)!.toHaveClass('text-text-secondary')
- })
- })
-
- describe('Collapsed Breadcrumbs (Dropdown)', () => {
- it('should show dropdown when breadcrumbs exceed displayBreadcrumbNum', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['folder1', 'folder2', 'folder3', 'folder4'],
- isInPipeline: false, // displayBreadcrumbNum = 3
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.getByRole('button', { name: 'common.operation.more' }))!.toBeInTheDocument()
- })
-
- it('should not show dropdown when breadcrumbs do not exceed displayBreadcrumbNum', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['folder1', 'folder2'],
- isInPipeline: false, // displayBreadcrumbNum = 3
- })
-
- const { container } = render(<Breadcrumbs {...props} />)
-
- // Assert - Should not have dropdown, just regular breadcrumbs
- // All breadcrumbs should be directly visible
- // Assert - Should not have dropdown, just regular breadcrumbs
- // All breadcrumbs should be directly visible
- expect(screen.getByText('folder1'))!.toBeInTheDocument()
- expect(screen.getByText('folder2'))!.toBeInTheDocument()
- // Count buttons - should be 3 (allFiles + folder1 + folder2)
- const buttons = container.querySelectorAll('button')
- expect(buttons.length).toBe(3)
- })
-
- it('should show prefix breadcrumbs and last breadcrumb when collapsed', async () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['folder1', 'folder2', 'folder3', 'folder4', 'folder5'],
- isInPipeline: false, // displayBreadcrumbNum = 3
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - First breadcrumb and last breadcrumb should be visible
- // Assert - First breadcrumb and last breadcrumb should be visible
- expect(screen.getByText('folder1'))!.toBeInTheDocument()
- expect(screen.getByText('folder2'))!.toBeInTheDocument()
- expect(screen.getByText('folder5'))!.toBeInTheDocument()
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- // Middle breadcrumbs should be in dropdown
- expect(screen.queryByText('folder3')).not.toBeInTheDocument()
- expect(screen.queryByText('folder4')).not.toBeInTheDocument()
- })
-
- it('should show collapsed breadcrumbs in dropdown when clicked', async () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['folder1', 'folder2', 'folder3', 'folder4', 'folder5'],
- isInPipeline: false,
- })
- render(<Breadcrumbs {...props} />)
-
- // Act - Click on dropdown trigger (the ... button)
- openCollapsedBreadcrumbDropdown()
-
- // Assert - Collapsed breadcrumbs should be visible
- expect(await screen.findByText('folder3')).toBeInTheDocument()
- expect(await screen.findByText('folder4')).toBeInTheDocument()
- })
- })
- })
-
- describe('Props', () => {
- describe('breadcrumbs prop', () => {
- it('should handle empty breadcrumbs array', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({ breadcrumbs: [] })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Only Drive should be visible
- // Assert - Only Drive should be visible
- expect(
- screen.getByText('datasetPipeline.onlineDrive.breadcrumbs.allFiles'),
- )!.toBeInTheDocument()
- })
-
- it('should handle single breadcrumb', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({ breadcrumbs: ['single-folder'] })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.getByText('single-folder'))!.toBeInTheDocument()
- })
-
- it('should handle breadcrumbs with special characters', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['folder [1]', 'folder (copy)'],
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.getByText('folder [1]'))!.toBeInTheDocument()
- expect(screen.getByText('folder (copy)'))!.toBeInTheDocument()
- })
-
- it('should handle breadcrumbs with unicode characters', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['文件夹', 'フォルダ'],
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.getByText('文件夹'))!.toBeInTheDocument()
- expect(screen.getByText('フォルダ'))!.toBeInTheDocument()
- })
- })
-
- describe('keywords prop', () => {
- it('should show search results when keywords is non-empty with results', () => {
- const props = createDefaultProps({
- keywords: 'search-term',
- searchResultsLength: 10,
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.getByText(/searchResult/))!.toBeInTheDocument()
- })
-
- it('should handle whitespace keywords', () => {
- const props = createDefaultProps({
- keywords: ' ',
- searchResultsLength: 5,
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Whitespace is truthy, so should show search results
- // Assert - Whitespace is truthy, so should show search results
- expect(screen.getByText(/searchResult/))!.toBeInTheDocument()
- })
- })
-
- describe('bucket prop', () => {
- it('should display bucket name when hasBucket and bucket are set', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- bucket: 'production-bucket',
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.getByText('production-bucket'))!.toBeInTheDocument()
- })
+const allFiles = 'datasetPipeline.onlineDrive.breadcrumbs.allFiles'
+const allBuckets = 'datasetPipeline.onlineDrive.breadcrumbs.allBuckets'
- it('should handle bucket with special characters', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- bucket: 'bucket-v2.0_backup',
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.getByText('bucket-v2.0_backup'))!.toBeInTheDocument()
- })
- })
-
- describe('searchResultsLength prop', () => {
- it('should handle zero searchResultsLength', () => {
- const props = createDefaultProps({
- keywords: 'test',
- searchResultsLength: 0,
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- // Assert - Should not show search results
- expect(screen.queryByText(/searchResult/)).not.toBeInTheDocument()
- })
-
- it('should handle large searchResultsLength', () => {
- const props = createDefaultProps({
- keywords: 'test',
- searchResultsLength: 10000,
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.getByText(/searchResult.*10000/))!.toBeInTheDocument()
- })
- })
-
- describe('isInPipeline prop', () => {
- it('should use displayBreadcrumbNum=2 when isInPipeline is true', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['folder1', 'folder2', 'folder3'],
- isInPipeline: true, // displayBreadcrumbNum = 2
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Should collapse because 3 > 2
- // Dropdown should be present
- expect(getDropdownTrigger()).toBeInTheDocument()
- })
-
- it('should use displayBreadcrumbNum=3 when isInPipeline is false', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['folder1', 'folder2', 'folder3'],
- isInPipeline: false, // displayBreadcrumbNum = 3
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Should NOT collapse because 3 <= 3
- // Assert - Should NOT collapse because 3 <= 3
- expect(screen.getByText('folder1'))!.toBeInTheDocument()
- expect(screen.getByText('folder2'))!.toBeInTheDocument()
- expect(screen.getByText('folder3'))!.toBeInTheDocument()
- })
-
- it('should reduce displayBreadcrumbNum by 1 when bucket is set', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- breadcrumbs: ['folder1', 'folder2', 'folder3'],
- bucket: 'my-bucket',
- isInPipeline: false, // displayBreadcrumbNum = 3 - 1 = 2
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Should collapse because 3 > 2
- expect(getDropdownTrigger()).toBeInTheDocument()
- })
- })
- })
-
- // Memoization Logic and Dependencies Tests
- describe('Memoization Logic and Dependencies', () => {
- describe('displayBreadcrumbNum useMemo', () => {
- it('should calculate correct value when isInPipeline=false and no bucket', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['a', 'b', 'c', 'd'],
- isInPipeline: false,
- bucket: '',
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - displayBreadcrumbNum = 3, so 4 breadcrumbs should collapse
- // First 2 visible, dropdown, last 1 visible
- // Assert - displayBreadcrumbNum = 3, so 4 breadcrumbs should collapse
- // First 2 visible, dropdown, last 1 visible
- expect(screen.getByText('a'))!.toBeInTheDocument()
- expect(screen.getByText('b'))!.toBeInTheDocument()
- expect(screen.getByText('d'))!.toBeInTheDocument()
- expect(screen.queryByText('c')).not.toBeInTheDocument()
- })
-
- it('should calculate correct value when isInPipeline=true and no bucket', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['a', 'b', 'c'],
- isInPipeline: true,
- bucket: '',
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - displayBreadcrumbNum = 2, so 3 breadcrumbs should collapse
- // Assert - displayBreadcrumbNum = 2, so 3 breadcrumbs should collapse
- expect(screen.getByText('a'))!.toBeInTheDocument()
- expect(screen.getByText('c'))!.toBeInTheDocument()
- expect(screen.queryByText('b')).not.toBeInTheDocument()
- })
-
- it('should calculate correct value when isInPipeline=false and bucket exists', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- breadcrumbs: ['a', 'b', 'c'],
- isInPipeline: false,
- bucket: 'my-bucket',
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - displayBreadcrumbNum = 3 - 1 = 2, so 3 breadcrumbs should collapse
- // Assert - displayBreadcrumbNum = 3 - 1 = 2, so 3 breadcrumbs should collapse
- expect(screen.getByText('a'))!.toBeInTheDocument()
- expect(screen.getByText('c'))!.toBeInTheDocument()
- expect(screen.queryByText('b')).not.toBeInTheDocument()
- })
- })
-
- describe('breadcrumbsConfig useMemo', () => {
- it('should correctly split breadcrumbs when collapsed', async () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['f1', 'f2', 'f3', 'f4', 'f5'],
- isInPipeline: false, // displayBreadcrumbNum = 3
- })
- render(<Breadcrumbs {...props} />)
-
- // Act - Click dropdown to see collapsed items
- openCollapsedBreadcrumbDropdown()
-
- // prefixBreadcrumbs = ['f1', 'f2']
- // collapsedBreadcrumbs = ['f3', 'f4']
- // lastBreadcrumb = 'f5'
- expect(screen.getByText('f1')).toBeInTheDocument()
- expect(screen.getByText('f2')).toBeInTheDocument()
- expect(screen.getByText('f5')).toBeInTheDocument()
- expect(await screen.findByText('f3')).toBeInTheDocument()
- expect(await screen.findByText('f4')).toBeInTheDocument()
- })
-
- it('should not collapse when breadcrumbs.length <= displayBreadcrumbNum', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['f1', 'f2'],
- isInPipeline: false, // displayBreadcrumbNum = 3
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - All breadcrumbs should be visible
- // Assert - All breadcrumbs should be visible
- expect(screen.getByText('f1'))!.toBeInTheDocument()
- expect(screen.getByText('f2'))!.toBeInTheDocument()
- })
- })
- })
-
- // Callback Stability and Event Handlers Tests
- describe('Callback Stability and Event Handlers', () => {
- describe('handleBackToBucketList', () => {
- it('should reset store state when called', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- bucket: 'my-bucket',
- breadcrumbs: [],
- })
- render(<Breadcrumbs {...props} />)
-
- // Act - Click bucket icon button (first button in Bucket component)
- const buttons = screen.getAllByRole('button')
- fireEvent.click(buttons[0]!) // Bucket icon button
-
- expect(mockStoreState.setOnlineDriveFileList).toHaveBeenCalledWith([])
- expect(mockStoreState.setSelectedFileIds).toHaveBeenCalledWith([])
- expect(mockStoreState.setBucket).toHaveBeenCalledWith('')
- expect(mockStoreState.setBreadcrumbs).toHaveBeenCalledWith([])
- expect(mockStoreState.setPrefix).toHaveBeenCalledWith([])
- })
- })
-
- describe('handleClickBucketName', () => {
- it('should reset breadcrumbs and prefix when bucket name is clicked', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- bucket: 'my-bucket',
- breadcrumbs: ['folder1'],
- })
- render(<Breadcrumbs {...props} />)
-
- // Act - Click bucket name button
- const bucketButton = screen.getByText('my-bucket')
- fireEvent.click(bucketButton)
-
- expect(mockStoreState.setOnlineDriveFileList).toHaveBeenCalledWith([])
- expect(mockStoreState.setSelectedFileIds).toHaveBeenCalledWith([])
- expect(mockStoreState.setBreadcrumbs).toHaveBeenCalledWith([])
- expect(mockStoreState.setPrefix).toHaveBeenCalledWith([])
- })
-
- it('should not call handler when bucket is disabled (no breadcrumbs)', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- bucket: 'my-bucket',
- breadcrumbs: [], // disabled when no breadcrumbs
- })
- render(<Breadcrumbs {...props} />)
-
- // Act - Click bucket name button (should be disabled)
- const bucketButton = screen.getByText('my-bucket')
- fireEvent.click(bucketButton)
-
- // Assert - Store methods should NOT be called because button is disabled
- expect(mockStoreState.setOnlineDriveFileList).not.toHaveBeenCalled()
- })
- })
-
- describe('handleBackToRoot', () => {
- it('should reset state when Drive button is clicked', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['folder1'],
- })
- render(<Breadcrumbs {...props} />)
-
- // Act - Click "All Files" button
- const driveButton = screen.getByText('datasetPipeline.onlineDrive.breadcrumbs.allFiles')
- fireEvent.click(driveButton)
-
- expect(mockStoreState.setOnlineDriveFileList).toHaveBeenCalledWith([])
- expect(mockStoreState.setSelectedFileIds).toHaveBeenCalledWith([])
- expect(mockStoreState.setBreadcrumbs).toHaveBeenCalledWith([])
- expect(mockStoreState.setPrefix).toHaveBeenCalledWith([])
- })
- })
-
- describe('handleClickBreadcrumb', () => {
- it('should slice breadcrumbs and prefix when breadcrumb is clicked', () => {
- mockStoreState.hasBucket = false
- mockStoreState.breadcrumbs = ['folder1', 'folder2', 'folder3']
- mockStoreState.prefix = ['prefix1', 'prefix2', 'prefix3']
- const props = createDefaultProps({
- breadcrumbs: ['folder1', 'folder2', 'folder3'],
- })
- render(<Breadcrumbs {...props} />)
-
- // Act - Click on first breadcrumb (index 0)
- const firstBreadcrumb = screen.getByText('folder1')
- fireEvent.click(firstBreadcrumb)
-
- // Assert - Should slice to index 0 + 1 = 1
- expect(mockStoreState.setOnlineDriveFileList).toHaveBeenCalledWith([])
- expect(mockStoreState.setSelectedFileIds).toHaveBeenCalledWith([])
- expect(mockStoreState.setBreadcrumbs).toHaveBeenCalledWith(['folder1'])
- expect(mockStoreState.setPrefix).toHaveBeenCalledWith(['prefix1'])
- })
-
- it('should not call handler when last breadcrumb is clicked (disabled)', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: ['folder1', 'folder2'],
- })
- render(<Breadcrumbs {...props} />)
-
- // Act - Click on last breadcrumb (should be disabled)
- const lastBreadcrumb = screen.getByText('folder2')
- fireEvent.click(lastBreadcrumb)
-
- // Assert - Store methods should NOT be called
- expect(mockStoreState.setBreadcrumbs).not.toHaveBeenCalled()
- })
-
- it('should handle click on collapsed breadcrumb from dropdown', async () => {
- mockStoreState.hasBucket = false
- mockStoreState.breadcrumbs = ['f1', 'f2', 'f3', 'f4', 'f5']
- mockStoreState.prefix = ['p1', 'p2', 'p3', 'p4', 'p5']
- const props = createDefaultProps({
- breadcrumbs: ['f1', 'f2', 'f3', 'f4', 'f5'],
- isInPipeline: false,
- })
- render(<Breadcrumbs {...props} />)
-
- // Act - Open dropdown and click on collapsed breadcrumb (f3, index=2)
- openCollapsedBreadcrumbDropdown()
- fireEvent.click(await screen.findByText('f3'))
-
- // Assert - Should slice to index 2 + 1 = 3
- expect(mockStoreState.setBreadcrumbs).toHaveBeenCalledWith(['f1', 'f2', 'f3'])
- expect(mockStoreState.setPrefix).toHaveBeenCalledWith(['p1', 'p2', 'p3'])
- })
- })
- })
-
- // Component Memoization Tests
- describe('Component Memoization', () => {
- it('should not re-render when props are the same', () => {
- const props = createDefaultProps()
- const { rerender } = render(<Breadcrumbs {...props} />)
-
- // Act - Rerender with same props
- rerender(<Breadcrumbs {...props} />)
-
- // Assert - Component should render without errors
- const container = document.querySelector('.flex.grow')
- expect(container)!.toBeInTheDocument()
- })
-
- it('should re-render when breadcrumbs change', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({ breadcrumbs: ['folder1'] })
- const { rerender } = render(<Breadcrumbs {...props} />)
- expect(screen.getByText('folder1'))!.toBeInTheDocument()
-
- // Act - Rerender with different breadcrumbs
- rerender(<Breadcrumbs {...createDefaultProps({ breadcrumbs: ['folder2'] })} />)
-
- expect(screen.getByText('folder2'))!.toBeInTheDocument()
- })
- })
-
- // Edge Cases and Error Handling Tests
- describe('Edge Cases and Error Handling', () => {
- it('should handle very long breadcrumb names', () => {
- mockStoreState.hasBucket = false
- const longName = 'a'.repeat(100)
- const props = createDefaultProps({
- breadcrumbs: [longName],
- })
-
- render(<Breadcrumbs {...props} />)
-
- expect(screen.getByText(longName))!.toBeInTheDocument()
- })
-
- it('should handle many breadcrumbs', async () => {
- mockStoreState.hasBucket = false
- const manyBreadcrumbs = Array.from({ length: 20 }, (_, i) => `folder-${i}`)
- const props = createDefaultProps({
- breadcrumbs: manyBreadcrumbs,
- })
- render(<Breadcrumbs {...props} />)
-
- // Act - Open dropdown
- openCollapsedBreadcrumbDropdown()
-
- // Assert - First, last, and collapsed should be accessible
- expect(screen.getByText('folder-0')).toBeInTheDocument()
- expect(screen.getByText('folder-1')).toBeInTheDocument()
- expect(screen.getByText('folder-19')).toBeInTheDocument()
- expect(await screen.findByText('folder-2')).toBeInTheDocument()
- })
-
- it('should handle empty bucket string', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- bucket: '',
- breadcrumbs: [],
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Should show all buckets title
- // Assert - Should show all buckets title
- expect(
- screen.getByText('datasetPipeline.onlineDrive.breadcrumbs.allBuckets'),
- )!.toBeInTheDocument()
- })
-
- it('should handle breadcrumb with only whitespace', () => {
- mockStoreState.hasBucket = false
- const props = createDefaultProps({
- breadcrumbs: [' ', 'normal-folder'],
- })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Both should be rendered
- // Assert - Both should be rendered
- expect(screen.getByText('normal-folder'))!.toBeInTheDocument()
- })
- })
-
- describe('Prop Variations', () => {
- it.each([
- { hasBucket: true, bucket: 'b1', breadcrumbs: [], expected: 'bucket visible' },
- { hasBucket: true, bucket: '', breadcrumbs: [], expected: 'all buckets title' },
- { hasBucket: false, bucket: '', breadcrumbs: [], expected: 'all files' },
- { hasBucket: false, bucket: '', breadcrumbs: ['f1'], expected: 'drive with breadcrumb' },
- ])('should render correctly for $expected', ({ hasBucket, bucket, breadcrumbs }) => {
- mockStoreState.hasBucket = hasBucket
- const props = createDefaultProps({ bucket, breadcrumbs })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Component should render without errors
- const container = document.querySelector('.flex.grow')
- expect(container)!.toBeInTheDocument()
- })
-
- it.each([
- { isInPipeline: true, bucket: '', expectedNum: 2 },
- { isInPipeline: false, bucket: '', expectedNum: 3 },
- { isInPipeline: true, bucket: 'b', expectedNum: 1 },
- { isInPipeline: false, bucket: 'b', expectedNum: 2 },
- ])(
- 'should calculate displayBreadcrumbNum=$expectedNum when isInPipeline=$isInPipeline and bucket=$bucket',
- ({ isInPipeline, bucket, expectedNum }) => {
- mockStoreState.hasBucket = !!bucket
- const breadcrumbs = Array.from({ length: expectedNum + 2 }, (_, i) => `f${i}`)
- const props = createDefaultProps({ isInPipeline, bucket, breadcrumbs })
-
- render(<Breadcrumbs {...props} />)
-
- // Assert - Should collapse because breadcrumbs.length > expectedNum
- expect(getDropdownTrigger()).toBeInTheDocument()
- },
- )
- })
+beforeEach(() => {
+ vi.clearAllMocks()
+ store.hasBucket = false
+ store.breadcrumbs = []
+ store.prefix = []
+})
- describe('Integration', () => {
- it('should handle full navigation flow: bucket -> folders -> navigation back', () => {
- mockStoreState.hasBucket = true
- mockStoreState.breadcrumbs = ['folder1', 'folder2']
- mockStoreState.prefix = ['prefix1', 'prefix2']
- const props = createDefaultProps({
- bucket: 'my-bucket',
- breadcrumbs: ['folder1', 'folder2'],
- })
- render(<Breadcrumbs {...props} />)
+it('exposes path items without counting decorative separators and marks the current directory', async () => {
+ const user = userEvent.setup()
+ renderPath()
+ const path = within(screen.getByRole('navigation', { name: allFiles }))
+ expect(path.getAllByRole('listitem')).toHaveLength(3)
+ const current = path.getByRole('button', { name: 'Reports' })
+ expect(current).toHaveAttribute('aria-current', 'location')
+ expect(current).toBeDisabled()
+ await user.click(current)
+ expect(store.setBreadcrumbs).not.toHaveBeenCalled()
+
+ await user.click(path.getByRole('button', { name: 'Documents' }))
+ expect(store.setBreadcrumbs).toHaveBeenCalledWith(['Documents'])
+ expect(store.setPrefix).toHaveBeenCalledWith(['prefix-0'])
+ expect(store.setOnlineDriveFileList).toHaveBeenCalledWith([])
+ expect(store.setSelectedFileIds).toHaveBeenCalledWith([])
+})
- // Act - Click on first folder to navigate back
- const firstFolder = screen.getByText('folder1')
- fireEvent.click(firstFolder)
+it('returns to the drive root and disables root navigation once already there', async () => {
+ const user = userEvent.setup()
+ const { rerender } = renderPath()
+ await user.click(screen.getByRole('button', { name: allFiles }))
+ expect(store.setBreadcrumbs).toHaveBeenCalledWith([])
+ expect(store.setPrefix).toHaveBeenCalledWith([])
+ expect(store.setOnlineDriveFileList).toHaveBeenCalledWith([])
+ expect(store.setSelectedFileIds).toHaveBeenCalledWith([])
+
+ rerender(
+ <Breadcrumbs
+ breadcrumbs={[]}
+ keywords=""
+ bucket=""
+ searchResultsLength={0}
+ isInPipeline={false}
+ />,
+ )
+ expect(screen.getAllByRole('listitem')).toHaveLength(1)
+ expect(screen.getByRole('button', { name: allFiles })).toBeDisabled()
+ expect(screen.getByRole('button', { name: allFiles })).toHaveAttribute('aria-current', 'location')
+})
- expect(mockStoreState.setBreadcrumbs).toHaveBeenCalledWith(['folder1'])
- expect(mockStoreState.setPrefix).toHaveBeenCalledWith(['prefix1'])
- })
+it('distinguishes returning to the current bucket from leaving it for the bucket list', async () => {
+ const user = userEvent.setup()
+ store.hasBucket = true
+ renderPath({ bucket: 'Storage' })
+ await user.click(screen.getByRole('button', { name: 'Storage' }))
+ expect(store.setBreadcrumbs).toHaveBeenCalledWith([])
+ expect(store.setPrefix).toHaveBeenCalledWith([])
+ expect(store.setBucket).not.toHaveBeenCalled()
+
+ await user.click(screen.getByRole('button', { name: allBuckets }))
+ expect(store.setBucket).toHaveBeenCalledWith('')
+ expect(store.setOnlineDriveFileList).toHaveBeenCalledWith([])
+ expect(store.setSelectedFileIds).toHaveBeenCalledWith([])
+})
- it('should handle search result display with navigation elements hidden', () => {
- mockStoreState.hasBucket = true
- const props = createDefaultProps({
- keywords: 'test',
- searchResultsLength: 5,
- bucket: 'my-bucket',
- breadcrumbs: ['folder1'],
- })
+it('keeps the bucket-list action available at the current bucket root', () => {
+ store.hasBucket = true
+ renderPath({ bucket: 'Storage', breadcrumbs: [] })
+ expect(screen.getByRole('button', { name: allBuckets })).toBeEnabled()
+ expect(screen.getByRole('button', { name: 'Storage' })).toBeDisabled()
+ expect(screen.getByRole('button', { name: 'Storage' })).toHaveAttribute(
+ 'aria-current',
+ 'location',
+ )
+})
- render(<Breadcrumbs {...props} />)
+it.each([
+ { isInPipeline: false, bucket: '', visiblePrefixes: ['A', 'B'] },
+ { isInPipeline: true, bucket: '', visiblePrefixes: ['A'] },
+ { isInPipeline: false, bucket: 'Storage', visiblePrefixes: ['A'] },
+ { isInPipeline: true, bucket: 'Storage', visiblePrefixes: [] },
+])(
+ 'keeps collapsed paths navigable with pipeline=$isInPipeline and bucket=$bucket',
+ async ({ isInPipeline, bucket, visiblePrefixes }) => {
+ const user = userEvent.setup()
+ store.hasBucket = !!bucket
+ renderPath({ breadcrumbs: ['A', 'B', 'C', 'D'], isInPipeline, bucket })
+ for (const name of visiblePrefixes)
+ expect(screen.getByRole('button', { name })).toBeInTheDocument()
+ expect(screen.queryByRole('button', { name: 'C' })).not.toBeInTheDocument()
+ expect(screen.getByRole('button', { name: 'D' })).toHaveAttribute('aria-current', 'location')
+
+ const more = screen.getByRole('button', { name: 'common.operation.more' })
+ more.focus()
+ await user.keyboard('{Enter}')
+ await user.click(await screen.findByRole('menuitem', { name: 'C' }))
+ expect(store.setBreadcrumbs).toHaveBeenCalledWith(['A', 'B', 'C'])
+ expect(store.setPrefix).toHaveBeenCalledWith(['prefix-0', 'prefix-1', 'prefix-2'])
+ expect(more).toHaveFocus()
+ },
+)
+
+it('shows a bucket-list heading instead of an empty navigation landmark', () => {
+ store.hasBucket = true
+ renderPath({ breadcrumbs: [] })
+ expect(screen.getByText(allBuckets)).toBeInTheDocument()
+ expect(screen.queryByRole('navigation')).not.toBeInTheDocument()
+})
- // Assert - Search result should be shown, navigation elements should be hidden
- // Assert - Search result should be shown, navigation elements should be hidden
- expect(screen.getByText(/searchResult/))!.toBeInTheDocument()
- expect(screen.queryByText('my-bucket')).not.toBeInTheDocument()
- })
- })
+it.each([
+ { breadcrumbs: [], bucket: 'Storage', folderName: 'Storage' },
+ { breadcrumbs: ['Documents', 'Reports'], bucket: 'Storage', folderName: 'Reports' },
+])(
+ 'replaces the path with search results scoped to $folderName',
+ ({ breadcrumbs, bucket, folderName }) => {
+ renderPath({ breadcrumbs, bucket, keywords: 'query', searchResultsLength: 5 })
+ expect(screen.getByText(/onlineDrive.breadcrumbs.searchResult/)).toHaveTextContent(folderName)
+ expect(screen.queryByRole('navigation')).not.toBeInTheDocument()
+ },
+)
+
+it('keeps the directory path available when a search has no results', () => {
+ renderPath({ keywords: 'query', searchResultsLength: 0 })
+ expect(screen.getByRole('navigation', { name: allFiles })).toBeInTheDocument()
+ expect(screen.getByRole('button', { name: 'Reports' })).toHaveAttribute(
+ 'aria-current',
+ 'location',
+ )
})
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/item.spec.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/item.spec.tsx
deleted file mode 100644
index b3f8ebdb1a7..00000000000
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/__tests__/item.spec.tsx
+++ /dev/null
@@ -1,48 +0,0 @@
-import { fireEvent, render, screen } from '@testing-library/react'
-import { beforeEach, describe, expect, it, vi } from 'vite-plus/test'
-import BreadcrumbItem from '../item'
-
-describe('BreadcrumbItem', () => {
- const defaultProps = {
- name: 'Documents',
- index: 2,
- handleClick: vi.fn(),
- }
-
- beforeEach(() => {
- vi.clearAllMocks()
- })
-
- it('should render name', () => {
- render(<BreadcrumbItem {...defaultProps} />)
- expect(screen.getByText('Documents')).toBeInTheDocument()
- })
-
- it('should show separator by default', () => {
- render(<BreadcrumbItem {...defaultProps} />)
- expect(screen.getByText('/')).toBeInTheDocument()
- })
-
- it('should hide separator when showSeparator is false', () => {
- render(<BreadcrumbItem {...defaultProps} showSeparator={false} />)
- expect(screen.queryByText('/')).not.toBeInTheDocument()
- })
-
- it('should call handleClick with index on click', () => {
- render(<BreadcrumbItem {...defaultProps} />)
- fireEvent.click(screen.getByText('Documents'))
- expect(defaultProps.handleClick).toHaveBeenCalledWith(2)
- })
-
- it('should not call handleClick when disabled', () => {
- render(<BreadcrumbItem {...defaultProps} disabled={true} />)
- fireEvent.click(screen.getByText('Documents'))
- expect(defaultProps.handleClick).not.toHaveBeenCalled()
- })
-
- it('should apply active styling', () => {
- render(<BreadcrumbItem {...defaultProps} isActive={true} />)
- const btn = screen.getByRole('button')
- expect(btn.className).toContain('system-sm-medium')
- })
-})
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/bucket.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/bucket.tsx
index 979e4bc8f81..fea774273a4 100644
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/bucket.tsx
+++ b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/bucket.tsx
@@ -1,15 +1,13 @@
-import { cn } from '@langgenius/dify-ui/cn'
+import { BreadcrumbItem, BreadcrumbSeparator } from '@langgenius/dify-ui/breadcrumb'
import { IconButton } from '@langgenius/dify-ui/icon-button'
import { Tooltip, TooltipContent, TooltipTrigger } from '@langgenius/dify-ui/tooltip'
import * as React from 'react'
-import { useCallback } from 'react'
import { useTranslation } from 'react-i18next'
+import DirectoryItem from './item'
type BucketProps = {
bucketName: string
- isActive?: boolean
- disabled?: boolean
- showSeparator?: boolean
+ current: boolean
handleBackToBucketList: () => void
handleClickBucketName: () => void
}
@@ -18,57 +16,43 @@ const Bucket = ({
bucketName,
handleBackToBucketList,
handleClickBucketName,
- disabled = false,
- isActive = false,
- showSeparator = true,
+ current,
}: BucketProps) => {
const { t } = useTranslation()
- const handleClickItem = useCallback(() => {
- if (!disabled) handleClickBucketName()
- }, [disabled, handleClickBucketName])
const allBucketsLabel = t(($) => $['onlineDrive.breadcrumbs.allBuckets'], {
ns: 'datasetPipeline',
})
return (
<>
- <Tooltip>
- <TooltipTrigger
- render={
- <IconButton
- type="button"
- variant="ghost"
- size="md"
- aria-label={allBucketsLabel}
- className="shrink-0"
- onClick={handleBackToBucketList}
- >
- <span
- aria-hidden
- className="i-custom-public-knowledge-online-drive-buckets-gray h-4.75 w-4.5"
- />
- </IconButton>
- }
- />
- <TooltipContent>{allBucketsLabel}</TooltipContent>
- </Tooltip>
- <span className="system-xs-regular text-divider-deep">/</span>
- <button
- type="button"
- className={cn(
- 'max-w-full shrink truncate rounded-md px-1.25 py-1',
- isActive
- ? 'system-sm-medium text-text-secondary'
- : 'system-sm-regular text-text-tertiary',
- !disabled && 'hover:bg-state-base-hover',
- )}
- disabled={disabled}
- onClick={handleClickItem}
+ <BreadcrumbItem className="shrink-0">
+ <Tooltip>
+ <TooltipTrigger
+ render={
+ <IconButton
+ type="button"
+ variant="ghost"
+ size="md"
+ aria-label={allBucketsLabel}
+ onClick={handleBackToBucketList}
+ >
+ <span
+ aria-hidden
+ className="i-custom-public-knowledge-online-drive-buckets-gray h-4.75 w-4.5"
+ />
+ </IconButton>
+ }
+ />
+ <TooltipContent>{allBucketsLabel}</TooltipContent>
+ </Tooltip>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator className="system-xs-regular text-divider-deep" />
+ <DirectoryItem
+ name={bucketName}
title={bucketName}
- >
- {bucketName}
- </button>
- {showSeparator && <span className="shrink-0 system-xs-regular text-divider-deep">/</span>}
+ current={current}
+ onClick={handleClickBucketName}
+ />
</>
)
}
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/drive.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/drive.tsx
index e435a84bbbd..3a970924188 100644
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/drive.tsx
+++ b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/drive.tsx
@@ -1,33 +1,19 @@
-import { cn } from '@langgenius/dify-ui/cn'
-import * as React from 'react'
import { useTranslation } from 'react-i18next'
+import BreadcrumbItem from './item'
type DriveProps = {
breadcrumbs: string[]
handleBackToRoot: () => void
}
-const Drive = ({ breadcrumbs, handleBackToRoot }: DriveProps) => {
+export default function Drive({ breadcrumbs, handleBackToRoot }: DriveProps) {
const { t } = useTranslation()
return (
- <>
- <button
- type="button"
- className={cn(
- 'max-w-full shrink truncate rounded-md px-1.25 py-1',
- breadcrumbs.length > 0 &&
- 'system-sm-regular text-text-tertiary hover:bg-state-base-hover',
- breadcrumbs.length === 0 && 'system-sm-medium text-text-secondary',
- )}
- onClick={handleBackToRoot}
- disabled={breadcrumbs.length === 0}
- >
- {t(($) => $['onlineDrive.breadcrumbs.allFiles'], { ns: 'datasetPipeline' })}
- </button>
- {breadcrumbs.length > 0 && <span className="system-xs-regular text-divider-deep">/</span>}
- </>
+ <BreadcrumbItem
+ name={t(($) => $['onlineDrive.breadcrumbs.allFiles'], { ns: 'datasetPipeline' })}
+ current={breadcrumbs.length === 0}
+ onClick={handleBackToRoot}
+ />
)
}
-
-export default React.memo(Drive)
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/__tests__/index.spec.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/__tests__/index.spec.tsx
deleted file mode 100644
index 3ea053b550d..00000000000
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/__tests__/index.spec.tsx
+++ /dev/null
@@ -1,819 +0,0 @@
-import { fireEvent, render, screen, waitFor } from '@testing-library/react'
-import * as React from 'react'
-import Dropdown from '../index'
-
-type DropdownProps = React.ComponentProps<typeof Dropdown>
-
-const createDefaultProps = (overrides?: Partial<DropdownProps>): DropdownProps => ({
- startIndex: 0,
- breadcrumbs: ['folder1', 'folder2'],
- onBreadcrumbClick: vi.fn(),
- ...overrides,
-})
-
-describe('Dropdown', () => {
- beforeEach(() => {
- vi.clearAllMocks()
- })
-
- describe('Rendering', () => {
- it('should render trigger button with more icon', () => {
- const props = createDefaultProps()
-
- const { container } = render(<Dropdown {...props} />)
-
- // Assert - Button should have the more icon
- const button = screen.getByRole('button')
- expect(button).toBeInTheDocument()
- expect(container.querySelector('.i-ri-more-fill')).toBeInTheDocument()
- })
-
- it('should render separator after dropdown', () => {
- const props = createDefaultProps()
-
- render(<Dropdown {...props} />)
-
- // Assert - Separator "/" should be visible
- // Assert - Separator "/" should be visible
- expect(screen.getByText('/'))!.toBeInTheDocument()
- })
-
- it('should not render menu content when closed', () => {
- const props = createDefaultProps({ breadcrumbs: ['visible-folder'] })
-
- render(<Dropdown {...props} />)
-
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- // Assert - Menu content should not be visible when dropdown is closed
- expect(screen.queryByText('visible-folder')).not.toBeInTheDocument()
- })
-
- it('should render menu content when opened', async () => {
- const props = createDefaultProps({ breadcrumbs: ['test-folder1', 'test-folder2'] })
- render(<Dropdown {...props} />)
-
- // Act - Open dropdown
- fireEvent.click(screen.getByRole('button'))
-
- // Assert - Menu items should be visible
- await waitFor(() => {
- expect(screen.getByText('test-folder1'))!.toBeInTheDocument()
- expect(screen.getByText('test-folder2'))!.toBeInTheDocument()
- })
- })
- })
-
- describe('Props', () => {
- describe('startIndex prop', () => {
- it('should pass startIndex to Menu component', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- startIndex: 5,
- breadcrumbs: ['folder1'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- render(<Dropdown {...props} />)
-
- // Act - Open dropdown and click on item
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('folder1'))!.toBeInTheDocument()
- })
-
- fireEvent.click(screen.getByText('folder1'))
-
- // Assert - Should be called with startIndex (5) + item index (0) = 5
- expect(mockOnBreadcrumbClick).toHaveBeenCalledWith(5)
- })
-
- it('should calculate correct index for second item', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- startIndex: 3,
- breadcrumbs: ['folder1', 'folder2'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- render(<Dropdown {...props} />)
-
- // Act - Open dropdown and click on second item
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('folder2'))!.toBeInTheDocument()
- })
-
- fireEvent.click(screen.getByText('folder2'))
-
- // Assert - Should be called with startIndex (3) + item index (1) = 4
- expect(mockOnBreadcrumbClick).toHaveBeenCalledWith(4)
- })
- })
-
- describe('breadcrumbs prop', () => {
- it('should render all breadcrumbs in menu', async () => {
- const props = createDefaultProps({
- breadcrumbs: ['folder-a', 'folder-b', 'folder-c'],
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('folder-a'))!.toBeInTheDocument()
- expect(screen.getByText('folder-b'))!.toBeInTheDocument()
- expect(screen.getByText('folder-c'))!.toBeInTheDocument()
- })
- })
-
- it('should handle single breadcrumb', async () => {
- const props = createDefaultProps({
- breadcrumbs: ['single-folder'],
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('single-folder'))!.toBeInTheDocument()
- })
- })
-
- it('should handle empty breadcrumbs array', async () => {
- const props = createDefaultProps({
- breadcrumbs: [],
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- // Assert - Menu should be rendered but with no items
- await waitFor(() => {
- // The menu container should exist but be empty
- // The menu container should exist but be empty
- expect(screen.getByRole('button'))!.toBeInTheDocument()
- })
- })
-
- it('should handle breadcrumbs with special characters', async () => {
- const props = createDefaultProps({
- breadcrumbs: ['folder [1]', 'folder (copy)', 'folder-v2.0'],
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('folder [1]'))!.toBeInTheDocument()
- expect(screen.getByText('folder (copy)'))!.toBeInTheDocument()
- expect(screen.getByText('folder-v2.0'))!.toBeInTheDocument()
- })
- })
-
- it('should handle breadcrumbs with unicode characters', async () => {
- const props = createDefaultProps({
- breadcrumbs: ['文件夹', 'フォルダ', 'Папка'],
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('文件夹'))!.toBeInTheDocument()
- expect(screen.getByText('フォルダ'))!.toBeInTheDocument()
- expect(screen.getByText('Папка'))!.toBeInTheDocument()
- })
- })
- })
-
- describe('onBreadcrumbClick prop', () => {
- it('should call onBreadcrumbClick with correct index when item clicked', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- startIndex: 0,
- breadcrumbs: ['folder1'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('folder1'))!.toBeInTheDocument()
- })
-
- fireEvent.click(screen.getByText('folder1'))
-
- expect(mockOnBreadcrumbClick).toHaveBeenCalledWith(0)
- expect(mockOnBreadcrumbClick).toHaveBeenCalledTimes(1)
- })
- })
- })
-
- describe('State Management', () => {
- describe('open state', () => {
- it('should initialize with closed state', () => {
- const props = createDefaultProps({ breadcrumbs: ['test-folder'] })
-
- render(<Dropdown {...props} />)
-
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- // Assert - Menu content should not be visible
- expect(screen.queryByText('test-folder')).not.toBeInTheDocument()
- })
-
- it('should toggle to open state when trigger is clicked', async () => {
- const props = createDefaultProps({ breadcrumbs: ['test-folder'] })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('test-folder'))!.toBeInTheDocument()
- })
- })
-
- it('should toggle to closed state when trigger is clicked again', async () => {
- const props = createDefaultProps({ breadcrumbs: ['test-folder'] })
- render(<Dropdown {...props} />)
-
- // Act - Open and then close
- fireEvent.click(screen.getByRole('button'))
- await waitFor(() => {
- expect(screen.getByText('test-folder'))!.toBeInTheDocument()
- })
-
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.queryByText('test-folder')).not.toBeInTheDocument()
- })
- })
-
- it('should close when breadcrumb item is clicked', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- breadcrumbs: ['test-folder'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- render(<Dropdown {...props} />)
-
- // Act - Open dropdown
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('test-folder'))!.toBeInTheDocument()
- })
-
- fireEvent.click(screen.getByText('test-folder'))
-
- // Assert - Menu should close
- await waitFor(() => {
- expect(screen.queryByText('test-folder')).not.toBeInTheDocument()
- })
- })
-
- it('should apply correct button styles based on open state', async () => {
- const props = createDefaultProps({ breadcrumbs: ['test-folder'] })
- render(<Dropdown {...props} />)
- const button = screen.getByRole('button')
-
- // Assert - Initial state (closed): should have hover:bg-state-base-hover
- // Assert - Initial state (closed): should have hover:bg-state-base-hover
-
- // Act - Open dropdown
- fireEvent.click(button)
-
- // Assert - Open state is exposed declaratively via data-popup-open
- await waitFor(() => {
- expect(button).toHaveAttribute('data-popup-open')
- })
- })
- })
- })
-
- // Event Handlers Tests
- describe('Event Handlers', () => {
- describe('handleTrigger', () => {
- it('should toggle open state when trigger is clicked', async () => {
- const props = createDefaultProps({ breadcrumbs: ['folder'] })
- render(<Dropdown {...props} />)
-
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- // Act & Assert - Initially closed
- expect(screen.queryByText('folder')).not.toBeInTheDocument()
-
- // Act - Click to open
- fireEvent.click(screen.getByRole('button'))
-
- // Assert - Now open
- await waitFor(() => {
- expect(screen.getByText('folder'))!.toBeInTheDocument()
- })
- })
-
- it('should toggle multiple times correctly', async () => {
- const props = createDefaultProps({ breadcrumbs: ['folder'] })
- render(<Dropdown {...props} />)
- const button = screen.getByRole('button')
-
- // Act & Assert - Toggle multiple times
- // 1st click - open
- fireEvent.click(button)
- await waitFor(() => {
- expect(screen.getByText('folder'))!.toBeInTheDocument()
- })
-
- // 2nd click - close
- fireEvent.click(button)
- await waitFor(() => {
- expect(screen.queryByText('folder')).not.toBeInTheDocument()
- })
-
- // 3rd click - open again
- fireEvent.click(button)
- await waitFor(() => {
- expect(screen.getByText('folder'))!.toBeInTheDocument()
- })
- })
- })
-
- describe('handleBreadCrumbClick', () => {
- it('should call onBreadcrumbClick and close menu', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- breadcrumbs: ['folder1'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- render(<Dropdown {...props} />)
-
- // Act - Open dropdown
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('folder1'))!.toBeInTheDocument()
- })
-
- fireEvent.click(screen.getByText('folder1'))
-
- expect(mockOnBreadcrumbClick).toHaveBeenCalledTimes(1)
-
- // Menu should close
- await waitFor(() => {
- expect(screen.queryByText('folder1')).not.toBeInTheDocument()
- })
- })
-
- it('should pass correct index to onBreadcrumbClick for each item', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- startIndex: 2,
- breadcrumbs: ['folder1', 'folder2', 'folder3'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- render(<Dropdown {...props} />)
-
- // Act - Open dropdown and click first item
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('folder1'))!.toBeInTheDocument()
- })
-
- fireEvent.click(screen.getByText('folder1'))
-
- // Assert - Index should be startIndex (2) + item index (0) = 2
- expect(mockOnBreadcrumbClick).toHaveBeenCalledWith(2)
- })
- })
- })
-
- // Callback Stability and Memoization Tests
- describe('Callback Stability and Memoization', () => {
- it('should maintain stable callback after rerender with same props', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- breadcrumbs: ['folder'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- const { rerender } = render(<Dropdown {...props} />)
-
- // Act - Open and click
- fireEvent.click(screen.getByRole('button'))
- await waitFor(() => {
- expect(screen.getByText('folder'))!.toBeInTheDocument()
- })
- fireEvent.click(screen.getByText('folder'))
-
- // Rerender with same props and click again
- rerender(<Dropdown {...props} />)
- fireEvent.click(screen.getByRole('button'))
- await waitFor(() => {
- expect(screen.getByText('folder'))!.toBeInTheDocument()
- })
- fireEvent.click(screen.getByText('folder'))
-
- expect(mockOnBreadcrumbClick).toHaveBeenCalledTimes(2)
- })
-
- it('should update callback when onBreadcrumbClick prop changes', async () => {
- const mockOnBreadcrumbClick1 = vi.fn()
- const mockOnBreadcrumbClick2 = vi.fn()
- const props = createDefaultProps({
- breadcrumbs: ['folder'],
- onBreadcrumbClick: mockOnBreadcrumbClick1,
- })
- const { rerender } = render(<Dropdown {...props} />)
-
- // Act - Open and click with first callback
- fireEvent.click(screen.getByRole('button'))
- await waitFor(() => {
- expect(screen.getByText('folder'))!.toBeInTheDocument()
- })
- fireEvent.click(screen.getByText('folder'))
-
- // Rerender with different callback
- rerender(
- <Dropdown
- {...createDefaultProps({
- breadcrumbs: ['folder'],
- onBreadcrumbClick: mockOnBreadcrumbClick2,
- })}
- />,
- )
-
- // Open and click with second callback
- fireEvent.click(screen.getByRole('button'))
- await waitFor(() => {
- expect(screen.getByText('folder'))!.toBeInTheDocument()
- })
- fireEvent.click(screen.getByText('folder'))
-
- expect(mockOnBreadcrumbClick1).toHaveBeenCalledTimes(1)
- expect(mockOnBreadcrumbClick2).toHaveBeenCalledTimes(1)
- })
-
- it('should not re-render when props are the same', () => {
- const props = createDefaultProps()
- const { rerender } = render(<Dropdown {...props} />)
-
- // Act - Rerender with same props
- rerender(<Dropdown {...props} />)
-
- // Assert - Component should render without errors
- // Assert - Component should render without errors
- expect(screen.getByRole('button'))!.toBeInTheDocument()
- })
- })
-
- describe('Edge Cases and Error Handling', () => {
- it('should handle rapid toggle clicks', async () => {
- const props = createDefaultProps({ breadcrumbs: ['folder'] })
- render(<Dropdown {...props} />)
- const button = screen.getByRole('button')
-
- // Act - Rapid clicks
- fireEvent.click(button)
- fireEvent.click(button)
- fireEvent.click(button)
-
- // Assert - Should handle gracefully (open after odd number of clicks)
- await waitFor(() => {
- expect(screen.getByText('folder'))!.toBeInTheDocument()
- })
- })
-
- it('should handle very long folder names', async () => {
- const longName = 'a'.repeat(100)
- const props = createDefaultProps({
- breadcrumbs: [longName],
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText(longName))!.toBeInTheDocument()
- })
- })
-
- it('should handle many breadcrumbs', async () => {
- const manyBreadcrumbs = Array.from({ length: 20 }, (_, i) => `folder-${i}`)
- const props = createDefaultProps({
- breadcrumbs: manyBreadcrumbs,
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- // Assert - First and last items should be visible
- await waitFor(() => {
- expect(screen.getByText('folder-0'))!.toBeInTheDocument()
- expect(screen.getByText('folder-19'))!.toBeInTheDocument()
- })
- })
-
- it('should handle startIndex of 0', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- startIndex: 0,
- breadcrumbs: ['folder'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
- await waitFor(() => {
- expect(screen.getByText('folder'))!.toBeInTheDocument()
- })
- fireEvent.click(screen.getByText('folder'))
-
- expect(mockOnBreadcrumbClick).toHaveBeenCalledWith(0)
- })
-
- it('should handle large startIndex values', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- startIndex: 999,
- breadcrumbs: ['folder'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
- await waitFor(() => {
- expect(screen.getByText('folder'))!.toBeInTheDocument()
- })
- fireEvent.click(screen.getByText('folder'))
-
- expect(mockOnBreadcrumbClick).toHaveBeenCalledWith(999)
- })
-
- it('should handle breadcrumbs with whitespace-only names', async () => {
- const props = createDefaultProps({
- breadcrumbs: [' ', 'normal-folder'],
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('normal-folder'))!.toBeInTheDocument()
- })
- })
-
- it('should handle breadcrumbs with empty string', async () => {
- const props = createDefaultProps({
- breadcrumbs: ['', 'folder'],
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('folder'))!.toBeInTheDocument()
- })
- })
- })
-
- describe('Prop Variations', () => {
- it.each([
- { startIndex: 0, breadcrumbs: ['a'], expectedIndex: 0 },
- { startIndex: 1, breadcrumbs: ['a'], expectedIndex: 1 },
- { startIndex: 5, breadcrumbs: ['a'], expectedIndex: 5 },
- { startIndex: 10, breadcrumbs: ['a', 'b'], expectedIndex: 10 },
- ])(
- 'should handle startIndex=$startIndex correctly',
- async ({ startIndex, breadcrumbs, expectedIndex }) => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- startIndex,
- breadcrumbs,
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
- await waitFor(() => {
- expect(screen.getByText(breadcrumbs[0]!))!.toBeInTheDocument()
- })
- fireEvent.click(screen.getByText(breadcrumbs[0]!))
-
- expect(mockOnBreadcrumbClick).toHaveBeenCalledWith(expectedIndex)
- },
- )
-
- it.each([
- { breadcrumbs: [], description: 'empty array' },
- { breadcrumbs: ['single'], description: 'single item' },
- { breadcrumbs: ['a', 'b'], description: 'two items' },
- { breadcrumbs: ['a', 'b', 'c', 'd', 'e'], description: 'five items' },
- ])('should render correctly with $description breadcrumbs', async ({ breadcrumbs }) => {
- const props = createDefaultProps({ breadcrumbs })
-
- render(<Dropdown {...props} />)
- fireEvent.click(screen.getByRole('button'))
-
- // Assert - Should render without errors
- await waitFor(() => {
- if (breadcrumbs.length > 0) expect(screen.getByText(breadcrumbs[0]!))!.toBeInTheDocument()
- })
- })
- })
-
- // Integration Tests (Menu and Item)
- describe('Integration with Menu and Item', () => {
- it('should render all menu items with correct content', async () => {
- const props = createDefaultProps({
- breadcrumbs: ['Documents', 'Projects', 'Archive'],
- })
- render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
-
- await waitFor(() => {
- expect(screen.getByText('Documents'))!.toBeInTheDocument()
- expect(screen.getByText('Projects'))!.toBeInTheDocument()
- expect(screen.getByText('Archive'))!.toBeInTheDocument()
- })
- })
-
- it('should handle click on any menu item', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- startIndex: 0,
- breadcrumbs: ['first', 'second', 'third'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- render(<Dropdown {...props} />)
-
- // Act - Open and click on second item
- fireEvent.click(screen.getByRole('button'))
- await waitFor(() => {
- expect(screen.getByText('second'))!.toBeInTheDocument()
- })
- fireEvent.click(screen.getByText('second'))
-
- // Assert - Index should be 1 (second item)
- expect(mockOnBreadcrumbClick).toHaveBeenCalledWith(1)
- })
-
- it('should close menu after any item click', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- breadcrumbs: ['item1', 'item2', 'item3'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
- render(<Dropdown {...props} />)
-
- // Act - Open and click on middle item
- fireEvent.click(screen.getByRole('button'))
- await waitFor(() => {
- expect(screen.getByText('item2'))!.toBeInTheDocument()
- })
- fireEvent.click(screen.getByText('item2'))
-
- // Assert - Menu should close
- await waitFor(() => {
- expect(screen.queryByText('item1')).not.toBeInTheDocument()
- expect(screen.queryByText('item2')).not.toBeInTheDocument()
- expect(screen.queryByText('item3')).not.toBeInTheDocument()
- })
- })
-
- it('should correctly calculate index for each item based on startIndex', async () => {
- const mockOnBreadcrumbClick = vi.fn()
- const props = createDefaultProps({
- startIndex: 3,
- breadcrumbs: ['folder-a', 'folder-b', 'folder-c'],
- onBreadcrumbClick: mockOnBreadcrumbClick,
- })
-
- // Test clicking each item
- for (let i = 0; i < 3; i++) {
- mockOnBreadcrumbClick.mockClear()
- const { unmount } = render(<Dropdown {...props} />)
-
- fireEvent.click(screen.getByRole('button'))
- await waitFor(() => {
- expect(screen.getByText(`folder-${String.fromCharCode(97 + i)}`))!.toBeInTheDocument()
- })
- fireEvent.click(screen.getByText(`folder-${String.fromCharCode(97 + i)}`))
-
- expect(mockOnBreadcrumbClick).toHaveBeenCalledWith(3 + i)
- unmount()
- }
- })
- })
-
- describe('Accessibility', () => {
- it('should render trigger as button element', () => {
- const props = createDefaultProps()
-
- render(<Dropdown {...props} />)
-
- const button = screen.getByRole('button')
- expect(button)!.toBeInTheDocument()
- expect(button.tagName).toBe('BUTTON')
- })
-
- it('should have type="button" attribute', () => {
- const props = createDefaultProps()
-
- render(<Dropdown {...props} />)
-
- const button = screen.getByRole('button')
- expect(button)!.toHaveAttribute('type', 'button')
- })
- })
-})
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/__tests__/item.spec.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/__tests__/item.spec.tsx
deleted file mode 100644
index f3662aa176e..00000000000
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/__tests__/item.spec.tsx
+++ /dev/null
@@ -1,54 +0,0 @@
-import type { ReactElement } from 'react'
-import { DropdownMenu, DropdownMenuContent } from '@langgenius/dify-ui/dropdown-menu'
-import { fireEvent, render, screen } from '@testing-library/react'
-import { beforeEach, describe, expect, it, vi } from 'vite-plus/test'
-import Item from '../item'
-
-const renderItem = (ui: ReactElement) => {
- return render(
- <DropdownMenu open>
- <DropdownMenuContent>{ui}</DropdownMenuContent>
- </DropdownMenu>,
- )
-}
-
-describe('Item', () => {
- const defaultProps = {
- name: 'Documents',
- index: 2,
- onBreadcrumbClick: vi.fn(),
- }
-
- beforeEach(() => {
- vi.clearAllMocks()
- })
-
- // Rendering: verify the breadcrumb name is displayed
- describe('Rendering', () => {
- it('should render breadcrumb name', () => {
- renderItem(<Item {...defaultProps} />)
-
- expect(screen.getByText('Documents')).toBeInTheDocument()
- })
- })
-
- // User interactions: clicking triggers callback with correct index
- describe('User Interactions', () => {
- it('should call onBreadcrumbClick with correct index on click', () => {
- renderItem(<Item {...defaultProps} />)
-
- fireEvent.click(screen.getByText('Documents'))
-
- expect(defaultProps.onBreadcrumbClick).toHaveBeenCalledOnce()
- expect(defaultProps.onBreadcrumbClick).toHaveBeenCalledWith(2)
- })
-
- it('should pass different index values correctly', () => {
- renderItem(<Item {...defaultProps} index={5} />)
-
- fireEvent.click(screen.getByText('Documents'))
-
- expect(defaultProps.onBreadcrumbClick).toHaveBeenCalledWith(5)
- })
- })
-})
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/__tests__/menu.spec.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/__tests__/menu.spec.tsx
deleted file mode 100644
index 6774e9a465f..00000000000
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/__tests__/menu.spec.tsx
+++ /dev/null
@@ -1,89 +0,0 @@
-import type { ReactElement } from 'react'
-import { DropdownMenu, DropdownMenuContent } from '@langgenius/dify-ui/dropdown-menu'
-import { fireEvent, render, screen } from '@testing-library/react'
-import { beforeEach, describe, expect, it, vi } from 'vite-plus/test'
-import Menu from '../menu'
-
-const renderMenu = (ui: ReactElement) => {
- return render(
- <DropdownMenu open>
- <DropdownMenuContent>{ui}</DropdownMenuContent>
- </DropdownMenu>,
- )
-}
-
-describe('Menu', () => {
- const defaultProps = {
- breadcrumbs: ['Folder A', 'Folder B', 'Folder C'],
- startIndex: 1,
- onBreadcrumbClick: vi.fn(),
- }
-
- beforeEach(() => {
- vi.clearAllMocks()
- })
-
- // Rendering: verify all breadcrumb items are displayed
- describe('Rendering', () => {
- it('should render all breadcrumb items', () => {
- renderMenu(<Menu {...defaultProps} />)
-
- expect(screen.getByText('Folder A')).toBeInTheDocument()
- expect(screen.getByText('Folder B')).toBeInTheDocument()
- expect(screen.getByText('Folder C')).toBeInTheDocument()
- })
-
- it('should render empty list when no breadcrumbs provided', () => {
- const { container } = render(
- <Menu breadcrumbs={[]} startIndex={0} onBreadcrumbClick={vi.fn()} />,
- )
-
- const menuContainer = container.firstElementChild
- expect(menuContainer?.children).toHaveLength(0)
- })
- })
-
- // Index mapping: startIndex offsets are applied correctly
- describe('Index Mapping', () => {
- it('should pass correct index (startIndex + offset) to each item', () => {
- renderMenu(<Menu {...defaultProps} />)
-
- fireEvent.click(screen.getByText('Folder A'))
- expect(defaultProps.onBreadcrumbClick).toHaveBeenCalledWith(1)
-
- fireEvent.click(screen.getByText('Folder B'))
- expect(defaultProps.onBreadcrumbClick).toHaveBeenCalledWith(2)
-
- fireEvent.click(screen.getByText('Folder C'))
- expect(defaultProps.onBreadcrumbClick).toHaveBeenCalledWith(3)
- })
-
- it('should offset from startIndex of zero', () => {
- renderMenu(
- <Menu
- breadcrumbs={['First', 'Second']}
- startIndex={0}
- onBreadcrumbClick={defaultProps.onBreadcrumbClick}
- />,
- )
-
- fireEvent.click(screen.getByText('First'))
- expect(defaultProps.onBreadcrumbClick).toHaveBeenCalledWith(0)
-
- fireEvent.click(screen.getByText('Second'))
- expect(defaultProps.onBreadcrumbClick).toHaveBeenCalledWith(1)
- })
- })
-
- // User interactions: clicking items triggers the callback
- describe('User Interactions', () => {
- it('should call onBreadcrumbClick with correct index when item clicked', () => {
- renderMenu(<Menu {...defaultProps} />)
-
- fireEvent.click(screen.getByText('Folder B'))
-
- expect(defaultProps.onBreadcrumbClick).toHaveBeenCalledOnce()
- expect(defaultProps.onBreadcrumbClick).toHaveBeenCalledWith(2)
- })
- })
-})
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/index.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/index.tsx
index 0c830fdddb4..3f4edb5320c 100644
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/index.tsx
+++ b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/index.tsx
@@ -1,14 +1,13 @@
-import { cn } from '@langgenius/dify-ui/cn'
+import { BreadcrumbItem, BreadcrumbSeparator } from '@langgenius/dify-ui/breadcrumb'
import {
DropdownMenu,
- DropdownMenuPopup,
- DropdownMenuPortal,
- DropdownMenuPositioner,
+ DropdownMenuContent,
+ DropdownMenuItem,
DropdownMenuTrigger,
} from '@langgenius/dify-ui/dropdown-menu'
+import { IconButton } from '@langgenius/dify-ui/icon-button'
import * as React from 'react'
import { useTranslation } from 'react-i18next'
-import Menu from './menu'
type DropdownProps = {
startIndex: number
@@ -20,34 +19,34 @@ const Dropdown = ({ startIndex, breadcrumbs, onBreadcrumbClick }: DropdownProps)
const { t } = useTranslation()
return (
- <DropdownMenu>
- <DropdownMenuTrigger
- render={
- <button
- type="button"
- aria-label={t(($) => $['operation.more'], { ns: 'common' })}
- className={cn(
- 'flex size-6 items-center justify-center rounded-md',
- 'hover:bg-state-base-hover focus-visible:ring-2 focus-visible:ring-state-accent-solid data-popup-open:bg-state-base-hover',
- )}
- >
- <span aria-hidden className="i-ri-more-fill size-4 text-text-tertiary" />
- </button>
- }
- />
- <DropdownMenuPortal>
- <DropdownMenuPositioner placement="bottom-start" sideOffset={4}>
- <DropdownMenuPopup>
- <Menu
- breadcrumbs={breadcrumbs}
- startIndex={startIndex}
- onBreadcrumbClick={onBreadcrumbClick}
- />
- </DropdownMenuPopup>
- </DropdownMenuPositioner>
- </DropdownMenuPortal>
- <span className="system-xs-regular text-divider-deep">/</span>
- </DropdownMenu>
+ <>
+ <BreadcrumbItem className="shrink-0">
+ <DropdownMenu>
+ <DropdownMenuTrigger
+ render={
+ <IconButton
+ aria-label={t(($) => $['operation.more'], { ns: 'common' })}
+ className="data-popup-open:bg-state-base-hover"
+ >
+ <span aria-hidden className="i-ri-more-fill size-4" />
+ </IconButton>
+ }
+ />
+ <DropdownMenuContent placement="bottom-start" className="w-34 px-1">
+ {breadcrumbs.map((breadcrumb, index) => (
+ <DropdownMenuItem
+ key={breadcrumbs.slice(0, index + 1).join('/')}
+ className="px-3 py-1.5 system-md-regular"
+ onClick={() => onBreadcrumbClick(startIndex + index)}
+ >
+ {breadcrumb}
+ </DropdownMenuItem>
+ ))}
+ </DropdownMenuContent>
+ </DropdownMenu>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator className="system-xs-regular text-divider-deep" />
+ </>
)
}
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/item.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/item.tsx
deleted file mode 100644
index 27fd12e210a..00000000000
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/item.tsx
+++ /dev/null
@@ -1,21 +0,0 @@
-import { DropdownMenuItem } from '@langgenius/dify-ui/dropdown-menu'
-import * as React from 'react'
-
-type ItemProps = {
- name: string
- index: number
- onBreadcrumbClick: (index: number) => void
-}
-
-const Item = ({ name, index, onBreadcrumbClick }: ItemProps) => {
- return (
- <DropdownMenuItem
- className="rounded-lg px-3 py-1.5 system-md-regular text-text-secondary hover:bg-state-base-hover"
- onClick={() => onBreadcrumbClick(index)}
- >
- {name}
- </DropdownMenuItem>
- )
-}
-
-export default React.memo(Item)
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/menu.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/menu.tsx
deleted file mode 100644
index 6ceb016c2b6..00000000000
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/dropdown/menu.tsx
+++ /dev/null
@@ -1,27 +0,0 @@
-import * as React from 'react'
-import Item from './item'
-
-type MenuProps = {
- breadcrumbs: string[]
- startIndex: number
- onBreadcrumbClick: (index: number) => void
-}
-
-const Menu = ({ breadcrumbs, startIndex, onBreadcrumbClick }: MenuProps) => {
- return (
- <div className="flex w-34 flex-col rounded-xl border-[0.5px] border-components-panel-border bg-components-panel-bg-blur p-1 shadow-lg shadow-shadow-shadow-5 backdrop-blur-[5px]">
- {breadcrumbs.map((breadcrumb, index) => {
- return (
- <Item
- key={breadcrumb}
- name={breadcrumb}
- index={startIndex + index}
- onBreadcrumbClick={onBreadcrumbClick}
- />
- )
- })}
- </div>
- )
-}
-
-export default React.memo(Menu)
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/index.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/index.tsx
index 051aff77cdb..a1f1da2aff2 100644
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/index.tsx
+++ b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/index.tsx
@@ -1,3 +1,4 @@
+import { Breadcrumb, BreadcrumbList } from '@langgenius/dify-ui/breadcrumb'
import * as React from 'react'
import { useCallback, useMemo } from 'react'
import { useTranslation } from 'react-i18next'
@@ -94,7 +95,7 @@ const Breadcrumbs = ({
)
return (
- <div className="flex grow items-center overflow-hidden">
+ <div className="flex min-w-0 grow items-center">
{showSearchResult && (
<div className="px-1.25 system-sm-medium">
{t(($) => $['onlineDrive.breadcrumbs.searchResult'], {
@@ -110,64 +111,63 @@ const Breadcrumbs = ({
</div>
)}
{!showSearchResult && !showBucketListTitle && (
- <div className="flex w-full items-center gap-x-0.5 overflow-hidden">
- {hasBucket && bucket && (
- <Bucket
- bucketName={bucket}
- handleBackToBucketList={handleBackToBucketList}
- handleClickBucketName={handleClickBucketName}
- isActive={breadcrumbs.length === 0}
- disabled={breadcrumbs.length === 0}
- showSeparator={breadcrumbs.length > 0}
- />
- )}
- {!hasBucket && <Drive breadcrumbs={breadcrumbs} handleBackToRoot={handleBackToRoot} />}
- {!breadcrumbsConfig.needCollapsed && (
- <>
- {breadcrumbsConfig.original.map((breadcrumb, index) => {
- const isLast = index === breadcrumbsConfig.original.length - 1
- return (
- <BreadcrumbItem
- key={`${breadcrumb}-${index}`}
- index={index}
- handleClick={handleClickBreadcrumb}
- name={breadcrumb}
- isActive={isLast}
- showSeparator={!isLast}
- disabled={isLast}
- />
- )
- })}
- </>
- )}
- {breadcrumbsConfig.needCollapsed && (
- <>
- {breadcrumbsConfig.prefixBreadcrumbs.map((breadcrumb, index) => {
- return (
- <BreadcrumbItem
- key={`${breadcrumb}-${index}`}
- index={index}
- handleClick={handleClickBreadcrumb}
- name={breadcrumb}
- />
- )
- })}
- <Dropdown
- startIndex={breadcrumbsConfig.prefixBreadcrumbs.length}
- breadcrumbs={breadcrumbsConfig.collapsedBreadcrumbs}
- onBreadcrumbClick={handleClickBreadcrumb}
+ <Breadcrumb
+ aria-label={t(($) => $['onlineDrive.breadcrumbs.allFiles'], { ns: 'datasetPipeline' })}
+ className="w-full"
+ >
+ <BreadcrumbList className="gap-0.5">
+ {hasBucket && bucket && (
+ <Bucket
+ bucketName={bucket}
+ handleBackToBucketList={handleBackToBucketList}
+ handleClickBucketName={handleClickBucketName}
+ current={breadcrumbs.length === 0}
/>
- <BreadcrumbItem
- index={breadcrumbs.length - 1}
- handleClick={handleClickBreadcrumb}
- name={breadcrumbsConfig.lastBreadcrumb!}
- isActive={true}
- disabled={true}
- showSeparator={false}
- />
- </>
- )}
- </div>
+ )}
+ {!hasBucket && <Drive breadcrumbs={breadcrumbs} handleBackToRoot={handleBackToRoot} />}
+ {!breadcrumbsConfig.needCollapsed && (
+ <>
+ {breadcrumbsConfig.original.map((breadcrumb, index) => {
+ const isLast = index === breadcrumbsConfig.original.length - 1
+ return (
+ <BreadcrumbItem
+ key={breadcrumbs.slice(0, index + 1).join('/')}
+ onClick={() => handleClickBreadcrumb(index)}
+ name={breadcrumb}
+ title={breadcrumb}
+ current={isLast}
+ />
+ )
+ })}
+ </>
+ )}
+ {breadcrumbsConfig.needCollapsed && (
+ <>
+ {breadcrumbsConfig.prefixBreadcrumbs.map((breadcrumb, index) => {
+ return (
+ <BreadcrumbItem
+ key={breadcrumbs.slice(0, index + 1).join('/')}
+ onClick={() => handleClickBreadcrumb(index)}
+ name={breadcrumb}
+ title={breadcrumb}
+ />
+ )
+ })}
+ <Dropdown
+ startIndex={breadcrumbsConfig.prefixBreadcrumbs.length}
+ breadcrumbs={breadcrumbsConfig.collapsedBreadcrumbs}
+ onBreadcrumbClick={handleClickBreadcrumb}
+ />
+ <BreadcrumbItem
+ onClick={() => handleClickBreadcrumb(breadcrumbs.length - 1)}
+ name={breadcrumbsConfig.lastBreadcrumb!}
+ title={breadcrumbsConfig.lastBreadcrumb!}
+ current
+ />
+ </>
+ )}
+ </BreadcrumbList>
+ </Breadcrumb>
)}
</div>
)
diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/item.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/item.tsx
index 4d564b7c5d0..14ef7736794 100644
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/item.tsx
+++ b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/header/breadcrumbs/item.tsx
@@ -1,50 +1,39 @@
+import { BreadcrumbSeparator, BreadcrumbItem as PathItem } from '@langgenius/dify-ui/breadcrumb'
import { cn } from '@langgenius/dify-ui/cn'
-import * as React from 'react'
-import { useCallback } from 'react'
type BreadcrumbItemProps = {
name: string
- index: number
- handleClick: (index: number) => void
- disabled?: boolean
- isActive?: boolean
- showSeparator?: boolean
+ onClick: () => void
+ current?: boolean
+ title?: string
}
-const BreadcrumbItem = ({
+export default function BreadcrumbItem({
name,
- index,
- handleClick,
- disabled = false,
- isActive = false,
- showSeparator = true,
-}: BreadcrumbItemProps) => {
- const handleClickItem = useCallback(() => {
- if (!disabled) handleClick(index)
- }, [disabled, handleClick, index])
-
+ onClick,
+ current = false,
+ title,
+}: BreadcrumbItemProps) {
return (
<>
- <button
- type="button"
- className={cn(
- 'max-w-full shrink truncate rounded-md px-1.25 py-1',
- isActive
- ? 'system-sm-medium text-text-secondary'
- : 'system-sm-regular text-text-tertiary',
- !disabled && 'hover:bg-state-base-hover',
- )}
- disabled={disabled}
- onClick={handleClickItem}
- title={name}
- >
- {name}
- </button>
- {showSeparator && <span className="shrink-0 system-xs-regular text-divider-deep">/</span>}
+ <PathItem>
+ <button
+ type="button"
+ aria-current={current ? 'location' : undefined}
+ className={cn(
+ 'truncate rounded-md px-1.25 py-1 focus-visible:ring-2 focus-visible:ring-state-accent-solid focus-visible:outline-hidden',
+ current
+ ? 'system-sm-medium text-text-secondary'
+ : 'system-sm-regular text-text-tertiary hover:bg-state-base-hover',
+ )}
+ disabled={current}
+ onClick={onClick}
+ title={title}
+ >
+ {name}
+ </button>
+ </PathItem>
+ {!current && <BreadcrumbSeparator className="system-xs-regular text-divider-deep" />}
</>
)
}
-
-BreadcrumbItem.displayName = 'BreadcrumbItem'
-
-export default React.memo(BreadcrumbItem)
diff --git a/web/app/components/plugins/marketplace/creator-profile/view.tsx b/web/app/components/plugins/marketplace/creator-profile/view.tsx
index e93f490f187..1df52782886 100644
--- a/web/app/components/plugins/marketplace/creator-profile/view.tsx
+++ b/web/app/components/plugins/marketplace/creator-profile/view.tsx
@@ -9,7 +9,16 @@ import type {
CreatorProfileViewModel,
} from './model'
import type { Plugin } from '@/app/components/plugins/types'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbLink,
+ BreadcrumbList,
+ BreadcrumbPage,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
import { cn } from '@langgenius/dify-ui/cn'
+import { iconButtonVariants } from '@langgenius/dify-ui/icon-button'
import { useTranslation } from '#i18n'
import Link from '@/next/link'
import DefaultCreatorBackground from './assets/default-background.png'
@@ -51,24 +60,28 @@ export default function CreatorProfileView({
isMarketplacePlatform ? 'md:px-6' : 'md:px-9',
)}
>
- <nav
+ <Breadcrumb
aria-label={t(($) => $['marketplace.creatorProfile.breadcrumbLabel'], { ns: 'plugin' })}
- className="flex h-12 shrink-0 items-end gap-2 overflow-hidden"
+ className="h-12 shrink-0"
>
- <Link
- href={homeHref}
- aria-label={t(($) => $['marketplace.creatorProfile.home'], { ns: 'plugin' })}
- className="flex size-6 shrink-0 items-center justify-center rounded-md text-text-tertiary outline-hidden hover:bg-state-base-hover hover:text-text-secondary focus-visible:ring-2 focus-visible:ring-state-accent-solid"
- >
- <span aria-hidden className="i-ri-home-4-line size-4" />
- </Link>
- <span aria-hidden className="pb-0.5 system-md-regular text-text-quaternary">
- /
- </span>
- <span className="pb-0.5 system-md-regular text-text-primary">
- {t(($) => $['marketplace.creatorProfile.title'], { ns: 'plugin' })}
- </span>
- </nav>
+ <BreadcrumbList className="h-full items-end gap-2">
+ <BreadcrumbItem className="shrink-0">
+ <BreadcrumbLink
+ render={<Link href={homeHref} />}
+ aria-label={t(($) => $['marketplace.creatorProfile.home'], { ns: 'plugin' })}
+ className={iconButtonVariants({ size: 'md' })}
+ >
+ <span aria-hidden className="i-ri-home-4-line size-4" />
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator className="pb-0.5 system-md-regular" />
+ <BreadcrumbItem>
+ <BreadcrumbPage className="pb-0.5 system-md-regular">
+ {t(($) => $['marketplace.creatorProfile.title'], { ns: 'plugin' })}
+ </BreadcrumbPage>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
<div className="w-full pt-5 pb-8">
<div
diff --git a/web/app/components/snippet-list/__tests__/index.spec.tsx b/web/app/components/snippet-list/__tests__/index.spec.tsx
index 23bf6333ca1..0eda8c85bc2 100644
--- a/web/app/components/snippet-list/__tests__/index.spec.tsx
+++ b/web/app/components/snippet-list/__tests__/index.spec.tsx
@@ -277,6 +277,10 @@ describe('SnippetList', () => {
expect(screen.getByRole('link', { name: 'common.menus.apps' })).toHaveAttribute('href', '/apps')
expect(screen.getByRole('heading', { name: 'workflow.tabs.snippets' })).toBeInTheDocument()
+ const path = within(screen.getByRole('navigation', { name: 'workflow.tabs.snippets' }))
+ expect(path.getByRole('link', { name: 'common.menus.apps' })).toHaveAttribute('href', '/apps')
+ expect(path.getAllByRole('listitem')).toHaveLength(2)
+ expect(path.getByText('workflow.tabs.snippets')).toHaveAttribute('aria-current', 'page')
expect(screen.getByText('app.studio.filters.creators')).toBeInTheDocument()
expect(
screen.getByRole('button', { name: /workflow\.common\.published \/ snippet\.draft/i }),
diff --git a/web/app/components/snippet-list/index.tsx b/web/app/components/snippet-list/index.tsx
index b5b0a4ddc85..3525e97f5d6 100644
--- a/web/app/components/snippet-list/index.tsx
+++ b/web/app/components/snippet-list/index.tsx
@@ -2,6 +2,14 @@
import type { SnippetPublishStatus } from './components/snippet-publish-status-filter'
import type { SnippetListItem } from '@/types/snippet'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbLink,
+ BreadcrumbList,
+ BreadcrumbPage,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
import { Button } from '@langgenius/dify-ui/button'
import { cn } from '@langgenius/dify-ui/cn'
import { useDebounce } from 'ahooks'
@@ -180,18 +188,23 @@ const SnippetList = () => {
>
<StudioListHeader
title={
- <>
- <Link
- href="/apps"
- className="min-w-0 truncate text-[18px]/[21.6px] font-semibold text-text-tertiary outline-hidden hover:text-text-secondary focus-visible:ring-2 focus-visible:ring-state-accent-solid"
- >
- {t(($) => $['menus.apps'], { ns: 'common' })}
- </Link>
- <span className="mx-1.5 shrink-0 font-light text-divider-deep">/</span>
- <h1 className="min-w-0 truncate text-[18px]/[21.6px] font-semibold text-text-primary">
- {t(($) => $['tabs.snippets'], { ns: 'workflow' })}
- </h1>
- </>
+ <Breadcrumb aria-label={t(($) => $['tabs.snippets'], { ns: 'workflow' })}>
+ <BreadcrumbList className="text-[18px]/[21.6px] font-semibold">
+ <BreadcrumbItem>
+ <BreadcrumbLink render={<Link href="/apps" />} className="block truncate">
+ {t(($) => $['menus.apps'], { ns: 'common' })}
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator className="text-base/6 font-light text-divider-deep" />
+ <BreadcrumbItem>
+ <h1 className="min-w-0 truncate">
+ <BreadcrumbPage>
+ {t(($) => $['tabs.snippets'], { ns: 'workflow' })}
+ </BreadcrumbPage>
+ </h1>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
}
>
<div className="flex flex-wrap items-center justify-between gap-2">
diff --git a/web/app/components/snippets/components/__tests__/snippet-detail-top.spec.tsx b/web/app/components/snippets/components/__tests__/snippet-detail-top.spec.tsx
new file mode 100644
index 00000000000..200ae07fe34
--- /dev/null
+++ b/web/app/components/snippets/components/__tests__/snippet-detail-top.spec.tsx
@@ -0,0 +1,38 @@
+import { render, screen, within } from '@testing-library/react'
+import userEvent from '@testing-library/user-event'
+import { SnippetDetailTop } from '../snippet-detail-top'
+
+const back = vi.fn()
+vi.mock('@/next/navigation', () => ({
+ useRouter: () => ({ back }),
+}))
+
+beforeEach(() => {
+ vi.clearAllMocks()
+})
+
+it('keeps browser history separate from the home and snippet collection destinations', async () => {
+ const user = userEvent.setup()
+ render(<SnippetDetailTop />)
+ const path = within(screen.getByRole('navigation', { name: 'workflow.tabs.snippets' }))
+ expect(path.getAllByRole('listitem')).toHaveLength(2)
+ expect(path.getByRole('link', { name: 'common.mainNav.home' })).toHaveAttribute('href', '/')
+ const collection = path.getByRole('link', { name: 'workflow.tabs.snippets' })
+ expect(collection).toHaveAttribute('href', '/snippets')
+ expect(collection).not.toHaveAttribute('aria-current')
+
+ const previous = path.getByRole('button', { name: 'common.operation.back' })
+ previous.focus()
+ await user.keyboard('{Enter}')
+ expect(back).toHaveBeenCalledOnce()
+})
+
+it('removes the path when collapsed while retaining the expand control', async () => {
+ const user = userEvent.setup()
+ const onToggle = vi.fn()
+ const { rerender } = render(<SnippetDetailTop onToggle={onToggle} />)
+ rerender(<SnippetDetailTop expand={false} onToggle={onToggle} />)
+ expect(screen.queryByRole('navigation')).not.toBeInTheDocument()
+ await user.click(screen.getByRole('button', { name: 'layout.sidebar.expandSidebar' }))
+ expect(onToggle).toHaveBeenCalledOnce()
+})
diff --git a/web/app/components/snippets/components/snippet-detail-top.tsx b/web/app/components/snippets/components/snippet-detail-top.tsx
index 9efa7f2b393..ac2b11ca18c 100644
--- a/web/app/components/snippets/components/snippet-detail-top.tsx
+++ b/web/app/components/snippets/components/snippet-detail-top.tsx
@@ -1,6 +1,14 @@
'use client'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbLink,
+ BreadcrumbList,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
import { DialogTrigger } from '@langgenius/dify-ui/dialog'
+import { IconButton } from '@langgenius/dify-ui/icon-button'
import { Kbd, KbdGroup } from '@langgenius/dify-ui/kbd'
import { Tooltip, TooltipContent, TooltipTrigger } from '@langgenius/dify-ui/tooltip'
import { formatForDisplay } from '@tanstack/react-hotkeys'
@@ -37,32 +45,35 @@ export function SnippetDetailTop({ expand = true, onToggle }: SnippetDetailTopPr
return (
<div className="flex items-center py-2 pr-2 pl-1">
- <div className="flex min-w-0 flex-1 items-center gap-px">
- <div className="flex shrink-0 items-center rounded-lg py-2 pr-1.5 pl-0.5 transition-colors hover:bg-background-default-hover">
- <button
- type="button"
- aria-label={t(($) => $['operation.back'], { ns: 'common' })}
- className="flex size-4 items-center justify-center text-text-tertiary hover:text-text-secondary"
- onClick={() => router.back()}
- >
- <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
- </button>
- <Link
- href="/"
- aria-label={t(($) => $['mainNav.home'], { ns: 'common' })}
- className="flex size-4 items-center justify-center text-text-tertiary hover:text-text-secondary"
- >
- <span aria-hidden className="i-custom-vender-main-nav-app-home size-4" />
- </Link>
- </div>
- <span className="shrink-0 system-md-regular text-text-quaternary">/</span>
- <Link
- href="/snippets"
- className="shrink-0 truncate rounded-lg px-1.5 py-2 system-sm-semibold-uppercase text-text-secondary transition-colors hover:bg-background-default-hover hover:text-text-primary"
- >
- {t(($) => $['tabs.snippets'], { ns: 'workflow' })}
- </Link>
- </div>
+ <Breadcrumb aria-label={t(($) => $['tabs.snippets'], { ns: 'workflow' })} className="flex-1">
+ <BreadcrumbList className="gap-px">
+ <BreadcrumbItem className="shrink-0 gap-0 rounded-lg py-2 pr-1.5 pl-0.5 transition-colors hover:bg-background-default-hover">
+ <IconButton
+ size="xs"
+ aria-label={t(($) => $['operation.back'], { ns: 'common' })}
+ onClick={() => router.back()}
+ >
+ <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
+ </IconButton>
+ <BreadcrumbLink
+ render={<Link href="/" />}
+ aria-label={t(($) => $['mainNav.home'], { ns: 'common' })}
+ className="size-4 justify-center"
+ >
+ <span aria-hidden className="i-custom-vender-main-nav-app-home size-4" />
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator className="system-md-regular" />
+ <BreadcrumbItem className="shrink-0">
+ <BreadcrumbLink
+ render={<Link href="/snippets" />}
+ className="rounded-lg px-1.5 py-2 system-sm-semibold-uppercase text-text-secondary hover:bg-background-default-hover hover:text-text-primary"
+ >
+ {t(($) => $['tabs.snippets'], { ns: 'workflow' })}
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
<Tooltip>
<TooltipTrigger
render={
diff --git a/web/app/components/workflow/nodes/human-input/components/__tests__/single-run-form.browser.spec.tsx b/web/app/components/workflow/nodes/human-input/components/__tests__/single-run-form.browser.spec.tsx
new file mode 100644
index 00000000000..0b15a5c4ea5
--- /dev/null
+++ b/web/app/components/workflow/nodes/human-input/components/__tests__/single-run-form.browser.spec.tsx
@@ -0,0 +1,41 @@
+import { render } from 'vitest-browser-react'
+import SingleRunForm from '../single-run-form'
+
+vi.mock('react-i18next', async () => {
+ const { createReactI18nextMock } = await import('@/test/i18n-mock')
+ return createReactI18nextMock({ 'workflow.nodes.humanInput.singleRun.back': 'Back' })
+})
+
+it('keeps the full node name inside the form panel', async () => {
+ const name = 'Research and development platform engineering operations team'
+ const screen = await render(
+ <div style={{ width: 400 }}>
+ <SingleRunForm
+ nodeName={name}
+ showBackButton
+ handleBack={() => {}}
+ data={{
+ form_id: 'form',
+ node_id: 'node',
+ node_title: name,
+ form_content: '',
+ inputs: [],
+ actions: [],
+ form_token: 'token',
+ resolved_default_values: {},
+ display_in_ui: true,
+ expiration_time: 0,
+ }}
+ />
+ </div>,
+ )
+ const navigation = screen.getByRole('navigation', { name }).element()
+ const bounds = navigation.getBoundingClientRect()
+ const text = document.createRange()
+ text.selectNodeContents(screen.getByText(name, { exact: true }).element())
+ for (const line of text.getClientRects()) {
+ expect(line.right).toBeLessThanOrEqual(bounds.right)
+ expect(line.bottom).toBeLessThanOrEqual(bounds.bottom)
+ }
+ expect(navigation.scrollWidth).toBeLessThanOrEqual(navigation.clientWidth)
+})
diff --git a/web/app/components/workflow/nodes/human-input/components/single-run-form.tsx b/web/app/components/workflow/nodes/human-input/components/single-run-form.tsx
index 6579ec1df1f..3700a8765d6 100644
--- a/web/app/components/workflow/nodes/human-input/components/single-run-form.tsx
+++ b/web/app/components/workflow/nodes/human-input/components/single-run-form.tsx
@@ -2,8 +2,14 @@
import type { HumanInputFieldValue } from '@/app/components/base/chat/chat/answer/human-input-content/field-renderer'
import type { UserAction } from '@/app/components/workflow/nodes/human-input/types'
import type { HumanInputFormData } from '@/types/workflow'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbList,
+ BreadcrumbPage,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
import { Button } from '@langgenius/dify-ui/button'
-import { RiArrowLeftLine } from '@remixicon/react'
import * as React from 'react'
import { useState } from 'react'
import { useTranslation } from 'react-i18next'
@@ -56,18 +62,29 @@ const FormContent = ({ nodeName, data, showBackButton, handleBack, onSubmit }: P
return (
<>
{showBackButton && (
- <div className="flex items-center p-4 pb-1">
- <button
- type="button"
- className="flex cursor-pointer items-center border-none bg-transparent p-0 text-left system-sm-semibold-uppercase text-text-accent"
- onClick={handleBack}
- >
- <RiArrowLeftLine className="mr-1 size-4" aria-hidden />
- {t(($) => $['nodes.humanInput.singleRun.back'], { ns: 'workflow' })}
- </button>
- <div className="mx-1 system-xs-regular text-divider-deep">/</div>
- <div className="system-sm-semibold-uppercase text-text-secondary">{nodeName}</div>
- </div>
+ <Breadcrumb aria-label={nodeName} className="p-4 pb-1">
+ <BreadcrumbList className="gap-0">
+ <BreadcrumbItem className="shrink-0">
+ <button
+ type="button"
+ className="flex cursor-pointer items-center gap-1 rounded-sm text-left system-sm-semibold-uppercase text-text-accent focus-visible:ring-2 focus-visible:ring-state-accent-solid focus-visible:outline-hidden"
+ onClick={handleBack}
+ >
+ <span className="i-ri-arrow-left-line size-4" aria-hidden />
+ {t(($) => $['nodes.humanInput.singleRun.back'], { ns: 'workflow' })}
+ </button>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator className="mx-1 system-xs-regular text-divider-deep" />
+ <BreadcrumbItem>
+ <BreadcrumbPage
+ aria-current="location"
+ className="system-sm-semibold-uppercase wrap-anywhere whitespace-normal text-text-secondary"
+ >
+ {nodeName}
+ </BreadcrumbPage>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
)}
<div className="px-4 py-3">
{contentList.map((content, index) => (
diff --git a/web/app/components/workflow/run/agent-log/__tests__/agent-log-nav.browser.spec.tsx b/web/app/components/workflow/run/agent-log/__tests__/agent-log-nav.browser.spec.tsx
new file mode 100644
index 00000000000..e7751c1a2a5
--- /dev/null
+++ b/web/app/components/workflow/run/agent-log/__tests__/agent-log-nav.browser.spec.tsx
@@ -0,0 +1,39 @@
+import type { AgentLogItemWithChildren } from '@/types/workflow'
+import { render } from 'vitest-browser-react'
+import { AgentLogNav } from '../agent-log-nav'
+
+vi.mock('react-i18next', async () => {
+ const { createReactI18nextMock } = await import('@/test/i18n-mock')
+ return createReactI18nextMock({ 'workflow.nodes.agent.strategy.label': 'Strategy' })
+})
+
+it('keeps a long current log name readable inside the result panel', async () => {
+ const label = 'Research and development platform engineering operations team'
+ const item: AgentLogItemWithChildren = {
+ message_id: 'tool',
+ label,
+ children: [],
+ status: 'succeeded',
+ node_execution_id: 'exec',
+ node_id: 'node',
+ data: {},
+ }
+ const screen = await render(
+ <div style={{ width: 400 }}>
+ <AgentLogNav
+ agentOrToolLogItemStack={[{ ...item, message_id: 'root', label: 'Strategy' }, item]}
+ onShowAgentOrToolLog={() => {}}
+ />
+ </div>,
+ )
+ const navigation = screen.getByRole('navigation').element()
+ const current = screen.getByText(label).element()
+ const text = document.createRange()
+ text.selectNodeContents(current)
+ const bounds = navigation.getBoundingClientRect()
+ for (const line of text.getClientRects()) {
+ expect(line.right).toBeLessThanOrEqual(bounds.right)
+ expect(line.bottom).toBeLessThanOrEqual(bounds.bottom)
+ }
+ expect(navigation.scrollWidth).toBeLessThanOrEqual(navigation.clientWidth)
+})
diff --git a/web/app/components/workflow/run/agent-log/agent-log-nav.tsx b/web/app/components/workflow/run/agent-log/agent-log-nav.tsx
index 5237356f9e6..b86f3561dc3 100644
--- a/web/app/components/workflow/run/agent-log/agent-log-nav.tsx
+++ b/web/app/components/workflow/run/agent-log/agent-log-nav.tsx
@@ -1,4 +1,11 @@
import type { AgentLogItemWithChildren } from '@/types/workflow'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbList,
+ BreadcrumbPage,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
import { Button } from '@langgenius/dify-ui/button'
import { useTranslation } from 'react-i18next'
import AgentLogNavMore from './agent-log-nav-more'
@@ -15,47 +22,68 @@ export function AgentLogNav({ agentOrToolLogItemStack, onShowAgentOrToolLog }: A
const end = agentOrToolLogItemStack.at(-1)
return (
- <div className="flex h-8 items-center bg-components-panel-bg p-1 pr-3">
- <Button
- className="shrink-0 px-1.25"
- size="small"
- variant="ghost-accent"
- onClick={() => {
- onShowAgentOrToolLog()
- }}
- >
- <span aria-hidden className="i-ri-arrow-left-line size-3.5" />
- AGENT
- </Button>
- <div className="mx-0.5 shrink-0 system-xs-regular text-divider-deep">/</div>
- {agentOrToolLogItemStackLength > 1 ? (
- <Button
- className="shrink-0 px-1.25"
- size="small"
- variant="ghost-accent"
- onClick={() => onShowAgentOrToolLog(first)}
- >
- {t(($) => $['nodes.agent.strategy.label'], { ns: 'workflow' })}
- </Button>
- ) : (
- <div className="flex items-center px-1.25 system-xs-medium-uppercase text-text-tertiary">
- {t(($) => $['nodes.agent.strategy.label'], { ns: 'workflow' })}
- </div>
- )}
- {!!mid.length && (
- <>
- <div className="mx-0.5 shrink-0 system-xs-regular text-divider-deep">/</div>
- <AgentLogNavMore options={mid} onShowAgentOrToolLog={onShowAgentOrToolLog} />
- </>
- )}
- {!!end && agentOrToolLogItemStackLength > 1 && (
- <>
- <div className="mx-0.5 shrink-0 system-xs-regular text-divider-deep">/</div>
- <div className="flex items-center px-1.25 system-xs-medium-uppercase text-text-tertiary">
- {end.label}
- </div>
- </>
- )}
- </div>
+ <Breadcrumb
+ aria-label={t(($) => $['nodes.agent.strategy.label'], { ns: 'workflow' })}
+ className="flex min-h-8 items-center bg-components-panel-bg p-1 pr-3"
+ >
+ <BreadcrumbList className="gap-0">
+ <BreadcrumbItem className="shrink-0">
+ <Button
+ className="px-1.25"
+ size="small"
+ variant="ghost-accent"
+ onClick={() => {
+ onShowAgentOrToolLog()
+ }}
+ >
+ <span aria-hidden className="i-ri-arrow-left-line size-3.5" />
+ AGENT
+ </Button>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator className="mx-0.5 system-xs-regular text-divider-deep" />
+ {agentOrToolLogItemStackLength > 1 ? (
+ <BreadcrumbItem className="shrink-0">
+ <Button
+ className="px-1.25"
+ size="small"
+ variant="ghost-accent"
+ onClick={() => onShowAgentOrToolLog(first)}
+ >
+ {t(($) => $['nodes.agent.strategy.label'], { ns: 'workflow' })}
+ </Button>
+ </BreadcrumbItem>
+ ) : (
+ <BreadcrumbItem>
+ <BreadcrumbPage
+ aria-current="location"
+ className="px-1.25 system-xs-medium-uppercase wrap-anywhere whitespace-normal text-text-tertiary"
+ >
+ {t(($) => $['nodes.agent.strategy.label'], { ns: 'workflow' })}
+ </BreadcrumbPage>
+ </BreadcrumbItem>
+ )}
+ {!!mid.length && (
+ <>
+ <BreadcrumbSeparator className="mx-0.5 system-xs-regular text-divider-deep" />
+ <BreadcrumbItem className="shrink-0">
+ <AgentLogNavMore options={mid} onShowAgentOrToolLog={onShowAgentOrToolLog} />
+ </BreadcrumbItem>
+ </>
+ )}
+ {!!end && agentOrToolLogItemStackLength > 1 && (
+ <>
+ <BreadcrumbSeparator className="mx-0.5 system-xs-regular text-divider-deep" />
+ <BreadcrumbItem>
+ <BreadcrumbPage
+ aria-current="location"
+ className="px-1.25 system-xs-medium-uppercase wrap-anywhere whitespace-normal text-text-tertiary"
+ >
+ {end.label}
+ </BreadcrumbPage>
+ </BreadcrumbItem>
+ </>
+ )}
+ </BreadcrumbList>
+ </Breadcrumb>
)
}
diff --git a/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/working-directory-breadcrumb.spec.tsx b/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/working-directory-breadcrumb.spec.tsx
index cf327f5687e..8e17c335b5b 100644
--- a/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/working-directory-breadcrumb.spec.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/working-directory-breadcrumb.spec.tsx
@@ -16,13 +16,13 @@ describe('AgentWorkingDirectoryBreadcrumb', () => {
name: 'agentV2.agentDetail.configure.workingDirectory.breadcrumbLabel',
}),
).toBeInTheDocument()
- expect(screen.getByRole('button', { name: '.' })).toHaveAttribute('aria-current', 'page')
+ expect(screen.getByRole('button', { name: '.' })).toHaveAttribute('aria-current', 'location')
})
it('should render the saved-files root path', () => {
render(<AgentWorkingDirectoryBreadcrumb path="~" onPathChange={vi.fn()} />)
- expect(screen.getByRole('button', { name: '~' })).toHaveAttribute('aria-current', 'page')
+ expect(screen.getByRole('button', { name: '~' })).toHaveAttribute('aria-current', 'location')
})
it('should render the saved-files prefix before its path segments', () => {
@@ -33,17 +33,21 @@ describe('AgentWorkingDirectoryBreadcrumb', () => {
screen.getByRole('button', {
name: 'web-game',
}),
- ).toHaveAttribute('aria-current', 'page')
+ ).toHaveAttribute('aria-current', 'location')
})
it('should collapse middle breadcrumb layers when path is deeper than three layers', () => {
render(<AgentWorkingDirectoryBreadcrumb path="~/web-game/src/app" onPathChange={vi.fn()} />)
+ expect(screen.getAllByRole('listitem')).toHaveLength(4)
expect(screen.getByRole('button', { name: '~' })).toBeInTheDocument()
- expect(screen.getByRole('button', { name: '...' })).toBeInTheDocument()
+ expect(screen.getByRole('button', { name: 'common.operation.more' })).toBeInTheDocument()
expect(screen.queryByRole('button', { name: 'web-game' })).not.toBeInTheDocument()
expect(screen.getByRole('button', { name: 'src' })).toBeInTheDocument()
- expect(screen.getByRole('button', { name: 'app' })).toHaveAttribute('aria-current', 'page')
+ expect(screen.getByRole('button', { name: 'app' })).toHaveAttribute(
+ 'aria-current',
+ 'location',
+ )
})
})
@@ -80,7 +84,7 @@ describe('AgentWorkingDirectoryBreadcrumb', () => {
/>,
)
- await user.click(screen.getByRole('button', { name: '...' }))
+ await user.click(screen.getByRole('button', { name: 'common.operation.more' }))
await user.click(
screen.getByRole('menuitem', {
name: 'web-game',
diff --git a/web/features/agent-v2/agent-detail/configure/components/preview/working-directory-breadcrumb.tsx b/web/features/agent-v2/agent-detail/configure/components/preview/working-directory-breadcrumb.tsx
index 786147eed09..325be1f4519 100644
--- a/web/features/agent-v2/agent-detail/configure/components/preview/working-directory-breadcrumb.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/preview/working-directory-breadcrumb.tsx
@@ -1,5 +1,11 @@
'use client'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbList,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
import { cn } from '@langgenius/dify-ui/cn'
import {
DropdownMenu,
@@ -7,6 +13,8 @@ import {
DropdownMenuItem,
DropdownMenuTrigger,
} from '@langgenius/dify-ui/dropdown-menu'
+import { IconButton } from '@langgenius/dify-ui/icon-button'
+import { Fragment } from 'react'
import { useTranslation } from 'react-i18next'
export const AGENT_SAVED_FILES_ROOT_PATH = '~'
@@ -101,7 +109,7 @@ function AgentWorkingDirectoryBreadcrumbItem({
<button
type="button"
onClick={onClick}
- aria-current={active ? 'page' : undefined}
+ aria-current={active ? 'location' : undefined}
className={cn(
'flex min-w-0 items-center justify-center gap-1 rounded-md py-0.5 pr-1 pl-0.5 text-text-tertiary hover:bg-state-base-hover hover:text-text-secondary focus-visible:ring-2 focus-visible:ring-state-accent-solid focus-visible:outline-hidden',
active && 'text-text-secondary',
@@ -124,71 +132,77 @@ export function AgentWorkingDirectoryBreadcrumb({
const items = getBreadcrumbItems(path)
const { hiddenItems, visibleItems } = getVisibleBreadcrumbItems(items)
- const renderSeparator = (key: string) => (
- <span key={key} aria-hidden className="system-xs-regular text-divider-deep">
- /
- </span>
- )
-
return (
<div className="mb-1 flex w-full shrink-0 flex-col border-y-[0.5px] border-divider-regular px-2.5">
- <nav
+ <Breadcrumb
aria-label={t(($) => $['agentDetail.configure.workingDirectory.breadcrumbLabel'])}
- className="flex min-w-0 items-center gap-0.5 py-1"
+ className="py-1"
>
- {visibleItems.map((item, index) => {
- const isLastItem = index === visibleItems.length - 1
-
- return (
- <div key={item.path} className="contents">
- {index > 0 && renderSeparator(`${item.path}-separator`)}
- {index === 1 && hiddenItems.length > 0 && (
- <>
- <DropdownMenu modal={false}>
- <DropdownMenuTrigger
- aria-label="..."
- className="flex size-6 shrink-0 items-center justify-center rounded-md p-1 text-text-tertiary hover:bg-state-base-hover hover:text-text-secondary focus-visible:ring-2 focus-visible:ring-state-accent-solid focus-visible:outline-hidden data-popup-open:bg-state-base-hover data-popup-open:text-text-secondary"
- >
- <span aria-hidden className="i-ri-more-fill size-4" />
- </DropdownMenuTrigger>
- <DropdownMenuContent
- placement="bottom-start"
- sideOffset={4}
- className="w-34 p-1"
- >
- {hiddenItems.map((hiddenItem) => (
- <DropdownMenuItem
- key={hiddenItem.path}
- className="gap-1 px-2 py-1.5"
- onClick={() => onPathChange(hiddenItem.path)}
+ <BreadcrumbList className="gap-0.5">
+ {visibleItems.map((item, index) => {
+ const isLastItem = index === visibleItems.length - 1
+
+ return (
+ <Fragment key={item.path}>
+ {index > 0 && (
+ <BreadcrumbSeparator className="system-xs-regular text-divider-deep" />
+ )}
+ {index === 1 && hiddenItems.length > 0 && (
+ <>
+ <BreadcrumbItem className="shrink-0">
+ <DropdownMenu modal={false}>
+ <DropdownMenuTrigger
+ render={
+ <IconButton
+ aria-label={t(($) => $['operation.more'], { ns: 'common' })}
+ className="data-popup-open:bg-state-base-hover data-popup-open:text-text-secondary"
+ >
+ <span aria-hidden className="i-ri-more-fill size-4" />
+ </IconButton>
+ }
+ />
+ <DropdownMenuContent
+ placement="bottom-start"
+ sideOffset={4}
+ className="w-34 p-1"
>
- <span
- aria-hidden
- className={cn(
- 'size-4 shrink-0 text-text-secondary',
- hiddenItem.iconClassName,
- )}
- />
- <span className="min-w-0 truncate px-1 system-md-regular">
- {hiddenItem.label}
- </span>
- </DropdownMenuItem>
- ))}
- </DropdownMenuContent>
- </DropdownMenu>
- {renderSeparator('hidden-items-separator')}
- </>
- )}
- <AgentWorkingDirectoryBreadcrumbItem
- active={isLastItem}
- iconClassName={item.iconClassName}
- label={item.label}
- onClick={() => onPathChange(item.path)}
- />
- </div>
- )
- })}
- </nav>
+ {hiddenItems.map((hiddenItem) => (
+ <DropdownMenuItem
+ key={hiddenItem.path}
+ className="gap-1 px-2 py-1.5"
+ onClick={() => onPathChange(hiddenItem.path)}
+ >
+ <span
+ aria-hidden
+ className={cn(
+ 'size-4 shrink-0 text-text-secondary',
+ hiddenItem.iconClassName,
+ )}
+ />
+ <span className="min-w-0 truncate px-1 system-md-regular">
+ {hiddenItem.label}
+ </span>
+ </DropdownMenuItem>
+ ))}
+ </DropdownMenuContent>
+ </DropdownMenu>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator className="system-xs-regular text-divider-deep" />
+ </>
+ )}
+ <BreadcrumbItem>
+ <AgentWorkingDirectoryBreadcrumbItem
+ active={isLastItem}
+ iconClassName={item.iconClassName}
+ label={item.label}
+ onClick={() => onPathChange(item.path)}
+ />
+ </BreadcrumbItem>
+ </Fragment>
+ )
+ })}
+ </BreadcrumbList>
+ </Breadcrumb>
</div>
)
}
diff --git a/web/features/agent-v2/agent-detail/navigation.tsx b/web/features/agent-v2/agent-detail/navigation.tsx
index dce91202121..22b345c48c5 100644
--- a/web/features/agent-v2/agent-detail/navigation.tsx
+++ b/web/features/agent-v2/agent-detail/navigation.tsx
@@ -4,6 +4,13 @@ import type { AgentIconType } from '@dify/contracts/api/console/agent/types.gen'
import type { ComponentProps } from 'react'
import type { AgentDetailSectionKey } from './section'
import type { NavIcon } from '@/app/components/app-sidebar/nav-link'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbLink,
+ BreadcrumbList,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
import { cn } from '@langgenius/dify-ui/cn'
import { DialogTrigger } from '@langgenius/dify-ui/dialog'
import { Kbd, KbdGroup } from '@langgenius/dify-ui/kbd'
@@ -110,23 +117,32 @@ export function AgentDetailTop({ expand = true, onToggle }: AgentDetailTopProps)
return (
<div className="flex items-center py-2 pr-2 pl-1">
- <div className="flex min-w-0 flex-1 items-center gap-px">
- <Link
- href="/"
- aria-label={tCommon(($) => $['mainNav.home'])}
- className="flex shrink-0 items-center rounded-lg py-2 pr-1.5 pl-0.5 text-text-tertiary transition-colors hover:bg-background-default-hover hover:text-text-secondary focus-visible:ring-2 focus-visible:ring-state-accent-solid focus-visible:outline-hidden"
- >
- <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
- <span aria-hidden className="i-custom-vender-main-nav-app-home size-4" />
- </Link>
- <span className="shrink-0 system-md-regular text-text-quaternary">/</span>
- <Link
- href="/agents"
- className="shrink-0 truncate rounded-lg px-1.5 py-2 system-sm-semibold-uppercase text-text-secondary transition-colors hover:bg-background-default-hover hover:text-text-primary focus-visible:ring-2 focus-visible:ring-state-accent-solid focus-visible:outline-hidden"
- >
- Agents
- </Link>
- </div>
+ <Breadcrumb
+ aria-label={tCommon(($) => $['roster.title'], { ns: 'agentV2' })}
+ className="flex-1"
+ >
+ <BreadcrumbList className="gap-px">
+ <BreadcrumbItem className="shrink-0">
+ <BreadcrumbLink
+ render={<Link href="/" />}
+ aria-label={tCommon(($) => $['mainNav.home'])}
+ className="gap-0 rounded-lg py-2 pr-1.5 pl-0.5 hover:bg-background-default-hover"
+ >
+ <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
+ <span aria-hidden className="i-custom-vender-main-nav-app-home size-4" />
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator className="system-md-regular" />
+ <BreadcrumbItem className="shrink-0">
+ <BreadcrumbLink
+ render={<Link href="/agents" />}
+ className="rounded-lg px-1.5 py-2 system-sm-semibold-uppercase text-text-secondary hover:bg-background-default-hover hover:text-text-primary"
+ >
+ Agents
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
<Tooltip>
<TooltipTrigger
render={
diff --git a/web/features/new-rag/knowledge-space-shell.tsx b/web/features/new-rag/knowledge-space-shell.tsx
index 9ab62898a3d..84c6f0c6702 100644
--- a/web/features/new-rag/knowledge-space-shell.tsx
+++ b/web/features/new-rag/knowledge-space-shell.tsx
@@ -1,6 +1,13 @@
'use client'
import type { ReactNode } from 'react'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbLink,
+ BreadcrumbList,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
import { Button, buttonVariants } from '@langgenius/dify-ui/button'
import { cn } from '@langgenius/dify-ui/cn'
import { useQuery } from '@tanstack/react-query'
@@ -132,22 +139,29 @@ export function KnowledgeSpaceShell({
{pageTitleElement}
<div className="flex min-h-0 min-w-0 flex-1 flex-col gap-1 overflow-hidden sm:flex-row">
<aside className="flex shrink-0 flex-col overflow-hidden rounded-lg bg-components-panel-bg shadow-xs sm:w-60">
- <div className="flex h-12 min-w-0 items-center px-1 pr-2">
- <Link
- href={newKnowledgeListPath}
- aria-label={t(($) => $['newKnowledge.backToList'])}
- className="flex h-8 w-10 shrink-0 items-center justify-center rounded-lg text-text-tertiary outline-hidden hover:bg-state-base-hover focus-visible:ring-2 focus-visible:ring-state-accent-solid"
- >
- <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
- <span aria-hidden className="i-ri-home-5-line size-4" />
- </Link>
- <span aria-hidden className="text-text-quaternary">
- /
- </span>
- <span className="truncate px-1.5 system-sm-semibold-uppercase text-text-secondary">
- {t(($) => $.knowledge)}
- </span>
- </div>
+ <Breadcrumb
+ aria-label={t(($) => $.knowledge)}
+ className="flex h-12 items-center px-1 pr-2"
+ >
+ <BreadcrumbList className="gap-0">
+ <BreadcrumbItem className="shrink-0">
+ <BreadcrumbLink
+ render={<Link href={newKnowledgeListPath} />}
+ aria-label={t(($) => $['newKnowledge.backToList'])}
+ className="h-8 w-10 justify-center gap-0 rounded-lg hover:bg-state-base-hover"
+ >
+ <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
+ <span aria-hidden className="i-ri-home-5-line size-4" />
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator className="text-base/6" />
+ <BreadcrumbItem>
+ <span className="truncate px-1.5 system-sm-semibold-uppercase text-text-secondary">
+ {t(($) => $.knowledge)}
+ </span>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
<div className="flex min-w-0 items-center px-1 py-2">
<div className="flex min-w-0 flex-1 items-center gap-2 rounded-xl p-2">
<div className="flex size-9 shrink-0 items-center justify-center rounded-lg border-[0.5px] border-divider-regular bg-components-icon-bg-orange-dark-soft">
diff --git a/web/features/skills/detail/file-tree.tsx b/web/features/skills/detail/file-tree.tsx
index 39beea3b2de..d7d471b6662 100644
--- a/web/features/skills/detail/file-tree.tsx
+++ b/web/features/skills/detail/file-tree.tsx
@@ -29,6 +29,13 @@ import {
AlertDialogDescription,
AlertDialogTitle,
} from '@langgenius/dify-ui/alert-dialog'
+import {
+ Breadcrumb,
+ BreadcrumbItem,
+ BreadcrumbLink,
+ BreadcrumbList,
+ BreadcrumbSeparator,
+} from '@langgenius/dify-ui/breadcrumb'
import { cn } from '@langgenius/dify-ui/cn'
import {
ContextMenu,
@@ -1198,23 +1205,29 @@ export function FileTree({
data-testid="skill-detail-sidebar-header"
className="flex h-12 shrink-0 items-center py-2 pr-2 pl-1"
>
- <div className="flex min-w-0 flex-1 items-center gap-px">
- <Link
- href="/skills"
- className="flex shrink-0 items-center rounded-lg py-2 pr-1.5 pl-0.5 text-text-tertiary outline-hidden hover:bg-background-default-hover hover:text-text-secondary focus-visible:ring-2 focus-visible:ring-state-accent-solid"
- aria-label={t(($) => $['skillManagement.detail.back'])}
- >
- <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
- <span aria-hidden className="i-custom-vender-main-nav-app-home size-4" />
- </Link>
- <span className="shrink-0 system-md-regular text-text-quaternary">/</span>
- <Link
- href="/skills"
- className="shrink-0 truncate rounded-lg px-1.5 py-2 system-sm-semibold-uppercase text-text-secondary transition-colors hover:bg-background-default-hover hover:text-text-primary focus-visible:ring-2 focus-visible:ring-state-accent-solid focus-visible:outline-hidden"
- >
- SKILLS
- </Link>
- </div>
+ <Breadcrumb aria-label={tCommon(($) => $['mainNav.skills'])} className="flex-1">
+ <BreadcrumbList className="gap-px">
+ <BreadcrumbItem className="shrink-0">
+ <BreadcrumbLink
+ render={<Link href="/skills" />}
+ className="gap-0 rounded-lg py-2 pr-1.5 pl-0.5 hover:bg-background-default-hover"
+ aria-label={t(($) => $['skillManagement.detail.back'])}
+ >
+ <span aria-hidden className="i-ri-arrow-left-s-line size-4" />
+ <span aria-hidden className="i-custom-vender-main-nav-app-home size-4" />
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ <BreadcrumbSeparator className="system-md-regular" />
+ <BreadcrumbItem className="shrink-0">
+ <BreadcrumbLink
+ render={<Link href="/skills" />}
+ className="rounded-lg px-1.5 py-2 system-sm-semibold-uppercase text-text-secondary hover:bg-background-default-hover hover:text-text-primary"
+ >
+ SKILLS
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ </BreadcrumbList>
+ </Breadcrumb>
<Tooltip>
<TooltipTrigger
render={