Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix(api): survive DST transitions when computing the next cron run (#43357)
Chengmian Liua2427050e189
diff --git a/api/libs/schedule_utils.py b/api/libs/schedule_utils.pyindex b80a5ea7227..2d52ff80efc 100644--- a/api/libs/schedule_utils.py+++ b/api/libs/schedule_utils.py@@ -1,7 +1,8 @@from datetime import UTC, datetime+from zoneinfo import ZoneInfo, ZoneInfoNotFoundError-import pytz # type: ignore[import-untyped]from croniter import croniter+from pytz.exceptions import UnknownTimeZoneErrordef calculate_next_run_at(@@ -38,7 +39,12 @@ def calculate_next_run_at(f"(@daily, @weekly, etc.). Got {len(parts)} fields: '{cron_expression}'")- tz = pytz.timezone(timezone)+ try:+ tz = ZoneInfo(timezone)+ except ZoneInfoNotFoundError as exc:+ # Preserve the public error contract: callers and tests expect the same+ # exception type pytz raised for unknown timezone names.+ raise UnknownTimeZoneError(timezone) from excif base_time is None:base_time = datetime.now(UTC)diff --git a/api/tests/unit_tests/libs/test_schedule_utils_enhanced.py b/api/tests/unit_tests/libs/test_schedule_utils_enhanced.pyindex 8e7f2af3ab1..ea6d5719989 100644--- a/api/tests/unit_tests/libs/test_schedule_utils_enhanced.py+++ b/api/tests/unit_tests/libs/test_schedule_utils_enhanced.py@@ -263,6 +263,44 @@ class TestTimezoneHandlingEnhanced(unittest.TestCase):assert local_time.hour in [2, 3]+class TestDstTransitionRegression(unittest.TestCase):+ """Regression tests for DST transitions crashing next-run calculation.++ See https://github.com/langgenius/dify/issues/42955 - localizing the+ candidate local time with pytz (which raises AmbiguousTimeError /+ NonExistentTimeError around clock changes) crashed the schedule poller+ for zones such as Europe/Dublin, Africa/Casablanca and Africa/El_Aaiun.+ """++ def test_fall_back_ambiguous_times_do_not_crash(self):+ """Zones with a fall-back clock change must not raise."""+ # Europe/Dublin falls back on 2026-10-25: 01:00 local occurs twice.+ # Africa/Casablanca and Africa/El_Aaiun change clocks on 2026-03-29.+ test_cases = [+ ("*/10 * * * *", "Europe/Dublin", datetime(2026, 10, 24, 23, 50, 5, tzinfo=UTC)),+ ("30 1 * * *", "Europe/Dublin", datetime(2026, 10, 24, 0, 30, 5, tzinfo=UTC)),+ ("30 1 * * *", "Africa/Casablanca", datetime(2026, 3, 26, 0, 30, 5, tzinfo=UTC)),+ ("30 1 * * *", "Africa/El_Aaiun", datetime(2026, 3, 26, 0, 30, 5, tzinfo=UTC)),+ ]++ for expr, timezone, base_time in test_cases:+ with self.subTest(timezone=timezone, expr=expr):+ result = calculate_next_run_at(expr, timezone, base_time)+ assert result is not None+ assert result.tzinfo is not None+ assert result > base_time++ def test_spring_forward_nonexistent_times_do_not_crash(self):+ """A cron time that does not exist locally must be skipped, not raise."""+ # Europe/Dublin springs forward on 2026-03-29: 01:30 local does not+ # exist. The next run is shifted to the first existing time (02:00).+ result = calculate_next_run_at("30 1 * * *", "Europe/Dublin", datetime(2026, 3, 28, 23, 0, 5, tzinfo=UTC))+ assert result is not None+ assert result > datetime(2026, 3, 28, 23, 0, 5, tzinfo=UTC)+ local_time = result.astimezone(pytz.timezone("Europe/Dublin"))+ assert (local_time.hour, local_time.minute) == (2, 0)++class TestErrorHandlingEnhanced(unittest.TestCase):"""Test error handling for enhanced syntax."""