Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

test: stream real datasource result messages (#43408)

Asuka Minatoac3cdea5bd0a
diff --git a/api/tests/unit_tests/core/datasource/online_document/test_online_document_plugin.py b/api/tests/unit_tests/core/datasource/online_document/test_online_document_plugin.py
index 84160355297..acd2c1b258e 100644
--- a/api/tests/unit_tests/core/datasource/online_document/test_online_document_plugin.py
+++ b/api/tests/unit_tests/core/datasource/online_document/test_online_document_plugin.py
@@ -1,9 +1,11 @@
-from unittest.mock import MagicMock, patch
+from unittest.mock import patch
from core.datasource.__base.datasource_runtime import DatasourceRuntime
from core.datasource.entities.datasource_entities import (
+ DatasourceMessage,
DatasourceProviderType,
GetOnlineDocumentPageContentRequest,
+ OnlineDocumentPagesMessage,
)
from core.datasource.online_document.online_document_plugin import OnlineDocumentDatasourcePlugin
from tests.unit_tests.core.datasource.factories import datasource_entity
@@ -58,12 +60,13 @@ class TestOnlineDocumentDatasourcePlugin:
datasource_parameters = {"param": "value"}
provider_type = "test_type"
- mock_generator = MagicMock()
+ messages = [OnlineDocumentPagesMessage(result=[])]
+ response_stream = (message for message in messages)
# Patch PluginDatasourceManager to isolate plugin behavior from external dependencies
with patch("core.datasource.online_document.online_document_plugin.PluginDatasourceManager") as MockManager:
mock_manager_instance = MockManager.return_value
- mock_manager_instance.get_online_document_pages.return_value = mock_generator
+ mock_manager_instance.get_online_document_pages.return_value = response_stream
# Act
result = plugin.get_online_document_pages(
@@ -71,7 +74,8 @@ class TestOnlineDocumentDatasourcePlugin:
)
# Assert
- assert result == mock_generator
+ assert result is response_stream
+ assert list(result) == messages
mock_manager_instance.get_online_document_pages.assert_called_once_with(
tenant_id=tenant_id,
user_id=user_id,
@@ -108,11 +112,12 @@ class TestOnlineDocumentDatasourcePlugin:
)
provider_type = "test_type"
- mock_generator = MagicMock()
+ messages = [DatasourceMessage(type="text", message=DatasourceMessage.TextMessage(text="document content"))]
+ response_stream = (message for message in messages)
with patch("core.datasource.online_document.online_document_plugin.PluginDatasourceManager") as MockManager:
mock_manager_instance = MockManager.return_value
- mock_manager_instance.get_online_document_page_content.return_value = mock_generator
+ mock_manager_instance.get_online_document_page_content.return_value = response_stream
# Act
result = plugin.get_online_document_page_content(
@@ -120,7 +125,8 @@ class TestOnlineDocumentDatasourcePlugin:
)
# Assert
- assert result == mock_generator
+ assert result is response_stream
+ assert list(result) == messages
mock_manager_instance.get_online_document_page_content.assert_called_once_with(
tenant_id=tenant_id,
user_id=user_id,
diff --git a/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_plugin.py b/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_plugin.py
index 59f6e8a29b8..2aa23ec687a 100644
--- a/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_plugin.py
+++ b/api/tests/unit_tests/core/datasource/online_drive/test_online_drive_plugin.py
@@ -1,9 +1,11 @@
-from unittest.mock import MagicMock, patch
+from unittest.mock import patch
from core.datasource.__base.datasource_runtime import DatasourceRuntime
from core.datasource.entities.datasource_entities import (
+ DatasourceMessage,
DatasourceProviderType,
OnlineDriveBrowseFilesRequest,
+ OnlineDriveBrowseFilesResponse,
OnlineDriveDownloadFileRequest,
)
from core.datasource.online_drive.online_drive_plugin import OnlineDriveDatasourcePlugin
@@ -59,17 +61,19 @@ class TestOnlineDriveDatasourcePlugin:
request = OnlineDriveBrowseFilesRequest(prefix="folder-1")
provider_type = "test_type"
- mock_generator = MagicMock()
+ messages = [OnlineDriveBrowseFilesResponse(result=[])]
+ response_stream = (message for message in messages)
with patch("core.datasource.online_drive.online_drive_plugin.PluginDatasourceManager") as MockManager:
mock_manager_instance = MockManager.return_value
- mock_manager_instance.online_drive_browse_files.return_value = mock_generator
+ mock_manager_instance.online_drive_browse_files.return_value = response_stream
# Act
result = plugin.online_drive_browse_files(user_id=user_id, request=request, provider_type=provider_type)
# Assert
- assert result == mock_generator
+ assert result is response_stream
+ assert list(result) == messages
mock_manager_instance.online_drive_browse_files.assert_called_once_with(
tenant_id=tenant_id,
user_id=user_id,
@@ -104,17 +108,19 @@ class TestOnlineDriveDatasourcePlugin:
request = OnlineDriveDownloadFileRequest(id="file-1")
provider_type = "test_type"
- mock_generator = MagicMock()
+ messages = [DatasourceMessage(type="text", message=DatasourceMessage.TextMessage(text="document content"))]
+ response_stream = (message for message in messages)
with patch("core.datasource.online_drive.online_drive_plugin.PluginDatasourceManager") as MockManager:
mock_manager_instance = MockManager.return_value
- mock_manager_instance.online_drive_download_file.return_value = mock_generator
+ mock_manager_instance.online_drive_download_file.return_value = response_stream
# Act
result = plugin.online_drive_download_file(user_id=user_id, request=request, provider_type=provider_type)
# Assert
- assert result == mock_generator
+ assert result is response_stream
+ assert list(result) == messages
mock_manager_instance.online_drive_download_file.assert_called_once_with(
tenant_id=tenant_id,
user_id=user_id,