Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix: validate rule for provider scoped credentials (#41659)
Yunlu Wenb1eafb0d82b7
diff --git a/api/models/agent_config_entities.py b/api/models/agent_config_entities.pyindex 7accbea4b3c..43d612ac7b8 100644--- a/api/models/agent_config_entities.py+++ b/api/models/agent_config_entities.py@@ -705,7 +705,9 @@ class AgentSoulDifyToolConfig(BaseModel):if not self.provider_id and not (self.plugin_id and self.provider):raise ValueError("Dify tool requires provider_id or plugin_id + provider")if self.credential_type != "unauthorized" and (self.credential_ref is None or not self.credential_ref.id):- raise ValueError("credential_ref.id is required for credentialed Dify tools")+ # credential resolved by provider_id, see ``ToolManager``+ if self.provider_type not in {ToolProviderType.API, ToolProviderType.WORKFLOW}:+ raise ValueError("credential_ref.id is required for credentialed Dify tools")# ``name`` is reserved for a future user-rename UX. Until that lands# the model-visible name is forced to match ``tool_name``; reject# explicit values so a frontend bug surfaces immediately instead ofdiff --git a/api/tests/unit_tests/core/workflow/nodes/agent_v2/test_dify_tools_builder.py b/api/tests/unit_tests/core/workflow/nodes/agent_v2/test_dify_tools_builder.pyindex 46ef8fdeb01..f13032325ec 100644--- a/api/tests/unit_tests/core/workflow/nodes/agent_v2/test_dify_tools_builder.py+++ b/api/tests/unit_tests/core/workflow/nodes/agent_v2/test_dify_tools_builder.py@@ -923,6 +923,50 @@ def test_rejects_unknown_provider_type_at_config_boundary():)[email protected]("provider_type", ["api", "workflow"])+def test_provider_scoped_tool_accepts_authorized_without_credential_id(provider_type: str):+ """``api`` / ``workflow`` credentials live on the provider record, so the+ runtime resolves them from ``provider_id`` alone. An authorized tool of+ these types must validate without a fabricated ``credential_ref.id``."""+ config = AgentSoulToolsConfig.model_validate(+ {+ "dify_tools": [+ {+ "provider_id": "api-provider-1",+ "provider_type": provider_type,+ "tool_name": "get_pet",+ "credential_type": "api-key",+ }+ ]+ }+ )++ tool = config.dify_tools[0]+ # No id is invented; the provider_id already locates the credential.+ assert tool.credential_ref is None+ assert tool.credential_type == "api-key"++[email protected]("provider_type", ["plugin", "builtin"])+def test_tool_scoped_provider_still_requires_credential_id(provider_type: str):+ """Tool-level credential providers (plugin / builtin) select a specific+ stored secret, so an authorized tool without a ``credential_ref.id`` is+ still rejected at the config boundary."""+ with pytest.raises(ValueError, match="credential_ref.id is required"):+ AgentSoulToolsConfig.model_validate(+ {+ "dify_tools": [+ {+ "provider_id": "langgenius/search/search",+ "provider_type": provider_type,+ "tool_name": "search",+ "credential_type": "api-key",+ }+ ]+ }+ )++# ── provider-level entries (tool_name omitted = all tools of the provider) ───