Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

ci: enable Ruff B903 (#44117)

Asuka Minatob953e69a0eb3
diff --git a/api/.ruff.toml b/api/.ruff.toml
index 1bd4cf4bfd4..2f91e4dded1 100644
--- a/api/.ruff.toml
+++ b/api/.ruff.toml
@@ -61,7 +61,6 @@ ignore = [
"E402", # module-import-not-at-top-of-file
"F841", # unused-variable
"B901", # allow return in yield
- "B903", # class-as-data-structure
"B904", # raise-without-from-inside-except
"N815", # mixed-case-variable-in-class-scope
"PT011", # pytest-raises-too-broad
diff --git a/api/core/app/apps/workflow_app_runner.py b/api/core/app/apps/workflow_app_runner.py
index e4759d28ec2..6d10ab721f0 100644
--- a/api/core/app/apps/workflow_app_runner.py
+++ b/api/core/app/apps/workflow_app_runner.py
@@ -158,7 +158,7 @@ class _WorkflowGraphConfig(BaseModel):
return self.model_dump(mode="python", exclude_unset=True)
-class WorkflowBasedAppRunner:
+class WorkflowBasedAppRunner: # noqa: B903 # Runtime owner; constructor names differ from private state.
def __init__(
self,
*,
diff --git a/api/tests/unit_tests/controllers/service_api/end_user/test_end_user.py b/api/tests/unit_tests/controllers/service_api/end_user/test_end_user.py
index d52b5613b38..14ba3947ef7 100644
--- a/api/tests/unit_tests/controllers/service_api/end_user/test_end_user.py
+++ b/api/tests/unit_tests/controllers/service_api/end_user/test_end_user.py
@@ -1,3 +1,4 @@
+from dataclasses import dataclass
from datetime import UTC, datetime
from inspect import unwrap
from uuid import UUID, uuid4
@@ -37,9 +38,9 @@ class ApplicationServicesStub:
self.app_scoped_end_users = AppScopedEndUserServicesStub(end_user_queries)
+@dataclass(eq=False, repr=False)
class AppScopedEndUserServicesStub:
- def __init__(self, queries: EndUserQueryServiceStub) -> None:
- self.queries = queries
+ queries: EndUserQueryServiceStub
class TestEndUserApi:
diff --git a/api/tests/unit_tests/controllers/service_api/test_wraps.py b/api/tests/unit_tests/controllers/service_api/test_wraps.py
index bcf8131240a..519ac21510a 100644
--- a/api/tests/unit_tests/controllers/service_api/test_wraps.py
+++ b/api/tests/unit_tests/controllers/service_api/test_wraps.py
@@ -3,6 +3,7 @@ Unit tests for Service API wraps (authentication decorators)
"""
import uuid
+from dataclasses import dataclass
from types import SimpleNamespace
from unittest.mock import Mock, patch
@@ -50,9 +51,9 @@ class _RecordingEndUserCommands:
return self._result
+@dataclass(eq=False, repr=False)
class _AppScopedEndUserServicesStub:
- def __init__(self, commands: _RecordingEndUserCommands) -> None:
- self.commands = commands
+ commands: _RecordingEndUserCommands
class _ApplicationServicesStub:
diff --git a/api/tests/unit_tests/controllers/trigger/test_webhook.py b/api/tests/unit_tests/controllers/trigger/test_webhook.py
index ac1cfaf1ebb..6c2cca8a8be 100644
--- a/api/tests/unit_tests/controllers/trigger/test_webhook.py
+++ b/api/tests/unit_tests/controllers/trigger/test_webhook.py
@@ -1,3 +1,4 @@
+from dataclasses import dataclass
from unittest.mock import patch
import pytest
@@ -16,9 +17,9 @@ class _RequestStub:
args = {"a": "b"}
+@dataclass(eq=False, repr=False)
class _AppScopedEndUserServicesStub:
- def __init__(self, commands: object) -> None:
- self.commands = commands
+ commands: object
class _ApplicationServicesStub:
diff --git a/api/tests/unit_tests/core/agent/test_fc_agent_runner.py b/api/tests/unit_tests/core/agent/test_fc_agent_runner.py
index c886bf084f9..6db592f26f9 100644
--- a/api/tests/unit_tests/core/agent/test_fc_agent_runner.py
+++ b/api/tests/unit_tests/core/agent/test_fc_agent_runner.py
@@ -1,5 +1,6 @@
import json
from collections.abc import Iterator
+from dataclasses import dataclass
from datetime import UTC, datetime
from decimal import Decimal
from typing import Any
@@ -87,10 +88,10 @@ class DummyMessage:
self.tool_calls: list[Any] = tool_calls or []
+@dataclass(eq=False, repr=False)
class DummyDelta:
- def __init__(self, message: DummyMessage | None = None, usage: LLMUsage | None = None):
- self.message: DummyMessage | None = message
- self.usage: LLMUsage | None = usage
+ message: DummyMessage | None = None
+ usage: LLMUsage | None = None
class DummyChunk:
diff --git a/api/tests/unit_tests/core/app/apps/test_base_app_runner.py b/api/tests/unit_tests/core/app/apps/test_base_app_runner.py
index b069d10352a..b6d387338da 100644
--- a/api/tests/unit_tests/core/app/apps/test_base_app_runner.py
+++ b/api/tests/unit_tests/core/app/apps/test_base_app_runner.py
@@ -1,6 +1,7 @@
from __future__ import annotations
import logging
+from dataclasses import dataclass
import pytest
from sqlalchemy import event, func, select
@@ -39,10 +40,10 @@ from graphon.model_runtime.errors.invoke import InvokeBadRequestError
from models.model import App, AppMode, Message, MessageFile
+@dataclass(eq=False, repr=False)
class _DummyParameterRule:
- def __init__(self, name: str, use_template: str | None = None) -> None:
- self.name = name
- self.use_template = use_template
+ name: str
+ use_template: str | None = None
class _TokenCountingModel:
diff --git a/api/tests/unit_tests/core/app/apps/test_message_based_app_generator.py b/api/tests/unit_tests/core/app/apps/test_message_based_app_generator.py
index fdd7b53c50a..c130b350b04 100644
--- a/api/tests/unit_tests/core/app/apps/test_message_based_app_generator.py
+++ b/api/tests/unit_tests/core/app/apps/test_message_based_app_generator.py
@@ -1,5 +1,6 @@
from __future__ import annotations
+from dataclasses import dataclass
from types import SimpleNamespace
import pytest
@@ -21,10 +22,10 @@ from services.errors.app_model_config import AppModelConfigBrokenError
from tests.unit_tests.model_factories import make_account, make_app
+@dataclass(eq=False, repr=False)
class DummyModelConf:
- def __init__(self, provider: str = "mock-provider", model: str = "mock-model") -> None:
- self.provider = provider
- self.model = model
+ provider: str = "mock-provider"
+ model: str = "mock-model"
class DummyCompletionGenerateEntity:
diff --git a/api/tests/unit_tests/core/app/task_pipeline/test_easy_ui_based_generate_task_pipeline_core.py b/api/tests/unit_tests/core/app/task_pipeline/test_easy_ui_based_generate_task_pipeline_core.py
index cb783c03171..dc98873ab87 100644
--- a/api/tests/unit_tests/core/app/task_pipeline/test_easy_ui_based_generate_task_pipeline_core.py
+++ b/api/tests/unit_tests/core/app/task_pipeline/test_easy_ui_based_generate_task_pipeline_core.py
@@ -2,6 +2,7 @@ from __future__ import annotations
import json
from collections.abc import Generator, Sequence
+from dataclasses import dataclass
from datetime import UTC, datetime
from decimal import Decimal
from threading import Thread
@@ -72,19 +73,19 @@ class _UnknownQueueEvent:
pass
+@dataclass(eq=False, repr=False)
class _AnnotationReply:
- def __init__(self, content: str) -> None:
- self.content = content
+ content: str
+@dataclass(eq=False, repr=False)
class _ModelConfigMode:
- def __init__(self, mode: str) -> None:
- self.mode = mode
+ mode: str
+@dataclass(eq=False, repr=False)
class _ProviderModelBundle:
- def __init__(self, model_type_instance: object) -> None:
- self.model_type_instance = model_type_instance
+ model_type_instance: object
class _AudioPublisher:
diff --git a/api/tests/unit_tests/core/callback_handler/test_index_tool_callback_handler.py b/api/tests/unit_tests/core/callback_handler/test_index_tool_callback_handler.py
index 2808da27236..4c40841fd98 100644
--- a/api/tests/unit_tests/core/callback_handler/test_index_tool_callback_handler.py
+++ b/api/tests/unit_tests/core/callback_handler/test_index_tool_callback_handler.py
@@ -19,12 +19,10 @@ from models.dataset import Document as DatasetDocument
from models.enums import CreatorUserRole, DatasetQuerySource, DataSourceType, DocumentCreatedFrom
+@dataclass(eq=False, repr=False)
class _DatabaseBinding:
engine: Engine
- def __init__(self, engine: Engine) -> None:
- self.engine = engine
-
@dataclass(frozen=True)
class _CallerSessionBoundary:
diff --git a/api/tests/unit_tests/core/external_data_tool/api/test_api.py b/api/tests/unit_tests/core/external_data_tool/api/test_api.py
index 33a5c28b23d..fef3a462e37 100644
--- a/api/tests/unit_tests/core/external_data_tool/api/test_api.py
+++ b/api/tests/unit_tests/core/external_data_tool/api/test_api.py
@@ -1,3 +1,4 @@
+from dataclasses import dataclass
from unittest.mock import MagicMock, patch
import pytest
@@ -13,14 +14,12 @@ pytestmark = [
]
+@dataclass(eq=False, repr=False)
class _DatabaseBinding:
"""Expose the real SQLite session used by extension queries."""
session: Session
- def __init__(self, session: Session) -> None:
- self.session = session
-
@pytest.fixture(autouse=True)
def bind_sqlite_session(sqlite_session: Session, monkeypatch: pytest.MonkeyPatch) -> None:
diff --git a/api/tests/unit_tests/core/mcp/test_entities.py b/api/tests/unit_tests/core/mcp/test_entities.py
index e7354fff551..eabf8c23d2b 100644
--- a/api/tests/unit_tests/core/mcp/test_entities.py
+++ b/api/tests/unit_tests/core/mcp/test_entities.py
@@ -1,5 +1,6 @@
"""Unit tests for MCP entities module."""
+from dataclasses import dataclass
from queue import Queue
from core.mcp.entities import (
@@ -131,9 +132,9 @@ class TestRequestContext:
assert isinstance(context_dict.lifespan_context, dict)
# Create context with custom object lifespan context
+ @dataclass(eq=False, repr=False)
class CustomLifespan:
- def __init__(self, data: str) -> None:
- self.data = data
+ data: str
custom_lifespan = CustomLifespan("test-data")
context_custom = RequestContext[_ClientSideSession, CustomLifespan](
diff --git a/api/tests/unit_tests/core/plugin/test_backwards_invocation_app.py b/api/tests/unit_tests/core/plugin/test_backwards_invocation_app.py
index 3734cf1f30b..46894f1882d 100644
--- a/api/tests/unit_tests/core/plugin/test_backwards_invocation_app.py
+++ b/api/tests/unit_tests/core/plugin/test_backwards_invocation_app.py
@@ -1,4 +1,5 @@
import json
+from dataclasses import dataclass
from typing import cast
import pytest
@@ -21,9 +22,9 @@ class _Chunk(BaseModel):
value: int
+@dataclass(eq=False, repr=False)
class _DatabaseWithEngine:
- def __init__(self, engine: Engine) -> None:
- self.engine = engine
+ engine: Engine
class _EndUserProvisioner:
diff --git a/api/tests/unit_tests/core/rag/datasource/test_datasource_retrieval.py b/api/tests/unit_tests/core/rag/datasource/test_datasource_retrieval.py
index 4d81e4424ed..1d2af8097bc 100644
--- a/api/tests/unit_tests/core/rag/datasource/test_datasource_retrieval.py
+++ b/api/tests/unit_tests/core/rag/datasource/test_datasource_retrieval.py
@@ -1,3 +1,4 @@
+from dataclasses import dataclass
from datetime import UTC, datetime
from typing import Any
from unittest.mock import MagicMock, Mock, PropertyMock, call, patch
@@ -171,12 +172,12 @@ def _upload_file(
return upload
+@dataclass(eq=False, repr=False)
class _SimpleRetrievalChildChunk:
- def __init__(self, id: str, content: str, score: float, position: int) -> None:
- self.id = id
- self.content = content
- self.score = score
- self.position = position
+ id: str
+ content: str
+ score: float
+ position: int
class _SimpleRetrievalSegment:
diff --git a/api/tests/unit_tests/core/rag/extractor/test_pdf_extractor.py b/api/tests/unit_tests/core/rag/extractor/test_pdf_extractor.py
index b7d5588c90f..ec940456784 100644
--- a/api/tests/unit_tests/core/rag/extractor/test_pdf_extractor.py
+++ b/api/tests/unit_tests/core/rag/extractor/test_pdf_extractor.py
@@ -25,12 +25,10 @@ class _Storage:
self.saves.append((key, data))
+@dataclass(eq=False, repr=False)
class _DatabaseBinding:
session: Session
- def __init__(self, session: Session) -> None:
- self.session = session
-
@dataclass(frozen=True)
class _Dependencies:
diff --git a/api/tests/unit_tests/core/tools/test_tool_engine.py b/api/tests/unit_tests/core/tools/test_tool_engine.py
index cc41ddc0a6c..4384eedbfbb 100644
--- a/api/tests/unit_tests/core/tools/test_tool_engine.py
+++ b/api/tests/unit_tests/core/tools/test_tool_engine.py
@@ -1,6 +1,7 @@
from __future__ import annotations
from collections.abc import Generator
+from dataclasses import dataclass
from typing import Any
from unittest.mock import patch
from uuid import uuid4
@@ -34,12 +35,10 @@ from core.tools.tool_engine import ToolEngine
from models.model import AppMode, Message, MessageFile
+@dataclass(eq=False, repr=False)
class _DatabaseBinding:
engine: Engine
- def __init__(self, engine: Engine) -> None:
- self.engine = engine
-
def _message() -> Message:
message = Message(
diff --git a/api/tests/unit_tests/core/tools/test_tool_label_manager.py b/api/tests/unit_tests/core/tools/test_tool_label_manager.py
index 2ddde3216d9..9543f49b92f 100644
--- a/api/tests/unit_tests/core/tools/test_tool_label_manager.py
+++ b/api/tests/unit_tests/core/tools/test_tool_label_manager.py
@@ -1,5 +1,6 @@
from __future__ import annotations
+from dataclasses import dataclass
from typing import Any, override
from unittest.mock import PropertyMock, patch
@@ -16,14 +17,12 @@ from core.tools.workflow_as_tool.provider import WorkflowToolProviderController
from models.tools import ToolLabelBinding
+@dataclass(eq=False, repr=False)
class _DatabaseBinding:
"""Expose the SQLite engine to code that owns its session lifecycle."""
engine: Engine
- def __init__(self, engine: Engine) -> None:
- self.engine = engine
-
# Create a mock class for testing abstract/base classes
class _ConcreteBuiltinToolProviderController(BuiltinToolProviderController):
diff --git a/api/tests/unit_tests/core/tools/utils/test_misc_utils_extra.py b/api/tests/unit_tests/core/tools/utils/test_misc_utils_extra.py
index f19950b5c12..e8e6b6cc132 100644
--- a/api/tests/unit_tests/core/tools/utils/test_misc_utils_extra.py
+++ b/api/tests/unit_tests/core/tools/utils/test_misc_utils_extra.py
@@ -2,6 +2,7 @@ from __future__ import annotations
import uuid
from contextlib import nullcontext
+from dataclasses import dataclass
from datetime import datetime
from pathlib import Path
from unittest.mock import patch
@@ -91,9 +92,9 @@ class _FakeCurrentApp:
return _FakeFlaskApp()
+@dataclass(eq=False, repr=False)
class _DatabaseWithSession:
- def __init__(self, session: scoped_session[Session]) -> None:
- self.session = session
+ session: scoped_session[Session]
class _UnusedProviderManager(ProviderManager):
diff --git a/api/tests/unit_tests/factories/test_file_factory.py b/api/tests/unit_tests/factories/test_file_factory.py
index fc6c53df5a2..7efea00c0ba 100644
--- a/api/tests/unit_tests/factories/test_file_factory.py
+++ b/api/tests/unit_tests/factories/test_file_factory.py
@@ -1,4 +1,5 @@
import re
+from dataclasses import dataclass
from datetime import UTC, datetime
from unittest.mock import MagicMock
from uuid import uuid4
@@ -15,10 +16,10 @@ from models import UploadFile
from models.enums import CreatorUserRole
+@dataclass(eq=False, repr=False)
class _FakeResponse:
- def __init__(self, status_code: int, headers: dict[str, str]):
- self.status_code = status_code
- self.headers = headers
+ status_code: int
+ headers: dict[str, str]
def _mock_head(monkeypatch: pytest.MonkeyPatch, headers: dict[str, str], status_code: int = 200):
diff --git a/api/tests/unit_tests/libs/test_token.py b/api/tests/unit_tests/libs/test_token.py
index b8c737bc11a..e4ae2bf4128 100644
--- a/api/tests/unit_tests/libs/test_token.py
+++ b/api/tests/unit_tests/libs/test_token.py
@@ -1,3 +1,4 @@
+from dataclasses import dataclass
from typing import cast
from unittest.mock import MagicMock
@@ -11,18 +12,12 @@ from libs import token
from libs.token import extract_access_token, extract_webapp_access_token, set_csrf_token_to_cookie
+@dataclass(eq=False, repr=False)
class MockRequest:
- def __init__(
- self,
- headers: dict[str, str],
- cookies: dict[str, str],
- args: dict[str, str],
- path: str = "/console/api/test",
- ):
- self.headers: dict[str, str] = headers
- self.cookies: dict[str, str] = cookies
- self.args: dict[str, str] = args
- self.path = path
+ headers: dict[str, str]
+ cookies: dict[str, str]
+ args: dict[str, str]
+ path: str = "/console/api/test"
def test_extract_access_token():
diff --git a/api/tests/unit_tests/services/test_message_service.py b/api/tests/unit_tests/services/test_message_service.py
index 21b7093a6f7..3b4933d43ea 100644
--- a/api/tests/unit_tests/services/test_message_service.py
+++ b/api/tests/unit_tests/services/test_message_service.py
@@ -1,5 +1,6 @@
import json
from collections.abc import Iterator
+from dataclasses import dataclass
from datetime import datetime
from decimal import Decimal
from unittest.mock import MagicMock
@@ -65,16 +66,13 @@ pytestmark = [
]
+@dataclass(eq=False, repr=False)
class _DatabaseBinding:
"""Expose the SQLite engine and shared session through the production DB interface."""
engine: Engine
session: scoped_session[Session]
- def __init__(self, engine: Engine, session: scoped_session[Session]) -> None:
- self.engine = engine
- self.session = session
-
class MessageServiceTestDataFactory:
"""Create real service inputs and persistent message-domain rows."""