Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix: fix upload for plugin (#41133)

FFXNbec4ef6ac70f
diff --git a/api/controllers/files/upload.py b/api/controllers/files/upload.py
index aac1c3b20c8..1da0d720be3 100644
--- a/api/controllers/files/upload.py
+++ b/api/controllers/files/upload.py
@@ -8,7 +8,7 @@ from werkzeug.exceptions import Forbidden
import services
from core.db.session_factory import session_factory
-from core.tools.signature import verify_plugin_file_signature
+from core.tools.signature import sign_tool_file, verify_plugin_file_signature
from core.tools.tool_file_manager import ToolFileManager, resolve_extension
from core.workflow.file_reference import build_file_reference
from fields.file_fields import FileResponse
@@ -136,7 +136,7 @@ class PluginUploadFileApi(Resource):
)
extension = resolve_extension(filename=tool_file.name, mimetype=tool_file.mimetype)
- preview_url = ToolFileManager.sign_file(tool_file_id=tool_file.id, extension=extension)
+ preview_url = sign_tool_file(tool_file_id=tool_file.id, extension=extension, for_external=True)
# Create a dictionary with all the necessary attributes
result = FileResponse(
diff --git a/api/tests/unit_tests/controllers/files/test_upload.py b/api/tests/unit_tests/controllers/files/test_upload.py
index dec841e35fd..7deb85df876 100644
--- a/api/tests/unit_tests/controllers/files/test_upload.py
+++ b/api/tests/unit_tests/controllers/files/test_upload.py
@@ -88,10 +88,12 @@ def _tool_file(*, name: str = "test.txt", mimetype: str = "text/plain") -> ToolF
class TestPluginUploadFileApi:
@patch.object(module, "verify_plugin_file_signature", return_value=True)
@patch.object(module, "get_user", return_value=_end_user())
+ @patch.object(module, "sign_tool_file", return_value="signed-url")
@patch.object(module, "ToolFileManager")
def test_success_upload(
self,
mock_tool_file_manager,
+ mock_sign_tool_file,
mock_get_user,
mock_verify_signature,
):
@@ -115,8 +117,6 @@ class TestPluginUploadFileApi:
mimetype="application/octet-stream",
)
- mock_tool_file_manager.sign_file.return_value = "signed-url"
-
api = module.PluginUploadFileApi()
post_fn = unwrap(api.post)
@@ -131,7 +131,11 @@ class TestPluginUploadFileApi:
assert mock_verify_signature.call_args.kwargs["conversation_id"] == "conversation-1"
tool_file_manager_instance.create_file_by_raw.assert_called_once()
assert tool_file_manager_instance.create_file_by_raw.call_args.kwargs["conversation_id"] == "conversation-1"
- mock_tool_file_manager.sign_file.assert_called_once_with(tool_file_id="file-id", extension=".docx")
+ mock_sign_tool_file.assert_called_once_with(
+ tool_file_id="file-id",
+ extension=".docx",
+ for_external=True,
+ )
@patch.object(module, "get_user")
@patch.object(module, "ToolFileManager")