Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

chore(web): address Agent Configure WCAG issues (SNP-894) (#43172)

Joelc005932db9cf
diff --git a/oxlint-suppressions.json b/oxlint-suppressions.json
index 59cda43093f..0259cb04543 100644
--- a/oxlint-suppressions.json
+++ b/oxlint-suppressions.json
@@ -748,11 +748,6 @@
"count": 1
}
},
- "web/app/components/base/chat/chat/chat-input-area/index.tsx": {
- "dify/require-disable-directive-description": {
- "count": 1
- }
- },
"web/app/components/base/chat/chat/check-input-forms-hooks.ts": {
"typescript/no-explicit-any": {
"count": 1
@@ -4108,11 +4103,6 @@
"count": 1
}
},
- "web/features/agent-v2/agent-detail/configure/components/preview/chat-session.tsx": {
- "dify/require-disable-directive-description": {
- "count": 1
- }
- },
"web/features/agent-v2/agent-detail/configure/components/preview/working-directory-panel.tsx": {
"@tanstack/query/prefer-query-options": {
"count": 4
diff --git a/web/app/components/base/chat/chat/chat-input-area/__tests__/index.spec.tsx b/web/app/components/base/chat/chat/chat-input-area/__tests__/index.spec.tsx
index 1b645c65b63..821e87a95f0 100644
--- a/web/app/components/base/chat/chat/chat-input-area/__tests__/index.spec.tsx
+++ b/web/app/components/base/chat/chat/chat-input-area/__tests__/index.spec.tsx
@@ -262,6 +262,23 @@ describe('ChatInputArea', () => {
expect(screen.getByPlaceholderText('Ask the assistant')).toBeInTheDocument()
})
+ it('keeps a visible label for the input after typing', async () => {
+ const user = userEvent.setup()
+ render(
+ <ChatInputArea
+ visionConfig={mockVisionConfig}
+ customPlaceholder="Describe your agent"
+ inputLabel="Describe your agent"
+ />,
+ )
+
+ const input = screen.getByRole('textbox', { name: 'Describe your agent' })
+ await user.type(input, 'A research assistant')
+
+ expect(input).toHaveValue('A research assistant')
+ expect(screen.getByText('Describe your agent')).toBeVisible()
+ })
+
it('should fall back to the readonly placeholder when readonly has a custom placeholder', () => {
render(
<ChatInputArea
diff --git a/web/app/components/base/chat/chat/chat-input-area/index.tsx b/web/app/components/base/chat/chat/chat-input-area/index.tsx
index 120fc7ee846..bf0ffe689e2 100644
--- a/web/app/components/base/chat/chat/chat-input-area/index.tsx
+++ b/web/app/components/base/chat/chat/chat-input-area/index.tsx
@@ -32,6 +32,7 @@ type ChatInputAreaProps = {
readonly?: boolean
botName?: string
customPlaceholder?: string
+ inputLabel?: string
showFeatureBar?: boolean
showFileUpload?: boolean
featureBarReadonly?: boolean
@@ -64,6 +65,7 @@ const ChatInputArea = ({
readonly,
botName,
customPlaceholder,
+ inputLabel,
showFeatureBar,
showFileUpload,
featureBarReadonly = readonly,
@@ -87,6 +89,7 @@ const ChatInputArea = ({
sendOnEnter = true,
}: ChatInputAreaProps) => {
const footerNoticeLabelId = useId()
+ const textareaId = useId()
const { t } = useTranslation(['appDebug', 'common'])
const {
@@ -311,15 +314,35 @@ const ChatInputArea = ({
<FileListInChatInput fileConfig={visionConfig!} />
</div>
<div className="relative max-h-39.5 overflow-x-hidden overflow-y-auto px-2.25">
- <div ref={wrapperRef} className="flex items-center justify-between">
- <div className="relative flex w-full grow items-center">
+ <div
+ ref={wrapperRef}
+ className={cn(
+ 'flex items-center justify-between',
+ inputLabel && 'max-sm:flex-col max-sm:items-stretch',
+ )}
+ >
+ <div
+ className={cn(
+ 'relative flex w-full grow items-center',
+ inputLabel && 'flex-col items-stretch',
+ )}
+ >
<div
ref={textValueRef}
className="pointer-events-none invisible absolute size-auto p-1 body-lg-regular leading-6 whitespace-pre"
>
{query}
</div>
+ {inputLabel && (
+ <label
+ htmlFor={textareaId}
+ className="px-1 py-1 system-xs-medium text-text-secondary"
+ >
+ {inputLabel}
+ </label>
+ )}
<Textarea
+ id={textareaId}
ref={(ref) => {
textareaRef.current = ref ?? undefined
}}
@@ -337,8 +360,7 @@ const ChatInputArea = ({
) || '',
)
}
- // Existing chat behavior focuses the composer as soon as it opens.
- // oxlint-disable-next-line jsx-a11y/no-autofocus
+ // oxlint-disable-next-line jsx-a11y/no-autofocus -- Existing chat behavior focuses the composer as soon as it opens.
autoFocus={autoFocus}
minRows={1}
value={query}
@@ -354,7 +376,12 @@ const ChatInputArea = ({
readOnly={readonly}
/>
</div>
- {!isMultipleLine && operation}
+ {!isMultipleLine &&
+ (inputLabel ? (
+ <div className="max-sm:flex max-sm:justify-end">{operation}</div>
+ ) : (
+ operation
+ ))}
</div>
</div>
{showVoiceInput && speechToTextTarget && (
diff --git a/web/app/components/detail-sidebar/index.tsx b/web/app/components/detail-sidebar/index.tsx
index 77bd9bc200d..1e82b347974 100644
--- a/web/app/components/detail-sidebar/index.tsx
+++ b/web/app/components/detail-sidebar/index.tsx
@@ -64,6 +64,7 @@ export function DetailSidebarFrame({
? 'preview'
: 'collapsed'
const visibleExpanded = sidebarView !== 'collapsed'
+ const overlayExpanded = sidebarView === 'preview' || (compact && expanded)
const showEnvTag = currentEnv === 'TESTING' || currentEnv === 'DEVELOPMENT'
function handleToggleDetailNavigation() {
@@ -131,7 +132,7 @@ export function DetailSidebarFrame({
<div
className={cn(
'relative flex h-full w-16 min-w-0 shrink-0 bg-background-body p-1 transition-[width] motion-reduce:transition-none',
- 'data-[sidebar-view=expanded]:w-62',
+ !compact && 'data-[sidebar-view=expanded]:w-62',
className,
)}
data-sidebar-view={sidebarView}
@@ -142,11 +143,11 @@ export function DetailSidebarFrame({
className={cn(
'flex min-h-0 w-14 shrink-0 flex-col overflow-hidden rounded-lg bg-components-panel-bg',
'data-visible-expanded:z-40 data-visible-expanded:w-60',
- 'data-preview:absolute data-preview:inset-y-1 data-preview:left-1',
- 'data-preview:bg-components-panel-bg-blur data-preview:shadow-[0px_12px_16px_0px_var(--color-shadow-shadow-5),0px_4px_6px_0px_var(--color-shadow-shadow-1)] data-preview:backdrop-blur-[5px]',
+ 'data-overlay:absolute data-overlay:inset-y-1 data-overlay:left-1',
+ 'data-overlay:bg-components-panel-bg-blur data-overlay:shadow-[0px_12px_16px_0px_var(--color-shadow-shadow-5),0px_4px_6px_0px_var(--color-shadow-shadow-1)] data-overlay:backdrop-blur-[5px]',
)}
data-visible-expanded={visibleExpanded || undefined}
- data-preview={sidebarView === 'preview' || undefined}
+ data-overlay={overlayExpanded || undefined}
>
<div className="flex min-h-0 flex-1 flex-col" onMouseEnter={openHoverPreview}>
{renderTop({
diff --git a/web/features/agent-v2/agent-detail/configure/components/composer-session.tsx b/web/features/agent-v2/agent-detail/configure/components/composer-session.tsx
index a00d5ad3dbb..e046bbb4370 100644
--- a/web/features/agent-v2/agent-detail/configure/components/composer-session.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/composer-session.tsx
@@ -473,6 +473,7 @@ function AgentConfigurePageComposerContent({
aria-busy={agentQuery.isFetching || isEnteringBuildMode}
leftPanel={
<AgentOrchestratePanel
+ className="max-xl:h-100 max-xl:w-full max-xl:max-w-none max-xl:min-w-0 max-xl:flex-none"
agentId={agentId}
agentSoulConfig={buildDraft.agentSoulConfig}
agentName={agentQuery.data?.name}
diff --git a/web/features/agent-v2/agent-detail/configure/components/orchestrate/files/tree.tsx b/web/features/agent-v2/agent-detail/configure/components/orchestrate/files/tree.tsx
index 3012c30325a..f5250559e27 100644
--- a/web/features/agent-v2/agent-detail/configure/components/orchestrate/files/tree.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/orchestrate/files/tree.tsx
@@ -13,8 +13,10 @@ import {
FileTreeLabel,
FileTreeList,
} from '@langgenius/dify-ui/file-tree'
+import { IconButton } from '@langgenius/dify-ui/icon-button'
import { ScrollArea, ScrollAreaContent, ScrollAreaViewport } from '@langgenius/dify-ui/scroll-area'
import { Fragment } from 'react'
+import { useTranslation } from 'react-i18next'
type AgentFileTreeFolderOpenStrategy = (context: { file: AgentFileNode; depth: number }) => boolean
@@ -43,7 +45,7 @@ function AgentFileTreeRows({
folderOpenStrategy,
folderOpenState,
onFolderOpenChange,
- onFolderDoubleClick,
+ onFolderEnter,
onFolderOpen,
renderFile,
renderFolderSuffix,
@@ -55,12 +57,14 @@ function AgentFileTreeRows({
folderOpenStrategy: AgentFileTreeFolderOpenStrategy
folderOpenState?: AgentFileTreeFolderOpenState
onFolderOpenChange?: (context: { file: AgentFileNode; depth: number; open: boolean }) => void
- onFolderDoubleClick?: (context: { file: AgentFileNode; depth: number }) => void
+ onFolderEnter?: (context: { file: AgentFileNode; depth: number }) => void
onFolderOpen?: (file: AgentFileNode) => void
renderFile: AgentFileTreeRenderFile
renderFolderSuffix?: AgentFileTreeRenderFolderSuffix
renderFolderPanel?: AgentFileTreeRenderFolderPanel
}) {
+ const { t } = useTranslation(['common'])
+
return files.map((file) => {
const children = (
<>
@@ -79,16 +83,29 @@ function AgentFileTreeRows({
open={folderOpenState?.({ file, depth })}
onOpenChange={(open) => onFolderOpenChange?.({ file, depth, open })}
>
- <FileTreeFolderTrigger
- onClick={() => onFolderOpen?.(file)}
- onDoubleClick={() => onFolderDoubleClick?.({ file, depth })}
- >
- <FileTreeIcon type="folder" />
- <FileTreeLabel className="max-w-full" title={file.name}>
- {file.name}
- </FileTreeLabel>
- {renderFolderSuffix?.({ depth, file })}
- </FileTreeFolderTrigger>
+ <div className="flex min-w-0 items-center gap-0.5">
+ <FileTreeFolderTrigger
+ className="min-w-0 flex-1"
+ onClick={() => onFolderOpen?.(file)}
+ onDoubleClick={() => onFolderEnter?.({ file, depth })}
+ >
+ <FileTreeIcon type="folder" />
+ <FileTreeLabel className="max-w-full" title={file.name}>
+ {file.name}
+ </FileTreeLabel>
+ {renderFolderSuffix?.({ depth, file })}
+ </FileTreeFolderTrigger>
+ {onFolderEnter && (
+ <IconButton
+ aria-label={`${t(($) => $['operation.view'])} ${file.name}`}
+ className="shrink-0"
+ size="sm"
+ onClick={() => onFolderEnter({ file, depth })}
+ >
+ <span aria-hidden className="i-ri-arrow-right-s-line size-4" />
+ </IconButton>
+ )}
+ </div>
<FileTreeFolderPanel>
{renderFolderPanel?.({ depth, file })}
<AgentFileTreeRows
@@ -98,7 +115,7 @@ function AgentFileTreeRows({
folderOpenStrategy={folderOpenStrategy}
folderOpenState={folderOpenState}
onFolderOpenChange={onFolderOpenChange}
- onFolderDoubleClick={onFolderDoubleClick}
+ onFolderEnter={onFolderEnter}
onFolderOpen={onFolderOpen}
renderFile={renderFile}
renderFolderSuffix={renderFolderSuffix}
@@ -142,7 +159,7 @@ export function AgentFileTree({
folderOpenStrategy = firstLevelFolderOpenStrategy,
folderOpenState,
onFolderOpenChange,
- onFolderDoubleClick,
+ onFolderEnter,
onFolderOpen,
renderFile = defaultRenderFile,
renderFolderSuffix,
@@ -161,7 +178,7 @@ export function AgentFileTree({
folderOpenStrategy?: AgentFileTreeFolderOpenStrategy
folderOpenState?: AgentFileTreeFolderOpenState
onFolderOpenChange?: (context: { file: AgentFileNode; depth: number; open: boolean }) => void
- onFolderDoubleClick?: (context: { file: AgentFileNode; depth: number }) => void
+ onFolderEnter?: (context: { file: AgentFileNode; depth: number }) => void
onFolderOpen?: (file: AgentFileNode) => void
renderFile?: AgentFileTreeRenderFile
renderFolderSuffix?: AgentFileTreeRenderFolderSuffix
@@ -189,7 +206,7 @@ export function AgentFileTree({
folderOpenStrategy={folderOpenStrategy}
folderOpenState={folderOpenState}
onFolderOpenChange={onFolderOpenChange}
- onFolderDoubleClick={onFolderDoubleClick}
+ onFolderEnter={onFolderEnter}
onFolderOpen={onFolderOpen}
renderFile={renderFile}
renderFolderSuffix={renderFolderSuffix}
diff --git a/web/features/agent-v2/agent-detail/configure/components/orchestrate/files/upload-dialog.tsx b/web/features/agent-v2/agent-detail/configure/components/orchestrate/files/upload-dialog.tsx
index 2d887df4c3d..7795dd7bdb1 100644
--- a/web/features/agent-v2/agent-detail/configure/components/orchestrate/files/upload-dialog.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/orchestrate/files/upload-dialog.tsx
@@ -175,7 +175,7 @@ function AgentFileUploader({ file, onChange }: { file?: File; onChange: (file?:
</div>
)}
{file && (
- <div className="group flex items-center rounded-lg border-[0.5px] border-components-panel-border bg-components-panel-on-panel-item-bg shadow-xs hover:bg-components-panel-on-panel-item-bg-hover">
+ <div className="flex items-center rounded-lg border-[0.5px] border-components-panel-border bg-components-panel-on-panel-item-bg shadow-xs hover:bg-components-panel-on-panel-item-bg-hover">
<div className="flex items-center justify-center p-3">
<FileTreeIcon type={getFileIconType(file.name, file.type)} />
</div>
@@ -189,7 +189,7 @@ function AgentFileUploader({ file, onChange }: { file?: File; onChange: (file?:
<span>{formatFileSize(file.size)}</span>
</div>
</div>
- <div className="hidden items-center pr-3 group-hover:flex">
+ <div className="flex items-center pr-3">
<IconButton
aria-label={tCommon(($) => $['operation.remove'])}
onClick={() => onChange(undefined)}
diff --git a/web/features/agent-v2/agent-detail/configure/components/orchestrate/publish-bar/index.tsx b/web/features/agent-v2/agent-detail/configure/components/orchestrate/publish-bar/index.tsx
index 27f7020b409..772036ffa33 100644
--- a/web/features/agent-v2/agent-detail/configure/components/orchestrate/publish-bar/index.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/orchestrate/publish-bar/index.tsx
@@ -390,11 +390,11 @@ function PublishBarActions({
const publishButtonLabelId = useId()
return (
- <div className="flex w-full min-w-0 items-center justify-between gap-2 p-2 group-data-open/publish-bar:justify-end group-data-open/publish-bar:px-4 group-data-open/publish-bar:pt-2 group-data-open/publish-bar:pb-4">
+ <div className="flex w-full min-w-0 items-center justify-between gap-2 p-2 group-data-open/publish-bar:justify-end group-data-open/publish-bar:px-4 group-data-open/publish-bar:pt-2 group-data-open/publish-bar:pb-4 max-sm:flex-wrap max-sm:justify-end">
<div
role="status"
aria-label={`${statusLabel}. ${metaLabel}`}
- className="flex min-w-0 flex-1 items-center gap-1 px-2 system-xs-regular text-text-tertiary group-data-open/publish-bar:hidden"
+ className="flex min-w-0 flex-1 items-center gap-1 px-2 system-xs-regular text-text-tertiary group-data-open/publish-bar:hidden max-sm:basis-full"
>
<span className="flex size-4 shrink-0 items-center justify-center">
<StatusDot size="small" status={dotStatus} />
diff --git a/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/detail-dialog.tsx b/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/detail-dialog.tsx
index af7a5b136da..765a804ce26 100644
--- a/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/detail-dialog.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/detail-dialog.tsx
@@ -58,7 +58,7 @@ export type AgentSkillDetail = {
isLoading?: boolean
}
onFolderOpenChange?: (context: { file: AgentSkillFileNode; depth: number; open: boolean }) => void
- onFolderDoubleClick?: (context: { file: AgentSkillFileNode; depth: number }) => void
+ onFolderEnter?: (context: { file: AgentSkillFileNode; depth: number }) => void
onDownloadFile?: (action: AgentSkillDetailDownloadAction) => void
onSelectFile?: (file: AgentSkillFileNode) => void
renderFolderSuffix?: (context: { file: AgentSkillFileNode; depth: number }) => ReactNode
@@ -77,7 +77,7 @@ function AgentSkillFileList({
files,
folderOpenState,
onFolderOpenChange,
- onFolderDoubleClick,
+ onFolderEnter,
onSelectFile,
renderFolderSuffix,
selectedFileId,
@@ -90,7 +90,7 @@ function AgentSkillFileList({
files: AgentSkillFileNode[]
folderOpenState?: AgentSkillDetail['folderOpenState']
onFolderOpenChange?: AgentSkillDetail['onFolderOpenChange']
- onFolderDoubleClick?: AgentSkillDetail['onFolderDoubleClick']
+ onFolderEnter?: AgentSkillDetail['onFolderEnter']
onSelectFile?: (file: AgentSkillFileNode) => void
renderFolderSuffix?: AgentSkillDetail['renderFolderSuffix']
selectedFileId?: string
@@ -126,7 +126,7 @@ function AgentSkillFileList({
folderOpenStrategy={keepSkillFoldersClosed}
folderOpenState={folderOpenState}
onFolderOpenChange={onFolderOpenChange}
- onFolderDoubleClick={onFolderDoubleClick}
+ onFolderEnter={onFolderEnter}
renderFile={
onSelectFile
? ({ depth, file, selected, children }) => (
@@ -375,7 +375,7 @@ export function AgentSkillDetailDialog({
files={detail.files}
folderOpenState={detail.folderOpenState}
onFolderOpenChange={detail.onFolderOpenChange}
- onFolderDoubleClick={detail.onFolderDoubleClick}
+ onFolderEnter={detail.onFolderEnter}
selectedFileId={detail.selectedFileId}
onSelectFile={detail.onSelectFile}
renderFolderSuffix={detail.renderFolderSuffix}
diff --git a/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/upload-dialog.tsx b/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/upload-dialog.tsx
index 4c9ee0da4ce..4ca8ae336ae 100644
--- a/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/upload-dialog.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/upload-dialog.tsx
@@ -179,7 +179,7 @@ function AgentSkillPackageUploader({
</div>
)}
{file && (
- <div className="group flex items-center rounded-lg border-[0.5px] border-components-panel-border bg-components-panel-on-panel-item-bg shadow-xs hover:bg-components-panel-on-panel-item-bg-hover">
+ <div className="flex items-center rounded-lg border-[0.5px] border-components-panel-border bg-components-panel-on-panel-item-bg shadow-xs hover:bg-components-panel-on-panel-item-bg-hover">
<div className="flex items-center justify-center p-3">
<span aria-hidden className="i-ri-file-zip-line size-6 shrink-0 text-text-tertiary" />
</div>
@@ -193,7 +193,7 @@ function AgentSkillPackageUploader({
<span>{formatFileSize(file.size)}</span>
</div>
</div>
- <div className="hidden items-center pr-3 group-hover:flex">
+ <div className="flex items-center pr-3">
<IconButton
aria-label={tCommon(($) => $['operation.remove'])}
onClick={() => onChange(undefined)}
diff --git a/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/versions-panel.spec.tsx b/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/versions-panel.spec.tsx
index b6264054b58..0daf898982d 100644
--- a/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/versions-panel.spec.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/versions-panel.spec.tsx
@@ -382,6 +382,33 @@ describe('AgentPreviewVersionsPanel', () => {
})
describe('Version filter', () => {
+ it('exposes which filter option is selected', async () => {
+ const user = userEvent.setup()
+ render(
+ <AgentPreviewVersionsPanel
+ agentId="agent-1"
+ activeVersionId="version-2"
+ onSelectVersion={vi.fn()}
+ onClose={vi.fn()}
+ />,
+ { accountProfile: { id: 'user-1', name: 'Alice', email: '[email protected]' } },
+ )
+
+ await user.click(screen.getByRole('button', { name: /filter/i }))
+ expect(screen.getByRole('button', { name: /all/i })).toHaveAttribute('aria-pressed', 'true')
+ expect(screen.getByRole('button', { name: /onlyYours/i })).toHaveAttribute(
+ 'aria-pressed',
+ 'false',
+ )
+
+ await user.click(screen.getByRole('button', { name: /onlyYours/i }))
+ expect(screen.getByRole('button', { name: /all/i })).toHaveAttribute('aria-pressed', 'false')
+ expect(screen.getByRole('button', { name: /onlyYours/i })).toHaveAttribute(
+ 'aria-pressed',
+ 'true',
+ )
+ })
+
it('should show filter options when the filter trigger is clicked', () => {
render(
<AgentPreviewVersionsPanel
diff --git a/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/working-directory-panel.spec.tsx b/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/working-directory-panel.spec.tsx
index b3b2d0dc2a5..051ce45568d 100644
--- a/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/working-directory-panel.spec.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/preview/__tests__/working-directory-panel.spec.tsx
@@ -1,6 +1,6 @@
import type { AgentWorkingDirectorySource } from '../working-directory-panel'
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'
-import { render, screen, waitFor } from '@testing-library/react'
+import { render, screen, waitFor, within } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { beforeEach, describe, expect, it, vi } from 'vite-plus/test'
import { toast } from '@/app/notifications'
@@ -350,6 +350,46 @@ describe('AgentWorkingDirectoryPanel', () => {
)
})
+ it('lets keyboard users expand and enter a folder with separate controls', async () => {
+ const user = userEvent.setup()
+ mocks.sandboxFilesQueryOptions.mockImplementation(({ input }: QueryOptionsInput) => {
+ const path = input.query?.path ?? '~'
+ return {
+ queryKey: ['sandbox-files-by-folder', path],
+ queryFn: async () => ({
+ path,
+ entries:
+ path === '~'
+ ? [{ name: 'reports', type: 'dir' }]
+ : [{ name: 'summary.txt', type: 'file' }],
+ }),
+ }
+ })
+ renderWorkingDirectoryPanel()
+
+ const folderTrigger = await screen.findByRole('button', { name: 'reports' })
+ expect(folderTrigger).toHaveAttribute('aria-expanded', 'false')
+
+ folderTrigger.focus()
+ await user.keyboard('{Enter}')
+ expect(folderTrigger).toHaveAttribute('aria-expanded', 'true')
+ expect(await screen.findByRole('button', { name: 'summary.txt' })).toBeInTheDocument()
+
+ const enterFolder = screen.getByRole('button', {
+ name: 'common.operation.view reports',
+ })
+ enterFolder.focus()
+ await user.keyboard('{Enter}')
+
+ const breadcrumb = screen.getByRole('navigation', {
+ name: 'agentV2.agentDetail.configure.workingDirectory.breadcrumbLabel',
+ })
+ expect(within(breadcrumb).getByRole('button', { name: 'reports' })).toHaveAttribute(
+ 'aria-current',
+ 'location',
+ )
+ })
+
it('should separate persistent and temporary files by their sandbox path roots', async () => {
const user = userEvent.setup()
mocks.sandboxFilesQueryOptions.mockImplementation(({ input }: QueryOptionsInput) => ({
diff --git a/web/features/agent-v2/agent-detail/configure/components/preview/chat-session.tsx b/web/features/agent-v2/agent-detail/configure/components/preview/chat-session.tsx
index 18ace33bbfe..265ae0241f6 100644
--- a/web/features/agent-v2/agent-detail/configure/components/preview/chat-session.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/preview/chat-session.tsx
@@ -154,9 +154,9 @@ export function AgentPreviewChatSession({
<ChatInputArea
botName={agentName || 'Agent'}
customPlaceholder={inputPlaceholder}
+ inputLabel={inputPlaceholder}
disabled={disabled || (isEmptyChat && isResponding)}
- // Build chat opts out so it does not steal focus from the configure editor.
- // oxlint-disable-next-line jsx-a11y/no-autofocus
+ // oxlint-disable-next-line jsx-a11y/no-autofocus -- Build chat opts out so it does not steal focus from the configure editor.
autoFocus={isEmptyChat ? inputAutoFocus : undefined}
sendButtonLoading={sendButtonLoading}
showFileUpload={false}
diff --git a/web/features/agent-v2/agent-detail/configure/components/preview/header.tsx b/web/features/agent-v2/agent-detail/configure/components/preview/header.tsx
index aa729171eb2..7608947ffcb 100644
--- a/web/features/agent-v2/agent-detail/configure/components/preview/header.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/preview/header.tsx
@@ -158,8 +158,8 @@ export function AgentPreviewHeader({
)
return (
- <div className="relative z-1 flex h-12 shrink-0 items-center justify-between gap-3 px-4 py-2">
- <div className="flex min-w-0 flex-1 items-center gap-2">
+ <div className="relative z-1 flex h-12 shrink-0 items-center justify-between gap-3 px-4 py-2 max-sm:h-auto max-sm:flex-wrap max-sm:gap-1 max-sm:px-2">
+ <div className="flex min-w-0 flex-1 items-center gap-2 max-sm:w-full max-sm:flex-none">
<SegmentedControl<AgentConfigureRightPanelMode>
value={mode}
onValueChange={(value) => onModeChange(value)}
@@ -211,8 +211,8 @@ export function AgentPreviewHeader({
</div>
</ModeInfoTip>
</div>
- <div className="flex shrink-0 items-center">
- <div className="flex items-center gap-2">
+ <div className="flex shrink-0 items-center max-sm:w-full max-sm:flex-wrap max-sm:justify-end">
+ <div className="flex items-center gap-2 max-sm:flex-wrap">
<Tooltip>
<TooltipTrigger
render={
@@ -244,7 +244,7 @@ export function AgentPreviewHeader({
</div>
{showChatFeaturesAction && (
<>
- <SegmentedControlDivider className="mx-3" />
+ <SegmentedControlDivider className="mx-3 max-sm:hidden" />
<button
type="button"
aria-expanded={isChatFeaturesOpen}
@@ -263,7 +263,7 @@ export function AgentPreviewHeader({
)}
{trailingAction != null && (
<>
- <SegmentedControlDivider className="mx-3" />
+ <SegmentedControlDivider className="mx-3 max-sm:hidden" />
{trailingAction}
</>
)}
diff --git a/web/features/agent-v2/agent-detail/configure/components/preview/versions-panel/filter.tsx b/web/features/agent-v2/agent-detail/configure/components/preview/versions-panel/filter.tsx
index 190ec18ece3..ee148b04841 100644
--- a/web/features/agent-v2/agent-detail/configure/components/preview/versions-panel/filter.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/preview/versions-panel/filter.tsx
@@ -18,6 +18,7 @@ function FilterItem({
return (
<button
type="button"
+ aria-pressed={selected}
onClick={onClick}
className="flex w-full cursor-pointer items-center justify-between gap-x-1 rounded-lg px-2 py-1.5 text-left hover:bg-state-base-hover focus-visible:ring-2 focus-visible:ring-state-accent-solid focus-visible:outline-hidden"
>
diff --git a/web/features/agent-v2/agent-detail/configure/components/preview/versions-panel/index.tsx b/web/features/agent-v2/agent-detail/configure/components/preview/versions-panel/index.tsx
index b62386860c7..533a692a30c 100644
--- a/web/features/agent-v2/agent-detail/configure/components/preview/versions-panel/index.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/preview/versions-panel/index.tsx
@@ -97,7 +97,7 @@ export function AgentPreviewVersionsPanel({
}
return (
- <aside className="flex h-full w-67 shrink-0 flex-col rounded-l-lg bg-components-panel-bg shadow-xl shadow-shadow-shadow-5">
+ <aside className="flex h-full w-67 shrink-0 flex-col rounded-l-lg bg-components-panel-bg shadow-xl shadow-shadow-shadow-5 max-xl:h-100 max-xl:w-full max-xl:min-w-0 max-xl:rounded-lg">
<div className="flex shrink-0 items-center gap-2 pt-3 pr-3 pl-4">
<h2 className="min-w-0 flex-1 truncate system-xl-semibold text-text-primary">
{tWorkflow(($) => $['versionHistory.title'], { ns: 'workflowHistory' })}
diff --git a/web/features/agent-v2/agent-detail/configure/components/preview/working-directory-panel.tsx b/web/features/agent-v2/agent-detail/configure/components/preview/working-directory-panel.tsx
index 61ed6041975..6d8df0af5ca 100644
--- a/web/features/agent-v2/agent-detail/configure/components/preview/working-directory-panel.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/preview/working-directory-panel.tsx
@@ -680,7 +680,7 @@ export function AgentWorkingDirectoryPanel({
: paths.filter((path) => path !== file.id),
)
},
- onFolderDoubleClick: ({ file }) => handleDirectoryPathChange(file.id),
+ onFolderEnter: ({ file }) => handleDirectoryPathChange(file.id),
onSelectFile: (selectedFile) => setSelectedFileId(selectedFile.id),
renderFolderSuffix: ({ file }) =>
loadingFolderPaths.has(file.id) ? (
diff --git a/web/features/agent-v2/agent-detail/configure/components/workspace.tsx b/web/features/agent-v2/agent-detail/configure/components/workspace.tsx
index 3aa1c5eb3e7..df59a7388ad 100644
--- a/web/features/agent-v2/agent-detail/configure/components/workspace.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/workspace.tsx
@@ -22,12 +22,12 @@ export function AgentConfigureWorkspace({
<section
aria-busy={ariaBusy}
className={cn(
- 'flex h-full min-w-0 flex-1 gap-1 overflow-hidden bg-background-body p-1',
+ 'flex h-full min-w-0 flex-1 gap-1 overflow-hidden bg-background-body p-1 max-xl:flex-col max-xl:overflow-y-auto',
className,
)}
>
{leftPanel}
- <div className="flex min-w-105 flex-1 gap-1 overflow-hidden">
+ <div className="flex min-w-105 flex-1 gap-1 overflow-hidden max-xl:w-full max-xl:min-w-0 max-xl:flex-none max-xl:flex-col max-xl:overflow-visible">
{rightPanel}
{sidePanels}
</div>
@@ -47,7 +47,7 @@ export function AgentConfigurePreviewSurface({
header,
}: AgentConfigurePreviewSurfaceProps) {
return (
- <div className="relative isolate flex min-w-105 flex-1 flex-col overflow-hidden rounded-lg border-[0.5px] border-components-panel-border bg-linear-to-b from-background-gradient-bg-fill-chat-bg-1 to-background-gradient-bg-fill-chat-bg-2 shadow-xl shadow-shadow-shadow-5">
+ <div className="relative isolate flex min-w-105 flex-1 flex-col overflow-hidden rounded-lg border-[0.5px] border-components-panel-border bg-linear-to-b from-background-gradient-bg-fill-chat-bg-1 to-background-gradient-bg-fill-chat-bg-2 shadow-xl shadow-shadow-shadow-5 max-xl:h-100 max-xl:w-full max-xl:min-w-0 max-xl:flex-none">
{background}
{header}
<div className="relative z-1 min-h-0 flex-1">{chat}</div>
diff --git a/web/features/agent-v2/agent-detail/detail-sidebar.tsx b/web/features/agent-v2/agent-detail/detail-sidebar.tsx
index e8503441223..2c172ea2b34 100644
--- a/web/features/agent-v2/agent-detail/detail-sidebar.tsx
+++ b/web/features/agent-v2/agent-detail/detail-sidebar.tsx
@@ -1,11 +1,15 @@
'use client'
import { DetailSidebarFrame } from '@/app/components/detail-sidebar'
+import useBreakpoints, { MediaType } from '@/hooks/use-breakpoints'
import { AgentDetailSection, AgentDetailTop } from './navigation'
export function AgentDetailSidebar() {
+ const media = useBreakpoints()
+
return (
<DetailSidebarFrame
+ compact={media !== MediaType.pc}
renderTop={({ expand, onToggle }) => <AgentDetailTop expand={expand} onToggle={onToggle} />}
renderSection={({ expand }) => <AgentDetailSection expand={expand} />}
/>