Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(web): name endpoint card actions (#40260)

yyhc79b9821fa61
diff --git a/web/app/components/plugins/plugin-detail-panel/__tests__/endpoint-card.spec.tsx b/web/app/components/plugins/plugin-detail-panel/__tests__/endpoint-card.spec.tsx
index d28ed387e13..6e4c5b3c1e4 100644
--- a/web/app/components/plugins/plugin-detail-panel/__tests__/endpoint-card.spec.tsx
+++ b/web/app/components/plugins/plugin-detail-panel/__tests__/endpoint-card.spec.tsx
@@ -1,5 +1,6 @@
import type { EndpointListItem, PluginDetail } from '../../types'
import { act, fireEvent, render, screen, waitFor } from '@testing-library/react'
+import userEvent from '@testing-library/user-event'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import EndpointCard from '../endpoint-card'
@@ -10,6 +11,10 @@ const mockDeleteEndpoint = vi.fn()
const mockUpdateEndpoint = vi.fn()
const mockToastNotify = vi.fn()
+const getEditButton = () => screen.getByRole('button', { name: 'common.operation.edit' })
+const getDeleteButton = () => screen.getByRole('button', { name: 'common.operation.delete' })
+const getCopyButton = () => screen.getByRole('button', { name: 'common.operation.copy' })
+
vi.mock('@langgenius/dify-ui/toast', () => ({
toast: Object.assign(
(message: string, options?: { type?: string }) =>
@@ -212,6 +217,26 @@ describe('EndpointCard', () => {
})
describe('User Interactions', () => {
+ it('should reach endpoint actions through the tab order', async () => {
+ const user = userEvent.setup()
+ render(
+ <EndpointCard
+ pluginDetail={mockPluginDetail}
+ data={mockEndpointData}
+ handleChange={mockHandleChange}
+ />,
+ )
+
+ await user.tab()
+ expect(getEditButton()).toHaveFocus()
+
+ await user.tab()
+ expect(getDeleteButton()).toHaveFocus()
+
+ await user.keyboard('{Enter}')
+ expect(screen.getByText('plugin.detailPanel.endpointDeleteTip')).toBeInTheDocument()
+ })
+
it('should show disable confirm when switching off', () => {
render(
<EndpointCard
@@ -251,8 +276,7 @@ describe('EndpointCard', () => {
/>,
)
- const allButtons = screen.getAllByRole('button')
- fireEvent.click(allButtons[1]!)
+ fireEvent.click(getDeleteButton())
expect(screen.getByText('plugin.detailPanel.endpointDeleteTip'))!.toBeInTheDocument()
})
@@ -266,8 +290,7 @@ describe('EndpointCard', () => {
/>,
)
- const allButtons = screen.getAllByRole('button')
- fireEvent.click(allButtons[1]!)
+ fireEvent.click(getDeleteButton())
fireEvent.click(screen.getByRole('button', { name: 'common.operation.confirm' }))
expect(mockDeleteEndpoint).toHaveBeenCalledWith('ep-1')
@@ -282,8 +305,7 @@ describe('EndpointCard', () => {
/>,
)
- const allButtons = screen.getAllByRole('button')
- fireEvent.click(allButtons[0]!)
+ fireEvent.click(getEditButton())
expect(screen.getByTestId('endpoint-modal'))!.toBeInTheDocument()
})
@@ -297,8 +319,7 @@ describe('EndpointCard', () => {
/>,
)
- const allButtons = screen.getAllByRole('button')
- fireEvent.click(allButtons[0]!)
+ fireEvent.click(getEditButton())
fireEvent.click(screen.getByTestId('modal-save'))
expect(mockUpdateEndpoint).toHaveBeenCalled()
@@ -316,8 +337,7 @@ describe('EndpointCard', () => {
/>,
)
- const allButtons = screen.getAllByRole('button')
- fireEvent.click(allButtons[2]!)
+ fireEvent.click(getCopyButton())
act(() => {
vi.advanceTimersByTime(2000)
@@ -386,8 +406,7 @@ describe('EndpointCard', () => {
/>,
)
- const allButtons = screen.getAllByRole('button')
- fireEvent.click(allButtons[1]!)
+ fireEvent.click(getDeleteButton())
expect(screen.getByText('plugin.detailPanel.endpointDeleteTip'))!.toBeInTheDocument()
fireEvent.click(screen.getByRole('button', { name: 'common.operation.cancel' }))
@@ -403,8 +422,7 @@ describe('EndpointCard', () => {
/>,
)
- const allButtons = screen.getAllByRole('button')
- fireEvent.click(allButtons[0]!)
+ fireEvent.click(getEditButton())
expect(screen.getByTestId('endpoint-modal'))!.toBeInTheDocument()
fireEvent.click(screen.getByTestId('modal-cancel'))
@@ -456,8 +474,7 @@ describe('EndpointCard', () => {
/>,
)
- const allButtons = screen.getAllByRole('button')
- fireEvent.click(allButtons[1]!)
+ fireEvent.click(getDeleteButton())
fireEvent.click(screen.getByRole('button', { name: 'common.operation.confirm' }))
expect(mockDeleteEndpoint).toHaveBeenCalled()
@@ -472,8 +489,7 @@ describe('EndpointCard', () => {
/>,
)
- const allButtons = screen.getAllByRole('button')
- fireEvent.click(allButtons[0]!)
+ fireEvent.click(getEditButton())
expect(screen.getByTestId('endpoint-modal'))!.toBeInTheDocument()
diff --git a/web/app/components/plugins/plugin-detail-panel/endpoint-card.tsx b/web/app/components/plugins/plugin-detail-panel/endpoint-card.tsx
index 7376cbe59c5..a7b08b8deec 100644
--- a/web/app/components/plugins/plugin-detail-panel/endpoint-card.tsx
+++ b/web/app/components/plugins/plugin-detail-panel/endpoint-card.tsx
@@ -154,11 +154,15 @@ const EndpointCard = ({ pluginDetail, data, handleChange }: Props) => {
<span aria-hidden className="i-ri-login-circle-line size-4" />
<div>{data.name}</div>
</div>
- <div className="hidden items-center group-hover:flex">
- <ActionButton onClick={showEndpointModalConfirm}>
+ <div className="flex w-0 items-center overflow-hidden opacity-0 group-hover:w-auto group-hover:overflow-visible group-hover:opacity-100 focus-within:w-auto focus-within:overflow-visible focus-within:opacity-100">
+ <ActionButton
+ aria-label={t(($) => $['operation.edit'], { ns: 'common' })}
+ onClick={showEndpointModalConfirm}
+ >
<span aria-hidden className="i-ri-edit-line size-4" />
</ActionButton>
<ActionButton
+ aria-label={t(($) => $['operation.delete'], { ns: 'common' })}
onClick={showDeleteConfirm}
className="text-text-tertiary hover:bg-state-destructive-hover hover:text-text-destructive"
>