Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(knowledge): only batch-enable segments whose indexing completed (#44017)

D41910c7e3f5a3241c
diff --git a/api/tasks/enable_segments_to_index_task.py b/api/tasks/enable_segments_to_index_task.py
index 044fe91b8f1..9b61f540a71 100644
--- a/api/tasks/enable_segments_to_index_task.py
+++ b/api/tasks/enable_segments_to_index_task.py
@@ -54,6 +54,13 @@ def enable_segments_to_index_task(segment_ids: list, dataset_id: str, document_i
DocumentSegment.id.in_(segment_ids),
DocumentSegment.dataset_id == dataset_id,
DocumentSegment.document_id == document_id,
+ # A segment that never finished indexing has no trustworthy index
+ # payload (its ``index_node_id`` may still be NULL), so it must not
+ # be pushed into the vector index. This mirrors the guard in
+ # ``enable_segment_to_index_task`` ("Segment is not completed,
+ # enable is not allowed") and in
+ # ``disable_segment_from_index_task``.
+ DocumentSegment.status == SegmentStatus.COMPLETED,
)
).all()
if not segments:
diff --git a/api/tests/unit_tests/tasks/test_enable_segment_index_tasks.py b/api/tests/unit_tests/tasks/test_enable_segment_index_tasks.py
index 260e8a15ba2..8653d532446 100644
--- a/api/tests/unit_tests/tasks/test_enable_segment_index_tasks.py
+++ b/api/tests/unit_tests/tasks/test_enable_segment_index_tasks.py
@@ -173,6 +173,32 @@ def test_enable_segments_commits_index_rows_after_loading(
assert enable_summaries.call_args.kwargs["segment_ids"] == [segment.id]
+def test_enable_segments_skips_segments_that_are_not_completed(
+ sqlite_session: Session,
+ indexed_segment: tuple[Dataset, Document, DocumentSegment],
+) -> None:
+ """A batch enable must not push a segment that never finished indexing."""
+ dataset, document, segment = indexed_segment
+ segment.status = SegmentStatus.ERROR
+ segment.enabled = False
+ sqlite_session.commit()
+
+ index_processor = MagicMock()
+
+ with (
+ patch("tasks.enable_segments_to_index_task.IndexProcessorFactory") as processor_factory,
+ patch(
+ "services.knowledge.summaries.adapters.SummaryIndexAdapter.enable_summaries_for_segments"
+ ) as enable_summaries,
+ patch("tasks.enable_segments_to_index_task.redis_client.delete"),
+ ):
+ processor_factory.return_value.init_index_processor.return_value = index_processor
+ enable_segments_to_index_task.run([segment.id], dataset.id, document.id)
+
+ index_processor.load.assert_not_called()
+ enable_summaries.assert_not_called()
+
+
def test_enable_segments_rolls_back_before_error_compensation(
sqlite_session: Session,
indexed_segment: tuple[Dataset, Document, DocumentSegment],