Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

refactor(web): use standard sizes for icon actions (#42684)

yyhcb044daf6010
diff --git a/web/app/components/app-sidebar/snippet-info/dropdown.tsx b/web/app/components/app-sidebar/snippet-info/dropdown.tsx
index 6ddc0d0081d..d582b801baf 100644
--- a/web/app/components/app-sidebar/snippet-info/dropdown.tsx
+++ b/web/app/components/app-sidebar/snippet-info/dropdown.tsx
@@ -131,7 +131,7 @@ const SnippetInfoDropdown = ({ snippet }: SnippetInfoDropdownProps) => {
render={
<IconButton
aria-label={t(($) => $['operation.more'], { ns: 'common' })}
- className="rounded-md data-popup-open:bg-state-base-hover data-popup-open:text-text-secondary"
+ className="data-popup-open:bg-state-base-hover data-popup-open:text-text-secondary"
>
<span aria-hidden className="i-ri-more-fill size-4" />
</IconButton>
diff --git a/web/app/components/app/configuration/config-var/config-select/index.tsx b/web/app/components/app/configuration/config-var/config-select/index.tsx
index ea5606005cb..64495b826e3 100644
--- a/web/app/components/app/configuration/config-var/config-select/index.tsx
+++ b/web/app/components/app/configuration/config-var/config-select/index.tsx
@@ -60,7 +60,7 @@ const ConfigSelect: FC<IConfigSelectProps> = ({ options, onChange, errorMessage,
>
<IconButton
{...getHandleProps(index)}
- className="handle size-6 shrink-0 cursor-grab aria-pressed:bg-state-accent-hover"
+ className="handle shrink-0 cursor-grab aria-pressed:bg-state-accent-hover"
>
<RiDraggable aria-hidden="true" className="size-4 text-text-quaternary" />
</IconButton>
diff --git a/web/app/components/app/configuration/config-var/var-item.tsx b/web/app/components/app/configuration/config-var/var-item.tsx
index 5f189876696..5387a7fdbf7 100644
--- a/web/app/components/app/configuration/config-var/var-item.tsx
+++ b/web/app/components/app/configuration/config-var/var-item.tsx
@@ -59,7 +59,7 @@ const VarItem: FC<ItemProps> = ({
<IconButton
{...dragHandleProps}
aria-label={dragHandleProps?.['aria-label'] ?? name}
- className="handle pointer-events-none absolute left-1.5 size-6 cursor-grab opacity-0 group-focus-within:pointer-events-auto group-focus-within:opacity-100 group-hover:pointer-events-auto group-hover:opacity-100 focus-visible:pointer-events-auto focus-visible:opacity-100 aria-pressed:bg-state-accent-hover"
+ className="handle pointer-events-none absolute left-1.5 cursor-grab opacity-0 group-focus-within:pointer-events-auto group-focus-within:opacity-100 group-hover:pointer-events-auto group-hover:opacity-100 focus-visible:pointer-events-auto focus-visible:opacity-100 aria-pressed:bg-state-accent-hover"
>
<RiDraggable aria-hidden="true" className="size-4 text-text-tertiary" />
</IconButton>
diff --git a/web/app/components/apps/creators-filter.tsx b/web/app/components/apps/creators-filter.tsx
index 34b3fe906b2..cd348aa4f93 100644
--- a/web/app/components/apps/creators-filter.tsx
+++ b/web/app/components/apps/creators-filter.tsx
@@ -160,7 +160,7 @@ const CreatorsFilter = ({ value, onChange }: CreatorsFilterProps) => {
<IconButton
size="sm"
aria-label={resetLabel}
- className="absolute top-1/2 right-1 size-5 -translate-y-1/2 text-text-tertiary peer-data-popup-open/creators-trigger:text-text-secondary"
+ className="absolute top-1/2 right-1 -translate-y-1/2 peer-data-popup-open/creators-trigger:text-text-secondary"
onClick={handleSelectionClear}
>
<span aria-hidden className="i-ri-close-circle-fill h-3.5 w-3.5" />
diff --git a/web/app/components/base/access-point/url.tsx b/web/app/components/base/access-point/url.tsx
index 837ac521699..24e102cedd0 100644
--- a/web/app/components/base/access-point/url.tsx
+++ b/web/app/components/base/access-point/url.tsx
@@ -119,7 +119,6 @@ export function AccessPointUrl({
) : (
<CopyFeedback
content={value}
- className="size-6"
copyLabel={copyLabel}
copiedLabel={copiedLabel}
onCopyError={onCopyError}
diff --git a/web/app/components/base/features/new-feature-panel/conversation-opener/modal.tsx b/web/app/components/base/features/new-feature-panel/conversation-opener/modal.tsx
index c2b0beccff6..4a6b2fdd24c 100644
--- a/web/app/components/base/features/new-feature-panel/conversation-opener/modal.tsx
+++ b/web/app/components/base/features/new-feature-panel/conversation-opener/modal.tsx
@@ -199,7 +199,7 @@ const OpeningSettingModal = ({
>
<IconButton
{...getHandleProps(index)}
- className="handle size-6 shrink-0 cursor-grab aria-pressed:bg-state-accent-hover"
+ className="handle shrink-0 cursor-grab aria-pressed:bg-state-accent-hover"
>
<span aria-hidden="true" className="i-ri-draggable size-4 text-text-quaternary" />
</IconButton>
diff --git a/web/app/components/base/form/components/base/__tests__/base-field.spec.tsx b/web/app/components/base/form/components/base/__tests__/base-field.spec.tsx
index d448a797b65..8163736c76a 100644
--- a/web/app/components/base/form/components/base/__tests__/base-field.spec.tsx
+++ b/web/app/components/base/form/components/base/__tests__/base-field.spec.tsx
@@ -7,6 +7,11 @@ import { FormItemValidateStatusEnum, FormTypeEnum } from '@/app/components/base/
import BaseField from '../base-field'
const mockDynamicOptions = vi.fn()
+const mockCopy = vi.fn()
+
+vi.mock('foxact/use-clipboard', () => ({
+ useClipboard: () => ({ copy: mockCopy, copied: false }),
+}))
vi.mock('@/hooks/use-i18n', () => ({
useRenderI18nObject: () => (content: Record<string, string>) =>
@@ -74,6 +79,30 @@ describe('BaseField', () => {
})
})
+ it.each([
+ { type: FormTypeEnum.textInput, value: 'server-value', copied: 'server-value' },
+ { type: FormTypeEnum.textNumber, value: 0, copied: '0' },
+ ])(
+ 'copies the $type field value through its keyboard-accessible action',
+ async ({ type, value, copied }) => {
+ const user = userEvent.setup()
+ renderBaseField({
+ formSchema: { type, name: 'value', label: 'Value', required: false, showCopy: true },
+ defaultValues: { value },
+ })
+
+ await user.click(screen.getByLabelText('Value'))
+ await user.tab()
+ const copyButton = screen.getByRole('button', { name: 'common.operation.copy' })
+ expect(copyButton).toHaveFocus()
+ await user.keyboard('{Enter}')
+
+ expect(mockCopy).toHaveBeenCalledWith(copied)
+ expect(copyButton).toHaveFocus()
+ expect(screen.getByLabelText('Value')).toHaveValue(String(value))
+ },
+ )
+
it.each([FormTypeEnum.textInput, FormTypeEnum.secretInput, FormTypeEnum.textNumber])(
'associates the visible label, description and required state for %s',
async (type) => {
diff --git a/web/app/components/base/form/components/base/base-field.tsx b/web/app/components/base/form/components/base/base-field.tsx
index 8de915f833d..66b86fc2488 100644
--- a/web/app/components/base/form/components/base/base-field.tsx
+++ b/web/app/components/base/form/components/base/base-field.tsx
@@ -337,11 +337,8 @@ const BaseField = ({
)}
>
<InputGroupInput {...textInputProps} />
- <InputGroupAddon align="inline-end" className="pe-0">
- <CopyFeedback
- content={stringValue ?? ''}
- className="size-7 hover:bg-transparent"
- />
+ <InputGroupAddon align="inline-end" className="pe-0.5">
+ <CopyFeedback content={stringValue ?? ''} className="hover:bg-transparent" />
</InputGroupAddon>
</InputGroup>
) : (
@@ -385,7 +382,7 @@ const BaseField = ({
{showCopy && (
<CopyFeedback
content={value == null ? '' : String(value)}
- className="size-7 shrink-0 hover:bg-transparent"
+ className="me-0.5 shrink-0 self-center hover:bg-transparent"
/>
)}
</NumberFieldGroup>
diff --git a/web/app/components/base/prompt-log-modal/card.tsx b/web/app/components/base/prompt-log-modal/card.tsx
index 4ee4984a1fb..0ac4e57d5a4 100644
--- a/web/app/components/base/prompt-log-modal/card.tsx
+++ b/web/app/components/base/prompt-log-modal/card.tsx
@@ -21,10 +21,7 @@ const Card: FC<CardProps> = ({ log }) => {
>
<div className="flex h-8 items-center justify-between">
<div className="font-semibold text-indigo-800">{item.role.toUpperCase()}</div>
- <CopyFeedback
- className="hidden size-6 group-hover/card:block"
- content={item.text}
- />
+ <CopyFeedback className="hidden group-hover/card:block" content={item.text} />
</div>
<div className="whitespace-pre-line text-text-secondary">{item.text}</div>
</div>
diff --git a/web/app/components/base/prompt-log-modal/index.tsx b/web/app/components/base/prompt-log-modal/index.tsx
index 9ec9ae954b3..1505911e159 100644
--- a/web/app/components/base/prompt-log-modal/index.tsx
+++ b/web/app/components/base/prompt-log-modal/index.tsx
@@ -43,7 +43,7 @@ const PromptLogModal: FC<PromptLogModalProps> = ({ currentLogItem, width, onCanc
<div className="flex items-center">
{currentLogItem.log?.length === 1 && (
<>
- <CopyFeedback className="size-6" content={currentLogItem.log[0]!.text} />
+ <CopyFeedback content={currentLogItem.log[0]!.text} />
<div className="mx-2.5 h-3.5 w-px bg-divider-regular" />
</>
)}
diff --git a/web/app/components/plugins/marketplace/detail-dialog/frame.tsx b/web/app/components/plugins/marketplace/detail-dialog/frame.tsx
index dd7a68f92da..afd671364eb 100644
--- a/web/app/components/plugins/marketplace/detail-dialog/frame.tsx
+++ b/web/app/components/plugins/marketplace/detail-dialog/frame.tsx
@@ -142,8 +142,8 @@ export default function MarketplaceDetailDialogFrame({
<IconButton
ref={closeButtonRef}
aria-label={t(($) => $['operation.close'], { ns: 'common' })}
- size="sm"
- className="absolute top-5 right-5 z-10 size-8 rounded-lg"
+ size="lg"
+ className="absolute top-5 right-5 z-10"
>
<span aria-hidden className="i-ri-close-line size-4" />
</IconButton>
diff --git a/web/app/components/plugins/readme-panel/dialog.tsx b/web/app/components/plugins/readme-panel/dialog.tsx
index 9f28fb46802..6f1ed770336 100644
--- a/web/app/components/plugins/readme-panel/dialog.tsx
+++ b/web/app/components/plugins/readme-panel/dialog.tsx
@@ -30,8 +30,8 @@ export function ReadmeDialog({ detail, open, onOpenChange, triggerId }: ReadmeDi
render={
<IconButton
aria-label={t(($) => $['operation.close'], { ns: 'common' })}
- size="sm"
- className="static size-8 rounded-lg"
+ size="lg"
+ className="static"
>
<span aria-hidden className="i-ri-close-line size-4" />
</IconButton>
diff --git a/web/app/components/rag-pipeline/components/panel/input-field/field-list/field-item.tsx b/web/app/components/rag-pipeline/components/panel/input-field/field-list/field-item.tsx
index d9589333bfd..77545f94299 100644
--- a/web/app/components/rag-pipeline/components/panel/input-field/field-list/field-item.tsx
+++ b/web/app/components/rag-pipeline/components/panel/input-field/field-list/field-item.tsx
@@ -78,7 +78,7 @@ const FieldItem = ({
{!readonly && dragHandleProps && (
<IconButton
{...dragHandleProps}
- className="handle pointer-events-none absolute -top-1 -left-1 size-6 cursor-grab opacity-0 group-focus-within:pointer-events-auto group-focus-within:opacity-100 group-hover:pointer-events-auto group-hover:opacity-100 focus-visible:pointer-events-auto focus-visible:opacity-100 aria-pressed:bg-state-accent-hover"
+ className="handle pointer-events-none absolute -top-1 -left-1 cursor-grab opacity-0 group-focus-within:pointer-events-auto group-focus-within:opacity-100 group-hover:pointer-events-auto group-hover:opacity-100 focus-visible:pointer-events-auto focus-visible:opacity-100 aria-pressed:bg-state-accent-hover"
>
<RiDraggable aria-hidden="true" className="size-4 text-text-quaternary" />
</IconButton>
diff --git a/web/app/components/workflow/nodes/_base/components/variable/var-list.tsx b/web/app/components/workflow/nodes/_base/components/variable/var-list.tsx
index 65d4feeb276..909ab31815c 100644
--- a/web/app/components/workflow/nodes/_base/components/variable/var-list.tsx
+++ b/web/app/components/workflow/nodes/_base/components/variable/var-list.tsx
@@ -177,7 +177,7 @@ const VarList: FC<Props> = ({
{canDrag && (
<IconButton
{...keyboardSort.getHandleProps(index)}
- className="handle pointer-events-none absolute top-1 -left-6 size-6 opacity-0 group-hover:pointer-events-auto group-hover:opacity-100 focus:pointer-events-auto focus:opacity-100 aria-pressed:pointer-events-auto aria-pressed:opacity-100"
+ className="handle pointer-events-none absolute top-1 -left-6 opacity-0 group-hover:pointer-events-auto group-hover:opacity-100 focus:pointer-events-auto focus:opacity-100 aria-pressed:pointer-events-auto aria-pressed:opacity-100"
>
<span aria-hidden="true" className="i-ri-draggable size-3" />
</IconButton>
diff --git a/web/app/components/workflow/nodes/if-else/components/condition-wrap.tsx b/web/app/components/workflow/nodes/if-else/components/condition-wrap.tsx
index a7c2350a60c..e14114b01ad 100644
--- a/web/app/components/workflow/nodes/if-else/components/condition-wrap.tsx
+++ b/web/app/components/workflow/nodes/if-else/components/condition-wrap.tsx
@@ -140,7 +140,7 @@ const ConditionWrap: FC<Props> = ({
{!readOnly && casesLength > 1 && (
<IconButton
{...keyboardSort.getHandleProps(index)}
- className="handle pointer-events-none absolute top-1 -left-2 z-10 size-6 opacity-0 group-hover:pointer-events-auto group-hover:opacity-100 focus:pointer-events-auto focus:opacity-100 aria-pressed:pointer-events-auto aria-pressed:opacity-100"
+ className="handle pointer-events-none absolute top-1 -left-2 z-10 opacity-0 group-hover:pointer-events-auto group-hover:opacity-100 focus:pointer-events-auto focus:opacity-100 aria-pressed:pointer-events-auto aria-pressed:opacity-100"
>
<span aria-hidden="true" className="i-ri-draggable size-3" />
</IconButton>
diff --git a/web/app/components/workflow/nodes/llm/components/config-prompt.tsx b/web/app/components/workflow/nodes/llm/components/config-prompt.tsx
index d9553a02528..2bd7eab6123 100644
--- a/web/app/components/workflow/nodes/llm/components/config-prompt.tsx
+++ b/web/app/components/workflow/nodes/llm/components/config-prompt.tsx
@@ -221,7 +221,7 @@ const ConfigPrompt: FC<Props> = ({
{canDrag && (
<IconButton
{...keyboardSort.getHandleProps(index)}
- className="handle pointer-events-none absolute top-1 -left-6 size-6 opacity-0 group-hover:pointer-events-auto group-hover:opacity-100 focus:pointer-events-auto focus:opacity-100 aria-pressed:pointer-events-auto aria-pressed:opacity-100"
+ className="handle pointer-events-none absolute top-1 -left-6 opacity-0 group-hover:pointer-events-auto group-hover:opacity-100 focus:pointer-events-auto focus:opacity-100 aria-pressed:pointer-events-auto aria-pressed:opacity-100"
>
<span
aria-hidden="true"
diff --git a/web/app/components/workflow/nodes/question-classifier/components/class-list.tsx b/web/app/components/workflow/nodes/question-classifier/components/class-list.tsx
index ffa6f81b9fc..4ebd995dc96 100644
--- a/web/app/components/workflow/nodes/question-classifier/components/class-list.tsx
+++ b/web/app/components/workflow/nodes/question-classifier/components/class-list.tsx
@@ -180,7 +180,7 @@ const ClassList: FC<Props> = ({
{canDrag && (
<IconButton
{...keyboardSort.getHandleProps(index)}
- className="handle pointer-events-none absolute top-1.5 left-0.5 z-10 size-6 opacity-0 group-hover:pointer-events-auto group-hover:opacity-100 focus:pointer-events-auto focus:opacity-100 aria-pressed:pointer-events-auto aria-pressed:opacity-100"
+ className="handle pointer-events-none absolute top-1.5 left-0.5 z-10 opacity-0 group-hover:pointer-events-auto group-hover:opacity-100 focus:pointer-events-auto focus:opacity-100 aria-pressed:pointer-events-auto aria-pressed:opacity-100"
>
<span aria-hidden="true" className="i-ri-draggable size-3" />
</IconButton>
diff --git a/web/app/components/workflow/nodes/start/components/var-list.tsx b/web/app/components/workflow/nodes/start/components/var-list.tsx
index de855b93a5f..246f4a8bf2c 100644
--- a/web/app/components/workflow/nodes/start/components/var-list.tsx
+++ b/web/app/components/workflow/nodes/start/components/var-list.tsx
@@ -127,7 +127,7 @@ const VarList: FC<Props> = ({ readonly, list, onChange }) => {
{canDrag && (
<IconButton
{...keyboardSort.getHandleProps(index)}
- className="handle pointer-events-none absolute top-1 left-1.5 size-6 opacity-0 group-hover:pointer-events-auto group-hover:opacity-100 focus:pointer-events-auto focus:opacity-100 aria-pressed:pointer-events-auto aria-pressed:opacity-100"
+ className="handle pointer-events-none absolute top-1 left-1.5 opacity-0 group-hover:pointer-events-auto group-hover:opacity-100 focus:pointer-events-auto focus:opacity-100 aria-pressed:pointer-events-auto aria-pressed:opacity-100"
>
<span aria-hidden="true" className="i-ri-draggable size-3" />
</IconButton>
diff --git a/web/features/agent-v2/agent-detail/configure/components/orchestrate/knowledge/dialog.tsx b/web/features/agent-v2/agent-detail/configure/components/orchestrate/knowledge/dialog.tsx
index c347587362a..44c0b135c32 100644
--- a/web/features/agent-v2/agent-detail/configure/components/orchestrate/knowledge/dialog.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/orchestrate/knowledge/dialog.tsx
@@ -458,8 +458,8 @@ function AgentKnowledgeRetrievalDialogContent({
render={
<IconButton
aria-label={t(($) => $['operation.close'], { ns: 'common' })}
- size="sm"
- className="static size-7 shrink-0 rounded-md"
+ size="lg"
+ className="-my-0.5 shrink-0"
>
<span aria-hidden className="i-ri-close-line size-4" />
</IconButton>
diff --git a/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/detail-dialog.tsx b/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/detail-dialog.tsx
index 2db44e9505f..41bc44eb3ed 100644
--- a/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/detail-dialog.tsx
+++ b/web/features/agent-v2/agent-detail/configure/components/orchestrate/skills/detail-dialog.tsx
@@ -392,14 +392,14 @@ export function AgentSkillDetailDialog({
</h2>
)}
</div>
- <div className="flex shrink-0 items-center gap-1">
+ <div className="-my-0.5 flex shrink-0 items-center gap-1">
{detail.onDownloadFile && previewTitle && (
<button
type="button"
aria-label={`${isHeaderDownloadLoading ? tCommon(($) => $['operation.downloading']) : tCommon(($) => $['operation.download'])} ${previewTitle}`}
onClick={() => detail.onDownloadFile?.('header')}
disabled={isHeaderDownloadLoading}
- className="flex size-7 shrink-0 items-center justify-center rounded-md text-text-tertiary outline-hidden hover:bg-state-base-hover hover:text-text-secondary focus-visible:bg-state-base-hover focus-visible:text-text-secondary focus-visible:ring-2 focus-visible:ring-state-accent-solid"
+ className="flex size-8 shrink-0 items-center justify-center rounded-lg text-text-tertiary outline-hidden hover:bg-state-base-hover hover:text-text-secondary focus-visible:bg-state-base-hover focus-visible:text-text-secondary focus-visible:ring-2 focus-visible:ring-state-accent-solid"
>
<span
aria-hidden
@@ -416,8 +416,8 @@ export function AgentSkillDetailDialog({
render={
<IconButton
aria-label={tCommon(($) => $['operation.close'])}
- size="sm"
- className="static size-7 shrink-0 rounded-md"
+ size="lg"
+ className="shrink-0"
>
<span aria-hidden className="i-ri-close-line size-4" />
</IconButton>