Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix(api): mark async workflow trigger log FAILED when dispatch raises (#42148) (#43009)
Taranum Wasud8ec14027ed8
diff --git a/api/services/async_workflow_service.py b/api/services/async_workflow_service.pyindex 48a113e8fcc..aaf01b8c239 100644--- a/api/services/async_workflow_service.py+++ b/api/services/async_workflow_service.py@@ -175,8 +175,22 @@ class AsyncWorkflowService:else: # SANDBOXtask = execute_workflow_sandbox.delay(task_data_dict)quota_charge.commit()- except Exception:+ except Exception as e:+ # Mark the trigger log as FAILED so it does not stay PENDING when the broker+ # or dispatcher refuses the task, then re-raise so the caller still surfaces+ # the error.+ trigger_log.status = WorkflowTriggerStatus.FAILED+ trigger_log.error = f"Failed to dispatch workflow task: {e}"+ trigger_log_repo.update(trigger_log)+ session.commit()quota_charge.refund()+ logger.exception(+ "Failed to dispatch workflow task for tenant %s, app %s, workflow %s, trigger log %s",+ trigger_data.tenant_id,+ trigger_data.app_id,+ workflow.id,+ trigger_log.id,+ )raise# 10. Update trigger log with task infodiff --git a/api/tests/unit_tests/services/test_async_workflow_service.py b/api/tests/unit_tests/services/test_async_workflow_service.pyindex 71332dd5473..510a3811524 100644--- a/api/tests/unit_tests/services/test_async_workflow_service.py+++ b/api/tests/unit_tests/services/test_async_workflow_service.py@@ -350,6 +350,54 @@ class TestAsyncWorkflowService:mocks["team_task"].delay.assert_not_called()mocks["sandbox_task"].delay.assert_not_called()+ def test_should_mark_log_failed_and_reraise_when_celery_dispatch_raises(+ self,+ async_workflow_trigger_mocks,+ caplog: pytest.LogCaptureFixture,+ sqlite_session: Session,+ ):+ """Test dispatch failure path marks trigger log FAILED, refunds quota, and re-raises."""+ # Arrange+ sqlite_session.add(AsyncWorkflowServiceTestDataFactory.create_app())+ sqlite_session.commit()+ trigger_data = AsyncWorkflowServiceTestDataFactory.create_trigger_data()+ workflow = AsyncWorkflowServiceTestDataFactory.create_workflow()++ mocks = async_workflow_trigger_mocks+ mocks["dispatcher"].get_queue_name.return_value = QueuePriority.SANDBOX+ mocks["get_workflow"].return_value = workflow++ quota_charge_mock = MagicMock()+ mocks["quota_service"].reserve.return_value = quota_charge_mock++ dispatch_error = RuntimeError("broker unavailable")+ mocks["sandbox_task"].delay.side_effect = dispatch_error+ caplog.set_level(logging.ERROR, logger=async_workflow_service_module.__name__)++ # Act / Assert+ with pytest.raises(RuntimeError) as exc_info:+ AsyncWorkflowService.trigger_workflow_async(+ session=sqlite_session,+ user=AsyncWorkflowServiceTestDataFactory.create_end_user("user-123"),+ trigger_data=trigger_data,+ )++ assert exc_info.value is dispatch_error+ quota_charge_mock.commit.assert_not_called()+ quota_charge_mock.refund.assert_called_once()+ assert not sqlite_session.in_transaction()++ updated_log = sqlite_session.scalar(select(WorkflowTriggerLog))+ assert updated_log is not None+ assert updated_log.status == WorkflowTriggerStatus.FAILED+ assert updated_log.error is not None+ assert "Failed to dispatch workflow task" in updated_log.error+ assert "broker unavailable" in updated_log.error+ assert (+ "Failed to dispatch workflow task for tenant tenant-123, app app-123, workflow workflow-123, "+ f"trigger log {updated_log.id}"+ ) in caplog.text+def test_should_raise_when_reinvoke_target_log_does_not_exist(self, sqlite_session: Session):"""Test reinvoke_trigger error path when original trigger log is missing."""# Arrange