Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(web): stabilize Home and Studio route titles (#41654)

yyhe577c007a0e6
diff --git a/web/app/(commonLayout)/apps/page.tsx b/web/app/(commonLayout)/apps/page.tsx
index 8651d0ed69d..d664642ed87 100644
--- a/web/app/(commonLayout)/apps/page.tsx
+++ b/web/app/(commonLayout)/apps/page.tsx
@@ -1,4 +1,9 @@
import { Apps } from '@/app/components/apps'
+import { getRouteMetadata } from '@/app/route-metadata'
+
+export function generateMetadata() {
+ return getRouteMetadata('common', ($) => $['menus.apps'])
+}
export default function AppsPage() {
return <Apps />
diff --git a/web/app/(commonLayout)/page.tsx b/web/app/(commonLayout)/page.tsx
index 50e232c3f32..4ab822cfe32 100644
--- a/web/app/(commonLayout)/page.tsx
+++ b/web/app/(commonLayout)/page.tsx
@@ -1,4 +1,10 @@
+import { getRouteMetadata } from '@/app/route-metadata'
import { HomePage } from '@/features/home/page'
+
+export function generateMetadata() {
+ return getRouteMetadata('common', ($) => $['mainNav.home'])
+}
+
export default function Page() {
return <HomePage />
}
diff --git a/web/app/__tests__/route-metadata.spec.ts b/web/app/__tests__/route-metadata.spec.ts
index 6d07ece5e39..b9308ee84b8 100644
--- a/web/app/__tests__/route-metadata.spec.ts
+++ b/web/app/__tests__/route-metadata.spec.ts
@@ -1,4 +1,6 @@
import { generateMetadata as generateAgentsMetadata } from '../(commonLayout)/agents/page'
+import { generateMetadata as generateAppsMetadata } from '../(commonLayout)/apps/page'
+import { generateMetadata as generateHomeMetadata } from '../(commonLayout)/page'
import { generateMetadata as generateWebappCheckCodeMetadata } from '../(shareLayout)/webapp-reset-password/check-code/layout'
import { generateMetadata as generateWebappResetPasswordMetadata } from '../(shareLayout)/webapp-reset-password/layout'
import { generateMetadata as generateWebappSetPasswordMetadata } from '../(shareLayout)/webapp-reset-password/set-password/layout'
@@ -28,9 +30,11 @@ vi.mock('../(shareLayout)/webapp-reset-password/reset-password-layout', () => ({
default: () => null,
}))
vi.mock('../init/InitPasswordPopup', () => ({ default: () => null }))
+vi.mock('@/app/components/apps', () => ({ Apps: () => null }))
vi.mock('@/features/agent-v2/roster/page', () => ({ default: () => null }))
+vi.mock('@/features/home/page', () => ({ HomePage: () => null }))
-describe('fixed authentication route metadata', () => {
+describe('fixed route metadata', () => {
it.each([
[generateResetPasswordMetadata, 'Reset Password'],
[generateCheckCodeMetadata, 'Check your email'],
@@ -46,6 +50,8 @@ describe('fixed authentication route metadata', () => {
[generateInitMetadata, 'Admin initialization password'],
[generateOAuthCallbackMetadata, 'Sign in'],
[generateAgentsMetadata, 'Agents'],
+ [generateAppsMetadata, 'Studio'],
+ [generateHomeMetadata, 'Home'],
])('provides the localized title %s', async (generateMetadata, expectedTitle) => {
await expect(generateMetadata()).resolves.toMatchObject({ title: expectedTitle })
})
diff --git a/web/app/components/apps/index.tsx b/web/app/components/apps/index.tsx
index d47c099253f..00ae6eb7f20 100644
--- a/web/app/components/apps/index.tsx
+++ b/web/app/components/apps/index.tsx
@@ -5,11 +5,9 @@ import type { TryAppSelection } from '@/types/try-app'
import type { TrackCreateAppParams } from '@/utils/create-app-tracking'
import { useAtomValue } from 'jotai'
import { useCallback, useRef, useState } from 'react'
-import { useTranslation } from 'react-i18next'
import { EducationExpireNotice } from '@/app/education/expire-notice'
import AppListContext from '@/context/app-list-context'
import { workspacePermissionKeysAtom } from '@/context/permission-state'
-import useDocumentTitle from '@/hooks/use-document-title'
import { useImportDSL } from '@/hooks/use-import-dsl'
import { DSLImportMode } from '@/models/app'
import dynamic from '@/next/dynamic'
@@ -31,7 +29,6 @@ const ImportFromMarketplaceTemplateModal = dynamic(
const AppListProvider = AppListContext.Provider
const AppsContent = () => {
- const { t } = useTranslation()
const searchParams = useSearchParams()
const { replace } = useRouter()
const workspacePermissionKeys = useAtomValue(workspacePermissionKeysAtom)
@@ -39,8 +36,6 @@ const AppsContent = () => {
const templateId = searchParams.get('template-id')
const templateDismissedRef = useRef(false)
- useDocumentTitle(t(($) => $['menus.apps'], { ns: 'common' }))
-
const [currentTryAppParams, setCurrentTryAppParams] = useState<TryAppSelection | undefined>(
undefined,
)
diff --git a/web/features/home/home-content/home-content.tsx b/web/features/home/home-content/home-content.tsx
index 076086b2346..a1e40fb2ba8 100644
--- a/web/features/home/home-content/home-content.tsx
+++ b/web/features/home/home-content/home-content.tsx
@@ -29,7 +29,6 @@ import { STEP_BY_STEP_TOUR_TASKS } from '@/app/components/step-by-step-tour/task
import { useLocale } from '@/context/i18n'
import { workspacePermissionKeysAtom } from '@/context/permission-state'
import { systemFeaturesQueryOptions } from '@/features/system-features/client'
-import useDocumentTitle from '@/hooks/use-document-title'
import { useImportDSL } from '@/hooks/use-import-dsl'
import { DSLImportMode } from '@/models/app'
import dynamic from '@/next/dynamic'
@@ -56,7 +55,6 @@ const HOME_STEP_BY_STEP_TOUR_TASK_ID = 'home' satisfies StepByStepTourTaskId
export function HomeContent() {
const { t } = useTranslation()
- useDocumentTitle(t(($) => $['mainNav.home'], { ns: 'common' }))
const locale = useLocale()
const queryClient = useQueryClient()
const workspacePermissionKeys = useAtomValue(workspacePermissionKeysAtom)