Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

test(api): annotate six test modules so strict pyrefly can check them (#45101)

Felix Shie8cf8f8d4d40
diff --git a/api/tests/unit_tests/controllers/console/app/test_workflow_app_log.py b/api/tests/unit_tests/controllers/console/app/test_workflow_app_log.py
index 0eddc2a3754..7970f40d17b 100644
--- a/api/tests/unit_tests/controllers/console/app/test_workflow_app_log.py
+++ b/api/tests/unit_tests/controllers/console/app/test_workflow_app_log.py
@@ -6,7 +6,7 @@ from controllers.console.app import workflow_app_log as workflow_app_log_module
from graphon.enums import WorkflowExecutionStatus
-def test_workflow_app_log_query_parses_bool_and_datetime():
+def test_workflow_app_log_query_parses_bool_and_datetime() -> None:
query = workflow_app_log_module.WorkflowAppLogQuery.model_validate(
{
"detail": "true",
@@ -22,7 +22,7 @@ def test_workflow_app_log_query_parses_bool_and_datetime():
assert query.limit == 10
-def test_workflow_app_log_pagination_response_normalizes_nested_fields():
+def test_workflow_app_log_pagination_response_normalizes_nested_fields() -> None:
created_at = datetime(2026, 1, 2, 3, 4, 5, tzinfo=UTC)
response = workflow_app_log_module.WorkflowAppLogPaginationResponse.model_validate(
{
diff --git a/api/tests/unit_tests/core/app/apps/workflow/test_active_workflow_tasks.py b/api/tests/unit_tests/core/app/apps/workflow/test_active_workflow_tasks.py
index 3107f5f97b1..d1b41f1876c 100644
--- a/api/tests/unit_tests/core/app/apps/workflow/test_active_workflow_tasks.py
+++ b/api/tests/unit_tests/core/app/apps/workflow/test_active_workflow_tasks.py
@@ -12,7 +12,7 @@ from core.app.apps.workflow.active_workflow_tasks import (
@pytest.fixture(autouse=True)
-def reset_active_tasks() -> None:
+def reset_active_tasks() -> Generator[None]:
reset_active_workflow_tasks()
yield
reset_active_workflow_tasks()
diff --git a/api/tests/unit_tests/events/event_handlers/test_clean_when_document_deleted.py b/api/tests/unit_tests/events/event_handlers/test_clean_when_document_deleted.py
index 098a7b67880..70b5a5d8844 100644
--- a/api/tests/unit_tests/events/event_handlers/test_clean_when_document_deleted.py
+++ b/api/tests/unit_tests/events/event_handlers/test_clean_when_document_deleted.py
@@ -3,7 +3,7 @@ from unittest.mock import patch
from events.event_handlers.clean_when_document_deleted import handle
-def test_handler_dispatches_cleanup_task():
+def test_handler_dispatches_cleanup_task() -> None:
with patch("events.event_handlers.clean_when_document_deleted.clean_document_task.delay") as delay:
handle(
"document-1",
diff --git a/api/tests/unit_tests/events/event_handlers/test_delete_tool_parameters_cache_when_sync_draft_workflow.py b/api/tests/unit_tests/events/event_handlers/test_delete_tool_parameters_cache_when_sync_draft_workflow.py
index 98fb9f44b72..d2e14d244a2 100644
--- a/api/tests/unit_tests/events/event_handlers/test_delete_tool_parameters_cache_when_sync_draft_workflow.py
+++ b/api/tests/unit_tests/events/event_handlers/test_delete_tool_parameters_cache_when_sync_draft_workflow.py
@@ -12,7 +12,7 @@ from models.workflow import Workflow, WorkflowType
def test_missing_tool_provider_does_not_log_error_traceback(
monkeypatch: pytest.MonkeyPatch,
caplog: pytest.LogCaptureFixture,
-):
+) -> None:
app = App(
id="workflow-id",
tenant_id="tenant-id",
diff --git a/api/tests/unit_tests/extensions/test_ext_redis.py b/api/tests/unit_tests/extensions/test_ext_redis.py
index b39713926f3..2db39ea3120 100644
--- a/api/tests/unit_tests/extensions/test_ext_redis.py
+++ b/api/tests/unit_tests/extensions/test_ext_redis.py
@@ -23,7 +23,7 @@ from tests.helpers.unit.config_override import apply_config_overrides
class TestPubsubChannelCases:
@staticmethod
- def test_get_pubsub_broadcast_channel_defaults_to_pubsub(monkeypatch: pytest.MonkeyPatch):
+ def test_get_pubsub_broadcast_channel_defaults_to_pubsub(monkeypatch: pytest.MonkeyPatch) -> None:
apply_config_overrides(monkeypatch, PUBSUB_REDIS_CHANNEL_TYPE="pubsub")
monkeypatch.setattr(ext_redis, "_pubsub_redis_client", object())
@@ -32,7 +32,7 @@ class TestPubsubChannelCases:
assert isinstance(channel, RedisBroadcastChannel)
@staticmethod
- def test_get_pubsub_broadcast_channel_sharded(monkeypatch: pytest.MonkeyPatch):
+ def test_get_pubsub_broadcast_channel_sharded(monkeypatch: pytest.MonkeyPatch) -> None:
apply_config_overrides(monkeypatch, PUBSUB_REDIS_CHANNEL_TYPE="sharded")
monkeypatch.setattr(ext_redis, "_pubsub_redis_client", object())
diff --git a/api/tests/unit_tests/extensions/test_workflow_warm_shutdown.py b/api/tests/unit_tests/extensions/test_workflow_warm_shutdown.py
index 88ca0a95cd5..de1c67cfa15 100644
--- a/api/tests/unit_tests/extensions/test_workflow_warm_shutdown.py
+++ b/api/tests/unit_tests/extensions/test_workflow_warm_shutdown.py
@@ -1,4 +1,5 @@
import logging
+from collections.abc import Generator
from unittest.mock import MagicMock
import pytest
@@ -10,7 +11,7 @@ from graphon.engine.command import AbortCommand
@pytest.fixture(autouse=True)
-def reset_warm_shutdown_state() -> None:
+def reset_warm_shutdown_state() -> Generator[None]:
reset_active_workflow_tasks()
workflow_warm_shutdown._celery_warm_shutdown_started.clear()
yield
diff --git a/api/tests/unit_tests/pyrefly.toml b/api/tests/unit_tests/pyrefly.toml
index 1eb62fbf229..f861e664ebb 100644
--- a/api/tests/unit_tests/pyrefly.toml
+++ b/api/tests/unit_tests/pyrefly.toml
@@ -33,7 +33,6 @@ project-excludes = [
"controllers/console/app/test_ops_trace.py",
"controllers/console/app/test_statistic.py",
"controllers/console/app/test_workflow.py",
- "controllers/console/app/test_workflow_app_log.py",
"controllers/console/app/test_workflow_node_output_inspector.py",
"controllers/console/app/test_workflow_run.py",
"controllers/console/app/test_wraps.py",
@@ -165,7 +164,6 @@ project-excludes = [
"core/helper/test_trace_id_helper.py",
"core/app/apps/workflow/test_app_generator.py",
"core/app/apps/test_workflow_app_runner.py",
- "core/app/apps/workflow/test_active_workflow_tasks.py",
"core/app/apps/workflow/test_app_queue_manager.py",
"core/app/apps/workflow/test_command_channels.py",
"core/app/apps/workflow/test_generate_response_converter.py",
@@ -339,8 +337,6 @@ project-excludes = [
"enterprise/telemetry/test_contracts.py",
"enterprise/telemetry/test_draft_trace.py",
"enterprise/telemetry/test_enterprise_trace.py",
- "events/event_handlers/test_clean_when_document_deleted.py",
- "events/event_handlers/test_delete_tool_parameters_cache_when_sync_draft_workflow.py",
"events/test_app_event.py",
"events/test___init__.py",
"extensions/logstore/repositories/test_logstore_api_workflow_node_execution_repository.py",
@@ -351,8 +347,6 @@ project-excludes = [
"extensions/test_ext_celery.py",
"extensions/test_ext_login.py",
"extensions/test_ext_socketio.py",
- "extensions/test_ext_redis.py",
- "extensions/test_workflow_warm_shutdown.py",
"factories/file_factory/test_builders.py",
"factories/file_factory/test_remote.py",
"factories/file_factory/test_validation.py",