Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix(web): honor upload limits for default files (#45700)
Wu Tianweief90101c13e6
diff --git a/web/app/components/app/configuration/config-var/config-modal/__tests__/file-default.browser.spec.tsx b/web/app/components/app/configuration/config-var/config-modal/__tests__/file-default.browser.spec.tsxnew file mode 100644index 00000000000..02e25d77d81--- /dev/null+++ b/web/app/components/app/configuration/config-var/config-modal/__tests__/file-default.browser.spec.tsx@@ -0,0 +1,204 @@+import type { UploadConfig } from '@dify/contracts/api/console/files/types.gen'+import type { InputVar, MoreInfo } from '@/app/components/workflow/types'+import { page } from 'vite-plus/test/browser'+import { render } from 'vitest-browser-react'+import { InputVarType, SupportUploadFileTypes } from '@/app/components/workflow/types'+import { AppToaster } from '@/app/notifications/app-toaster'+import { consoleQuery } from '@/service/console'+import { createConsoleQueryWrapper } from '@/test/console/query-data'+import { createFileUploadConfigFixture } from '@/test/fixtures/file-upload-config'+import { guardUnexpectedFetch } from '@/test/unexpected-fetch'+import { TransferMethod } from '@/types/app'+import ConfigModal from '../index'++// oxlint-disable-next-line typescript/no-deprecated -- The native file picker still uses the XHR upload transport.+const upload = vi.hoisted(() => vi.fn<typeof import('@/service/base').upload>())+// oxlint-disable-next-line typescript/no-deprecated -- Replace the Console HTTP transport for remote uploads.+const request = vi.hoisted(() => vi.fn<typeof import('@/service/base').request>())+vi.mock('@/service/base', () => ({ request, upload, post: vi.fn() }))+vi.mock('@/next/navigation', () => ({ useParams: () => ({}), usePathname: () => '/apps' }))++const MIB = 1024 * 1024+const pixel = Uint8Array.from(+ atob('R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7'),+ (c) => c.charCodeAt(0),+)+const createImage = (name: string, sizeInMib: number) =>+ new File([pixel, new Uint8Array(sizeInMib * MIB - pixel.length)], name, { type: 'image/gif' })+const createDocument = (name: string, size: number) =>+ new File(['a'.repeat(size)], name, { type: 'text/plain' })++async function openFileDefaults(payload: InputVar, limits: Partial<UploadConfig>) {+ const { queryClient, wrapper: Query } = createConsoleQueryWrapper()+ queryClient.setQueryData(+ consoleQuery.files.upload.get.queryKey(),+ createFileUploadConfigFixture(limits),+ )+ const onConfirm = vi.fn<(value: InputVar, moreInfo?: MoreInfo) => void>()+ await render(+ <Query>+ <AppToaster />+ <ConfigModal isShow supportFile payload={payload} onClose={vi.fn()} onConfirm={onConfirm} />+ </Query>,+ )+ return onConfirm+}++async function getFilePicker() {+ const uploadButton = page.getByRole('dialog').getByRole('button', {+ name: 'common.fileUploader.uploadFromComputer',+ })+ await expect.element(uploadButton).toBeVisible()+ return page.elementLocator(uploadButton.element().querySelector('input[type="file"]')!)+}++beforeEach(() => {+ onTestFinished(guardUnexpectedFetch())+ upload.mockReset()+ request.mockReset()+})++it('uses the server size limit when uploading a default image', async () => {+ upload.mockResolvedValue({ id: 'uploaded-image' })+ const onConfirm = await openFileDefaults(+ {+ type: InputVarType.singleFile,+ label: 'Image',+ variable: 'image',+ required: false,+ allowed_file_types: [SupportUploadFileTypes.image],+ allowed_file_upload_methods: [TransferMethod.local_file],+ },+ { image_file_size_limit: 20 },+ )+ const dialog = page.getByRole('dialog')+ const input = await getFilePicker()++ await input.upload(createImage('over-limit.gif', 21))+ await expect.element(page.getByText(/fileUploader\.uploadFromComputerLimit/)).toBeVisible()+ expect(upload).not.toHaveBeenCalled()++ await input.upload(createImage('default.gif', 12))+ await expect.element(dialog.getByText('default.gif')).toBeVisible()+ await expect.element(dialog.getByRole('progressbar')).not.toBeInTheDocument()+ await dialog.getByRole('button', { name: 'common.operation.save' }).click()++ expect(onConfirm).toHaveBeenCalledExactlyOnceWith(+ expect.objectContaining({+ default: expect.objectContaining({ uploadedId: 'uploaded-image', name: 'default.gif' }),+ }),+ undefined,+ )+})++it('checks each document in a default file list against the configured size limit', async () => {+ upload.mockImplementation(async ({ data }) => ({+ id: `uploaded-${(data.get('file') as File).name}`,+ }))+ const onConfirm = await openFileDefaults(+ {+ type: InputVarType.multiFiles,+ label: 'Documents',+ variable: 'documents',+ required: false,+ max_length: 2,+ allowed_file_types: [SupportUploadFileTypes.document],+ allowed_file_upload_methods: [TransferMethod.local_file],+ },+ { file_size_limit: 1 },+ )+ const dialog = page.getByRole('dialog')+ const input = await getFilePicker()++ await input.upload(createDocument('oversized.txt', 2 * MIB))+ await expect+ .element(page.getByText(/fileUploader\.uploadFromComputerLimit.*1\.00 MB/))+ .toBeVisible()+ expect(upload).not.toHaveBeenCalled()++ await input.upload([+ createDocument('first.txt', (3 * MIB) / 4),+ createDocument('second.txt', (3 * MIB) / 4),+ ])+ await expect.element(dialog.getByText('first.txt')).toBeVisible()+ await expect.element(dialog.getByText('second.txt')).toBeVisible()+ await expect.element(dialog.getByRole('progressbar')).not.toBeInTheDocument()+ await dialog.getByRole('button', { name: 'common.operation.save' }).click()++ expect(upload).toHaveBeenCalledTimes(2)+ expect(onConfirm).toHaveBeenCalledOnce()+ const savedDefault = onConfirm.mock.lastCall?.[0].default+ expect(savedDefault).toHaveLength(2)+ expect(savedDefault).toEqual(+ expect.arrayContaining([+ expect.objectContaining({ uploadedId: 'uploaded-first.txt', name: 'first.txt' }),+ expect.objectContaining({ uploadedId: 'uploaded-second.txt', name: 'second.txt' }),+ ]),+ )+})++it('rejects an oversized file link and saves one within the configured size limit', async () => {+ const oversized = 'https://example.com/oversized.txt'+ const allowed = 'https://example.com/default.txt'+ request+ .mockResolvedValueOnce(+ Response.json({+ id: 'oversized',+ name: 'oversized.txt',+ mime_type: 'text/plain',+ size: 21 * MIB,+ url: oversized,+ }),+ )+ .mockResolvedValueOnce(+ Response.json({+ id: 'uploaded-link',+ name: 'default.txt',+ mime_type: 'text/plain',+ size: 16 * MIB,+ url: allowed,+ }),+ )+ const onConfirm = await openFileDefaults(+ {+ type: InputVarType.singleFile,+ label: 'Document',+ variable: 'document',+ required: false,+ allowed_file_types: [SupportUploadFileTypes.document],+ allowed_file_upload_methods: [TransferMethod.remote_url],+ },+ { file_size_limit: 20 },+ )+ const dialog = page.getByRole('dialog')+ await dialog.getByRole('button', { name: 'common.fileUploader.pasteFileLink' }).click()+ const input = page.getByPlaceholder('common.fileUploader.pasteFileLinkInputPlaceholder')+ const addLink = page.getByRole('button', { name: 'common.operation.ok' })++ await input.fill(oversized)+ await addLink.click()+ await expect+ .element(page.getByText(/fileUploader\.uploadFromComputerLimit.*20\.00 MB/))+ .toBeVisible()+ await expect.element(dialog.getByText(oversized)).not.toBeInTheDocument()++ await input.fill(allowed)+ await addLink.click()+ await expect.element(dialog.getByText(allowed)).toBeVisible()+ await expect.element(dialog.getByRole('progressbar')).not.toBeInTheDocument()+ await dialog.getByRole('button', { name: 'common.operation.save' }).click()++ expect(request).toHaveBeenCalledTimes(2)+ expect(await request.mock.calls[0]?.[2]?.request?.json()).toEqual({ url: oversized })+ expect(await request.mock.calls[1]?.[2]?.request?.json()).toEqual({ url: allowed })+ expect(onConfirm).toHaveBeenCalledExactlyOnceWith(+ expect.objectContaining({+ default: expect.objectContaining({+ uploadedId: 'uploaded-link',+ transferMethod: TransferMethod.remote_url,+ url: allowed,+ }),+ }),+ undefined,+ )+})diff --git a/web/app/components/app/configuration/config-var/config-modal/form-fields.tsx b/web/app/components/app/configuration/config-var/config-modal/form-fields.tsxindex a23cc8d2264..6c36681923f 100644--- a/web/app/components/app/configuration/config-var/config-modal/form-fields.tsx+++ b/web/app/components/app/configuration/config-var/config-modal/form-fields.tsx@@ -24,6 +24,7 @@ import {SelectValue,} from '@langgenius/dify-ui/select'import { Textarea } from '@langgenius/dify-ui/textarea'+import { useQuery } from '@tanstack/react-query'import * as React from 'react'import { Trans } from 'react-i18next'import { FileUploaderInAttachmentWrapper } from '@/app/components/base/file-uploader'@@ -32,6 +33,7 @@ import FileUploadSetting from '@/app/components/workflow/nodes/_base/components/import { CodeLanguage } from '@/app/components/workflow/nodes/code/types'import { InputVarType, SupportUploadFileTypes } from '@/app/components/workflow/types'import { useDocLink } from '@/context/i18n'+import { consoleQuery } from '@/service/console'import { TransferMethod } from '@/types/app'import ConfigSelect from '../config-select'import ConfigString from '../config-string'@@ -92,6 +94,9 @@ const ConfigModalFormFields: FC<ConfigModalFormFieldsProps> = ({? Number(tempPayload.default): Number.NaNconst isFileInput = fileInputTypes.includes(type)+ const { data: fileUploadConfig } = useQuery(+ consoleQuery.files.upload.get.queryOptions({ enabled: isFileInput }),+ )const docLink = useDocLink()const fieldId = React.useId()const errorId = `${fieldId}-error`@@ -351,6 +356,7 @@ const ConfigModalFormFields: FC<ConfigModalFormFieldsProps> = ({allowed_file_upload_methods: tempPayload.allowed_file_upload_methods || [TransferMethod.remote_url,],+ fileUploadConfig,number_limits: type === InputVarType.singleFile ? 1 : tempPayload.max_length || 5,}}/>diff --git a/web/app/components/snippets/components/__tests__/snippet-file-default.browser.spec.tsx b/web/app/components/snippets/components/__tests__/snippet-file-default.browser.spec.tsxnew file mode 100644index 00000000000..8f097b06773--- /dev/null+++ b/web/app/components/snippets/components/__tests__/snippet-file-default.browser.spec.tsx@@ -0,0 +1,137 @@+import type { ComponentProps } from 'react'+import type { InputVar } from '@/models/pipeline'+import type { SnippetDetail } from '@/models/snippet'+import { useState } from 'react'+import { page } from 'vite-plus/test/browser'+import { render } from 'vitest-browser-react'+import { AppToaster } from '@/app/notifications/app-toaster'+import { createConsoleQueryWrapper } from '@/test/console/query-data'+import { createFileUploadConfigFixture } from '@/test/fixtures/file-upload-config'+import { guardUnexpectedFetch } from '@/test/unexpected-fetch'+import { SnippetSidebarContent } from '../snippet-sidebar'++// oxlint-disable-next-line typescript/no-deprecated -- Control the Console HTTP transport for configuration and remote uploads.+const request = vi.hoisted(() => vi.fn<typeof import('@/service/base').request>())+// oxlint-disable-next-line typescript/no-deprecated -- Local files still use the XHR upload transport.+const upload = vi.hoisted(() => vi.fn<typeof import('@/service/base').upload>())+vi.mock('@/service/base', () => ({ request, upload, post: vi.fn() }))+vi.mock('@/next/navigation', () => ({+ useParams: () => ({ snippetId: 'snippet-1' }),+ usePathname: () => '/snippets/snippet-1/orchestrate',+ useRouter: () => ({ replace: vi.fn() }),+ useSelectedLayoutSegment: () => 'orchestrate',+}))+vi.mock('@/next/link', () => ({+ default: ({ children, ...props }: ComponentProps<'a'>) => <a {...props}>{children}</a>,+}))++const MIB = 1024 * 1024+const snippet: SnippetDetail = {+ id: 'snippet-1',+ name: 'Example snippet',+ description: null,+ updatedAt: '2026-11-06T00:00:00Z',+ usage: '0',+ tags: [],+}++function EditableSnippetInputs() {+ const [fields, setFields] = useState<InputVar[]>([])+ return (+ <aside aria-label="Snippet settings" className="h-screen w-80">+ <SnippetSidebarContent+ snippet={snippet}+ fields={fields}+ readonly={false}+ onFieldsChange={setFields}+ />+ </aside>+ )+}++it('adds a default file list from the Snippet sidebar and enforces the configured limit when replacing its file', async () => {+ onTestFinished(guardUnexpectedFetch())+ const oversized = 'https://example.com/oversized.txt'+ const replacement = 'https://example.com/replacement.txt'+ request.mockImplementation(async (_url, _init, options) => {+ if (options?.request?.method === 'GET')+ return Response.json(createFileUploadConfigFixture({ file_size_limit: 2 }))++ const { url } = (await options?.request?.json()) as { url: string }+ const tooLarge = url === oversized+ return Response.json({+ id: tooLarge ? 'oversized-file' : 'replacement-file',+ name: tooLarge ? 'oversized.txt' : 'replacement.txt',+ mime_type: 'text/plain',+ size: (tooLarge ? 3 : 1) * MIB,+ url,+ })+ })+ upload.mockResolvedValue({ id: 'original-file' })+ const { wrapper: Query } = createConsoleQueryWrapper()+ await render(+ <Query>+ <AppToaster />+ <EditableSnippetInputs />+ </Query>,+ )++ const sidebar = page.getByRole('complementary', { name: 'Snippet settings' })+ await sidebar.getByRole('button', { name: 'common.operation.add snippet.inputVariables' }).click()+ const addDialog = page.getByRole('dialog', { name: 'appDebug.variableConfig.addModalTitle' })+ await addDialog.getByRole('combobox', { name: 'appDebug.variableConfig.fieldType' }).click()+ await page.getByRole('option', { name: /^appDebug\.variableConfig\.multi-files/ }).click()+ await addDialog+ .getByRole('textbox', { name: 'appDebug.variableConfig.labelName' })+ .fill('Source files')+ await addDialog+ .getByRole('textbox', { name: 'appDebug.variableConfig.varName' })+ .fill('source_files')+ await addDialog+ .getByRole('checkbox', { name: 'appDebug.variableConfig.file.document.name' })+ .click()+ await expect+ .element(addDialog.getByText(/variableConfig\.maxNumberTip.*"docLimit":"2\.00 MB"/))+ .toBeVisible()++ const uploadButton = addDialog.getByRole('button', {+ name: 'common.fileUploader.uploadFromComputer',+ })+ await expect.element(uploadButton).toBeVisible()+ const input = page.elementLocator(uploadButton.element().querySelector('input[type="file"]')!)+ await input.upload(new File(['original'], 'original.txt', { type: 'text/plain' }))+ await expect.element(addDialog.getByText('original.txt')).toBeVisible()+ await expect.element(addDialog.getByRole('progressbar')).not.toBeInTheDocument()+ await addDialog.getByRole('button', { name: 'common.operation.save' }).click()+ await expect.element(addDialog).not.toBeInTheDocument()++ const editButton = sidebar.getByRole('button', { name: 'common.operation.edit' })+ const field = sidebar.getByText('source_files')+ await field.hover()+ await editButton.click()+ const editDialog = page.getByRole('dialog', { name: 'appDebug.variableConfig.editModalTitle' })+ await expect.element(editDialog.getByText('original.txt')).toBeVisible()+ await editDialog.getByRole('button', { name: 'common.fileUploader.pasteFileLink' }).click()+ const urlInput = page.getByPlaceholder('common.fileUploader.pasteFileLinkInputPlaceholder')+ const addLink = page.getByRole('button', { name: 'common.operation.ok' })+ await urlInput.fill(oversized)+ await addLink.click()+ await expect+ .element(page.getByText(/fileUploader\.uploadFromComputerLimit.*2\.00 MB/))+ .toBeVisible()+ await expect.element(editDialog.getByText(oversized)).not.toBeInTheDocument()+ await expect.element(editDialog.getByText('original.txt')).toBeVisible()++ await urlInput.fill(replacement)+ await addLink.click()+ await expect.element(editDialog.getByText(replacement)).toBeVisible()+ await expect.element(editDialog.getByRole('progressbar')).not.toBeInTheDocument()+ await editDialog.getByRole('button', { name: 'common.operation.remove original.txt' }).click()+ await editDialog.getByRole('button', { name: 'common.operation.save' }).click()+ await expect.element(editDialog).not.toBeInTheDocument()++ await field.hover()+ await editButton.click()+ await expect.element(editDialog.getByText(replacement)).toBeVisible()+ await expect.element(editDialog.getByText('original.txt')).not.toBeInTheDocument()+})