Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(web): remove duplicate tag create separator (#43759)

yyhf39832b7bc7e
diff --git a/web/features/tag-management/components/tag-search-content.tsx b/web/features/tag-management/components/tag-search-content.tsx
index 3dd84d8cf57..92c64fe94f7 100644
--- a/web/features/tag-management/components/tag-search-content.tsx
+++ b/web/features/tag-management/components/tag-search-content.tsx
@@ -10,11 +10,10 @@ import {
ComboboxItemText,
ComboboxList,
ComboboxSeparator,
- useComboboxFilteredItems,
} from '@langgenius/dify-ui/combobox'
import { IconButton } from '@langgenius/dify-ui/icon-button'
import { useAtomValue } from 'jotai'
-import { Fragment, useRef } from 'react'
+import { useRef } from 'react'
import { useTranslation } from 'react-i18next'
import { workspacePermissionKeysAtom } from '@/context/permission-state'
import { hasPermission } from '@/utils/permission'
@@ -47,8 +46,6 @@ export const TagSearchContentView = ({
}: TagSearchContentViewProps) => {
const { t } = useTranslation(['common'])
const inputRef = useRef<HTMLInputElement>(null)
- const filteredItems = useComboboxFilteredItems<TagComboboxItem>()
- const realItemCount = filteredItems.filter((tag) => !isCreateTagOption(tag)).length
const placeholder = t(($) => $['tag.selectorPlaceholder'], { ns: 'common' }) || ''
const handleClearInput = () => {
@@ -88,21 +85,18 @@ export const TagSearchContentView = ({
{(tag) => {
if (isCreateTagOption(tag) && canManageTags) {
return (
- <Fragment key={tag.id}>
- <ComboboxItem<string> value={tag.id}>
- <ComboboxItemText className="flex items-center gap-x-1 px-0">
- <span
- aria-hidden="true"
- className="i-ri-add-line size-4 shrink-0 text-text-tertiary"
- />
- <span className="min-w-0 grow truncate px-1 system-md-regular text-text-secondary">
- {`${t(($) => $['tag.create'], { ns: 'common' })} `}
- <span className="system-md-medium">{`'${tag.name}'`}</span>
- </span>
- </ComboboxItemText>
- </ComboboxItem>
- {realItemCount > 0 && <ComboboxSeparator />}
- </Fragment>
+ <ComboboxItem<string> key={tag.id} value={tag.id}>
+ <ComboboxItemText className="flex items-center gap-x-1 px-0">
+ <span
+ aria-hidden="true"
+ className="i-ri-add-line size-4 shrink-0 text-text-tertiary"
+ />
+ <span className="min-w-0 grow truncate px-1 system-md-regular text-text-secondary">
+ {`${t(($) => $['tag.create'], { ns: 'common' })} `}
+ <span className="system-md-medium">{`'${tag.name}'`}</span>
+ </span>
+ </ComboboxItemText>
+ </ComboboxItem>
)
}