Skip to content

armgit / dify

Public Imported from GitHub
0

Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.

fix(web): close member details after a successful role save (#44669)

yyhfaddecf1d80c
diff --git a/web/app/components/header/account-setting/members-page/__tests__/index.spec.tsx b/web/app/components/header/account-setting/members-page/__tests__/index.spec.tsx
index 42dbe2a16ff..968bfa570c1 100644
--- a/web/app/components/header/account-setting/members-page/__tests__/index.spec.tsx
+++ b/web/app/components/header/account-setting/members-page/__tests__/index.spec.tsx
@@ -337,6 +337,30 @@ describe('MembersPage', () => {
expect(updateRoles).toHaveBeenCalledTimes(2)
})
+ it('closes member details once a pending role save succeeds', async () => {
+ const user = userEvent.setup()
+ const save = updateRoles.getMockImplementation()!
+ let resolveSave!: () => void
+ updateRoles.mockImplementationOnce(async (input) => {
+ await new Promise<void>((resolve) => {
+ resolveSave = resolve
+ })
+ return save(input)
+ })
+ await renderMembersPage()
+ const dialog = await chooseRoles(user, false)
+ await user.click(within(dialog).getByRole('button', { name: 'common.operation.save' }))
+ await user.keyboard('{Escape}')
+ expect(dialog).toBeInTheDocument()
+ await act(async () => {
+ resolveSave()
+ })
+ await waitFor(() => expect(screen.queryByRole('dialog')).not.toBeInTheDocument())
+ expect(
+ await within(screen.getByRole('row', { name: /[email protected]/ })).findByText('Next role'),
+ ).toBeInTheDocument()
+ })
+
it('opens ownership transfer from the owner action without opening member details', async () => {
const user = userEvent.setup()
await renderMembersPage()
diff --git a/web/app/components/header/account-setting/members-page/index.tsx b/web/app/components/header/account-setting/members-page/index.tsx
index d36840d0256..85668924337 100644
--- a/web/app/components/header/account-setting/members-page/index.tsx
+++ b/web/app/components/header/account-setting/members-page/index.tsx
@@ -135,7 +135,7 @@ const MembersPageContent = () => {
<Dialog
handle={detailsDialogHandle}
onOpenChange={(open, details) => {
- if (!open && isSavingMember) details.cancel()
+ if (!open && isSavingMember && details.reason !== 'imperative-action') details.cancel()
}}
>
{({ payload: member }) => (