Build Agentic workflows, RAG pipelines, with rich AI model and tool support on one collaborative workspace. Deploy on cloud, VPC, or self-hosted, so teams move from prototype to production without rebuilding the stack.
Python agentagentic-aiagentic-frameworkagentic-workflowaiautomationclaudedeepseekgenaigptllmlow-codemcpnextjsno-codeopenaipythonskillsworkflow
fix(ui): standardize icon-only controls (#42513)
yyhfbe69a114cfc
diff --git a/packages/dify-ui/src/icon-button/README.md b/packages/dify-ui/src/icon-button/README.mdindex 3e15f5ae641..06976f9fc35 100644--- a/packages/dify-ui/src/icon-button/README.md+++ b/packages/dify-ui/src/icon-button/README.md@@ -31,6 +31,17 @@ appearance variant.Omit `variant` for the IconButton-specific neutral appearance. The other appearance names alignwith `Button`. Use `tone="destructive"` for destructive intent.+For an icon-only link, keep the native anchor or router link and apply `iconButtonVariants`+from `@langgenius/dify-ui/icon-button`. The link owns its accessible name and navigation:++```tsx+<a href="/help" aria-label="Help" className={iconButtonVariants({ size: 'md' })}>+ <span aria-hidden="true" className="i-ri-book-open-line size-4" />+</a>+```++Do not render navigation through `IconButton`: its Base UI button behavior is for commands.+## CompositionWhen Toggle, Menu, Popover, Tooltip, or Collapsible owns the interaction state, keep thatdiff --git a/packages/dify-ui/src/icon-button/index.tsx b/packages/dify-ui/src/icon-button/index.tsxindex 714d0fee5a4..49c26f865f4 100644--- a/packages/dify-ui/src/icon-button/index.tsx+++ b/packages/dify-ui/src/icon-button/index.tsx@@ -47,6 +47,6 @@ function IconButton({)}-export { IconButton }+export { IconButton, iconButtonVariants }export type { IconButtonProps }diff --git a/web/app/components/app-sidebar/app-detail-top.tsx b/web/app/components/app-sidebar/app-detail-top.tsxindex 35d4914750a..7c719b58321 100644--- a/web/app/components/app-sidebar/app-detail-top.tsx+++ b/web/app/components/app-sidebar/app-detail-top.tsx@@ -27,7 +27,6 @@ export function AppDetailTop({ expand = true, onToggle }: AppDetailTopProps) {expand={expand}onToggle={onToggle}icon={<SidebarLeftArrowIcon aria-hidden className="size-4" />}- className="size-8 rounded-[10px] border-0 bg-transparent px-0 text-text-tertiary shadow-none hover:border-0 hover:bg-state-base-hover hover:text-text-secondary"/>)}</div>@@ -93,7 +92,6 @@ export function AppDetailTop({ expand = true, onToggle }: AppDetailTopProps) {expand={expand}onToggle={onToggle}icon={<SidebarLeftArrowIcon aria-hidden className="size-4" />}- className="size-8 rounded-[10px] border-0 bg-transparent px-0 text-text-tertiary shadow-none hover:border-0 hover:bg-state-base-hover hover:text-text-secondary"/>)}</div>diff --git a/web/app/components/app-sidebar/dataset-detail-top.tsx b/web/app/components/app-sidebar/dataset-detail-top.tsxindex 0f4523993c2..b0056aa4b28 100644--- a/web/app/components/app-sidebar/dataset-detail-top.tsx+++ b/web/app/components/app-sidebar/dataset-detail-top.tsx@@ -27,7 +27,6 @@ export function DatasetDetailTop({ expand = true, onToggle }: DatasetDetailTopPrexpand={expand}onToggle={onToggle}icon={<SidebarLeftArrowIcon aria-hidden className="size-4" />}- className="size-8 rounded-[10px] border-0 bg-transparent px-0 text-text-tertiary shadow-none hover:border-0 hover:bg-state-base-hover hover:text-text-secondary"/>)}</div>@@ -93,7 +92,6 @@ export function DatasetDetailTop({ expand = true, onToggle }: DatasetDetailTopPrexpand={expand}onToggle={onToggle}icon={<SidebarLeftArrowIcon aria-hidden className="size-4" />}- className="size-8 rounded-[10px] border-0 bg-transparent px-0 text-text-tertiary shadow-none hover:border-0 hover:bg-state-base-hover hover:text-text-secondary"/>)}</div>diff --git a/web/app/components/datasets/create-from-pipeline/header.tsx b/web/app/components/datasets/create-from-pipeline/header.tsxindex 532f9c0c4a4..8ae1abe6ac4 100644--- a/web/app/components/datasets/create-from-pipeline/header.tsx+++ b/web/app/components/datasets/create-from-pipeline/header.tsx@@ -1,5 +1,5 @@-import { buttonVariants } from '@langgenius/dify-ui/button'import { cn } from '@langgenius/dify-ui/cn'+import { iconButtonVariants } from '@langgenius/dify-ui/icon-button'import { RiArrowLeftLine } from '@remixicon/react'import * as React from 'react'import { useTranslation } from 'react-i18next'@@ -12,14 +12,15 @@ const Header = () => {<div className="relative flex px-16 pt-5 pb-2 system-md-semibold text-text-primary"><span>{t(($) => $['creation.backToKnowledge'], { ns: 'datasetPipeline' })}</span><Link+ aria-label={t(($) => $['creation.backToKnowledge'], { ns: 'datasetPipeline' })}className={cn(- buttonVariants({ variant: 'secondary-accent' }),- 'absolute bottom-0 left-5 size-9 rounded-full p-0',+ iconButtonVariants({ variant: 'secondary-accent', size: 'xl' }),+ 'absolute bottom-0 left-5 rounded-full',)}href="/datasets"replace>- <RiArrowLeftLine className="size-5" />+ <RiArrowLeftLine aria-hidden className="size-5" /></Link></div>)diff --git a/web/app/components/datasets/documents/create-from-pipeline/left-header.tsx b/web/app/components/datasets/documents/create-from-pipeline/left-header.tsxindex 4e999925385..cb0d235a586 100644--- a/web/app/components/datasets/documents/create-from-pipeline/left-header.tsx+++ b/web/app/components/datasets/documents/create-from-pipeline/left-header.tsx@@ -1,8 +1,9 @@import type { Step } from './step-indicator'-import { buttonVariants } from '@langgenius/dify-ui/button'import { cn } from '@langgenius/dify-ui/cn'+import { iconButtonVariants } from '@langgenius/dify-ui/icon-button'import { RiArrowLeftLine } from '@remixicon/react'import * as React from 'react'+import { useTranslation } from 'react-i18next'import Effect from '@/app/components/base/effect'import Link from '@/next/link'import { useParams } from '@/next/navigation'@@ -16,6 +17,7 @@ type LeftHeaderProps = {const LeftHeader = ({ steps, title, currentStep }: LeftHeaderProps) => {const { datasetId } = useParams()+ const { t } = useTranslation()return (<div className="relative flex flex-col gap-y-0.5 pt-4 pb-2">@@ -29,14 +31,15 @@ const LeftHeader = ({ steps, title, currentStep }: LeftHeaderProps) => {<div className="system-md-semibold text-text-primary">{steps[currentStep - 1]?.label}</div>{currentStep !== steps.length && (<Link+ aria-label={t(($) => $['operation.back'], { ns: 'common' })}href={`/datasets/${datasetId}/documents`}replaceclassName={cn(- buttonVariants({ variant: 'secondary-accent' }),- 'absolute top-3.5 -left-11 size-9 rounded-full p-0',+ iconButtonVariants({ variant: 'secondary-accent', size: 'xl' }),+ 'absolute top-3.5 -left-11 rounded-full',)}>- <RiArrowLeftLine className="size-5" />+ <RiArrowLeftLine aria-hidden className="size-5" /></Link>)}<Effect className="-top-8.5 left-8 opacity-20" />diff --git a/web/app/components/detail-sidebar/toggle-button.tsx b/web/app/components/detail-sidebar/toggle-button.tsxindex 0b992db17e5..027297a6ec4 100644--- a/web/app/components/detail-sidebar/toggle-button.tsx+++ b/web/app/components/detail-sidebar/toggle-button.tsx@@ -1,6 +1,5 @@import type { ReactNode } from 'react'-import { Button } from '@langgenius/dify-ui/button'-import { cn } from '@langgenius/dify-ui/cn'+import { IconButton } from '@langgenius/dify-ui/icon-button'import { Kbd, KbdGroup } from '@langgenius/dify-ui/kbd'import { Tooltip, TooltipContent, TooltipTrigger } from '@langgenius/dify-ui/tooltip'import { formatForDisplay } from '@tanstack/react-hotkeys'@@ -31,22 +30,18 @@ export function DetailSidebarToggleButton({<Tooltip><TooltipTriggerrender={- <Button- variant="ghost"- size="small"- aria-label={label}- onClick={onToggle}- className={cn('rounded-full px-1', className)}- />+ <IconButton size="lg" aria-label={label} onClick={onToggle} className={className}>+ <span aria-hidden className="inline-flex">+ {icon ??+ (expand ? (+ <span className="i-ri-arrow-left-s-line size-4" />+ ) : (+ <span className="i-ri-arrow-right-s-line size-4" />+ ))}+ </span>+ </IconButton>}- >- {icon ??- (expand ? (- <span aria-hidden className="i-ri-arrow-left-s-line size-4" />- ) : (- <span aria-hidden className="i-ri-arrow-right-s-line size-4" />- ))}- </TooltipTrigger>+ /><TooltipContent placement="right" className="rounded-lg p-1.5"><div className="flex items-center gap-x-1"><span className="px-0.5 system-xs-medium text-text-secondary">{label}</span>diff --git a/web/app/components/explore/try-app/index.tsx b/web/app/components/explore/try-app/index.tsxindex 0f6c9b64d9e..99708fba984 100644--- a/web/app/components/explore/try-app/index.tsx+++ b/web/app/components/explore/try-app/index.tsx@@ -1,7 +1,7 @@'use client'import type { RecommendedAppResponse } from '@dify/contracts/api/console/explore/types.gen'-import { Button } from '@langgenius/dify-ui/button'import { Dialog, DialogContent } from '@langgenius/dify-ui/dialog'+import { IconButton } from '@langgenius/dify-ui/icon-button'import { Tabs, TabsList, TabsPanel, TabsTab } from '@langgenius/dify-ui/tabs'import * as React from 'react'import { useState } from 'react'@@ -89,15 +89,14 @@ function TryApp({</span></TabsTab></TabsList>- <Button- size="large"+ <IconButton+ size="lg"variant="tertiary"aria-label={t(($) => $['operation.close'], { ns: 'common' })}- className="flex size-7 items-center justify-center rounded-[10px] p-0 text-components-button-tertiary-text"onClick={onClose}><span aria-hidden className="i-ri-close-line size-5" />- </Button>+ </IconButton></div>{/* Main content */}<div className="mt-2 flex h-0 grow justify-between space-x-2">diff --git a/web/app/components/snippets/components/snippet-detail-top.tsx b/web/app/components/snippets/components/snippet-detail-top.tsxindex 5e43cfbf51d..9efa7f2b393 100644--- a/web/app/components/snippets/components/snippet-detail-top.tsx+++ b/web/app/components/snippets/components/snippet-detail-top.tsx@@ -29,7 +29,6 @@ export function SnippetDetailTop({ expand = true, onToggle }: SnippetDetailTopPrexpand={expand}onToggle={onToggle}icon={<SidebarLeftArrowIcon aria-hidden className="size-4" />}- className="size-8 rounded-[10px] border-0 bg-transparent px-0 text-text-tertiary shadow-none hover:border-0 hover:bg-state-base-hover hover:text-text-secondary"/>)}</div>@@ -98,7 +97,6 @@ export function SnippetDetailTop({ expand = true, onToggle }: SnippetDetailTopPrexpand={expand}onToggle={onToggle}icon={<SidebarLeftArrowIcon aria-hidden className="size-4" />}- className="size-8 rounded-[10px] border-0 bg-transparent px-0 text-text-tertiary shadow-none hover:border-0 hover:bg-state-base-hover hover:text-text-secondary"/>)}</div>diff --git a/web/app/components/workflow/nodes/_base/components/help-link.tsx b/web/app/components/workflow/nodes/_base/components/help-link.tsxindex 429cc078544..84a319771bd 100644--- a/web/app/components/workflow/nodes/_base/components/help-link.tsx+++ b/web/app/components/workflow/nodes/_base/components/help-link.tsx@@ -1,6 +1,6 @@import type { BlockEnum } from '@/app/components/workflow/types'-import { buttonVariants } from '@langgenius/dify-ui/button'import { cn } from '@langgenius/dify-ui/cn'+import { iconButtonVariants } from '@langgenius/dify-ui/icon-button'import { Tooltip, TooltipContent, TooltipTrigger } from '@langgenius/dify-ui/tooltip'import { memo } from 'react'import { useTranslation } from 'react-i18next'@@ -26,10 +26,7 @@ const HelpLink = ({ nodeType }: HelpLinkProps) => {href={link}target="_blank"rel="noopener noreferrer"- className={cn(- buttonVariants({ variant: 'ghost', size: 'small' }),- 'mr-1 w-6 p-0 text-text-tertiary hover:bg-state-base-hover hover:text-text-secondary',- )}+ className={cn(iconButtonVariants({ size: 'md' }), 'mr-1')}><span aria-hidden className="i-ri-book-open-line size-4" /></a>diff --git a/web/app/components/workflow/nodes/human-input/components/__tests__/button-style-dropdown.spec.tsx b/web/app/components/workflow/nodes/human-input/components/__tests__/button-style-dropdown.spec.tsxindex e914180c864..442e297eb1a 100644--- a/web/app/components/workflow/nodes/human-input/components/__tests__/button-style-dropdown.spec.tsx+++ b/web/app/components/workflow/nodes/human-input/components/__tests__/button-style-dropdown.spec.tsx@@ -25,13 +25,30 @@ describe('ButtonStyleDropdown', () => {<ButtonStyleDropdown text="Approve" data={UserActionButtonType.Ghost} onChange={onChange} />,)- await user.click(screen.getByRole('button'))+ await user.click(+ screen.getByRole('button', { name: 'nodes.humanInput.userActions.chooseStyle' }),+ )expect(screen.getByText('nodes.humanInput.userActions.chooseStyle')).toBeInTheDocument()await user.click(screen.getAllByRole('button', { name: 'Approve' })[0]!)expect(onChange).toHaveBeenCalledWith(UserActionButtonType.Primary)})+ it('opens from the named keyboard trigger and closes with Escape', async () => {+ const user = userEvent.setup()+ render(+ <ButtonStyleDropdown text="Approve" data={UserActionButtonType.Ghost} onChange={onChange} />,+ )++ const trigger = screen.getByRole('button', { name: 'nodes.humanInput.userActions.chooseStyle' })+ await user.tab()+ expect(trigger).toHaveFocus()+ await user.keyboard('{Enter}')+ expect(await screen.findByRole('dialog')).toBeInTheDocument()+ await user.keyboard('{Escape}')+ expect(screen.queryByRole('dialog')).not.toBeInTheDocument()+ })+it('should keep the dropdown closed in readonly mode', async () => {const user = userEvent.setup()render(@@ -43,7 +60,9 @@ describe('ButtonStyleDropdown', () => {/>,)- await user.click(screen.getByRole('button'))+ const trigger = screen.getByRole('button', { name: 'nodes.humanInput.userActions.chooseStyle' })+ expect(trigger).toBeDisabled()+ await user.click(trigger)expect(screen.queryByText('nodes.humanInput.userActions.chooseStyle')).not.toBeInTheDocument()expect(onChange).not.toHaveBeenCalled()diff --git a/web/app/components/workflow/nodes/human-input/components/button-style-dropdown.tsx b/web/app/components/workflow/nodes/human-input/components/button-style-dropdown.tsxindex daf9262d846..e1e2b0def6a 100644--- a/web/app/components/workflow/nodes/human-input/components/button-style-dropdown.tsx+++ b/web/app/components/workflow/nodes/human-input/components/button-style-dropdown.tsx@@ -1,6 +1,7 @@import type { FC } from 'react'import { Button } from '@langgenius/dify-ui/button'import { cn } from '@langgenius/dify-ui/cn'+import { IconButton, iconButtonVariants } from '@langgenius/dify-ui/icon-button'import { Popover, PopoverContent, PopoverTrigger } from '@langgenius/dify-ui/popover'import { RiFontSize } from '@remixicon/react'import * as React from 'react'@@ -43,16 +44,24 @@ const ButtonStyleDropdown: FC<Props> = ({ text = 'Button Text', data, onChange,><PopoverTriggerrender={- <div- className={cn(- 'flex items-center justify-center rounded-lg bg-components-button-tertiary-bg p-1 data-popup-open:bg-components-button-tertiary-bg-hover',- !readonly && 'cursor-pointer hover:bg-components-button-tertiary-bg-hover',- )}+ <IconButton+ aria-label={t(($) => $[`${i18nPrefix}.userActions.chooseStyle`], { ns: 'workflow' })}+ variant="tertiary"+ size="lg"+ disabled={readonly}+ className="p-1 data-popup-open:bg-components-button-tertiary-bg-hover">- <Button size="small" className="pointer-events-none px-1" variant={currentStyle}>+ {/* Keep the selected style preview static while the trigger owns hover. */}+ <span+ aria-hidden+ className={cn(+ iconButtonVariants({ variant: currentStyle, size: 'md' }),+ 'pointer-events-none',+ )}+ ><RiFontSize className="size-4" />- </Button>- </div>+ </span>+ </IconButton>}/><PopoverContentdiff --git a/web/app/components/workflow/variable-inspect/right.tsx b/web/app/components/workflow/variable-inspect/right.tsxindex c34c683ecd0..6d0fe07f38e 100644--- a/web/app/components/workflow/variable-inspect/right.tsx+++ b/web/app/components/workflow/variable-inspect/right.tsx@@ -1,8 +1,7 @@import type { currentVarType } from './panel'import type { GenRes } from '@/service/debug'-import { buttonVariants } from '@langgenius/dify-ui/button'import { cn } from '@langgenius/dify-ui/cn'-import { IconButton } from '@langgenius/dify-ui/icon-button'+import { IconButton, iconButtonVariants } from '@langgenius/dify-ui/icon-button'import { Tooltip, TooltipContent, TooltipTrigger } from '@langgenius/dify-ui/tooltip'import { useBoolean } from 'ahooks'import { produce } from 'immer'@@ -233,10 +232,7 @@ const Right = ({ nodeId, currentNodeVar, handleOpenMenu, isValueFetching }: Prophref={fullContent?.download_url}target="_blank"rel="noopener noreferrer"- className={cn(- buttonVariants({ variant: 'ghost', size: 'small' }),- 'size-6 rounded-lg p-0 text-text-tertiary hover:bg-state-base-hover hover:text-text-secondary',- )}+ className={iconButtonVariants({ size: 'md' })}><span aria-hidden className="i-ri-file-download-fill size-4" /></a>diff --git a/web/features/agent-v2/agent-detail/access/components/agent-api-key-modal.tsx b/web/features/agent-v2/agent-detail/access/components/agent-api-key-modal.tsxindex 9eabb3f9a66..cf8a6d5932f 100644--- a/web/features/agent-v2/agent-detail/access/components/agent-api-key-modal.tsx+++ b/web/features/agent-v2/agent-detail/access/components/agent-api-key-modal.tsx@@ -210,16 +210,14 @@ export function AgentApiKeyModal({</div><div className="flex grow gap-2 px-3"><CopyFeedback content={apiKey.token} />- <Button- variant="ghost"- size="small"- className="size-6 px-0 text-text-tertiary hover:text-text-secondary"+ <IconButton+ size="md"aria-label={tCommon(($) => $['operation.delete'])}disabled={isDeleting}onClick={() => setApiKeyToDelete(apiKey)}><span aria-hidden className="i-ri-delete-bin-line size-4" />- </Button>+ </IconButton></div></div>))}diff --git a/web/features/agent-v2/agent-detail/navigation.tsx b/web/features/agent-v2/agent-detail/navigation.tsxindex b7a43fb2d42..dce91202121 100644--- a/web/features/agent-v2/agent-detail/navigation.tsx+++ b/web/features/agent-v2/agent-detail/navigation.tsx@@ -102,7 +102,6 @@ export function AgentDetailTop({ expand = true, onToggle }: AgentDetailTopProps)expand={expand}onToggle={onToggle}icon={<SidebarLeftArrowIcon aria-hidden className="size-4" />}- className="size-8 rounded-[10px] border-0 bg-transparent px-0 text-text-tertiary shadow-none hover:border-0 hover:bg-state-base-hover hover:text-text-secondary"/>)}</div>@@ -162,7 +161,6 @@ export function AgentDetailTop({ expand = true, onToggle }: AgentDetailTopProps)expand={expand}onToggle={onToggle}icon={<SidebarLeftArrowIcon aria-hidden className="size-4" />}- className="size-8 rounded-[10px] border-0 bg-transparent px-0 text-text-tertiary shadow-none hover:border-0 hover:bg-state-base-hover hover:text-text-secondary"/>)}</div>diff --git a/web/features/new-rag/document-chunk-detail.tsx b/web/features/new-rag/document-chunk-detail.tsxindex c1ba713e1e4..2331d01deaa 100644--- a/web/features/new-rag/document-chunk-detail.tsx+++ b/web/features/new-rag/document-chunk-detail.tsx@@ -4,6 +4,7 @@ import type {LogicalDocumentRevision,} from '@dify/contracts/knowledge-fs/types.gen'import { Button } from '@langgenius/dify-ui/button'+import { IconButton } from '@langgenius/dify-ui/icon-button'import copy from 'copy-to-clipboard'import { useEffect, useMemo } from 'react'import { useTranslation } from 'react-i18next'@@ -119,18 +120,17 @@ export function DocumentChunkDetail({{t(($) => $['newKnowledge.chunkLocation'], { position: chunk.ordinal })}</p></div>- <Button+ <IconButtonaria-label={tCommon(($) => $['operation.copy'])}className="opacity-0 transition-opacity group-focus-within:opacity-100 group-hover:opacity-100 motion-reduce:transition-none"onClick={() => {copy(chunk.text)toast.success(tCommon(($) => $['actionMsg.copySuccessfully']))}}- size="small"- variant="ghost"+ size="md"><span aria-hidden className="i-ri-file-copy-line size-4" />- </Button>+ </IconButton></div>{content.body && (<p className="mt-3 body-md-regular wrap-break-word whitespace-pre-wrap text-text-primary">diff --git a/web/features/skills/detail/builder-panel.tsx b/web/features/skills/detail/builder-panel.tsxindex 7d0f066aaa0..38ffb262eab 100644--- a/web/features/skills/detail/builder-panel.tsx+++ b/web/features/skills/detail/builder-panel.tsx@@ -6,8 +6,8 @@ import type {} from '@dify/contracts/api/console/workspaces/types.gen'import type { BuilderChatMessage, SkillBuilderAttachment, SkillBuilderModel } from './shared'import type { FormValue } from '@/app/components/header/account-setting/model-provider-page/declarations'-import { Button } from '@langgenius/dify-ui/button'import { cn } from '@langgenius/dify-ui/cn'+import { IconButton } from '@langgenius/dify-ui/icon-button'import { useQuery, useQueryClient } from '@tanstack/react-query'import { useEffect, useId, useMemo, useRef, useState } from 'react'import { useTranslation } from 'react-i18next'@@ -1094,10 +1094,11 @@ export function SkillBuilderPanel({/></button></div>- <Button+ <IconButtonaria-label={t(($) => $['skillManagement.detail.builder.send'])}variant="primary"- className="size-8 px-0 focus-visible:ring-inset"+ size="lg"+ className="focus-visible:ring-inset"disabled={!canSendBuilderMessage ||(!prompt.trim() && attachments.length === 0) ||@@ -1115,7 +1116,7 @@ export function SkillBuilderPanel({'size-4',)}/>- </Button>+ </IconButton></div></div></div>