Skip to content

A platform for community discussion. Free, open, simple.

9.7 KB
Raw Blame
# frozen_string_literal: true

describe TopicQuery do
  before { SiteSetting.assign_enabled = true }

  fab!(:user)
  fab!(:user2, :user)
  fab!(:user3, :user)
  fab!(:user4, :user)

  include_context "with group that is allowed to assign"

  before do
    assign_allowed_group.add(user)
    assign_allowed_group.add(user2)
  end

  def assign_to(topic:, user:, assignee:)
    topic.tap { |assigned_topic| Assigner.new(assigned_topic, user).assign(assignee) }
  end

  describe "#list_messages_assigned" do
    fab!(:private_message) { Fabricate(:private_message_post, user: user).topic }

    fab!(:topic) { Fabricate(:post, user: user).topic }
    fab!(:group_topic) { Fabricate(:post, user: user).topic }

    before do
      assign_to(topic: private_message, user: user, assignee: user)
      assign_to(topic: topic, user: user, assignee: user)
      assign_to(topic: group_topic, user: user, assignee: assign_allowed_group)
    end

    it "Includes topics and PMs assigned to user" do
      assigned_messages = TopicQuery.new(user, { page: 0 }).list_messages_assigned(user).topics

      expect(assigned_messages).to contain_exactly(private_message, topic, group_topic)
    end

    it "Excludes inactive assignments" do
      Assignment.update_all(active: false)

      assigned_messages = TopicQuery.new(user, { page: 0 }).list_messages_assigned(user).topics

      expect(assigned_messages).to eq([])
    end

    it "Excludes topics and PMs not assigned to user" do
      assigned_messages = TopicQuery.new(user2, { page: 0 }).list_messages_assigned(user2).topics

      expect(assigned_messages).to contain_exactly(group_topic)
    end

    it "direct filter excludes group assignment" do
      assigned_messages =
        TopicQuery.new(user, { page: 0, filter: :direct }).list_messages_assigned(user).topics

      expect(assigned_messages).to contain_exactly(private_message, topic)
    end

    it "Returns the results ordered by the bumped_at field" do
      topic.update(bumped_at: 2.weeks.ago)

      assigned_messages = TopicQuery.new(user, { page: 0 }).list_messages_assigned(user).topics

      expect(assigned_messages).to eq([group_topic, private_message, topic])
    end
  end

  describe "#list_group_topics_assigned" do
    fab!(:private_message) { Fabricate(:private_message_post, user: user).topic }

    fab!(:topic) { Fabricate(:post, user: user).topic }

    fab!(:group_topic) { Fabricate(:post, user: user).topic }

    before do
      assign_to(topic: private_message, user: user, assignee: user)
      assign_to(topic: topic, user: user2, assignee: user2)
      assign_to(topic: group_topic, user: user, assignee: assign_allowed_group)
    end

    it "Includes topics and PMs assigned to user" do
      assigned_messages =
        TopicQuery.new(user, { page: 0 }).list_group_topics_assigned(assign_allowed_group).topics

      expect(assigned_messages).to contain_exactly(private_message, topic, group_topic)
    end

    it "Returns the results ordered by the bumped_at field" do
      topic.update(bumped_at: 2.weeks.ago)

      assigned_messages =
        TopicQuery.new(user, { page: 0 }).list_group_topics_assigned(assign_allowed_group).topics

      expect(assigned_messages).to eq([group_topic, private_message, topic])
    end

    it "direct filter shows only group assignments" do
      assigned_messages =
        TopicQuery
          .new(user, { page: 0, filter: :direct })
          .list_group_topics_assigned(assign_allowed_group)
          .topics

      expect(assigned_messages).to contain_exactly(group_topic)
    end

    it "excludes assignments to deleted posts and topics" do
      # Create a new topic with only a post assignment (no topic assignment)
      post_only_topic = Fabricate(:post, user: user).topic
      post_in_topic = Fabricate(:post, topic: post_only_topic)
      assign_to(topic: post_in_topic, user: user, assignee: user)

      assigned_messages =
        TopicQuery.new(user, { page: 0 }).list_group_topics_assigned(assign_allowed_group).topics
      expect(assigned_messages).to contain_exactly(
        private_message,
        topic,
        group_topic,
        post_only_topic,
      )

      # delete entire topic (soft deletion)
      post_only_topic.update!(deleted_at: Time.current)
      assigned_messages =
        TopicQuery.new(user, { page: 0 }).list_group_topics_assigned(assign_allowed_group).topics
      expect(assigned_messages).to contain_exactly(private_message, topic, group_topic)

      # restore topic, but delete the post (moderator deletion)
      post_only_topic.update!(deleted_at: nil)
      post_in_topic.update!(deleted_at: Time.current)
      assigned_messages =
        TopicQuery.new(user, { page: 0 }).list_group_topics_assigned(assign_allowed_group).topics
      expect(assigned_messages).to contain_exactly(private_message, topic, group_topic)

      # user deletion of post
      post_in_topic.update!(deleted_at: nil, user_deleted: true)
      assigned_messages =
        TopicQuery.new(user, { page: 0 }).list_group_topics_assigned(assign_allowed_group).topics
      expect(assigned_messages).to contain_exactly(private_message, topic, group_topic)

      # system deletion of post
      post_in_topic.update!(user_deleted: false, deleted_by_id: Discourse.system_user.id)
      assigned_messages =
        TopicQuery.new(user, { page: 0 }).list_group_topics_assigned(assign_allowed_group).topics
      expect(assigned_messages).to contain_exactly(private_message, topic, group_topic)
    end
  end

  describe "#list_private_messages_assigned" do
    let(:user_topic) do
      topic =
        create_post(
          user: user3,
          target_usernames: [user.username, user2.username],
          archetype: Archetype.private_message,
        ).topic

      create_post(topic_id: topic.id, user: user)

      topic
    end

    let(:assigned_topic) do
      topic =
        create_post(
          user: user4,
          target_usernames: [user.username, user2.username],
          archetype: Archetype.private_message,
        ).topic

      assign_to(topic: topic, user: user, assignee: user)
    end

    let(:group2) { Fabricate(:group, messageable_level: Group::ALIAS_LEVELS[:everyone]) }

    let(:group_assigned_topic) do
      topic =
        create_post(
          user: user,
          target_group_names: [assign_allowed_group.name, group2.name],
          archetype: Archetype.private_message,
        ).topic

      assign_to(topic: topic, user: user, assignee: user)
    end

    before do
      Group.refresh_automatic_groups!

      assign_allowed_group.update!(messageable_level: Group::ALIAS_LEVELS[:everyone])

      user_topic
      assigned_topic
      group_assigned_topic
    end

    it "returns messages assigned to the user or their group" do
      expect(TopicQuery.new(user).list_private_messages_assigned(user).topics).to contain_exactly(
        assigned_topic,
        group_assigned_topic,
      )

      UserArchivedMessage.archive!(user.id, assigned_topic)

      expect(TopicQuery.new(user).list_private_messages_assigned(user).topics).to contain_exactly(
        assigned_topic,
        group_assigned_topic,
      )

      GroupArchivedMessage.archive!(group2.id, group_assigned_topic)

      expect(TopicQuery.new(user).list_private_messages_assigned(user).topics).to contain_exactly(
        assigned_topic,
        group_assigned_topic,
      )

      GroupArchivedMessage.archive!(assign_allowed_group.id, group_assigned_topic)

      expect(TopicQuery.new(user).list_private_messages_assigned(user).topics).to contain_exactly(
        assigned_topic,
        group_assigned_topic,
      )
    end
  end

  describe "assigned filter" do
    it "filters topics assigned to a user" do
      assigned_topic = Fabricate(:post).topic
      assigned_topic2 = Fabricate(:post).topic

      Assigner.new(assigned_topic, user).assign(user)
      Assigner.new(assigned_topic2, user2).assign(user2)
      query = TopicQuery.new(user, assigned: user.username).list_latest

      expect(query.topics.length).to eq(1)
      expect(query.topics.first).to eq(assigned_topic)
    end

    it "filters topics assigned to the current user" do
      assigned_topic = Fabricate(:post).topic
      assigned_topic2 = Fabricate(:post).topic

      Assigner.new(assigned_topic, user).assign(user)
      Assigner.new(assigned_topic2, user2).assign(user2)
      query = TopicQuery.new(user2, assigned: "me").list_latest

      expect(query.topics.length).to eq(1)
      expect(query.topics.first).to eq(assigned_topic2)
    end

    it "filters topics assigned to nobody" do
      assigned_topic = Fabricate(:post).topic
      unassigned_topic = Fabricate(:topic)

      Assigner.new(assigned_topic, user).assign(user)
      query = TopicQuery.new(user, assigned: "nobody").list_latest

      expect(query.topics.length).to eq(1)
      expect(query.topics.first).to eq(unassigned_topic)
    end

    it "filters topics assigned to anybody (*)" do
      assigned_topic = Fabricate(:post).topic
      Fabricate(:topic)

      Assigner.new(assigned_topic, user).assign(user)
      query = TopicQuery.new(user, assigned: "*").list_latest

      expect(query.topics.length).to eq(1)
      expect(query.topics.first).to eq(assigned_topic)
    end

    it "ignores the assigned filter for scoped users" do
      SiteSetting.assign_allowed_on_groups = ""
      category = Fabricate(:category)
      scoped_group = Fabricate(:group)
      scoped_user = Fabricate(:user, groups: [scoped_group])
      allow_group_to_assign_in_category(category, scoped_group)
      assigned_topic = Fabricate(:post).topic.tap { |topic| topic.update!(category: category) }
      unassigned_topic = Fabricate(:topic)

      Assigner.new(assigned_topic, scoped_user).assign(scoped_user)
      query = TopicQuery.new(scoped_user, assigned: scoped_user.username).list_latest

      expect(query.topics).to contain_exactly(assigned_topic, unassigned_topic)
    end
  end
end