Skip to content

A platform for community discussion. Free, open, simple.

5.9 KB
Raw Blame
# frozen_string_literal: true

describe Auth::DiscourseIdAuthenticator do
  let(:authenticator) { described_class.new }
  let(:user) { Fabricate(:user) }

  context "with default settings" do
    before do
      SiteSetting.discourse_id_client_id = "client_id"
      SiteSetting.discourse_id_client_secret = "client_secret"
      SiteSetting.enable_discourse_id = true
    end

    it "has the right name" do
      expect(authenticator.name).to eq("discourse_id")
    end

    it "can connect to existing user" do
      expect(authenticator.can_connect_existing_user?).to eq(true)
    end

    it "can be revoked" do
      expect(authenticator.can_revoke?).to eq(true)
    end

    it "verifies email by default" do
      expect(authenticator.primary_email_verified?({})).to eq(true)
    end

    it "does not always update user email" do
      expect(authenticator.always_update_user_email?).to eq(false)
    end

    describe "#enabled?" do
      it "is enabled with proper settings" do
        expect(authenticator.enabled?).to eq(true)
      end

      it "is disabled without client id" do
        SiteSetting.discourse_id_client_id = ""
        expect(authenticator.enabled?).to eq(false)
      end

      it "is disabled without client secret" do
        SiteSetting.discourse_id_client_secret = ""
        expect(authenticator.enabled?).to eq(false)
      end

      it "is disabled when `discourse_login_client_enabled` is false" do
        SiteSetting.enable_discourse_id = false
        expect(authenticator.enabled?).to eq(false)
      end
    end

    describe "#site" do
      it "returns default URL when setting is blank" do
        SiteSetting.discourse_id_provider_url = ""
        expect(authenticator.site).to eq("https://id.discourse.com")
      end

      it "returns configured URL when setting is present" do
        SiteSetting.discourse_id_provider_url = "https://custom.example.com"
        expect(authenticator.site).to eq("https://custom.example.com")
      end
    end
  end

  describe "DiscourseIdStrategy" do
    let(:strategy) { Auth::DiscourseIdAuthenticator::DiscourseIdStrategy.new({}) }

    it "uses 'discourse_id' name" do
      expect(strategy.options.name).to eq("discourse_id")
    end

    it "uses basic auth as authentication scheme" do
      expect(strategy.options.client_options.auth_scheme).to eq(:basic_auth)
    end

    it "defines callback_url" do
      expect(strategy.callback_url).to eq("http://test.localhost/auth/discourse_id/callback")
    end

    describe "#authorize_params" do
      let(:env) { Rack::MockRequest.env_for("http://example.com/auth/discourse_id", params:) }
      let(:request) { Rack::Request.new(env) }
      let(:strategy) do
        strategy = Auth::DiscourseIdAuthenticator::DiscourseIdStrategy.new({})
        allow(strategy).to receive(:request).and_return(request)
        strategy
      end

      before do
        allow_any_instance_of(OmniAuth::Strategies::OAuth2).to receive(
          :authorize_params,
        ).and_return({})
      end

      context "when just email parameter is present" do
        let(:params) { { "email" => "[email protected]" } }

        it "does not include email in authorize params" do
          expect(strategy.authorize_params[:email]).to be_nil
        end
      end

      context "when signup parameter is true" do
        let(:params) { { "signup" => "true" } }

        it "includes signup intent in authorize params" do
          expect(strategy.authorize_params[:intent]).to eq("signup")
        end
      end

      context "when signup parameter is false" do
        let(:params) { { "signup" => "false" } }

        it "does not include signup intent in authorize params" do
          expect(strategy.authorize_params[:intent]).to be_nil
        end
      end

      context "when signup is false and email is present" do
        let(:params) { { "email" => "[email protected]", "signup" => "false" } }

        it "does not include anything in authorize params" do
          params = strategy.authorize_params
          expect(params[:email]).to be_nil
          expect(params[:intent]).to be_nil
        end
      end

      context "when signup is true and email is present" do
        let(:params) { { "email" => "[email protected]", "signup" => "true" } }

        it "includes both email and intent in authorize params" do
          params = strategy.authorize_params
          expect(params[:email]).to eq("[email protected]")
          expect(params[:intent]).to eq("signup")
        end
      end
    end
  end

  let(:hash) do
    OmniAuth::AuthHash.new(
      provider: "discourse_id",
      info: {
        "nickname" => "test_user",
        "name" => "Test User",
        "email" => user.email,
        "image" => "http://example.com/avatar.png",
        "uuid" => "12345",
      },
      uid: "99",
    )
  end

  describe "after_authenticate" do
    it "works and syncs username, email, name, avatar" do
      result = authenticator.after_authenticate(hash)
      expect(result.user).to eq(user)
      expect(result.failed).to eq(false)

      expect(result.username).to eq("test_user")
      expect(result.name).to eq("Test User")
      expect(result.email).to eq(user.email)

      associated_record =
        UserAssociatedAccount.find_by(provider_name: "discourse_id", user_id: user.id)

      expect(associated_record[:info]["image"]).to eq("http://example.com/avatar.png")
      expect(associated_record[:info]["uuid"]).to eq("12345")
    end

    context "when name is not provided by the provider" do
      let(:hash_without_name) do
        OmniAuth::AuthHash.new(
          provider: "discourse_id",
          info: {
            "nickname" => "test_user",
            "email" => user.email,
            "image" => "http://example.com/avatar.png",
            "uuid" => "12345",
          },
          uid: "99",
        )
      end

      it "result name is nil" do
        result = authenticator.after_authenticate(hash_without_name)
        expect(result.name).to be_nil
      end
    end
  end
end