A platform for community discussion. Free, open, simple.
# frozen_string_literal: true
RSpec.describe UserStat do
it "is created automatically when a user is created" do
user = Fabricate(:evil_trout)
expect(user.user_stat).to be_present
# It populates the `new_since` field by default
expect(user.user_stat.new_since).to be_present
end
describe ".recalculate_likes!" do
fab!(:liker, :user)
fab!(:author, :user)
def like!(post)
UserAction.create!(
action_type: UserAction::LIKE,
user_id: liker.id,
acting_user_id: liker.id,
target_post_id: post.id,
target_topic_id: post.topic_id,
)
UserAction.create!(
action_type: UserAction::WAS_LIKED,
user_id: author.id,
acting_user_id: liker.id,
target_post_id: post.id,
target_topic_id: post.topic_id,
)
end
it "only counts likes on visible regular posts in visible public topics" do
like!(Fabricate(:post, user: author))
like!(Fabricate(:private_message_post, user: author))
like!(Fabricate(:post, user: author, post_type: Post.types[:whisper]))
like!(Fabricate(:post, user: author, hidden: true))
like!(Fabricate(:post, user: author, deleted_at: Time.zone.now))
like!(Fabricate(:post, user: author, topic: Fabricate(:topic, visible: false)))
liker.user_stat.update!(likes_given: 42)
UserStat.recalculate_likes!([liker.id, author.id])
expect(liker.user_stat.reload).to have_attributes(likes_given: 1, likes_received: 0)
expect(author.user_stat.reload).to have_attributes(likes_given: 0, likes_received: 1)
end
it "matches the directory refresh" do
like!(Fabricate(:post, user: author))
like!(Fabricate(:post, user: author, hidden: true))
DirectoryItem.refresh_period!(:all, force: true)
directory_counts =
UserStat.where(user_id: [liker.id, author.id]).pluck(:likes_given, :likes_received)
UserStat.where(user_id: [liker.id, author.id]).update_all(likes_given: 9, likes_received: 9)
UserStat.recalculate_likes!([liker.id, author.id])
expect(
UserStat.where(user_id: [liker.id, author.id]).pluck(:likes_given, :likes_received),
).to eq(directory_counts)
end
end
describe "#update_view_counts" do
let(:user) { Fabricate(:user) }
let(:stat) { user.user_stat }
context "with topics_entered" do
context "without any views" do
it "doesn't increase the user's topics_entered" do
expect {
UserStat.update_view_counts
stat.reload
}.not_to change(stat, :topics_entered)
end
end
context "with a view" do
fab!(:topic)
let!(:view) { TopicViewItem.add(topic.id, "127.0.0.1", user.id) }
before do
user.update_column :last_seen_at, 1.second.ago
stat.update_column :topics_entered, 0
end
it "adds one to the topics entered" do
expect { UserStat.update_view_counts }.to change { stat.reload.topics_entered }.to 1
end
it "does not count a repeat view as another topic" do
TopicViewItem.add(topic.id, "127.0.0.1", user.id)
expect { UserStat.update_view_counts }.to change { stat.reload.topics_entered }.to 1
end
end
end
context "with posts_read_count" do
context "without any post timings" do
it "doesn't increase the user's posts_read_count" do
expect {
UserStat.update_view_counts
stat.reload
}.not_to change(stat, :posts_read_count)
end
end
context "with a post timing" do
let!(:post) { Fabricate(:post) }
let!(:post_timings) do
PostTiming.record_timing(
msecs: 1234,
topic_id: post.topic_id,
user_id: user.id,
post_number: post.post_number,
)
end
before do
user.update_column :last_seen_at, 1.second.ago
stat.update_column :posts_read_count, 0
end
it "increases posts_read_count" do
expect { UserStat.update_view_counts }.to change { stat.reload.posts_read_count }.to 1
end
end
end
end
describe ".update_first_unread" do
fab!(:user) { Fabricate(:user, last_seen_at: Time.zone.now) }
[false, true].each do |enabled|
it "includes logged-in pseudogroup topics with granular permissions #{enabled}" do
freeze_time
SiteSetting.granular_anonymous_and_logged_in_groups_permissions = enabled
author = Fabricate(:admin)
category = Fabricate(:category, permissions: { logged_in_users: :readonly })
post = create_post(category: category, user: author, created_at: 1.hour.ago)
private_category = Fabricate(:private_category, group: Fabricate(:group))
private_post =
create_post(category: private_category, user: author, created_at: 2.hours.ago)
[post, private_post].each do |unread_post|
TopicUser.change(
user.id,
unread_post.topic_id,
last_read_post_number: 0,
notification_level: TopicUser.notification_levels[:tracking],
)
end
UserStat.update_first_unread(1.day.ago)
expected = post.topic.reload.updated_at
expect(user.user_stat.reload.first_unread_at).to eq_time(expected)
end
end
end
describe "ensure consistency!" do
it "can update first unread" do
post = create_post
freeze_time 10.minutes.from_now
create_post(topic_id: post.topic_id)
post.user.update!(last_seen_at: Time.now)
UserStat.ensure_consistency!
post.user.user_stat.reload
expect(post.user.user_stat.first_unread_at).to eq_time(Time.zone.now)
end
it "updates first unread pm timestamp correctly" do
freeze_time
user = Fabricate(:user, last_seen_at: Time.zone.now)
user_2 = Fabricate(:user, last_seen_at: Time.zone.now)
pm_topic = Fabricate(:private_message_topic, user: user, recipient: user_2)
create_post(user: user, topic_id: pm_topic.id)
TopicUser.change(
user.id,
pm_topic.id,
notification_level: TopicUser.notification_levels[:tracking],
)
# user that is not tracking PM topic
TopicUser.change(
user_2.id,
pm_topic.id,
notification_level: TopicUser.notification_levels[:regular],
)
# User that has not been seen recently
user_3 = Fabricate(:user, last_seen_at: 1.year.ago)
pm_topic.allowed_users << user_3
TopicUser.change(
user_3.id,
pm_topic.id,
notification_level: TopicUser.notification_levels[:tracking],
)
user_3_orig_first_unread_pm_at = user_3.user_stat.first_unread_pm_at
# User that is not related to the PM
user_4 = Fabricate(:user, last_seen_at: Time.zone.now)
user_4_orig_first_unread_pm_at = user_4.user_stat.first_unread_pm_at
# User for another PM topic
user_5 = Fabricate(:user, last_seen_at: Time.zone.now)
user_6 = Fabricate(:user, last_seen_at: 10.minutes.ago)
pm_topic_2 = Fabricate(:private_message_topic, user: user_5, recipient: user_6)
create_post(user: user_5, topic_id: pm_topic_2.id)
TopicUser.change(
user_5.id,
pm_topic_2.id,
notification_level: TopicUser.notification_levels[:tracking],
)
# User out of last seen limit
TopicUser.change(
user_6.id,
pm_topic_2.id,
notification_level: TopicUser.notification_levels[:tracking],
)
create_post(user: user_6, topic_id: pm_topic_2.id)
user_6_orig_first_unread_pm_at = user_6.user_stat.first_unread_pm_at
create_post(user: user_2, topic_id: pm_topic.id)
create_post(user: user_6, topic_id: pm_topic_2.id)
pm_topic.update!(updated_at: 10.minutes.from_now)
pm_topic_2.update!(updated_at: 20.minutes.from_now)
stub_const(UserStat, "UPDATE_UNREAD_USERS_LIMIT", 4) do
UserStat.ensure_consistency!(1.hour.ago)
end
# User affected
expect(user.user_stat.reload.first_unread_pm_at).to be_within(1.second).of(
pm_topic.reload.updated_at,
)
expect(user_2.user_stat.reload.first_unread_pm_at).to be_within(1.second).of(
UserStat::UPDATE_UNREAD_MINUTES_AGO.minutes.ago,
)
expect(user_3.user_stat.reload.first_unread_pm_at).to eq_time(user_3_orig_first_unread_pm_at)
expect(user_4.user_stat.reload.first_unread_pm_at).to be_within(1.second).of(
UserStat::UPDATE_UNREAD_MINUTES_AGO.minutes.ago,
)
expect(user_5.user_stat.reload.first_unread_pm_at).to eq_time(pm_topic_2.reload.updated_at)
expect(user_6.user_stat.reload.first_unread_pm_at).to eq_time(user_6_orig_first_unread_pm_at)
end
end
describe "update_time_read!" do
fab!(:user)
let(:stat) { user.user_stat }
it "always expires redis key" do
# this tests implementation which is not 100% ideal
# that said, redis key leaks are not good
stat.update_time_read!
ttl = Discourse.redis.ttl(UserStat.last_seen_key(user.id))
expect(ttl).to be > 0
expect(ttl).to be <= UserStat::MAX_TIME_READ_DIFF
end
it "makes no changes if nothing is cached" do
Discourse.redis.del(UserStat.last_seen_key(user.id))
stat.update_time_read!
stat.reload
expect(stat.time_read).to eq(0)
end
it "makes a change if time read is below threshold" do
freeze_time
UserStat.cache_last_seen(user.id, (Time.now - 10).to_f)
stat.update_time_read!
stat.reload
expect(stat.time_read).to eq(10)
end
it "makes no change if time read is above threshold" do
freeze_time
t = Time.now - 1 - UserStat::MAX_TIME_READ_DIFF
UserStat.cache_last_seen(user.id, t.to_f)
stat.update_time_read!
stat.reload
expect(stat.time_read).to eq(0)
end
end
describe ".update_distinct_badge_count" do
fab!(:user)
let(:stat) { user.user_stat }
fab!(:badge1, :badge)
fab!(:badge2, :badge)
it "updates counts correctly" do
expect(stat.reload.distinct_badge_count).to eq(0)
BadgeGranter.grant(badge1, user)
expect(stat.reload.distinct_badge_count).to eq(1)
BadgeGranter.grant(badge1, user)
expect(stat.reload.distinct_badge_count).to eq(1)
BadgeGranter.grant(badge2, user)
expect(stat.reload.distinct_badge_count).to eq(2)
user.reload.user_badges.destroy_all
expect(stat.reload.distinct_badge_count).to eq(0)
end
it "can update counts for all users simultaneously" do
user2 = Fabricate(:user)
stat2 = user2.user_stat
BadgeGranter.grant(badge1, user)
BadgeGranter.grant(badge1, user)
BadgeGranter.grant(badge2, user)
BadgeGranter.grant(badge1, user2)
# Set some clearly incorrect values
stat.update(distinct_badge_count: 999)
stat2.update(distinct_badge_count: 999)
UserStat.ensure_consistency!
expect(stat.reload.distinct_badge_count).to eq(2)
expect(stat2.reload.distinct_badge_count).to eq(1)
end
it "ignores disabled badges" do
BadgeGranter.grant(badge1, user)
BadgeGranter.grant(badge2, user)
expect(stat.reload.distinct_badge_count).to eq(2)
badge2.update(enabled: false)
expect(stat.reload.distinct_badge_count).to eq(1)
badge2.update(enabled: true)
expect(stat.reload.distinct_badge_count).to eq(2)
end
end
describe ".update_draft_count" do
fab!(:user)
it "updates draft_count" do
Draft.create!(user: user, draft_key: "topic_1", data: {})
Draft.create!(user: user, draft_key: "new_topic", data: {})
Draft.create!(user: user, draft_key: "topic_2", data: {})
UserStat.update_all(draft_count: 0)
UserStat.update_draft_count(user.id)
expect(user.user_stat.draft_count).to eq(3)
end
end
describe "#update_pending_posts" do
subject(:update_pending_posts) { stat.update_pending_posts }
let!(:reviewable) { Fabricate(:reviewable_queued_post) }
let(:user) { reviewable.target_created_by }
let(:stat) { user.user_stat }
before do
stat.update!(pending_posts_count: 0) # the reviewable callback will have set this to 1 already.
end
it "sets 'pending_posts_count'" do
expect { update_pending_posts }.to change { stat.pending_posts_count }.to 1
end
it "publishes a message to clients" do
MessageBus.expects(:publish).with(
"/u/#{user.username_lower}/counters",
{ pending_posts_count: 1 },
user_ids: [user.id],
group_ids: [Group::AUTO_GROUPS[:staff]],
)
update_pending_posts
end
end
describe "trigger_badges" do
fab!(:user)
it "queues a badge grant for the user when present" do
stat = user.user_stat
BadgeGranter.expects(:queue_badge_grant).with(Badge::Trigger::UserChange, user:)
stat.save!
end
it "does not raise when the user row is gone" do
stat = user.user_stat
User.where(id: user.id).delete_all
stat.reload
expect(stat.user).to be_nil
expect { stat.save! }.not_to raise_error
end
end
end