A platform for community discussion. Free, open, simple.
# frozen_string_literal: true
RSpec.describe AboutController do
describe "#index" do
it "displays the about page anonymously when login is optional" do
SiteSetting.login_required = false
get "/about"
expect(response.status).to eq(200)
expect(response.body).to include("<title>About - Discourse</title>")
end
it "redirects anonymous users to login when login is required" do
SiteSetting.login_required = true
get "/about"
expect(response).to redirect_to "/login"
end
it "displays the about page to logged-in users when login is required" do
SiteSetting.login_required = true
sign_in(Fabricate(:user))
get "/about"
expect(response.status).to eq(200)
end
context "with crawler view" do
it "includes the page title" do
get "/about", headers: { "HTTP_USER_AGENT" => "Googlebot" }
expect(response.status).to eq(200)
expect(response.body).to include("<title>About - Discourse</title>")
end
it "includes the user URLs" do
Fabricate(:admin, username: "anAdminUser")
get "/about", headers: { "HTTP_USER_AGENT" => "Googlebot" }
expect(response.status).to eq(200)
expect(response.body).to include("/u/anadminuser")
end
it "supports unicode usernames" do
SiteSetting.unicode_usernames = true
Fabricate(:admin, username: "martínez")
get "/about", headers: { "HTTP_USER_AGENT" => "Googlebot" }
expect(response.status).to eq(200)
expect(response.body).to include("/u/mart%25C3%25ADnez")
end
end
context "with localized site settings" do
before do
SiteSetting.content_localization_enabled = true
SiteSetting.set_locale_from_param = true
SiteSetting.title = "English title"
SiteSetting.site_description = "English description"
SiteSettingLocalization.create!(setting_name: "title", locale: "ja", value: "日本語タイトル")
SiteSettingLocalization.create!(
setting_name: "site_description",
locale: "ja",
value: "日本語の説明",
)
end
it "uses localized values in the JSON response" do
get "/about.json", params: { Discourse::LOCALE_PARAM => "ja" }
expect(response.status).to eq(200)
expect(response.parsed_body.dig("about", "title")).to eq("日本語タイトル")
expect(response.parsed_body.dig("about", "description")).to eq("日本語の説明")
end
it "localizes JSON responses from Accept-Language for clients classified as crawlers" do
SiteSetting.allow_user_locale = true
SiteSetting.set_locale_from_accept_language_header = true
SiteSetting.content_localization_crawler_param = true
SiteSetting.content_localization_supported_locales = "ja"
get "/about.json",
headers: {
"HTTP_USER_AGENT" => "curl/8.0",
"HTTP_ACCEPT_LANGUAGE" => "ja",
}
expect(response.status).to eq(200)
expect(response.parsed_body.dig("about", "title")).to eq("日本語タイトル")
get "/about",
headers: {
"HTTP_USER_AGENT" => "curl/8.0",
"HTTP_ACCEPT" => "application/json, text/html;q=0.5",
"HTTP_ACCEPT_LANGUAGE" => "ja",
}
expect(response.status).to eq(200)
expect(response.parsed_body.dig("about", "title")).to eq("日本語タイトル")
end
it "falls back to default values when a localized value is blank" do
SiteSettingLocalization.find_by!(setting_name: "title", locale: "ja").update_column(
:value,
"",
)
get "/about.json", params: { Discourse::LOCALE_PARAM => "ja" }
expect(response.status).to eq(200)
expect(response.parsed_body.dig("about", "title")).to eq("English title")
expect(response.parsed_body.dig("about", "description")).to eq("日本語の説明")
end
it "uses localized values in crawler metadata" do
get "/about",
params: {
Discourse::LOCALE_PARAM => "ja",
},
headers: {
"HTTP_USER_AGENT" => "Googlebot",
}
expect(response.status).to eq(200)
expect(response.body).to include(
"<title>#{I18n.t("js.about.simple_title", locale: :ja)} - 日本語タイトル</title>",
)
expect(response.body).to include(%(meta name="description" content="日本語の説明"))
end
it "localizes site settings independently of topic and post translation preferences" do
user = Fabricate(:user, locale: "ja")
user.user_option.update!(automatically_translate: false)
sign_in(user)
get "/about.json", params: { Discourse::LOCALE_PARAM => "ja" }
expect(response.status).to eq(200)
expect(response.parsed_body.dig("about", "title")).to eq("日本語タイトル")
expect(response.parsed_body.dig("about", "description")).to eq("日本語の説明")
end
end
it "serializes stats when 'Guardian#can_see_about_stats?' is true" do
Guardian.any_instance.stubs(:can_see_about_stats?).returns(true)
get "/about.json"
expect(response.status).to eq(200)
expect(response.parsed_body["about"].keys).to include("stats")
end
it "does not serialize stats when 'Guardian#can_see_about_stats?' is false" do
Guardian.any_instance.stubs(:can_see_about_stats?).returns(false)
get "/about.json"
expect(response.status).to eq(200)
expect(response.parsed_body["about"].keys).not_to include("stats")
end
context "with a granular API key" do
fab!(:admin)
fab!(:user)
fab!(:api_key, refind: false) do
Fabricate(
:api_key,
api_key_scopes: [Fabricate.build(:api_key_scope, resource: "about", action: "read")],
)
end
before do
SiteSetting.hide_user_profiles_from_public = true
SiteSetting.login_required = true
end
it "uses the supplied API username for about requests" do
get "/about.json", headers: { "Api-Key": api_key.key, "Api-Username": user.username }
expect(response.status).to eq(200)
expect(response.parsed_body.dig("about", "title")).to eq(SiteSetting.title)
expect(response.parsed_body.dig("about", "admin_ids") || []).to include(admin.id)
end
end
context "with profile visibility controls" do
fab!(:admin)
fab!(:moderator)
def user_ids_from(key)
response.parsed_body["about"]["#{key}_ids"] || []
end
context "when hide_user_profiles_from_public is enabled" do
before { SiteSetting.hide_user_profiles_from_public = true }
it "does not expose admins and moderators to anonymous users" do
get "/about.json"
expect(response.status).to eq(200)
expect(user_ids_from("admin")).to be_empty
expect(user_ids_from("moderator")).to be_empty
end
it "exposes admins and moderators to logged in users" do
sign_in(Fabricate(:user))
get "/about.json"
expect(response.status).to eq(200)
expect(user_ids_from("admin")).to include(admin.id)
expect(user_ids_from("moderator")).to include(moderator.id)
end
end
context "when a staff member has hide_profile enabled" do
before do
SiteSetting.allow_users_to_hide_profile = true
admin.user_option.update!(hide_profile: true)
end
it "excludes them from the about page for anonymous users" do
get "/about.json"
expect(response.status).to eq(200)
expect(user_ids_from("admin")).not_to include(admin.id)
end
it "excludes them from the about page for regular users" do
sign_in(Fabricate(:user))
get "/about.json"
expect(response.status).to eq(200)
expect(user_ids_from("admin")).not_to include(admin.id)
end
it "still shows them to staff users" do
sign_in(Fabricate(:admin))
get "/about.json"
expect(response.status).to eq(200)
expect(user_ids_from("admin")).to include(admin.id)
end
end
context "with category moderators" do
fab!(:group, :public_group)
fab!(:category_mod) { Fabricate(:user, last_seen_at: 1.day.ago) }
fab!(:category)
fab!(:category_moderation_group) do
group.add(category_mod)
Fabricate(:category_moderation_group, category: category, group: group)
end
it "does not expose category moderators to anonymous users when hide_user_profiles_from_public is enabled" do
SiteSetting.hide_user_profiles_from_public = true
get "/about.json"
expect(response.status).to eq(200)
expect(response.parsed_body["about"]["category_moderators"]).to be_empty
end
it "excludes category moderators with hide_profile enabled" do
SiteSetting.allow_users_to_hide_profile = true
category_mod.user_option.update!(hide_profile: true)
get "/about.json"
expect(response.status).to eq(200)
all_mod_ids =
response.parsed_body["about"]["category_moderators"].flat_map do |cm|
cm["moderator_ids"]
end
expect(all_mod_ids).not_to include(category_mod.id)
end
end
end
end
end