Skip to content

A platform for community discussion. Free, open, simple.

2.6 KB
Raw Blame
# frozen_string_literal: true

describe TopicViewStatsController do
  fab!(:topic)

  it "returns an error on login-required sites" do
    SiteSetting.login_required = true
    get "/t/#{topic.id}/view-stats.json"
    expect(response.status).to eq(403)
  end

  it "returns the same not found response for inaccessible and nonexistent topics" do
    SiteSetting.detailed_404 = false
    topic.category.update!(read_restricted: true)

    get "/t/#{topic.id}/view-stats.json"

    expect(response.status).to eq(404)
    inaccessible_topic_response = response.parsed_body

    get "/t/#{topic.id + 1_000_000}/view-stats.json"

    expect(response.status).to eq(404)
    expect(response.parsed_body).to eq(inaccessible_topic_response)
  end

  it "returns an access error for private topics when detailed 404 errors are enabled" do
    SiteSetting.detailed_404 = true
    topic.category.update!(read_restricted: true)

    get "/t/#{topic.id}/view-stats.json"

    expect(response.status).to eq(403)
    expect(response.parsed_body).to include(
      "errors" => ["You are not permitted to view the requested resource."],
    )
  end

  it "returns errors for invalid parameters" do
    get "/t/999999999999999999999999999999990000009/view-stats.json"
    expect(response.status).to eq(404)
  end

  it "returns an error for invalid date parameters" do
    get "/t/#{topic.id}/view-stats.json?from=abc&to=xxx"

    expect(response.status).to eq(422)
  end

  it "returns view statistics for public topics" do
    freeze_time "2021-01-01 12:00"

    TopicViewStat.create!(
      topic_id: topic.id,
      viewed_at: Date.yesterday,
      anonymous_views: 2,
      logged_in_views: 3,
    )

    TopicViewStat.create!(
      topic_id: topic.id,
      viewed_at: Date.today,
      anonymous_views: 1,
      logged_in_views: 2,
    )

    get "/t/#{topic.id}/view-stats.json"
    expect(response.status).to eq(200)

    expected = {
      "topic_id" => topic.id,
      "stats" => [
        { "viewed_at" => "2020-12-31", "views" => 5 },
        { "viewed_at" => "2021-01-01", "views" => 3 },
      ],
    }

    expect(response.parsed_body).to eq(expected)

    get "/t/#{topic.id}/view-stats.json?from=2019-12-31&to=2019-12-31"
    expect(response.parsed_body).to eq({ "topic_id" => topic.id, "stats" => [] })

    get "/t/#{topic.id}/view-stats.json?from=2000-12-31&to=2020-12-31"
    expected = {
      "topic_id" => topic.id,
      "stats" => [{ "viewed_at" => "2020-12-31", "views" => 5 }],
    }
    expect(response.parsed_body).to eq(expected)

    get "/t/#{topic.id}/view-stats.json?from=2020-12-31&to=2020-12-31"
    expect(response.parsed_body).to eq(expected)
  end
end