Skip to content

A platform for community discussion. Free, open, simple.

4.4 KB
Raw Blame
# frozen_string_literal: true

describe "Admin User Fields" do
  fab!(:current_user, :admin)

  before { sign_in(current_user) }

  let(:user_fields_page) { PageObjects::Pages::AdminUserFields.new }
  let(:page_header) { PageObjects::Components::DPageHeader.new }

  it "correctly saves user fields" do
    user_fields_page.visit
    expect(page_header).to be_visible
    user_fields_page.add_field(name: "Occupation", description: "What you do for work")

    expect(user_fields_page).to have_user_field("Occupation")

    user_fields_page.refresh

    expect(user_fields_page).to have_user_field("Occupation")
  end

  it "displays an error when missing required fields" do
    user_fields_page.visit

    user_fields_page.add_field(name: "Occupation", description: "")

    expect(user_fields_page.form.field("description")).to have_errors("Required")
  end

  it "makes sure new required fields are editable after signup" do
    user_fields_page.visit
    user_fields_page.click_add_field

    expect(page_header).to be_hidden

    form = page.find(".user-field")
    editable_label = I18n.t("admin_js.admin.user_fields.editable.title")

    user_fields_page.choose_requirement("for_all_users")

    expect(form).to have_field(editable_label, checked: true, disabled: true, visible: :all)

    user_fields_page.choose_requirement("optional")

    expect(form).to have_field(editable_label, checked: true, disabled: false, visible: :all)
  end

  it "makes sure fields are available on signup when they have to" do
    user_fields_page.visit
    user_fields_page.click_add_field

    expect(page_header).to be_hidden

    form = page.find(".user-field")
    show_on_signup_label = I18n.t("admin_js.admin.user_fields.show_on_signup.title")

    user_fields_page.choose_requirement("for_all_users")

    expect(form).to have_field(show_on_signup_label, checked: true, disabled: true, visible: :all)

    user_fields_page.choose_requirement("on_signup")

    expect(form).to have_field(show_on_signup_label, checked: true, disabled: true, visible: :all)

    user_fields_page.choose_requirement("optional")

    expect(form).to have_field(show_on_signup_label, checked: true, disabled: false, visible: :all)

    user_fields_page.unselect_preference("editable")

    expect(form).to have_field(show_on_signup_label, checked: true, disabled: true, visible: :all)
  end

  it "requires confirmation when applying required fields retroactively" do
    user_fields_page.visit
    user_fields_page.add_field(
      name: "Favourite Pokémon",
      description: "Hint: It's Mudkip",
      save: false,
    )
    user_fields_page.choose_requirement("for_all_users")
    user_fields_page.form.submit

    expect(page).to have_text(I18n.t("admin_js.admin.user_fields.requirement.confirmation"))
  end

  context "when editing an existing user field" do
    fab!(:user_field) { Fabricate(:user_field, requirement: "for_all_users") }

    it "does not require confirmation if the field already applies to all users" do
      user_fields_page.visit
      user_fields_page.click_edit

      form = page.find(".user-field")

      form.find(".user-field-name").fill_in(with: "Favourite Transformer")

      expect(page_header).to be_hidden

      form.find(".btn-primary").click

      expect(page).to have_no_text(I18n.t("admin_js.admin.user_fields.requirement.confirmation"))
    end
  end

  context "when enable_new_reordering_controls is enabled" do
    fab!(:field1) { Fabricate(:user_field, name: "Favourite colour") }
    fab!(:field2) { Fabricate(:user_field, name: "Home town") }

    before { SiteSetting.enable_new_reordering_controls = true }

    it "keeps each row's controls anchored to its own row on mobile", mobile: true do
      user_fields_page.visit

      expect(page).to have_css(".admin-user_field-item", count: 2)

      escaped = page.evaluate_script(<<~JS)
          Array.from(document.querySelectorAll(".d-table__cell.--controls")).filter(
            (cell) => cell.offsetParent !== cell.closest("tr")
          ).length
        JS

      expect(escaped).to eq(0)
    end

    it "sizes the drag handle column to the handle" do
      user_fields_page.visit

      expect(page).to have_css(".admin-user_field-item", count: 2)

      width = page.evaluate_script(<<~JS)
          Math.round(
            document
              .querySelector(".d-reorderable-list__handle")
              .closest("td")
              .getBoundingClientRect().width
          )
        JS

      expect(width).to be < 60
    end
  end
end