Skip to content

A platform for community discussion. Free, open, simple.

DEV: Improve `Plugin::Instance#humanized_name` (#39626)

Jarek Radosz005702b1d55e
diff --git a/lib/plugin/instance.rb b/lib/plugin/instance.rb
index 0a098428fb5..efb54183b98 100644
--- a/lib/plugin/instance.rb
+++ b/lib/plugin/instance.rb
@@ -183,7 +183,7 @@ class Plugin::Instance
delegate :name, to: :metadata
def humanized_name
- (setting_category_name || name).sub(/\Adiscourse[\s-]+/i, "").gsub("-", " ").upcase_first
+ (setting_category_name || name).sub(/\Adiscourse[\s\-_]+/i, "").tr("-_", " ").upcase_first
end
def add_to_serializer(
diff --git a/spec/lib/plugin/instance_spec.rb b/spec/lib/plugin/instance_spec.rb
index e1261242d94..8fde4a6c337 100644
--- a/spec/lib/plugin/instance_spec.rb
+++ b/spec/lib/plugin/instance_spec.rb
@@ -46,6 +46,11 @@ TEXT
expect(plugin_instance.humanized_name).to eq("Sample plugin")
end
+ it "converts underscores in the plugin name to spaces" do
+ plugin_instance.metadata.stubs(:name).returns("docker_manager")
+ expect(plugin_instance.humanized_name).to eq("Docker manager")
+ end
+
it "removes any Discourse prefix from the setting category name" do
TranslationOverride.upsert!(
"en",