Skip to content

A platform for community discussion. Free, open, simple.

MT: Put badges without a group into "Other" in generic bulk import

Gerhard Schlager00961e09be3f
diff --git a/script/bulk_import/generic_bulk.rb b/script/bulk_import/generic_bulk.rb
index ecff4784044..64a9e7c81a4 100644
--- a/script/bulk_import/generic_bulk.rb
+++ b/script/bulk_import/generic_bulk.rb
@@ -4438,6 +4438,7 @@ class BulkImport::Generic < BulkImport::Base
rows = query(<<~SQL)
SELECT DISTINCT badge_group
FROM badges
+ WHERE badge_group IS NOT NULL
ORDER BY badge_group
SQL
@@ -4480,7 +4481,7 @@ class BulkImport::Generic < BulkImport::Base
name: badge_name,
description: row["description"],
badge_type_id: row["badge_type_id"],
- badge_grouping_id: @badge_group_mapping[row["badge_group"]],
+ badge_grouping_id: @badge_group_mapping[row["badge_group"]] || BadgeGrouping::Other,
long_description: row["long_description"],
image_upload_id:
(
diff --git a/spec/script/bulk_import/generic_bulk_spec.rb b/spec/script/bulk_import/generic_bulk_spec.rb
index d6812a94da0..41e6211539a 100644
--- a/spec/script/bulk_import/generic_bulk_spec.rb
+++ b/spec/script/bulk_import/generic_bulk_spec.rb
@@ -621,6 +621,41 @@ if generic_import_dependencies_available
end
end
+ describe "badges without a group" do
+ let(:source_db) { SQLite3::Database.new(":memory:", results_as_hash: true) }
+ let(:importer) do
+ described_class.allocate.tap do |instance|
+ instance.instance_variable_set(:@source_db, source_db)
+ instance.instance_variable_set(:@badge_mapping, {})
+ end
+ end
+
+ before do
+ source_db.execute("CREATE TABLE badges (id INTEGER, name TEXT, badge_group TEXT)")
+ source_db.execute(
+ "INSERT INTO badges (id, name, badge_group) VALUES (1, 'Grouped', 'Imported'), (2, 'Ungrouped', NULL)",
+ )
+ end
+
+ after { source_db.close }
+
+ it "puts them into the Other grouping" do
+ badges = []
+ allow(importer).to receive(:create_badges) do |rows, &block|
+ badges = rows.filter_map(&block)
+ end
+
+ importer.import_badge_groupings
+ importer.import_badges
+
+ imported_grouping = BadgeGrouping.find_by!(name: "Imported")
+ expect(badges.map { |badge| badge.slice(:name, :badge_grouping_id) }).to contain_exactly(
+ { name: "Grouped", badge_grouping_id: imported_grouping.id },
+ { name: "Ungrouped", badge_grouping_id: BadgeGrouping::Other },
+ )
+ end
+ end
+
describe "mapping selection" do
fab!(:canonical_user, :user)
fab!(:other_user, :user)