A platform for community discussion. Free, open, simple.
DEV: Check featured topic visibility in `CurrentUserSerializer` (#40755)
Gabriel Grubba00c47da07bc1
diff --git a/app/serializers/current_user_serializer.rb b/app/serializers/current_user_serializer.rbindex 45f7a93ddac..774ca080541 100644--- a/app/serializers/current_user_serializer.rb+++ b/app/serializers/current_user_serializer.rb@@ -354,6 +354,10 @@ class CurrentUserSerializer < BasicUserSerializerobject.totp_enabled? || object.security_keys_enabled?end+ def include_featured_topic?+ scope.can_see_topic?(object.user_profile.featured_topic)+ end+def featured_topicBasicTopicSerializer.new(object.user_profile.featured_topic, scope: scope, root: false).as_jsonenddiff --git a/spec/requests/session_controller_spec.rb b/spec/requests/session_controller_spec.rbindex 91c392abfc8..346e26cdb51 100644--- a/spec/requests/session_controller_spec.rb+++ b/spec/requests/session_controller_spec.rb@@ -2997,6 +2997,17 @@ RSpec.describe SessionController doexpect(json["current_user"]).to be_presentexpect(json["current_user"]["id"]).to eq(user.id)end++ it "does not include a featured topic the user cannot see" do+ private_category = Fabricate(:private_category, group: Fabricate(:group))+ featured_topic = Fabricate(:topic, category: private_category)+ user.user_profile.update!(featured_topic_id: featured_topic.id)++ get "/session/current.json"++ expect(response.status).to eq(200)+ expect(response.parsed_body["current_user"]).not_to have_key("featured_topic")+ endendcontext "when logged in as an anonymous shadow user" do